Commit graph

46 commits

Author SHA1 Message Date
Cheng Zhao
64c4a34507 Make devtools_web_contents_ is destroyed before everything
The WebContentsDestroyed still access the other members, so if they are
destroyed before the devtools_web_contents_ in the destructor, we will
crash there.
2015-06-09 10:44:48 +08:00
Cheng Zhao
d1e70e7826 Add InspectableWebContents::GetDevToolsWebContents 2015-06-05 14:33:37 +08:00
Cheng Zhao
05f182f650 Clean up code 2015-06-05 12:24:48 +08:00
Cheng Zhao
aa926680a2 No more need to override DidFinishLoad 2015-06-05 12:10:01 +08:00
Cheng Zhao
56747e975e Avoid calling JavaScript of devtools WebContents too early
It would craete a context that window.location is about:blank
2015-06-05 11:58:27 +08:00
Cheng Zhao
9a9bc5530e Handle network requests from devtools 2015-06-05 11:20:20 +08:00
Cheng Zhao
d48a80bdfa Update to new devtools messages 2015-06-05 11:03:47 +08:00
Cheng Zhao
a9a5765544 Remove trailing space 2015-05-27 15:02:01 +08:00
deepak1556
145c18f4c8 method to reset agent_host 2015-05-18 19:26:03 +05:30
Cheng Zhao
90b255f2cd Fix API changes 2015-04-21 18:54:57 +08:00
Robo
4ae52721c4 detecting focus on devtools webcontents 2015-04-01 15:22:53 +05:30
Cheng Zhao
99e2dbd6e8 Fix inspectable_web_contents_impl.h 2015-03-08 19:13:17 -07:00
Cheng Zhao
c0356f0269 Fix ui/gfx/geometry headers 2015-03-08 19:02:38 -07:00
Cheng Zhao
8ec5b5ad20 DevToolsClientHost is discarded 2014-12-09 22:39:44 -08:00
Cheng Zhao
74025ee985 Enable setting devtools to not able to dock 2014-11-03 21:32:11 +08:00
Cheng Zhao
6b49e23312 Fix leaking WebContents from devtools. 2014-10-27 16:42:54 +08:00
Cheng Zhao
7b39673215 No need for "virtual" when "override" is used 2014-10-27 16:39:54 +08:00
Cheng Zhao
f809fef22d OVERRIDE => override 2014-10-23 11:10:39 +08:00
Cheng Zhao
733931c7ad Fix loading devtools 2014-10-11 19:00:30 +08:00
Cheng Zhao
5bec155c81 Adapt to API changes of Chrome 38 2014-10-11 16:38:27 +08:00
Cheng Zhao
a6627a7286 Add a method in InspectableWebContentDelegate to set icon for devtools window. 2014-09-09 15:29:35 +08:00
Cheng Zhao
4107089363 Use new devtools resizing strategy from Chrome 37. 2014-09-01 19:15:07 +08:00
Cheng Zhao
47bc6a29a7 Print console output of devtools. 2014-08-28 12:53:35 +08:00
Cheng Zhao
4e63780e4a Prototype of WebContentsDestroyed has changed. 2014-07-27 10:27:19 +00:00
Cheng Zhao
46e765f79b Fix crash when closing docked devtools by clicking close button.
We need to send ack for the close message, so we should destroy web contents
after the beforeunload event has fired.
2014-07-13 10:08:28 +08:00
Cheng Zhao
0a7b1fdd87 Add new devtools messages in Chrome 35. 2014-07-09 10:26:01 +08:00
Cheng Zhao
651ebdde65 views: Remember bounds of devtools window. 2014-07-09 10:26:01 +08:00
Cheng Zhao
1722532e6d No need to remember dock state.
All devtools states are remembered by devtools itself now.
2014-07-09 10:24:10 +08:00
Cheng Zhao
2efeaa268f Place DevTools WebContents underneath inspected WebContents.
This commit has this strategy implemented on Mac.

See https://code.google.com/p/chromium/issues/detail?id=318751.
2014-07-09 10:24:10 +08:00
Cheng Zhao
d2ff5ad798 Provide a way to close devtools completely. 2014-03-20 09:26:21 +08:00
Cheng Zhao
e3aaaf2643 Add InspectableWebContentsDelegate. 2014-03-04 16:26:50 +08:00
Cheng Zhao
b080e5c52d Rename IsDevToolsOpened to IsDevToolsViewShowing. 2013-12-10 18:38:35 -08:00
Cheng Zhao
de7892cd6e Add API to get whether the devtools is opened. 2013-12-09 09:03:29 +00:00
Adam Roben
265076f19a Update for changes to devtools in Chrome 31
browser/devtools_embedder_message_dispatcher.* came from
chrome/browser/devtools, and were modified just enough to compile within
brightray.
2013-12-02 13:00:39 -05:00
Adam Roben
d4ad45334f Turn off build/include_what_you_use
Chromium doesn't seem to use this rule.
2013-11-17 18:42:15 -05:00
Adam Roben
877a1f0371 Fix cpplint errors in inspectable_web_contents_impl.h 2013-11-17 18:22:48 -05:00
Adam Roben
9ac1a539ee Fix all remaining readability/namespace errors 2013-11-17 18:20:17 -05:00
Cheng Zhao
f623ddf7fc Cleanup unused headers, data members and functions. 2013-10-11 07:17:53 -04:00
Cheng Zhao
2cd6dd791e Setup devtools in the correct phase.
* RegisterDevToolsClientHostFor should be called right after the agent_host and
  the frontend host are created.
* SetupDevToolsFrontendClient should be called before the devtools window is
  going to start navigation.
2013-10-11 07:17:03 -04:00
Adam Roben
aa4f991659 Add DevToolsFrontendHostDelegate indexing methods from Chrome 30
See http://src.chromium.org/viewvc/chrome?view=revision&revision=215622.
2013-10-07 16:31:57 -04:00
Adam Roben
35199ba31f MSVC doesn't allow override on destructors 2013-05-16 09:15:55 -04:00
Cheng Zhao
082f88ed3c frontend_host_ should be destructed after devtools_web_contents_. 2013-05-01 22:00:20 +08:00
Cheng Zhao
082aa61870 InspectableWebContents should be able to accept existing WebContents. 2013-04-20 13:24:45 +08:00
Adam Roben
3c513d6ae8 Remember where the dev tools were docked between launches 2013-04-08 13:53:53 -04:00
Adam Roben
d20ecc0e2b Merge InspectableWebContentsImpl and DevToolsFrontend
While this prevents clients from easily implementing their own devtools
windows, it gives us much easier control over the devtools experience.
2013-03-27 11:20:15 -04:00
Adam Roben
b2a79856ef Add InspectableWebContents
This class can be used to create a content::WebContents that can be inspected
by the Chrome Dev Tools. This requires embedding applications to copy
content_shell.pak into their resource bundle.

Right now the dev tools are always docked to the bottom of the view; we don't
yet support undocking or changing the docked side.

Fixes #1.
2013-03-14 09:05:42 -04:00