Kevin Sawicki
f9f697298d
Add FIXME link to #6828
2017-06-14 14:12:51 -07:00
Kevin Sawicki
626a1550dc
Send cached visibility state when guest DOM is ready
2017-06-14 14:11:38 -07:00
Birunthan Mohanathas
7d2226e05e
Let Chromium manage document.visibilityState and document.hidden
...
Chromium already includes the necessary plumbing to manage the
visibility properties and `visibilitychange` event so this gets rid of
most of our custom logic for `BrowserWindow` and `BrowserView`.
Note that `webview` remains unchanged and is still affected by the issues
listed below.
User facing changes:
- The `document` visibility properties and `visibilitychange` event are
now also updated/fired in response to occlusion changes on macOS. In
other words, `document.visibilityState` will now be `hidden` on macOS
if the window is occluded by another window.
- Previously, `visibilitychange` was also fired by *both* Electron and
Chromium in some cases (e.g. when hiding the window). Now it is only
fired by Chromium so you no longer get duplicate events.
- The visiblity state of `BrowserWindow`s created with `{ show: false }`
is now initially `visible` until the window is shown and hidden.
- The visibility state of `BrowserWindow`s with `backgroundThrottling`
disabled is now permanently `visible`.
This should also fix #6860 (but not for `webview`).
2017-06-06 15:16:01 -07:00
Kevin Sawicki
9ac2cf0d44
Add comment about disablePopups setting
2017-05-26 10:10:36 -07:00
Kevin Sawicki
dbd240a7cb
Return null from native window.open when allowpopups is unset
2017-05-26 10:10:36 -07:00
Kevin Sawicki
47759a01de
Only forward events when nativeWindowOpen is set
2017-05-26 10:10:36 -07:00
Kevin Sawicki
7baf472c0f
Implement BrowserPluginGuestDelegate::CreateNewGuestWindow for nativeWindowOpen
2017-05-26 10:10:36 -07:00
Kevin Sawicki
1d84d83fd4
Forward webview visibility change events from browser process
2017-02-28 08:23:00 -08:00
deepak1556
71fd3e807c
use sync zoom api with guest view manager webpreferences
2017-02-18 01:34:32 +05:30
deepak1556
203a920c64
fix signature of zoom getter apis
2017-02-18 01:34:32 +05:30
deepak1556
63c0e4cbb1
Add ZoomController to manager zoom changes for webcontents
2017-02-12 00:49:17 +05:30
Kevin Sawicki
941f6c63e3
🎨 Use embedder var for clarity
2017-02-09 11:48:45 -08:00
Kevin Sawicki
a7c050107b
Remove guest from will-attach-webview event
2017-02-09 11:47:45 -08:00
Kevin Sawicki
8b0d3a2567
Emit attach params as well in event
2017-02-09 11:45:07 -08:00
Kevin Sawicki
46f1a49594
new-webview -> will-attach-webview
2017-02-09 11:45:07 -08:00
Kevin Sawicki
7eda8fbdfb
Add new-webview event that can be prevented
2017-02-09 11:45:07 -08:00
Javan Makhmali
a64bdbd306
Add "context-menu" DOM event to <webview>
2017-01-13 17:04:09 -05:00
Kevin Sawicki
133ad6e18b
Only set size and load URL on first attach
2016-11-07 13:42:36 -08:00
Kevin Sawicki
a737732521
Only remove guest from embedder when view id changes
2016-11-07 13:42:36 -08:00
Kevin Sawicki
73774f21b7
🎨
2016-11-07 08:28:02 -08:00
Kevin Sawicki
3c18de9c5a
Only return when guestInstance is non-null
2016-11-07 08:25:01 -08:00
Kevin Sawicki
76f96bd99c
Destructure requires
2016-11-07 08:25:01 -08:00
Kevin Sawicki
48bcad87c2
Use template strings
2016-11-07 08:25:01 -08:00
Kevin Sawicki
712b15286c
Use let/const instead of var
2016-11-07 08:25:01 -08:00
Kevin Sawicki
3053be345b
Remove unneeded returns
2016-11-07 08:25:01 -08:00
Kevin Sawicki
3aad6a0c99
Use forEach and destructuring for parsing features
2016-10-25 10:31:50 +09:00
Paul Frazee
f35536bdc5
factor out parse-features-string.js
2016-10-24 20:21:42 -05:00
Paul Frazee
e7962c7ba2
fixes and tests for webview 'webpreferences' attr
2016-10-14 18:04:33 -05:00
Paul Frazee
194b14100e
add the 'webpreferences' attribute to webviews
2016-10-14 17:16:39 -05:00
Dave Townsend
313b2faa3c
Add a guestinstance attribute to webviews reflecting their current guest
...
instance ID and allowing moving a guest instance to a new webview.
2016-09-09 10:32:05 -07:00
Cheng Zhao
bb10551d23
Work around a compiler bug that crashes on Windows
2016-06-16 10:55:25 +09:00
Kevin Sawicki
ee0bab6389
Specify type instead of isGuest
2016-06-14 15:47:33 -07:00
Cheng Zhao
6c5eaf6178
Merge pull request #5923 from electron/disable-blink-features
...
Support disabling Blink features
2016-06-08 02:00:30 +00:00
Kevin Sawicki
02e0ca60ef
Use lowercase param key
2016-06-07 16:35:23 -07:00
Kevin Sawicki
96012d6523
Remove trailing comma
2016-06-07 16:24:05 -07:00
Kevin Sawicki
ca6e3ed1ef
Add webview support for disabled blink features
2016-06-07 13:49:31 -07:00
Kevin Sawicki
ba762464d2
More let/const-ing
2016-06-07 10:29:29 -07:00
Kevin Sawicki
5c880b7c99
We -> we
2016-06-07 10:25:21 -07:00
Kevin Sawicki
ce1a9740f6
🎨 Use const and for/of loops
2016-06-07 10:24:48 -07:00
Kevin Sawicki
3bcb411e28
Don't collect unused results array
2016-06-07 10:24:33 -07:00
Cheng Zhao
3c873736d7
Add update-target-url event
2016-06-07 15:56:19 +09:00
Cheng Zhao
8ac93e02c6
Merge pull request #5616 from electron/inherit-zoom
...
Inherit zoomFactor in webview
2016-05-20 00:27:06 +00:00
Kevin Sawicki
cc7395eea8
Remove returns from event listeners
2016-05-19 15:28:08 -07:00
Kevin Sawicki
4754e4aabb
Add zoomFactor to guest params
2016-05-19 14:32:16 -07:00
Cheng Zhao
90f52169af
No more need to check for nodeIntegration when creating guest view
2016-05-17 17:06:02 +09:00
Kevin Sawicki
8e7bf1051d
Disable node integration on webview when disabled on window
2016-04-21 11:52:10 -07:00
Kevin Sawicki
8d8d5878a3
Rename ATOM_ ipc event prefix to ELECTRON_
2016-04-07 09:04:55 -07:00
Zeke Sikelianos
2c3cacdc08
standardize by hand
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
4794385fac
first pass at standardizing; suite still passing!
2016-03-30 17:00:30 -07:00
Kevin Sawicki
4127b524d5
Destructure params directly
2016-03-22 13:11:42 -07:00
