shelley vohr
f50f725a9c
fix: prevent Menu.buildFromTemplate with empty array ( #23308 )
...
Prevent issues with menu creation and subsequent pane focus from menu bar by preventing menus from being created from an empty array. I can't conceive a valid use case for this, since if one wants to remove a menu they should be be passing null to win.setMenu() or calling win.removeMenu(). This issue is also specific to top-level menus, and not submenus, so the new check and exception is scoped to top-level menus.
2020-04-30 08:29:02 -07:00
Samuel Attard
0d2e967960
feat: expose electron/{process} typed modules ( #22937 )
...
* feat: expose electron/{process} typed modules
* chore: update imports for common modules
* chore: update typescript generator
* chore: remap electron/* to the internal packages
2020-04-06 17:04:09 -07:00
Samuel Attard
5d657dece4
build: enable JS semicolons ( #22783 )
2020-03-20 13:28:31 -07:00
Samuel Attard
b87b501161
build: update eslint + eslint plugins ( #22777 )
...
* build: run eslint --fix
* chore: manually fix all hasOwnProperty errors
* chore: manually fix all void 0 vs undefined errors
* chore: manually fix all async-in-promise errors
* chore: manually fix lexical declaration in case block
2020-03-20 11:12:18 -04:00
Electron Bot
39baf68790
chore: bump chromium to 5b340c815ce15ab2efcf277ed19e9 (master) ( #22064 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: loc <andy@slack-corp.com>
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>
2020-03-03 13:35:05 -08:00
Cheng Zhao
629c2121ba
chore: print more logging for failed tests ( #22060 )
2020-02-06 11:15:55 -05:00
Cheng Zhao
0209302d84
test: use exit event to wait for process exit ( #21865 )
2020-01-27 10:29:50 +09:00
Cheng Zhao
3cb0ed306b
fix: hiding window menu should work on startup ( #21436 )
...
* fix: menu visibility should not be overwritten on startup
* fix: removing menu for window without global menubar
* test: setMenu tests are not for mac
2019-12-09 11:17:36 -08:00
Milan Burda
3f2cb91a35
refactor: declare KeyWeakMap<K, V> returned by createIDWeakMap() / createDoubleIDWeakMap() ( #21171 )
2019-11-21 13:32:31 +01:00
Cheng Zhao
50f2d2b5ab
fix: menu should not be garbage-collected when popuping ( #21169 )
...
* fix: retain menu when popuping
* test: menu should not be garbage-collected when popuping
2019-11-20 20:17:39 +09:00
Jeremy Apthorp
6781d5e3c8
test: there is only --ci ( #20794 )
2019-10-30 16:38:21 -07:00
Jeremy Apthorp
d50298ed96
test: move menu spec to main process ( #19412 )
2019-07-26 10:17:14 -04:00
