Commit graph

2232 commits

Author SHA1 Message Date
Cheng Zhao
63874da087 test: add test for window.open in BrowserView 2018-11-27 11:10:07 +09:00
Samuel Attard
f02f9ba9fb chore: add spec for --inspect after a -- () 2018-11-20 16:23:50 -05:00
Ondřej Záruba
de05ff894b feat: Add app.getLocaleCountryCode() method for region detection ()
* Add method to get system´s user region

* Fix linter

* Remove auto types

* Improved detection for POSIX

* Change name, add specs, minor fixes

* Remove left overs

* Fix locale test

* Fix Linux test

* Coding style fixes

* Fix docs

* Add test excaption for Linux

* fix spelling

* Polishing
2018-11-20 15:33:23 -05:00
Pedro Pontes
57d2ae1aec revert: "fix: window.open site instance should belong to same browsing instance ()" ()
This reverts commit 8f35198bfb.
2018-11-20 21:28:26 +01:00
Jeremy Apthorp
0642be296d
fix: crash in sandbox on linux when getting execPath () 2018-11-15 12:59:01 -08:00
Shelley Vohr
565e4c5910
chore: fix window width in spec for win () 2018-11-13 11:31:03 -05:00
Pedro Pontes
8f35198bfb fix: window.open site instance should belong to same browsing instance () 2018-11-12 22:01:43 +01:00
Shelley Vohr
c06f023313
feat: allow partial setting of window bounds ()
Extend the existing win.setBounds functionality by allowing developers to partially update bounds without being forced to pass in all four bounds values. No existing functionality is altere
2018-11-12 15:31:14 -05:00
Jacob
b21dbdb20d fix: bypass DOM storage quota () 2018-11-12 18:19:01 +01:00
Nitish Sakhawalkar
5994bf6745
fix: Menu accelerators not working ()
This change fixes the regression in the menu accelerators working in linux, on some environments.
2018-11-09 13:54:16 -08:00
John Kleinschmidt
9e2b7dbea5
ci: add testing for mksnapshot ()
* ci: add testing for mksnapshot
2018-11-09 10:54:17 -04:00
Robo
82322968a3 refactor: printing implementation ()
* refactor: basic printing

* move build files to chromium_src/BUILD.gn
* remove dependency on chrome prerender sources

* spec: move printing specs behind feature flag

* build: register pdf compositor service
2018-11-09 14:42:34 +11:00
Cheng Zhao
746beb0d8b fix: destroy WebContents synchronously on shutdown () 2018-11-08 07:57:28 -08:00
Jeremy Apthorp
7e0e12b8a3 fix: match Chrome's font fallback behavior ()
* fix: match Chrome's font fallback behavior

Fixes 

* add a cache

* add test

* another test

* fix tests

* arial -> dejavu sans on linux apparently?
2018-11-08 10:51:51 -04:00
Heilig Benedek
ca2d74e118 feat: add methods to allow customization of save dialog during will-download event ()
* feat: add method to DownloadItem that allows customization of dialog options

* docs: add docs for get/setSaveDialogOptions

* add missing copy constructor for DialogSettings on mac and linux

* fix: don't filter dialog options for mas build, don't return properties

* test: add test for get/setSaveDialogOptions

* fix: remove openDevtools added for debugging

* test: fix failing test because of new event parameter

* docs: use SaveDialogOptions instead of Object
2018-11-08 10:51:06 -04:00
Shelley Vohr
e9ba26f50e
feat: allow registering multiple shortcuts ()
This PR allows for multiple global shortcuts to be registered such that triggering any of them calls the same callback.
2018-11-07 09:40:38 -08:00
Jeremy Apthorp
10969b8c3c
fix: make feature strings more robust to whitespace ()
Fixes 
2018-11-06 15:52:06 -08:00
Shelley Vohr
649f04b7bc
chore: add simple set/unset loginitem spec () 2018-11-06 11:31:32 -08:00
Heilig Benedek
1f5e0c42f3 style: no need for done call in sync tests () 2018-11-02 10:50:17 -04:00
Jeremy Apthorp
932ffdc1e1
test: fix a possible race condition in sendInputEvent test () 2018-11-01 10:25:46 -07:00
Cheng Zhao
a8f2646ba6 Fix missing remote object error when calling remote function created in preload script ()
* fix: report wrong context error based on contextId

* fix: destroyed remote renderer warning is now async
2018-10-31 11:26:57 -04:00
Heilig Benedek
aa6f7a5d9f fix: don't append Shift modifier text twice to accelerators ()
* fix: don't append Shift modifier text twice to accelerators

* style: use the new way of creating patches

* test: add menu item accelerator display tests

* fix: allocate accelerator on the stack

* fix: adjust tests to match expected behavior on mac
2018-10-31 10:13:44 -04:00
Shelley Vohr
1d81d1a706 chore: re-enable protocol partition request spec () 2018-10-31 07:12:32 -05:00
Shelley Vohr
29964079ae chore: re-enable failing netlog spec () 2018-10-30 17:45:05 -05:00
Shelley Vohr
94f853c654 chore: re-enable execFileSync binary exec spec () 2018-10-30 15:45:46 -04:00
David Sanders
bae652f46d docs: http protocol handlers can access headers ()
* test: check http protocol handlers can access headers

* docs: http protocol handlers can access headers
2018-10-30 11:37:49 -07:00
Alexey Kuzmin
ec4a0e096f ci: run more Chromium unit tests ()
* test: add an option to native tests runner to run also disabled tests

* ci: run all native tests on clean Chromium

* ci: update the disabled tests list for native unittests
2018-10-25 14:28:50 -04:00
Cheng Zhao
2f3a8ecd42
fix: child window with nativeWindowOpen should disable node integration ()
* fix: child window with nativeWindowOpen should disable node integration

* Revert "fix: do not enable node integration in child window if not enabled ()"

This reverts commit 0252d7686c.

This patch is not needed anymore since we are force disabling node integration
for child windows.
2018-10-25 15:31:07 +09:00
Islam Sharabash
3b6f0d83e1 fix: allow stream protocols to return headers with multiple values ()
* fix: allow stream protocols to return headers with multiple values

This allows stream protocols to return headers with multiple values as
an array of values.

Fixes https://github.com/electron/electron/issues/14778

* Prefer ConvertFromV8

* Cleanup header conversion

1. Deduplicate the code by using a lambda
2. Remove duplicate calls to headers->Get(key)

* Fix broken test

Headers with multiple values are now being converted correctly, this
test asserted the wrong behavior.
2018-10-25 11:34:20 +11:00
Shelley Vohr
1f246229b1 test: convert node spec to expect () 2018-10-24 11:23:12 +11:00
Shelley Vohr
40874ddec6
fix: update fs methods for options param ()
* fix: update fs methods for options param

* fix: update rest of fs methods with changes
2018-10-23 15:14:05 -07:00
Alexey Kuzmin
5e199152e2 ci: run unittests on clean Chromium ()
* ci: run unittests on clean Chromium

* test: add '--run-only-disabled-tests' flag to "script/native-tests.py"

* ci: add a job to run only disabled unittests

* test: use a different GN config for the native tests

* test: enable blink_common_unittests

* test: disable WeakPtrDeathTest*
2018-10-22 16:12:19 -04:00
Shelley Vohr
939ee94e67
spec: increase MAS timeout for login items () 2018-10-19 13:11:11 -07:00
Shelley Vohr
f9f34fd628
fix: ability to fetch separators by id () 2018-10-19 13:09:40 -07:00
Alexey Kuzmin
b3f134de06 test: asyncawaitify one of sandbox related tests () 2018-10-19 14:28:23 +11:00
Andy Dill
37f2113032 feat: expose setBackgroundThrottling api () 2018-10-19 11:32:22 +11:00
Michelle Tilley
51f3fb9bde
fix: correctly enable and disable windows on Windows and Linux () 2018-10-18 14:23:40 -07:00
Nitish Sakhawalkar
a9ca152069 feat: Spellchecker Async Implementation ()
* feat:Spellchecker Async Implementation

* Adhere to chromium style

* Updating dependency to use gh branch

* Update docs and electron-typescript-definitions module

* Fix lint

* Update electron typescript definitions version

* Update spec

* Address review
2018-10-18 11:11:53 -05:00
Milan Burda
db37ab1039 feat: add remote.require() / remote.getGlobal() filtering () 2018-10-18 14:36:45 +11:00
Milan Burda
508551b81b fix: small refactoring regressions ()
* fix: require('@electron/internal/browser/guest-view-manager')

* fix: add missing crashServicePid used by tests
2018-10-17 12:18:18 -07:00
Jeremy Apthorp
30ccb6aea5
fix: allow renaming electron.exe () 2018-10-15 17:26:34 -07:00
Nitish Sakhawalkar
0c711f690e fix: add microtask runner and fix promise test ()
* fix: Promise resolution and unit test

* Update to use microtask runner

* Address review
2018-10-16 02:26:47 +11:00
Milan Burda
d3efc52745 feat: add webPreferences.enableRemoteModule option () 2018-10-13 20:50:07 +03:00
Shelley Vohr
72db5ed7cb fix: split out login item tests () 2018-10-13 18:52:19 +11:00
Shelley Vohr
6fc2a2a051 fix: natively implement LoginItem functions () 2018-10-12 15:19:27 -07:00
Heilig Benedek
95696c9456 refactor: move text-to-speech out of chromium_src ()
* chore: add tts patch and buildflag, makes tts work again

* chore: add tts patch and buildflag, makes tts work again

* fix: make things compile

* build: add relevant tts files for linux

* fix: update patch and patch description, should now compile on mac

* build: move chrome specific sources under chromium_src:chrome target

* build: enable_extensions again

We are depending on them, check `//electron/chromium_src:chrome` target
for more info.

* fix: update tts.patch to receive notifications about browser context destruction

* fix: extend browser process from chrome layer

The global state g_browser_process is shared between //chrome
and //electron.

* spec: add basic speech synthesis test

* spec: skip speech tests on ci

* build: fix compilation on windows
2018-10-11 08:52:12 -05:00
Alexey Kuzmin
5788600c46 Revert "FIXME: disable isCurrentlyAudible test to unblock merge" ()
This reverts commit c8a9a3f63c.
2018-10-11 08:26:37 -05:00
Milan Burda
5bd6de52e0 feat: add app.enableSandbox() () 2018-10-10 15:32:09 +11:00
Samuel Attard
2420cdf027 fix: ensure that the window is focused when testing spellchecker 2018-10-10 14:02:46 +11:00
Jeremy Apthorp
c8a9a3f63c FIXME: disable isCurrentlyAudible test to unblock merge 2018-10-09 14:39:39 -07:00