Charles Kerr
e70ce89235
chore: more iwyu ( #43063 )
...
* chore: iwyu shell/browser/electron_pdf_document_helper_client.h
* chore: iwyu shell/browser/hid/electron_hid_delegate.h
* chore: iwyu content/public/browser/web_contents.h
* chore: iwyu shell/browser/usb/electron_usb_delegate.h
* chore: iwyu shell/browser/browser_observer.h
* chore: iwyu shell/browser/bluetooth/electron_bluetooth_delegate.h
* chore: iwyu shell/browser/serial/electron_serial_delegate.h
* chore: iwyu shell/browser/api/frame_subscriber.h
* chore: iwyu mojo/public/cpp/bindings/
* chore: iwyu components/
* chore: iwyu extensions/
* chore: iwyu shell/common/gin_helper/
* chore: iwyu v8/
* chore: iwyu base/containers/linked_list.h
* chore: iwyu shell/browser/native_window.h
* chore: iwyu shell/browser/api/electron_api_base_window.h
* chore: iwyu shell/common/node_includes.h
* chore: iwyu gin/handle.h
* chore: iwyu base/functional/callback.h
* chore: iwyu ui/gfx/
* chore: iwyu content/public/browser/render_frame_host.h
* fix: mac
* fix: mac
* fix: win
* chore: iwyu base/files/file_path.h
* chore: iwyu base/unguessable_token.h
* chore: iwyu ui/display/screen.h
* chore: iwyu chrome/browser/predictors/preconnect_manager.h
* chore: iwyu base/observer_list_types.h
* chore: iwyu content/public/browser/web_contents.h
* chore: iwyu chrome/browser/devtools/devtools_eye_dropper.h
* chore: iwyu shell/browser/ui/inspectable_web_contents.h
* chore: iwyu content/public/browser/keyboard_event_processing_result.h
* chore: iwyu net/cookies/canonical_cookie.h
* chore: iwyu net/base/address_list.h
* chore: iwyu net/cert/x509_certificate.h
* chore: iwyu net/cookies/cookie_change_dispatcher.h
* chore: iwyu net/dns/public/host_resolver_results.h
* fix: mac
* Revert "chore: iwyu net/cert/x509_certificate.h"
This reverts commit 002896f71146e90f1e29e090a1d6eede48cee11e.
2024-07-29 12:42:57 -05:00
Fedor Indutny
55e7a47d70
fix: always terminate active Node Streams ( #43056 )
...
`.destroy()` is an important method in the lifecycle of a Node.js
Readable stream. It is typically called to reclaim the resources
(e.g., close file descriptor). The only situations where calling
it manually isn't necessary are when the following events are
emitted first:
- `end`: natural end of a stream
- `error`: stream terminated due to a failure
Prior to this commit the ended state was incorrectly tracked together
with a pending internal error. It led to situations where the request
could get aborted during a read and then get marked as ended (having
pending error).
With this change we disentangle pending "error" and "destroyed" cases to
always properly terminate an active Node.js Readable stream.
Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com>
2024-07-27 12:25:43 -05:00
Milan Burda
892c9d78a3
chore: replace absl::optional<T> with std::optional<T> ( #40928 )
...
* chore: replace absl::optional<T> with std::optional<T>
* IWYU
2024-01-10 16:23:35 -06:00
John Kleinschmidt
3dbc0a365f
chore: enable check raw ptr fields ( #38167 )
2023-05-11 16:07:39 -04:00
Jeremy Rose
fda8ea9277
feat: add protocol.handle ( #36674 )
2023-03-27 10:00:55 -07:00
electron-roller[bot]
16f459228b
chore: bump chromium to 108.0.5329.0 (main) ( #35628 )
...
Co-authored-by: Samuel Attard <sattard@salesforce.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2022-10-03 13:21:00 -07:00
Milan Burda
c4ea33d1bf
chore: add ELECTRON_ prefix to C++ include guards ( #31925 )
2021-11-22 16:34:31 +09:00
Milan Burda
65a980c673
refactor: replace deprecated DISALLOW_COPY_AND_ASSIGN ( #31633 )
2021-11-03 20:41:45 +09:00
electron-roller[bot]
8532e1239e
chore: bump chromium to 93.0.4530.0 (master) ( #29256 )
...
* chore: bump chromium in DEPS to 92.0.4512.6
* 2887336: [CaptureHandle][#2 ] Propagate CaptureHandleConfig in browser process
https://chromium-review.googlesource.com/c/chromium/src/+/2887336
* refactor: base::Optional -> absl::optional
* chore: fixup patch indices
* chore: bump chromium in DEPS to 92.0.4514.0
* 2899417: Make build work when enable_pdf is set to false.
https://chromium-review.googlesource.com/c/chromium/src/+/2899417
* 2904731: use BrowserContext instead of Profile in PreconnectManager
https://chromium-review.googlesource.com/c/chromium/src/+/2904731
* 2295749: fix: check IsSecureEventInputEnabled in constructor before setting SetPasswordInputEnabled to true
https://chromium-review.googlesource.com/c/chromium/src/+/2295749
* 2893803: Add a GetWebView to RenderFrame.
https://chromium-review.googlesource.com/c/chromium/src/+/2893803
* 2892345: Implement WebContents::ForEachRenderFrameHost
https://chromium-review.googlesource.com/c/chromium/src/+/2892345
* chore: fixup patch indices
* 2892048: Real instance methods for BrowserContext: remaining 5 methods.
https://chromium-review.googlesource.com/c/chromium/src/+/2892048
* 2902821: [mojo] Don't require full header includes for referenced interfaces
https://chromium-review.googlesource.com/c/chromium/src/+/2902821
* 2496500: Remove last deprecated extension Event ctor.
https://chromium-review.googlesource.com/c/chromium/src/+/2496500
* chore: fixup malformed pepper support patch
* chore: bump chromium in DEPS to 92.0.4515.0
* 2908461: Add CreateEmptyPrintPagesParamsPtr() inside print_view_manager_base.cc.
https://chromium-review.googlesource.com/c/chromium/src/+/2908461
* 2880838: viz: add optional HDRMetadata to TransferableResource
https://chromium-review.googlesource.com/c/chromium/src/+/2880838
* chore: fixup patch indices
* chore: bump chromium in DEPS to 92.0.4515.5
* chore: update patches
* chore: bump chromium in DEPS to 92.0.4515.7
* chore: bump chromium in DEPS to 92.0.4515.9
* chore: bump chromium in DEPS to 93.0.4522.0
* chore: bump chromium in DEPS to 93.0.4523.0
* chore: bump chromium in DEPS to 93.0.4524.0
* chore: update patches
* chore: enable_pak_file_integrity_checks was reverted
* chore: update patches
* refactor: base/optional was replaced with absl::optional
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* refactor: replace all usages of base::nullopt with absl::nullopt
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* chore: add missing base::Contains include
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* refactor: replace all usages of base::make_optional with
absl::make_optional
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* refactor: replace WorldScriptContext() with GetScriptContextFromWorldId
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2893213
* chore: clean up left over opening namespace
Refs: 95bfe6d08f
* chore: add missing base::Contains include
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* refactor: replace GetCurrentDisplayIterator with the hard checker
GetCurrentDisplay
This code looks suspicious but if the iterator was invalid before it
will also be invalid now.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2893191
* refactor: headers are now passed directly in extensions client
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2918906
* refactor: base::DictionaryValue::empty() has been removed
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2912424
* chore: add missing includes for network URLLoaderFactory
Refs: unknown, probably a side effect of header changes
* refactor: make convenience wrapper around AppendArg
There is no converter FromV8 for base::StringPiece (apparently its not
possible). So we now take in an std::string and use the construct for
StringPiece to do implicit conversion.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2905544
* chore: add patch
* chore: bump chromium in DEPS to 93.0.4525.0
* chore: update patches
* refactor: CanResize has been de-virtualized
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2485774
* chore: update resource integrity patch
* chore: add character encoding idl patch
* chore: bump chromium in DEPS to 93.0.4526.0
* chore: update patches
* chore: bump chromium in DEPS to 93.0.4527.0
* chore: bump chromium in DEPS to 93.0.4528.0
* chore: update patches
* chore: update idl encoding patch
* chore: bump chromium in DEPS to 93.0.4529.0
* chore: update patches
* chore: bump chromium in DEPS to 93.0.4530.0
* chore: update patches
* fix: only SetCanResize after the widget has been initialized
* chore: add patch for vr on windows gn gen
* spec: fix focus related tests on linux due to delay in focus swap
* chore: remove new usages of base::Optional from main
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <sattard@slack-corp.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2021-06-03 01:05:04 -07:00
Electron Bot
ca75bca667
chore: bump chromium to 90.0.4415.0 (master) ( #27694 )
...
* chore: bump chromium in DEPS to 520c02b46668fc608927e0fcd79b6a90885a48bf
* chore: bump chromium in DEPS to 90.0.4414.0
* resolve chromium conflicts
* resolve v8 conflicts
* fix node gn files
* 2673502: Remove RenderViewCreated use from ExtensionHost.
https://chromium-review.googlesource.com/c/chromium/src/+/2673502
* 2676903: [mojo] Remove most legacy Binding classes.
https://chromium-review.googlesource.com/c/chromium/src/+/2676903
* 2644847: Move self-deleting URLLoaderFactory base into //services/network.
https://chromium-review.googlesource.com/c/chromium/src/+/2644847
* 2664006: Remove from mojo::DataPipe.
https://chromium-review.googlesource.com/c/chromium/src/+/2664006
* 2674530: Remove CertVerifierService feature
https://chromium-review.googlesource.com/c/chromium/src/+/2674530
* 2668748: Move OnSSLCertificateError to a new interface.
https://chromium-review.googlesource.com/c/chromium/src/+/2668748
* 2672923: Remove RAPPOR reporting infrastructure.
https://chromium-review.googlesource.com/c/chromium/src/+/2672923
* 2673502: Remove RenderViewCreated use from ExtensionHost.
https://chromium-review.googlesource.com/c/chromium/src/+/2673502
* 2655126: Convert FrameHostMsg_ContextMenu and FrameMsg_ContextMenuClosed|CustomContextMenuAction to Mojo
https://chromium-review.googlesource.com/c/chromium/src/+/2655126
* 2628705: Window Placement: Implement screen.isExtended and change event
https://chromium-review.googlesource.com/c/chromium/src/+/2628705
* 2643161: Refactor storage::kFileSystem*Native*
https://chromium-review.googlesource.com/c/chromium/src/+/2643161
* fix build
* only remove the biggest subdir of //ios
* chore: bump chromium in DEPS to 90.0.4415.0
* update patches
* update sysroots
* 2686147: Remove WebContentsObserver::RenderViewCreated().
https://chromium-review.googlesource.com/c/chromium/src/+/2686147
* 2596429: Fixing how extension's split and spanning modes affect OriginAccessList.
https://chromium-review.googlesource.com/c/chromium/src/+/2596429
* 2686026: [mojo] Delete AssociatedInterfacePtr (replaced by AssociatedRemote)
https://chromium-review.googlesource.com/c/chromium/src/+/2686026
* 2651705: Move ui/base/dragdrop/file_info to ui/base/clipboard
https://chromium-review.googlesource.com/c/chromium/src/+/2651705
* 358217: drawBitmap is deprecated
https://skia-review.googlesource.com/c/skia/+/358217
* fix gn check
* 2678098: Use gen/front_end as input to generate_devtools_grd
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2678098
* 2674530: Remove CertVerifierService feature
https://chromium-review.googlesource.com/c/chromium/src/+/2674530
* fixup 2664006: Remove from mojo::DataPipe.
https://chromium-review.googlesource.com/c/chromium/src/+/2664006
* fixup build_add_electron_tracing_category.patch
* 2673415: [base] Prepare CrashReporterClient for string16 switch
https://chromium-review.googlesource.com/c/chromium/src/+/2673415
* 2673413: Add CursorFactoryWin to handle Cursors on Windows
https://chromium-review.googlesource.com/c/chromium/src/+/2673413
* 2668748: Move OnSSLCertificateError to a new interface.
https://chromium-review.googlesource.com/c/chromium/src/+/2668748
* fix mas gn check
* update patch after merge
* Update node for .mjs files
* build: load v8_prof_processor dependencies as ESM
* chore: add patch to fix linux 32bit
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2021-03-04 09:27:05 -08:00
Milan Burda
ddf3ef0a5f
refactor: use C++11 class member variable initialization ( #27477 )
2021-01-26 12:16:21 -06:00
Paul Frazee
81d09bea44
fix: correctly handle nexttick scheduling in stream reads ( #24022 )
2020-06-11 09:55:59 -07:00
Electron Bot
dc72f74020
chore: bump chromium to 580fe983e138952553cd6af11ee8b (master) ( #23379 )
...
* chore: bump chromium in DEPS to 5ce64b91b4d6a78c97480059f15ff6469fc0918e
* chore: bump chromium in DEPS to e74c73d0000f81b3f40a513176c8d024bba57d28
* chore: bump chromium in DEPS to 501640e650d4657ba63db65fa257e4a899168de7
* chore: bump chromium in DEPS to 00db20e1bc3d77706723a87ada3c1c647a1c37b7
* chore: update patches
* refactor: AddNewContents now takes a target_url
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2167732
* chore: SetHostCleanupFinalizationGroupCallback has been removed from V8
* refactor: use WebInputEvent::Namespace types directly
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2160523
* refactor: FollowRedirect takes in cors exempt headers now
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2129787
* refactor: printing::DuplexMode moved to mojo
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2162388
* refactor: use MessagePortDescriptor instead of raw mojo::MessagePipeHandles
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1952124
* chore: update patches
* chore: bump chromium in DEPS to f1537676d613f3567cfb43adf577b3847fba4bc3
* chore: update patches
* refactor: service_manager::BinderMapWithContext merged into mojo::BinderMap
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2174654
* chore: unused argument removed from ReadAvailableTypes in ui::Clipboard
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2173666
* chore: bump chromium in DEPS to 949888433ab935dd6125c107226a4c9d6da9bf48
* chore: update patches
* update patches
* chore: update sysroots
* chore: bump chromium in DEPS to eaac5b5035fe189b6706e1637122e37134206059
* chore: bump chromium in DEPS to 258b54b903d33dab963adf59016691e6537f8b70
* build: update patches
* refactor: cursor.mojom and cursor_types.mojom moved to //ui/base/cursor/mojom
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2172874
* chore: DesktopWindowTreeHostLinux becomes DesktopWindowTreeHostPlatform
Refs:
* refactor: LogErrorEventDescription moved from ui to x11
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2164245
* chore: update patches
* chore: bump chromium in DEPS to bd06abcfe807d4461683479237cdd920dafa52ca
* chore: bump chromium in DEPS to 1afb0891e56f1e79d204db43ca053a46d0974511
* chore: bump chromium in DEPS to 5cb0f794bf7f155bf8c0a241b94e01c9d90c2744
* chore: bump chromium in DEPS to 37327ba3303234e1a3cd3310ca11a68e81b95123
* update patches
* remove ClientSideDetectionService from browser_process
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2175320
* refactor: shuttle cursor changed event to WebContentsObserver
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2172779
* chore: bump chromium in DEPS to 1d97904bb6936e106df13705208b73e47367c2b9
* avoid IPC crash introduced earlier in the roll
Refs: b67334e781 (diff-607f4e8f7c5686aa09af98c783925babR128)
* remove WebContentsView::SizeContents
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2188931
* chore: bump chromium in DEPS to 87066d1db0546a9de33952ba964e1e42f76f1dae
* update patches
* adapt to //content creating NetworkContexts
https://chromium-review.googlesource.com/c/chromium/src/+/2195196
* WIP temporarily ignore mojo-ified PrintHostMsg_PrintPreviewFailed
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2195343
* add checkout_pgo_profiles to DEPS
* chore: bump chromium in DEPS to a095318bec1dedf580d676f408eaeefdbd9956b1
* add blink's execution_context to electron_lib deps
Refs:
b67334e781
#, https://chromium-review.googlesource.com/c/chromium/src/+/1952124
* update patches
* update patches
* refactor: use newly mojo-ified PrintPreviewFailed
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2195343
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: update patches
* chore: remove NOTIFICATION_EXTENSIONS_READY_DEPRECATED
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2199874
* avoid a call to Profile::FromBrowserContext in printing
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2195757
* chore: bump chromium in DEPS to 8f5c6a46861a991e12ffd80554b6bd41a11b0b65
* chore: bump chromium in DEPS to ab66134739ff3b6bdb8de53bbc58a97d1b7b5d8a
* chore: bump chromium in DEPS to dd08df9f6c8d6198f0a7b931ca9e845e27dae033
* chore: update patches
* [printing] Mojofy PrintHostMsg_PrintPreviewCancelled
https://chromium-review.googlesource.com/c/chromium/src/+/2198331
* [printing] Mojofy PrintHostMsg_PrintPreviewInvalidPrinterSettings
https://chromium-review.googlesource.com/c/chromium/src/+/2200556
* [printing] Mojofy PrintHostMsg_DidPrepareDocumentForPreview
https://chromium-review.googlesource.com/c/chromium/src/+/2201496
* fix: inherit base network context params
* fix: use message handle api specific to embedders
* update patches
* chore: update v8 headers
* fixup! avoid a call to Profile::FromBrowserContext in printing
* chore: bump chromium in DEPS to f198bc3276828d992b6202d75a9da6a8363164ea
* chore: update patches
* Remove cors_exempt_headers.h
https://chromium-review.googlesource.com/c/chromium/src/+/2203759
* Supply speech recognition sandbox from service_sandbox_type.h
https://chromium-review.googlesource.com/c/chromium/src/+/2206918
* [content] Remove unused methods from WebContents
https://chromium-review.googlesource.com/c/chromium/src/+/2199113
* [XProto] Replace XAtom with x11::Atom
https://chromium-review.googlesource.com/c/chromium/src/+/2202789
* chore: bump chromium in DEPS to 5df37fabaaed09f3ea511f4ef49203d8ebee7b68
* [UI] Support secondary labels in dropdown menus
https://chromium-review.googlesource.com/c/chromium/src/+/2208976
* chore: update patches
* refactor: GetSublabelAt => GetSecondaryLabelAt
* Revert "[printing] Mojofy PrintHostMsg_DidPrepareDocumentForPreview"
This reverts commit 44ed0892a0c81716229638f17253bbb2cf8f037d.
https://chromium-review.googlesource.com/c/chromium/src/+/2208778
* Unnest CanonicalCookie::CookieInclusionStatus
https://chromium-review.googlesource.com/c/chromium/src/+/2203171
* update print-to-pdf.html with latest html data
https://bugs.chromium.org/p/chromium/issues/detail?id=1085667
* chore: bump chromium in DEPS to 5dfa8d5f706580fe983e138952553cd6af11ee8b
* fix crash in x server when setting window icon
* chore: update patches
* Use a normal return value for WebContentsView::GetContainerBounds.
https://chromium-review.googlesource.com/c/chromium/src/+/2212481
* fix build on windows
* chore: bump chromium in DEPS to 9d15054f4cba060901e43deecf74002f11f47be3
* chore: update patches
* [printing] Mojofy PrintHostMsg_CheckForCancel
https://chromium-review.googlesource.com/c/chromium/src/+/2212181
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: Electron Bot <anonymous@electronjs.org>
Co-authored-by: Andy Locascio <andy@slack-corp.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2020-05-26 13:06:26 -07:00
Electron Bot
0f2f9a580a
chore: bump chromium to 94cc24d3bb17a7406ba6c6cc6dc29 (master) ( #21485 )
2019-12-13 12:13:12 -08:00
Electron Bot
49b47ee4ed
chore: bump chromium to f755b70e34659441e72c1a928a406 (master) ( #21000 )
2019-12-10 16:22:35 -08:00
Electron Bot
eb2d2264d0
chore: bump chromium to 63be48daea281d4f8c834c2e707a7 (master) ( #19923 )
2019-09-18 15:58:00 -04:00
Heilig Benedek
3f49f984e6
fix: race condition in NodeStreamLoader ( #19811 )
...
* fix: race condition in NodeStreamLoader
* nit: add comments
2019-08-21 12:23:46 +09:00
Electron Bot
e959137a4b
chore: bump chromium to 32e0bab929213da1019992bf31d29 (master) ( #19488 )
2019-08-02 16:56:46 -07:00
Electron Bot
bd526f97a5
chore: bump chromium to 79eae5b7b2d9dac441ac0182ee160 (master) ( #19166 )
2019-07-24 15:58:51 -07:00
Samuel Attard
34c4c8d508
refactor: rename the atom namespace to electron
2019-06-19 17:33:28 -07:00
Samuel Attard
56930338e8
chore: fix linting after shell rename
2019-06-19 17:33:28 -07:00
Samuel Attard
d7f07e8a80
refactor: rename the atom directory to shell
2019-06-19 17:33:28 -07:00