Felix Rieseberg 
								
							 
						 
						
							
							
								
							
							
	d586ef2f39  
						 
						
							
							
								
								
								feature: Hot security tips ( #11810 )  
							
							 
							
							... 
							
							
							
							* 🔧  Add security issue detection (and logs)
* 🔧  Check for it on load
* 👷  Add some tests
* 👷  Make the linter happy
* 🔧  Allow them to be enabled by force
* 📝  Make message slightly prettier
* 🔧  Fix a typo in the code comment
* 🔧  Classic mistake
* 🚀  Optimize things a bit more
* 👷  Add tests, fix tests
* 📝  Document things
* 🔧  Make linter happy
* 🔧  One more piece of cleanup 
							
						 
						
							2018-02-03 07:50:12 -07:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Felix Rieseberg 
								
							 
						 
						
							
							
								
							
							
	9f0df695ca  
						 
						
							
							
								
								
								🔧  Spec: Fix style issues  
							
							 
							
							
							
						 
						
							2017-11-23 14:22:58 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Felix Rieseberg 
								
							 
						 
						
							
							
								
							
							
	3311e0bd67  
						 
						
							
							
								
								
								👷  This calls for tests  
							
							 
							
							
							
						 
						
							2017-11-18 00:51:27 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	9ced85d860  
						 
						
							
							
								
								
								Terminate tests when renderer process crashed  
							
							 
							
							
							
						 
						
							2017-07-31 16:24:23 +09:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	0c8f773dec  
						 
						
							
							
								
								
								Remove debug logging  
							
							 
							
							
							
						 
						
							2017-07-17 11:55:15 -07:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	c71b0a5441  
						 
						
							
							
								
								
								Add spec for configuring web preferences from sandboxed new-window event  
							
							 
							
							
							
						 
						
							2017-07-17 11:55:15 -07:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									deepak1556 
								
							 
						 
						
							
							
								
							
							
	50ac7b2edd  
						 
						
							
							
								
								
								Revert "Merge pull request  #8724  from electron/defer_load_url"  
							
							 
							
							... 
							
							
							
							Possible cause for #9121 
This reverts commit 886b47e713 , reversing
changes made to 479af3c9e2 . 
							
						 
						
							2017-06-05 19:04:21 +05:30  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	5cf4995f2e  
						 
						
							
							
								
								
								DRY up logic to check if native modules should be loaded  
							
							 
							
							
							
						 
						
							2017-05-30 09:15:38 -07:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	fd782706b2  
						 
						
							
							
								
								
								Add explicit spec for removing preload from webview  
							
							 
							
							
							
						 
						
							2017-05-17 13:47:00 -07:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									22222 
								
							 
						 
						
							
							
								
							
							
	4044548f3e  
						 
						
							
							
								
								
								Add 'will-prevent-unload' event.  
							
							 
							
							
							
						 
						
							2017-05-11 06:35:35 -05:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									deepak1556 
								
							 
						 
						
							
							
								
							
							
	e4524ce42e  
						 
						
							
							
								
								
								add spec  
							
							 
							
							
							
						 
						
							2017-05-01 16:53:55 +09:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	35a627fd60  
						 
						
							
							
								
								
								Log all crashes during specs  
							
							 
							
							
							
						 
						
							2017-04-24 09:26:24 -07:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	de62f1ea6c  
						 
						
							
							
								
								
								Restart crash service in each spec  
							
							 
							
							
							
						 
						
							2017-04-19 16:37:24 -07:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	6fcb784f6e  
						 
						
							
							
								
								
								Add failing spec for no callback  
							
							 
							
							
							
						 
						
							2017-03-06 10:49:23 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									deepak1556 
								
							 
						 
						
							
							
								
							
							
	90885d1d8c  
						 
						
							
							
								
								
								simply spec  
							
							 
							
							
							
						 
						
							2017-03-06 00:22:20 +05:30  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									deepak1556 
								
							 
						 
						
							
							
								
							
							
	eb827eb020  
						 
						
							
							
								
								
								update spec  
							
							 
							
							
							
						 
						
							2017-03-06 00:10:46 +05:30  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									deepak1556 
								
							 
						 
						
							
							
								
							
							
	763b9ab8d8  
						 
						
							
							
								
								
								add zoom spec  
							
							 
							
							
							
						 
						
							2017-02-18 01:34:32 +05:30  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	a7c050107b  
						 
						
							
							
								
								
								Remove guest from will-attach-webview event  
							
							 
							
							
							
						 
						
							2017-02-09 11:47:45 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	acff2f6baf  
						 
						
							
							
								
								
								Adjust src from will-attach-webview  
							
							 
							
							
							
						 
						
							2017-02-09 11:45:07 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	46f1a49594  
						 
						
							
							
								
								
								new-webview -> will-attach-webview  
							
							 
							
							
							
						 
						
							2017-02-09 11:45:07 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	706b9f6cbf  
						 
						
							
							
								
								
								Add new-webview specs  
							
							 
							
							
							
						 
						
							2017-02-09 11:45:07 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	1004d205d8  
						 
						
							
							
								
								
								Add spec for unhandledRejection event in main process  
							
							 
							
							
							
						 
						
							2017-01-26 14:46:50 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	24fb560a9d  
						 
						
							
							
								
								
								Add failing spec for uncaught main process errors  
							
							 
							
							
							
						 
						
							2017-01-26 14:46:50 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	330ac5f266  
						 
						
							
							
								
								
								Fix standard linting error  
							
							 
							
							
							
						 
						
							2017-01-25 12:36:55 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	56a8eb3a94  
						 
						
							
							
								
								
								Check that sender is a WebContents instance  
							
							 
							
							
							
						 
						
							2017-01-25 12:36:55 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Charlie Hess 
								
							 
						 
						
							
							
								
							
							
	f6410d3b77  
						 
						
							
							
								
								
								Assert that listener count decreases after a remove event.  
							
							 
							
							
							
						 
						
							2017-01-25 12:36:55 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Charlie Hess 
								
							 
						 
						
							
							
								
							
							
	c213971a2d  
						 
						
							
							
								
								
								Write a warning instead of crashing.  
							
							 
							
							
							
						 
						
							2017-01-25 12:36:55 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	45986405b8  
						 
						
							
							
								
								
								Assert remote event names  
							
							 
							
							
							
						 
						
							2017-01-25 12:36:55 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	97dd680b32  
						 
						
							
							
								
								
								Remove linter errors  
							
							 
							
							
							
						 
						
							2017-01-12 10:28:08 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	c5da330cdf  
						 
						
							
							
								
								
								Add failing spec for sandboxed window.open  
							
							 
							
							
							
						 
						
							2017-01-12 10:28:08 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	1f07977f09  
						 
						
							
							
								
								
								Remove lint errors  
							
							 
							
							
							
						 
						
							2017-01-06 09:58:40 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	fd23c7bf76  
						 
						
							
							
								
								
								Assert duplicate objects are supported  
							
							 
							
							
							
						 
						
							2017-01-06 09:58:40 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	1944fdc962  
						 
						
							
							
								
								
								Track visited parents and null out cycles  
							
							 
							
							
							
						 
						
							2017-01-06 09:58:40 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	12382f064b  
						 
						
							
							
								
								
								Add failing spec for cycle in options  
							
							 
							
							
							
						 
						
							2017-01-06 09:58:40 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	abea1196de  
						 
						
							
							
								
								
								Add spec for closing from will-navigate listener  
							
							 
							
							
							
						 
						
							2016-12-28 13:40:07 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	2a8b36c761  
						 
						
							
							
								
								
								Merge pull request  #8134  from deepak1556/empty_client_certificate_patch  
							
							 
							
							... 
							
							
							
							app: select-client-certificate event callback can accept certificate optionally 
							
						 
						
							2016-12-15 08:31:12 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	7a5ec96d53  
						 
						
							
							
								
								
								Prevent input event from main process  
							
							 
							
							
							
						 
						
							2016-12-13 15:54:13 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Paul Frazee 
								
							 
						 
						
							
							
								
							
							
	99ea50649a  
						 
						
							
							
								
								
								finish implementation of {secure:true} opt on protocol.registerStandardScehesm, and add working test  
							
							 
							
							
							
						 
						
							2016-12-12 12:49:57 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									deepak1556 
								
							 
						 
						
							
							
								
							
							
	f124732431  
						 
						
							
							
								
								
								add spec  
							
							 
							
							
							
						 
						
							2016-12-09 09:37:46 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									deepak1556 
								
							 
						 
						
							
							
								
							
							
	cbddbdb296  
						 
						
							
							
								
								
								fix code style  
							
							 
							
							
							
						 
						
							2016-12-07 15:33:56 +05:30  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									deepak1556 
								
							 
						 
						
							
							
								
							
							
	1c45285fe3  
						 
						
							
							
								
								
								add spec  
							
							 
							
							
							
						 
						
							2016-12-07 13:26:06 +05:30  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	857e1da6a3  
						 
						
							
							
								
								
								Make executeJavaScript return a Promise so that caught errors can be sent to the caller  
							
							 
							
							
							
						 
						
							2016-11-03 09:33:47 -07:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									ali.ibrahim 
								
							 
						 
						
							
							
								
							
							
	c198828e58  
						 
						
							
							
								
								
								Adding gc tests: fixing a memory leak with C++ URLRequest objects.  
							
							 
							
							
							
						 
						
							2016-10-17 19:02:25 +02:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									ali.ibrahim 
								
							 
						 
						
							
							
								
							
							
	9b4e9c642a  
						 
						
							
							
								
								
								Making test code run directly in main browser context to avoid rpc persistent handles.  
							
							 
							
							
							
						 
						
							2016-10-17 11:51:20 +02:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	b3b856f476  
						 
						
							
							
								
								
								Set productName in main process on Linux  
							
							 
							
							
							
						 
						
							2016-10-06 09:02:02 -07:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	d407eab0ff  
						 
						
							
							
								
								
								Set crashReporter productName in specs  
							
							 
							
							
							
						 
						
							2016-09-08 11:52:29 -07:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	10d39f673a  
						 
						
							
							
								
								
								Add failing spec for duplicate references over IPC  
							
							 
							
							
							
						 
						
							2016-08-25 09:25:13 -07:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	dfb6a9b07d  
						 
						
							
							
								
								
								Show window when not on CI  
							
							 
							
							
							
						 
						
							2016-08-17 14:25:42 -07:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	ad07a20d9a  
						 
						
							
							
								
								
								Use electabul to instrument and report coverage  
							
							 
							
							
							
						 
						
							2016-08-03 16:23:39 -07:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	300bf24241  
						 
						
							
							
								
								
								Save coverage data when browser windows are destroyed  
							
							 
							
							
							
						 
						
							2016-08-03 16:23:38 -07:00