deepak1556
5c25855ac5
create user data dir on thread that allows IO
2018-01-02 16:37:05 +09:00
Cheng Zhao
d04ae88426
The RenderWidgetHostView might not be available when showing menu
2018-01-01 19:37:59 +09:00
Cheng Zhao
bc61f2eafa
Copy the callback instead of reference
...
I don't really see how this could be a problem, likely a bug of VS 2017?
2018-01-01 19:37:59 +09:00
Cheng Zhao
46330ac2a9
Remove the closed event of Menu
...
The callback of Menu.popup does more things, and there is actually no
request for the closed event.
2018-01-01 17:22:07 +09:00
Cheng Zhao
c3eadd5b63
mac: Call callback when menu is programmely closed
2018-01-01 16:49:25 +09:00
Cheng Zhao
7b01a8b860
Add callback parameter to Menu.popup
2018-01-01 16:26:19 +09:00
Cheng Zhao
d7bc127c60
mac: Correctly close popup menu
2018-01-01 15:40:15 +09:00
Cheng Zhao
c0c2461245
Do not create duplicate V8Platform in NodeDebugger
2017-12-22 20:29:09 +09:00
Cheng Zhao
00afeaba9a
Use Node's V8Platform instead of gin's
2017-12-22 20:29:08 +09:00
Cheng Zhao
65871cd567
Merge pull request #11238 from electron/spellchecker_iframe_patch
...
fix: manually set spellchecker for sub frames
2017-12-21 17:00:01 +09:00
Cheng Zhao
7a8864063b
mac: Handle the case when closing all menu runners
2017-12-21 15:57:27 +09:00
Cheng Zhao
088042841d
win: Correctly close popup menu
2017-12-21 15:26:32 +09:00
Cheng Zhao
e4770c7604
Coding style fixes
2017-12-20 18:48:09 +09:00
deepak1556
83d2917363
fix: manually set spellchecker for sub frames
2017-12-20 12:48:02 +05:30
Heilig Benedek
ef7357dedc
update tests for menu closed event and call cancel on closePopup
2017-12-20 15:40:07 +09:00
Heilig Benedek
bcef6eb3df
document menu closed event and fix styling issue
2017-12-20 15:40:07 +09:00
Heilig Benedek
c586806609
fix flash menu being unresponsive to commands
2017-12-20 15:40:07 +09:00
Heilig Benedek
d5ab691fdb
fix osr devtools crash introduced during merge
2017-12-20 12:57:02 +09:00
Cheng Zhao
b2e6340622
Reduce the number of helpers
2017-12-20 10:49:49 +09:00
Cheng Zhao
4fd8b04329
Better field names for details object
2017-12-20 10:25:31 +09:00
Samuel Attard
4d7b85bd01
Appease the linter
2017-12-20 10:21:38 +09:00
Samuel Attard
98e9311669
Give user access to the URL that is attempting to be openExternal'ed
2017-12-20 10:21:38 +09:00
Cheng Zhao
81527b71ba
Merge pull request #11279 from sethlu/openrecent
...
Update submenu's title at replacement
2017-12-19 15:28:02 +09:00
Cheng Zhao
b27e42f3f7
Fix indentions
2017-12-19 10:42:36 +09:00
Hugo Mano
ae7b96991c
Add webFrame.setIsolatedWorldSecurityOrigin
...
Move vector to cc file
Map executed javascript in isolated world to url
Some 💅
Documentation
Use WebSource[] as argument in executeJavaScriptInIsolatedWorld
Refactor and lint with @poiru’s comments
Remove duplicate call
Typo
Lint
2017-12-19 10:36:03 +09:00
Hugo Mano
389edb6229
Add webFrame.setIsolatedWorldHumanReadableName
2017-12-19 10:36:03 +09:00
Hugo Mano
f74f113d23
Add webFrame.setIsolatedWorldContentSecurityPolicy
2017-12-19 10:36:03 +09:00
Alexandre Lachèze
936d8c1117
Add webframe. executeJavaScriptInIsolatedWorld
...
Attempt runInIsolatedWorldContext
Replace RunInIsolatedWorldContext by GetIsolatedWorldGlobalObject
Fix linting
Remove useless getIsolatedWorldGlobalObject
Add support for scriptExecutionType
2017-12-19 10:36:03 +09:00
Shelley Vohr
3fc844c15a
add loop to catch null values
2017-12-13 14:02:43 -05:00
Shelley Vohr
6252ce466c
remove failing badDefault
2017-12-12 13:39:38 -05:00
Shelley Vohr
8b447b9291
fixing error in registerDefaults
2017-12-12 13:08:09 -05:00
Alexey Kuzmin
1caa04c0bf
Revert "Add systemPreferences.registerDefaults()"
2017-12-12 13:59:15 +03:00
Cheng Zhao
19f1fef040
Merge pull request #11283 from electron/fix-event-subscriber-race
...
Fix race condition in event_subscriber.h
2017-12-12 10:49:17 +09:00
Charles Kerr
99c980ab40
Merge pull request #11395 from electron/add-reg-defaults
...
Add systemPreferences.registerDefaults()
2017-12-11 17:45:32 -06:00
Shelley Vohr
a8e67e7f61
fixes from review
2017-12-11 18:20:12 -05:00
Shelley Vohr
84bab48627
improve error handling
2017-12-11 13:11:03 -05:00
Charles Kerr
87f8bd4ea7
Merge pull request #11359 from electron/fix_spell_checker_crash
...
Fixed crash in `atom::api::SpellCheckClient`
2017-12-11 10:18:27 -06:00
Shelley Vohr
c5aeda1fdd
fixes from code review
2017-12-11 00:20:26 -05:00
Shelley Vohr
18ee34f1a1
add method binding and error guards
2017-12-10 11:25:43 -05:00
Shelley Vohr
1ccad4a7e9
fix capitalization and clean logic
2017-12-10 11:04:05 -05:00
Shelley Vohr
f82086e6d3
first pass at adding infra for registerDefaults
2017-12-10 00:45:49 -05:00
simurai
fe0f203312
Replace app icons
2017-12-07 16:10:45 -05:00
deepak1556
19de41b764
BrowserClient::CanCreateWindow is no longer called on the IO thread
...
https://codereview.chromium.org/2821473002
2017-12-07 09:47:32 +05:30
Charles Kerr
5fa29fcf58
Merge pull request #11329 from electron/remove-classes-key
...
fix: Properly cleanup in `removeAsDefaultProtocolClient`
2017-12-06 17:31:50 -06:00
Ales Pergl
7a73b1d523
Fixed crash in atom::api::SpellCheckClient
...
The class didn't save the V8 context for the spell checking JS function. When
it later tried to call the JS function and there was no active context, V8
crashed.
I also optimized the spell checking loop by introducing `SpellCheckScope` and
reusing the V8 handles throughout the whole loop.
2017-12-06 14:50:20 +01:00
Cheng Zhao
9c109daa4b
Merge pull request #11168 from sethlu/fix-icns-color
...
fix: Update icns
2017-12-06 14:45:36 +09:00
Thiago de Arruda
897712359f
Implement powerMonitor "suspend"/"resume" events for Linux.
2017-12-05 08:12:44 -03:00
Cheng Zhao
24b3ee3a4a
Revert some unnecessary changes
2017-12-05 16:50:25 +09:00
Cheng Zhao
cb3a9c69ab
Add a SessionPreferences to manage session related data
...
By design the BrowserClient should not be aware of the api:: classes.
2017-12-05 15:59:15 +09:00
Cheng Zhao
776e8afa2b
Coding style changes
2017-12-05 11:50:06 +09:00
