Commit graph

13 commits

Author SHA1 Message Date
Charles Kerr
d663b4eaee
fix: fix gn cpplint warnings (#14583)
* chore: fix cpplint 'include_what_you_use' warnings

Typically by including <memory>, <utility> etc.

* chore: fix 'static/global string constant' warning

Use C style strings instead of std::string.

Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

/home/charles/electron/electron-gn/src/electron/script/cpplint.js

* refactor: remove global string variables.

Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.

The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

* fix: initializer error introduced in last commit

* fix: remove WIP file that was included by accident

* fix: include order

* fix: include order

* fix: include order

* fix: include order, again
2018-09-12 19:25:56 -05:00
Shelley Vohr
c6f4bbd143
also format missing .cc files 2018-04-18 20:48:45 -04:00
deepak1556
62635f43f4 base::LaunchOptions fds_to_remap is no longer a pointer
https://codereview.chromium.org/2950153002
2018-02-23 10:21:23 +09:00
Aleš Pergl
c49cb29ddf Disallow launching unknown apps via browser client.
CVE-2018-1000006
2018-01-22 16:49:30 -06:00
Cheng Zhao
3de41fb22d Correctly quotes the argv on Windows 2016-06-02 21:10:39 +09:00
Cheng Zhao
9a08cbce27 Uniform when to use args or argv 2016-06-02 20:41:59 +09:00
Cheng Zhao
0d066de53e Make sure the new instance inherite cwd on mac 2016-06-02 20:32:29 +09:00
Cheng Zhao
0646f6ea9e Implement Relaunch on Windows 2016-06-02 19:49:36 +09:00
Cheng Zhao
a3f39e9d0b Implement Relaunch on Linux 2016-06-02 16:54:21 +09:00
Cheng Zhao
c3fe2dae9d Separate LaunchProgram from mac implementation 2016-06-02 16:23:46 +09:00
Cheng Zhao
060829da64 Separate implementations of RelauncherMain and RelauncherSynchronizeWithParent 2016-06-02 09:09:32 +09:00
Cheng Zhao
fc30a2a084 Use AtomCommandLine to process command line parameters 2016-06-01 22:15:50 +09:00
Cheng Zhao
6df18956cd Get ready to make relauncher cross-platform 2016-06-01 22:04:20 +09:00
Renamed from chromium_src/chrome/browser/mac/relauncher.cc (Browse further)