Felix Rieseberg
|
5b7f7c8a1a
|
🔧 Menu returns its properties now
|
2017-12-12 11:25:01 -08:00 |
|
Felix Rieseberg
|
ffc54967e9
|
🔧 Fix value shift
|
2017-12-12 11:25:01 -08:00 |
|
Felix Rieseberg
|
99031834ff
|
🔧 Cleanup
|
2017-12-12 11:25:01 -08:00 |
|
Felix Rieseberg
|
3719ee0b53
|
🔧 Allow for menu.popup({})
|
2017-12-12 11:25:01 -08:00 |
|
Felix Rieseberg
|
9e660b1d32
|
🔧 Always find a window (or error)
|
2017-12-12 11:25:01 -08:00 |
|
Felix Rieseberg
|
4f901c6d24
|
🔧 Oh wow, that looks wrong
|
2017-12-12 11:25:01 -08:00 |
|
Alexey Kuzmin
|
1c8eb03574
|
Revert "fix: Fix menu.popup() bugs"
|
2017-12-12 13:59:34 +03:00 |
|
Felix Rieseberg
|
927c63b477
|
🔧 Last round of feedback
|
2017-12-11 15:19:33 -08:00 |
|
Felix Rieseberg
|
89b90be6a2
|
🔧 Feedback
|
2017-12-11 14:43:35 -08:00 |
|
Felix Rieseberg
|
22e9d665d2
|
🔧 Menu returns its properties now
|
2017-12-11 14:03:01 -08:00 |
|
Felix Rieseberg
|
93b46116f4
|
🔧 Fix value shift
|
2017-12-11 13:30:35 -08:00 |
|
Felix Rieseberg
|
abd56eda6f
|
🔧 Cleanup
|
2017-12-08 14:40:51 -08:00 |
|
Felix Rieseberg
|
955564abd7
|
🔧 Allow for menu.popup({})
|
2017-12-08 14:37:16 -08:00 |
|
Felix Rieseberg
|
bd6767fac6
|
🔧 Always find a window (or error)
|
2017-12-08 14:36:52 -08:00 |
|
Felix Rieseberg
|
38bb9baac5
|
🔧 Oh wow, that looks wrong
|
2017-12-08 14:36:29 -08:00 |
|
Birunthan Mohanathas
|
4e859b4718
|
Remove "async" option from menu.popup()
All menus are async now. See "Cleanup MenuRunner API"
https://codereview.chromium.org/2790773002
|
2017-11-24 10:58:17 +09:00 |
|
Felix Rieseberg
|
d475eaf011
|
🔧 One commit per character is now hot
|
2017-11-07 19:44:24 -08:00 |
|
Felix Rieseberg
|
3dcde82485
|
🔧 Make this easier to read
|
2017-11-07 18:26:10 -08:00 |
|
Felix Rieseberg
|
1454783450
|
🔧 Check menu for being falsy
|
2017-11-07 13:29:14 -08:00 |
|
Shelley Vohr
|
bccaf56200
|
remove common sense comments
|
2017-10-25 12:23:41 -04:00 |
|
Shelley Vohr
|
ffd43c1886
|
remove quotes and const replaces
|
2017-10-25 10:17:41 -04:00 |
|
Shelley Vohr
|
e8935232b1
|
clean falsy statements
|
2017-10-24 18:52:12 -04:00 |
|
Shelley Vohr
|
75f32afcd5
|
clean up excess code from generateGroupId
|
2017-10-24 00:24:57 -04:00 |
|
Shelley Vohr
|
f93121b226
|
don't reassign parameters in Menu.prototype.popup
|
2017-10-24 00:07:39 -04:00 |
|
Shelley Vohr
|
b1e707d535
|
abstract out switch case from Menu.prototype.insert
|
2017-10-23 23:46:39 -04:00 |
|
Shelley Vohr
|
7c0f7329d9
|
appease the linter overlords
|
2017-10-23 22:35:42 -04:00 |
|
Shelley Vohr
|
508b614769
|
remove excess code in delegate
|
2017-10-23 22:33:23 -04:00 |
|
Shelley Vohr
|
9b364d5be3
|
refactor menuWillShow
|
2017-10-23 22:22:39 -04:00 |
|
Shelley Vohr
|
9038987e1d
|
significant cleanup; all tests still passing
|
2017-10-23 20:04:22 -04:00 |
|
Shelley Vohr
|
3fc5d51a96
|
clean up delegate
|
2017-10-23 18:35:16 -04:00 |
|
Shelley Vohr
|
577c0042b0
|
update to ES6
|
2017-10-23 14:47:47 -04:00 |
|
Shelley Vohr
|
87802b2c17
|
initial port of things into a Menu class
|
2017-10-23 12:11:59 -04:00 |
|
Shelley Vohr
|
61a93c711c
|
clean up popup
|
2017-10-23 00:47:02 -04:00 |
|
Shelley Vohr
|
f9c3123f5f
|
clean up menuWillShow
|
2017-10-23 00:16:35 -04:00 |
|
Shelley Vohr
|
1cd53768ab
|
clean up indexToInsertByPosition
|
2017-10-22 23:57:23 -04:00 |
|
Shelley Vohr
|
b7ebee985b
|
refactor indexOfItemById
|
2017-10-22 23:51:33 -04:00 |
|
Shelley Vohr
|
c932871bb1
|
change default to null
|
2017-09-26 20:35:14 -04:00 |
|
Shelley Vohr
|
f49f7d65a5
|
remove check on items instance
|
2017-09-26 14:38:34 -04:00 |
|
Shelley Vohr
|
afe033a6e1
|
stray semicolon fml
|
2017-09-26 12:10:16 -04:00 |
|
Shelley Vohr
|
4753ada7a9
|
rewrite method with only id parameter
|
2017-09-26 12:05:45 -04:00 |
|
Shelley Vohr
|
5217718d7b
|
conform to linter standard
|
2017-09-26 09:50:47 -04:00 |
|
Shelley Vohr
|
ea42851c9b
|
add first pass at getMenuItemById
|
2017-09-26 09:47:13 -04:00 |
|
Kevin Sawicki
|
23b235c9c7
|
Default async to false when object is specified
|
2017-03-20 20:37:52 -07:00 |
|
Kevin Sawicki
|
c951e253c6
|
Default to focused window whenever param is null/undefined
|
2017-02-24 08:39:22 -08:00 |
|
Kevin Sawicki
|
3e05350d6b
|
Check that window is non-null before accessing constructor prop
|
2017-02-24 08:39:22 -08:00 |
|
Kevin Sawicki
|
d0b07d5c36
|
Check that x is non-null
|
2017-02-22 10:49:25 -08:00 |
|
Kevin Sawicki
|
6a023dc4fe
|
Add Menu.closePopup API on macOS
|
2017-02-22 10:30:28 -08:00 |
|
Kevin Sawicki
|
4430927f98
|
Add async option to menu.popup
|
2017-02-22 10:30:28 -08:00 |
|
Zeke Sikelianos
|
8aaf029e55
|
remove unused var
|
2016-10-10 15:38:27 -07:00 |
|
Zeke Sikelianos
|
2cd10d339f
|
remove duplicated prop copying
|
2016-10-10 11:07:01 -07:00 |
|