Commit graph

46 commits

Author SHA1 Message Date
Marco Trevisan (Treviño)
59ed6ad413 Notification: pass tag to Show method 2016-04-13 06:12:46 +02:00
Felix Rieseberg
b68be5c583 🏁 Notify only when enabled
- Previously, we'd attempt to create a notification no matter what the
  user's configuration was. Microsoft advises against that, because it
  can create race conditions if notifications are disabled.
- This fixes the issue.

Closes https://github.com/atom/electron/issues/4681
2016-03-15 17:10:24 -07:00
Paul Betts
157f3abe64 Not quite sure how this ever worked 2016-03-07 22:02:42 -08:00
Paul Betts
da59c0f58b basictypes.h => macros.h 2016-03-07 21:40:41 -08:00
Felix Rieseberg
728f0f985b 🏁 🍎 Add Silent Notification Support
* Implements support for silent notifications on Windows and OS X
 * Exposes bool `silent` to Linux notification presenters
2016-01-21 09:24:42 -08:00
Cheng Zhao
82cef44623 win: Fire NotificationFailed when failed to show notification 2015-12-25 11:17:35 +08:00
Cheng Zhao
b091f27abf win: Adapt to new Notification style 2015-12-25 11:05:48 +08:00
Cheng Zhao
513b6ae0d6 Do not use icon url when showing notification 2015-12-24 20:03:54 +08:00
Cheng Zhao
087eeedab8 Use application name when app user model ID is not available 2015-11-24 15:11:43 +08:00
Cheng Zhao
c060539562 Only create NotificationPresenter when succeeded to initailize toast manager
This fix crash when we failed to initailize toast manager.
2015-11-24 14:40:58 +08:00
Cheng Zhao
aa8d164036 Use AppUserModelID as app id 2015-11-20 13:28:37 +08:00
Felix Rieseberg
571b595571 Fix Tag Typo
We should probably have tests for Windows notifications ;-)
2015-11-16 07:41:37 -08:00
Cheng Zhao
8ff0b050f8 There is no more NotificationError 2015-11-16 16:47:34 +08:00
Milan Burda
dedf3553e2 Call content::DesktopNotificationDelegate::NotificationError when toast notification fails on Windows 2015-11-13 15:42:35 +01:00
Felix Rieseberg
b4ac9547c4 Windows Toasts: Don't call WFI statically 2015-11-10 18:37:43 -08:00
Felix Rieseberg
2c84d70f8f Delay Load WinRT Libraries 2015-11-10 18:04:09 -08:00
Cheng Zhao
f9f8a289d9 Simplify the management of objects 2015-11-10 20:23:08 +08:00
Cheng Zhao
4f73de0930 Make the toast type really work 2015-11-10 20:07:12 +08:00
Cheng Zhao
6b9371c4cd Use smart pointer for everything 2015-11-10 19:50:38 +08:00
Cheng Zhao
1b9c9e40e3 Code cleanup with Chromium's coding style 2015-11-10 18:30:58 +08:00
Cheng Zhao
37a89ee0d9 Fix compilation error 2015-11-10 18:04:46 +08:00
Milan Burda
8f5463faab Simplify ToastEventHandler using WRL::RuntimeClass, which implements the IUnknown interface 2015-11-09 20:47:18 +01:00
Jason Poon
8dbeca8c7f Windows Toasts: Hide(), Runtime Check, Header Cleanup 2015-11-09 12:00:50 +01:00
Felix Rieseberg
86ea0759d8 Windows Toasts: Icons, Events, Cleanup, Documentation
- Enable documentations
- Add a small usage example to the header
- Final cleanups
2015-11-09 12:00:49 +01:00
Jason Poon
498bff9e5a Windows Toasts: Enable Basic Notifications
To test this puppy out, build and open up the Chromium Dev Tools.
Then, run `new Notification("Test title", {body: "Test body"});`
2015-11-09 12:00:21 +01:00
Cheng Zhao
81d31b1d49 Remove Windows's devtools implementation. 2014-07-09 10:37:54 +08:00
Adam Roben
8f367f6b35 More coding style fixes 2014-07-07 14:42:30 -04:00
Adam Roben
e86c409e6b Update DevToolsWindow to use views and aura
This is required to make it work in Chrome 35.
2014-07-07 14:27:23 -04:00
Adam Roben
307d936d75 Update to use CR_* Windows message macros
See https://codereview.chromium.org/146833020.
2014-06-27 13:40:33 -04:00
Cheng Zhao
1b274a1fd6 Add comments on the usage of attached devtools. 2014-06-10 12:44:30 +08:00
Cheng Zhao
9a70c9bb44 Enable undocked devtools. 2014-06-10 12:35:23 +08:00
Cheng Zhao
d70d24c360 Implement setting dock side. 2014-06-10 12:03:20 +08:00
Cheng Zhao
1943d88bdc Handle focus correctly. 2014-06-10 11:37:07 +08:00
Cheng Zhao
bd0f9df96c Put devtools in split view. 2014-06-10 10:29:39 +08:00
Cheng Zhao
566022cb66 ContainerView should manage itself. 2014-06-10 10:03:35 +08:00
Cheng Zhao
b0374b6a1d Use views::View to represent web view. 2014-06-10 09:58:28 +08:00
Cheng Zhao
b080e5c52d Rename IsDevToolsOpened to IsDevToolsViewShowing. 2013-12-10 18:38:35 -08:00
Cheng Zhao
de7892cd6e Add API to get whether the devtools is opened. 2013-12-09 09:03:29 +00:00
Adam Roben
7e6f5aa734 Update for ui -> gfx moves in Chrome 31
See https://codereview.chromium.org/23769011.
2013-12-02 13:00:39 -05:00
Adam Roben
1595940723 Fix cpplint errors in devtools_window.cc 2013-11-17 19:05:21 -05:00
Adam Roben
0271ff1964 Fix cpplint errors in inspectable_web_contents_view_win.h 2013-11-17 19:03:41 -05:00
Adam Roben
073b1c164b Fix cpplint errors in inspectable_web_contents_view_win.cc 2013-11-17 19:02:49 -05:00
Adam Roben
779dfd2baf Fix most cpplint errors in devtools_window.h
It's still complaining about the non-const reference in BOOL&.
2013-11-17 19:01:36 -05:00
Adam Roben
9ac1a539ee Fix all remaining readability/namespace errors 2013-11-17 18:20:17 -05:00
Adam Roben
9ad77c4a38 Implement undocked dev tools on Windows
DevToolsWindow represents a vanilla top-level window that shows the dev tools.
It uses ui::WindowImpl to implement window functionality, which requires a
newer libchromiumcontent which contains the necessary headers for using that
class, and requires some modifications to brightray.gypi to make WTL's  headers
available.

* vendor/libchromiumcontent 2f53a96...fc02d93 (4):
  > Export third_party/wtl/include headers
  > Export test_support_base.pdb and test_support_content.pdb
  > Fix linker errors with test_support_base on Windows
  > Fix linker errors with base_prefs_test_support on Windows
2013-06-04 14:33:29 -04:00
Adam Roben
cf14f09228 Stub out InspectableWebContentsViewWin
This class doesn't implement any devtools behavior yet. Right now it's just a
glorified wrapper around a content::WebContents. But it's enough to show web
content on screen on Windows!
2013-05-22 16:57:32 -04:00