Samuel Attard
|
b31acfb706
|
docs: clarify security semantics of safeStorage (#42666)
* docs: clarify security semantics of safeStorage
* Apply suggestions from code review
Co-authored-by: Erick Zhao <erick@hotmail.ca>
* Update safe-storage.md
* Update safe-storage.md
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca>
|
2024-06-26 13:24:06 -07:00 |
|
Robo
|
34e7c3696a
|
feat: expose safestorage backend information on linux (#38873)
* feat: expose safestorage backend information on linux
* Remove gnome-keyring
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4609704
|
2023-07-13 11:14:33 +02:00 |
|
Darshan Sen
|
03e68e2efe
|
fix: fix a crash in safeStorage on Linux (#33913)
On Linux, `isEncryptionAvailable()` was crashing instead of returning a
boolean before the 'ready' event was emitted by the app. The reason of
the crash is that [`CreateKeyStorage()`](https://source.chromium.org/chromium/chromium/src/+/main:components/os_crypt/os_crypt_linux.cc;l=74;drc=35be6215ec8f09e50176f36753c68f26c63d1885;bpv=1;bpt=0)
expects the config to be set but the function responsible for setting the
config, [`SetConfig()`](https://source.chromium.org/chromium/chromium/src/+/main:components/os_crypt/os_crypt_linux.cc;l=237;drc=35be6215ec8f09e50176f36753c68f26c63d1885;bpv=1;bpt=0),
is called only after the app is ready inside [`PostCreateMainMessageLoop()`](https://github.com/electron/electron/blob/main/shell/browser/electron_browser_main_parts.cc#L499).
So this changes `IsEncryptionAvailable()` to return `false` when the app
is not ready on Linux and uses that instead of the raw API in other
places like `EncryptString()` and `DecryptString()`.
Fixes: https://github.com/electron/electron/issues/32206
Signed-off-by: Darshan Sen <raisinten@gmail.com>
|
2022-05-09 09:38:53 -04:00 |
|
Shelley Vohr
|
3057ff0120
|
docs: note safeStorage.isEncryptionAvailable() needs ready event (#33724)
|
2022-04-12 12:47:15 -07:00 |
|
Milan Burda
|
e6b1d95a1c
|
docs: type names changed from wrapper to primitive (#31752)
|
2021-11-15 22:13:18 -06:00 |
|
George Xu
|
bc508c6113
|
feat: add electron.safeStorage encryption API (#30020)
* feat: add SafeStorage api; first commit
* chore: rename files to fit semantically
* chore: add linkedBindings
* chore: fix function signatures
* chore: refactor eisCookieEncryptionEnabled() fuse
* chore: create test file
* chore: add tests and documentation
* chore: add copyright and lint
* chore: add additional tests
* chore: fix constructor
* chore: commit for pair programming
* wip: commit for keeley pairing
* chore: docs change and code cleanup
* chore: add linux import
* chore: add description to documentation
* chore: fixing tests
* chore: modify behaviour to not allow unencrypted strings as decyption input
* fix add patch for enabling default v11 encryption on Linux
* chore: remove file after each test
* chore: fix patch
* chore: remove chromium patch
* chore: add linux specific tests
* chore: fix path
* chore: add checker for linuux file deletion
* chore: add dcheck back
* chore: remove reference to headless mode
* chore: remove tests for linux
* chore: edit commit message
* chore: refactor safeStorage to not be a class
* chore: remove static variable from header
* chore: spec file remove settimeout
Co-authored-by: VerteDinde <keeleymhammond@gmail.com>
|
2021-08-05 15:12:54 -07:00 |
|