mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
28293 commits 1 branch 183 tags 5.3 GiB
Commit graph

132 commits

Author SHA1 Message Date
trop[bot]
2d36065a15
docs: correct the return value for canceled showSaveDialog (#41947) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com>
 2024-04-23 12:49:30 -04:00
David Sanders
3d2a754531
chore: extend linting of code blocks in the docs (#40245) 
* chore: extend linting of code blocks in the docs

* chore: combine lint:markdownlint and lint:markdown scripts
 2023-11-21 16:50:08 +09:00
David Sanders
905aad9cb6
chore: type check JS in docs (#38423) 
* build(deps): update @electron/lint-roller

* chore: type check JS in docs

* docs: add @ts-check and @ts-expect-error to code blocks

* chore: fix type check errors in docs

* chore: add ts-type to blocks
 2023-06-05 16:26:26 +09:00
David Sanders
e138f5f915
docs: fix typing of message box type value (#38336) 
* docs: fix typing of dialog type value

* test: add smoke tests

* test: update test
 2023-05-17 10:33:30 -07:00
Charles Kerr
ddd66543f7
docs: explicitly allow string for MessageBoxOptions.icon (#32422) 
Fixes #32390. See #19782 for context.
 2022-01-13 10:30:15 +09:00
Milan Burda
e6b1d95a1c
docs: type names changed from wrapper to primitive (#31752) 2021-11-15 22:13:18 -06:00
Milan Burda
77579614e0
feat: add width option to dialog.showMessageBox() (#30474) 2021-09-23 19:56:14 +09:00
Cheng Zhao
05ba6359d0
feat: add signal option to dialog.showMessageBox (#26102) 
* mac: add dialog.closeMessageBox API

* win: Implement dialog.closeMessageBox

* mac: Return cancelId with closeMessageBox

* gtk: Implement dialog.closeMessageBox

* win: Fix 32bit build

* win: Reduce the scope of lock

* fix: Build error after rebase

* feat: Use AbortSignal to close message box

* chore: silently handle duplicate ID

* win: Add more notes about the threads

* chore: apply reviews

* fix: base::NoDestructor should be warpped in function

* chore: fix style on windows
 2021-07-15 07:59:27 +09:00
Jeremy Rose
c5066cce22
docs: fix broken markdown in dialog.md (#29782) 2021-06-22 09:49:30 -07:00
Tabea4
014bdc9f8a
docs: option title for showSaveDialog is not supported for some platforms (#28747) 2021-05-19 09:44:17 +02:00
Germain
2865d161b7
docs: remove checkbox options in dialog.showMessageBoxSync (#28418) 2021-04-07 00:18:19 -07:00
David Sanders
43dbd1bdf8
chore: cleanup whitespace in docs (#26356) 2020-11-05 14:12:43 -08:00
Cheng Zhao
a631a8a8b0
docs: put required field frontmost in the dialog options (#26059) 2020-10-21 20:07:44 +09:00
Jaroslav Maslo
4f54d71518
docs: fix incorrect dialog.showMessageBox() docs (#25549) 2020-09-23 10:35:00 +09:00
Jeremy Rose
5de7eb3618
docs: remove references to remote from docs (#25416) 2020-09-14 10:36:54 -07:00
GitHubPang
5c5e006e46
docs: fix typos (#24982) 
* docs: sync table of content from pull-requests.md to CONTRIBUTING.md

This also fixes some incorrect / dead links.

* docs: fix a bunch of typos
 2020-08-18 16:55:16 +09:00
CezaryKulakowski
c65f41dfbd
fix: don't assign NSAlert to window which is not visible (#22672) 
* fix: don't assign NSAlert to window which is not visible

Without this change it's possible to create message box which can't
be dismissed on mac.

* fixup! fix: don't assign NSAlert to window which is not visible

* fixup! fix: don't assign NSAlert to window which is not visible
 2020-04-13 17:25:55 +09:00
Ross Rosen
1d58072f65 docs: added info on bookmark return values for securityScopedBookmarks (#17584) 2020-01-23 10:17:39 +09:00
Micha Hanselmann
56d10aeef7 docs: add mising return desc (#19778) 2019-08-16 09:24:17 -07:00
Jean-Philippe Morin
42ac64284f docs: MessageBoxOptions.icon should allow type string (#19782) 
In the `dialog` documentation (and the generated typings in `electron.d.ts`), it is mentionned that the `icon` property only supports `NativeImage`, but the `nativeImage` documentation says that:

```
In Electron, for the APIs that take images, you can pass either file paths or NativeImage
```
 2019-08-16 17:06:02 +02:00
Shelley Vohr
28466a39d8
feat: add property customization to save dialogs (#19672) 2019-08-13 13:40:07 -07:00
Shelley Vohr
b5798326e8
feat: add dontAddToRecent to windows showOpenDialog (#19669) 2019-08-13 08:48:22 -07:00
Samuel Attard
db3cf52add
docs: add support for readonly,deprecated and platform doc annotations (#19478) 2019-07-26 16:12:59 -07:00
Milan Burda
c79613b037 chore: convert more files to TypeScript (#18820) 2019-07-17 10:23:52 -07:00
Samuel Attard
4e2990d3aa
docs: make the dialog example work out of the box on all 3 platforms (#19055) 2019-07-01 16:53:07 -07:00
Felix Rieseberg
cb4579fe28 docs: Fix incorrect dialog docs (#18227) 
* docs: Fix incorrect dialog docs

We had multiple definitions for `showSaveDialog`.

* docs: Update, take two
 2019-06-03 12:54:47 -07:00
Milan Burda
09d544f6ad docs: remove obsolete callback argument from dialog.showOpenDialog() (#18496) 2019-05-30 12:00:22 +02:00
Lucas Gabriel Schneider
72b1c01836 fix: docs/api/dialog.md: fix typo (#18392) 2019-05-22 20:22:51 -07:00
Samuel Attard
a96b6e2c96 build: move to the new docs parser (#18103) 
* build: move to the new docs parser

* chore: remove the bad getTitle param doc

* build: update parser/ts gen deps + fix some docs issues highlighted by GH desktop

* chore: apply suggestions from code review

Co-Authored-By: MarshallOfSound <samuel.r.attard@gmail.com>

* chore: update docs for accidentally removed things

* chore: update docs/api/command-line.md

Co-Authored-By: MarshallOfSound <samuel.r.attard@gmail.com>
 2019-05-06 08:29:01 -07:00
Shelley Vohr
d87b3ead76 chore: remove promisification deprecation callbacks (#17907) 
* chore: remove promisification deprecation callbacks

* update docs

* fix smoke test

* fix executejs issue

* cleanup leftovers

* fix webContents.executeJavaScript tests

* cleanup WebContents.prototype.takeHeapSnapshot

* fix "sets arbitrary webContents as devtools" test

* fix executeJavaScriptInFrame related tests
 2019-04-30 07:08:32 -07:00
Milan Burda
a82bbd010e build: strip trailing whitespace in docs (#17488) 2019-03-20 13:12:47 -07:00
Shelley Vohr
879462af4b
docs: document modernization initiative more clearly (#17376) 
* docs: document modernization initiative more clearly
 2019-03-19 10:31:45 -07:00
Shelley Vohr
961c9a88a8 feat: promisify dialog.showCertificateTrustDialog() (#17181) 
* feat: promisify dialog.showCertificateTrustDialog()

* update promisification doc
 2019-03-15 09:02:50 +09:00
Shelley Vohr
8991c0056e
feat: promisify dialog.showMessageBox() (#17298) 
* feat: promisify dialog.showMessageBox()

* address feedback from review
 2019-03-12 11:06:59 -07:00
Shelley Vohr
6cb7b8d3a4
feat: promisify dialog.showSaveDialog() (#17054) 
* feat: promisify dialog.showSaveDialog()

* address some feedback from review

* filename => filePath

* fix last filename => filePath
 2019-03-05 13:48:20 -08:00
Shelley Vohr
e05985145b
feat: promisify dialog.showOpenDialog() (#16973) 
* feat: promisify dialog.showOpenDialog()

* address feedback from review

* address feedback from review
 2019-03-05 05:54:48 -08:00
Samuel Attard
e01c3615c4
chore: replace usage of deprecated beginSheetModalForWindow API (#16994) 2019-02-27 10:23:17 -08:00
Samuel Attard
28638b0a6b docs: update dialog documentation for "undefined" ret vals (#16970) 2019-02-14 14:28:17 -08:00
Birunthan Mohanathas
24f1eac84f docs: Recommend use of callback with dialog.showSaveDialog (#16649) 
See #14606.

Notes: no-notes
 2019-02-03 23:56:51 -08:00
Ho Wing Yip
cd8099d336 Fixed typo in dialog.md (#15861) 
Changed "masOS" to "macOS"
 2018-11-28 20:41:27 -08:00
nixxquality
6e6ab9b907 Fix callback info for showSaveDialog and showOpenDialog (#15549) 2018-11-02 10:47:19 -04:00
Samuel Attard
558fff69e7
chore: update to standard 12 2018-09-14 14:57:01 +10:00
secult
9902d42760 docs: cancelId works on windows (#13882) 
The note about cancelId not working on windows is not valid. Tried on Windows 7 and Windows 10 and it works in both cases (tested on electron 1.8.7).
 2018-08-10 16:07:39 +10:00
Samuel Attard
baced3152f Mark securityScopedBookmarks as optional and a boolean (#11901) 2018-02-12 13:48:45 -05:00
acheronfail
d1d50a4c92 Implement App-Scoped Security scoped bookmarks (#11711) 
* implementation of security scoped bookmarks

* option is now only available on mas builds
 2018-02-12 13:25:06 -05:00
Toinane
0a0d88a5dc
remove all double spaces not needed 2017-11-29 11:58:24 +01:00
Toinane
323ea2b27b
fix(docs): fix all missing dots and add some links 2017-11-29 11:38:35 +01:00
Kevin Sawicki
7db3009234 Remove s 2017-07-18 10:19:00 -07:00
Kevin Sawicki
908c1fdfa0 Mark treatPackageAsDirectory as mac only 2017-07-18 10:18:23 -07:00
Shubham
b25a1d10a2 🍎 Add treatPackageasDirectory as an option 2017-07-18 10:13:25 -07:00