Juan Cruz Viotti
1a27ecdad4
Override child_process.execFile
asar patch for child_process.exec
...
NodeJS implements `child_process.exec` by simply passing the whole
command to `child_process.execFile`. See:
- https://github.com/nodejs/node/blob/master/lib/child_process.js#L90
- https://github.com/nodejs/node/blob/master/lib/child_process.js#L99
Electron patches `child_process.execFile` to add support for `asar`
archives by injecting logic that extracts the required files from the
`asar` to a temporary location before delegating the work to the
original `child_process.execFile`.
In order to decide whether to inject the custom `asar` extracting logic,
Electron makes use of a helper function called `splitPath()`. See:
- https://github.com/electron/electron/blob/master/lib/common/asar.js#L37
If the first argument of the returned array equals `true`, means that
the path is considered to be an `asar` archive, and thus the extraction
logic takes place. The problem is that if the command passed to
`child_process.execFile` *contains* a path to an asar archive, padded
with other commands/arguments, `splitPath()` will consider it to be an
`asar` archive, and will try to extract it, throwing a rightfully
`Invalid package` error.
Fixes: https://github.com/electron/electron/issues/5571
Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
2016-05-19 17:19:36 -04:00
Ben Gotow
2bade868bb
Update remote.md to mention enumerable property limitation
...
#5599
2016-05-19 09:31:02 -07:00
Sergey
836e2e4e91
docs : Russian
...
Russian language for http://electron.atom.io/docs/tutorial/mac-app-store-submission-guide/
2016-05-19 16:46:42 +03:00
Cheng Zhao
a2b6731bf2
Merge pull request #5606 from electron/process-docs
...
Cleanup the docs of process object
2016-05-19 11:59:37 +00:00
Cheng Zhao
983d611e96
Cleanup the docs of process object
2016-05-19 20:12:56 +09:00
Cheng Zhao
0bd3e28a05
Merge pull request #5526 from electron/process-stats
...
Process and System memory statistics API
2016-05-19 10:34:01 +00:00
Cheng Zhao
480f0fbfd7
Merge pull request #5600 from tensor5/update_clang_only_if_needed
...
Update Clang only if needed
2016-05-19 10:29:29 +00:00
Cheng Zhao
590c2bcf23
Merge pull request #5604 from preco21/korean-docs-5
...
docs: Update Korean docs as upstream
2016-05-19 10:27:03 +00:00
Cheng Zhao
8fd9957453
Merge pull request #5605 from preco21/document-fixes-5
...
docs: Improve docs
2016-05-19 10:26:38 +00:00
Cheng Zhao
e488320d37
Ignore failures of OS X on Travis CI
2016-05-19 19:23:02 +09:00
Cheng Zhao
195e0e64d0
Update brightray for #5578
2016-05-19 19:22:32 +09:00
Cheng Zhao
17528a4dfd
Merge pull request #5578 from deepak1556/disable_http2_patch
...
browser: flag to disable HTTP/2 and SPDY/3.1 protocols
2016-05-19 10:21:36 +00:00
Cheng Zhao
53d0db0a28
Merge pull request #5602 from electron/static-linking-vs-runtime
...
Link with VS2015 libraries statically for Release build
2016-05-19 09:50:53 +00:00
Plusb Preco
d6ab81c1da
📝 Fix link to improve readability
...
[ci skip]
2016-05-19 18:36:26 +09:00
Plusb Preco
3ee9eef308
📝 Remove unused link
...
[ci skip]
2016-05-19 18:34:08 +09:00
Plusb Preco
9cbcd228f3
📝 Adjust line length to 80
...
[ci skip]
2016-05-19 18:32:43 +09:00
Plusb Preco
e1bf0ea2b4
📝 Adjust line length to 80
...
[ci skip]
2016-05-19 18:28:29 +09:00
Plusb Preco
5c8ecd8a97
📝 Small fixes
...
* Adjust line length to `80`.
* Fix typos
[ci skip]
2016-05-19 18:28:00 +09:00
Plusb Preco
2b7c3735bd
📝 Update Korean docs as upstream
...
[ci skip]
2016-05-19 17:22:51 +09:00
Cheng Zhao
f8c1db160e
Only use the osfhandle hack on Windows
2016-05-19 17:02:40 +09:00
Cheng Zhao
e609a5bee2
Fix passing fd across modules
2016-05-19 16:38:37 +09:00
leethomas
eaacbc86c7
📝 update english docs to include setSheetOffsets
2016-05-18 23:59:25 -07:00
Cheng Zhao
4702d8b640
No need to download and ship vs runtime libraries
2016-05-19 15:49:26 +09:00
leethomas
359123458d
🍎 allow x-axis offset to be set for sheets
2016-05-18 23:45:54 -07:00
Cheng Zhao
d8c05ecc0d
Link with Vs2015 runtime statically for Release build
2016-05-19 15:06:47 +09:00
Cheng Zhao
f441ba2694
Merge pull request #5601 from electron/team-id
...
Include team ID in the base bundle ID
2016-05-19 03:24:31 +00:00
Cheng Zhao
5d906c0e4e
docs: Team ID is now required for signing
2016-05-19 11:13:09 +09:00
Cheng Zhao
a361d50b95
Add team ID to base Bundle ID
2016-05-19 10:57:57 +09:00
Nicola Squartini
18b2094198
Update Clang only if needed
2016-05-19 10:14:57 +09:00
Kevin Sawicki
1032287511
Merge pull request #5588 from brunoqueiros/error-message
...
Improve error message
2016-05-18 17:41:57 -07:00
Cheng Zhao
d3beaa0b16
Merge pull request #5595 from miniak/asar-fix
...
Make js2asar.py more robust
2016-05-18 23:40:11 +00:00
Bruno Queiros
046cb0df8d
🎨 Use the same stack trace for both cases
2016-05-18 19:02:42 -03:00
Kevin Sawicki
97d903bca3
Merge pull request #5587 from kcrt/master
...
Japanese manual: add electron-versioning.
2016-05-18 13:55:10 -07:00
Kevin Sawicki
0456be1535
Merge pull request #5594 from Gaserd/patch-3
...
Create supported-platforms.md
2016-05-18 13:52:47 -07:00
Milan Burda
161bd89a24
Make js2asar.py more robust
2016-05-18 12:54:53 -07:00
Sergey
5f9976c46a
Create supported-platforms.md
...
Create new file - supported-platforms.
Russian language for this page - http://electron.atom.io/docs/tutorial/supported-platforms/
2016-05-18 22:40:12 +03:00
Paul Betts
872c6ea763
📝
2016-05-18 11:08:04 -07:00
Paul Betts
e995befcd0
Move everything into atom_bindings
2016-05-18 11:07:30 -07:00
Paul Betts
d49302858b
Merge pull request #5589 from Gaserd/patch-2
...
исправление ошибки в слове
2016-05-18 10:57:53 -07:00
Sergey
d3e0c08255
исправление ошибки в слове
...
ничего критичного, просто букву не ту поставили.
2016-05-18 18:04:52 +03:00
Bruno Queiros
06e3e65c1b
🎨 Improve error message
2016-05-18 11:00:08 -03:00
TAKAHASHI Kyohei
962ce6c44c
Japanese manual: add electron-versioning.
...
electron-versioning.md is translated.
Other tutorial files are updated.
[ci skip]
2016-05-18 22:33:21 +09:00
Cheng Zhao
e05f795d1d
Merge pull request #5584 from electron/sandbox-no-expl
...
Enable sandboxing without using temporary-exception
2016-05-18 10:02:30 +00:00
Cheng Zhao
906948218f
docs: Update MAS guide without using temporary-exception
2016-05-18 16:48:22 +09:00
Cheng Zhao
deddf98533
Currently set base bundle ID
2016-05-18 16:42:26 +09:00
Plusb Preco
d7fdb16078
📝 Update Korean docs as upstream
...
[ci skip]
2016-05-18 16:41:21 +09:00
Cheng Zhao
d2a567d6ab
Merge pull request #5582 from electron/notification-user-info
...
Pass userInfo in systemPreferences.subscribeNotification
2016-05-18 07:36:31 +00:00
Cheng Zhao
3d0b98c9ca
Use string description for unknown types
2016-05-18 16:01:08 +09:00
Cheng Zhao
68cf267b1d
Do not convert NSDictionary to JSON
2016-05-18 15:49:33 +09:00
Cheng Zhao
240c346d02
Ignore invalid JSON object when converting NSDictionary
2016-05-18 14:54:37 +09:00