trop[bot]
b6e19c5a45
chore: avoid crash while notification removal ( #43061 )
...
* avoid crash of operation on an invalid entry while erase set iterator.
Co-authored-by: bill.shen <shenyb32768@gmail.com>
* fix notification removal crash due to the nullptr presenter
Co-authored-by: bill.shen <shenyb32768@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: bill.shen <shenyb32768@gmail.com>
2024-07-26 16:32:43 -04:00
trop[bot]
871136bf91
refactor: move safe_storage functions into anonymous namespace ( #43051 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-25 22:32:17 +02:00
trop[bot]
94381733ff
fix: File System API permissions should reset on WebContents destruction ( #43048 )
...
fix: active File System API permissions should reset on WebContents destruction
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-25 16:01:56 -04:00
electron-roller[bot]
ca9027bc38
chore: bump chromium to 126.0.6478.185 (31-x-y) ( #43027 )
...
chore: bump chromium in DEPS to 126.0.6478.185
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-07-25 10:21:03 -04:00
trop[bot]
139abe73a1
fix: desktopCapturer breaks BrowserWindow resizable on macOS ( #43044 )
...
* fix: desktopCapturer breaks BrowserWindow resizable on macOS
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* test: oops fix showing
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-25 15:35:23 +02:00
trop[bot]
097a3e9024
chore: use v8::Local<>, not v8::Handle<> ( #43037 )
...
v8::Handle is an alias for v8::Local that "is kept around for historical
reasons" and is disabled when V8_IMMINENT_DEPRECATION_WARNING is defined
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-25 11:00:05 +02:00
trop[bot]
9e14f8d828
feat: emit an event when accessing restricted path in File System Access API ( #42994 )
...
* fix: show a dialog when accessing restricted path in File System Access API
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: allow overriding initial blocked paths
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* docs: fix doc
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update docs/api/session.md
Co-authored-by: Erick Zhao <erick@hotmail.ca>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: change block to deny for consistency
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-24 13:23:33 -04:00
trop[bot]
f797f92716
docs: note macOS fullscreen events in fullscreen query ( #43016 )
...
docs: note macOS fullscreen events in fs query
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-23 16:56:58 -04:00
trop[bot]
7f6eab8c25
docs: improve desktop capture example ( #43005 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-23 12:35:00 +02:00
trop[bot]
b288f3ee59
refactor: remove WindowListObserver::OnWindowAdded() ( #42984 )
...
refactor: remove WindowListObserver::OnWindowRemove()
these have never been used
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-22 19:12:59 +02:00
trop[bot]
b833c3f02a
chore: remove unused BaseWindow::GetWeakPtr() ( #42988 )
...
last caller removed in 67ba3040#37902 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-22 10:20:27 -05:00
trop[bot]
d53f1d8ff4
chore: remove unused WrappableBase::AfterInit() ( #42986 )
...
last caller removed in 6159066c#22916 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-22 15:52:56 +02:00
trop[bot]
e259dd591f
chore: remove unused typedef CreateDownloadPathCallback ( #42968 )
...
chore: remove unused typedef ElectronDownloadManagerDelegate::CreateDownloadPathCallback
use was removed in e3c580e9
2024-07-19 21:44:54 -05:00
trop[bot]
daf8d22e07
refactor: remove unused web contents preferences methods ( #42969 )
...
* chore: remove unused WebContentsPreferences::ShouldDisableDialogs()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: remove unused WebContentsPreferences::ShouldUseSafeDialogs()
caller removed in 85bc005c85bc005c
2024-07-19 18:55:07 -05:00
electron-roller[bot]
6249f596f9
chore: bump chromium to 126.0.6478.183 (31-x-y) ( #42942 )
...
* chore: bump chromium in DEPS to 126.0.6478.182
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6478.184
* chore: bump chromium in DEPS to 126.0.6478.183
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-07-19 16:30:41 -05:00
trop[bot]
6c1409ae57
chore: remove unused field ElectronBrowserClient::browser_main_parts_ ( #42965 )
...
chore: remove unused field ElectronBrowserClient::browser_main_parts_
caller removed in 48d0b09a
2024-07-19 14:37:32 -05:00
trop[bot]
0d9918cd24
fix: dangling raw_ptr NodeBindings::uv_env_ ( #42955 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-19 12:26:37 -05:00
trop[bot]
bb093817ed
fix: dangling raw_ptr<views::View> in api::View ( #42951 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-17 23:31:40 -05:00
trop[bot]
1de0bb30b1
feat: add getPercentComplete / getCurrentBytesPerSecond / getEndTime to DownloadItem ( #42915 )
...
feat: getCurrentSpeed / getPercentComplete / getEndTime on DownloadItem
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Theo Gravity <theo@suteki.nu>
2024-07-17 09:49:05 -07:00
trop[bot]
e429b6f745
fix: crash with creating OffScreenWebContentsView ( #42941 )
...
On the Mac platform, OffScreenWebContentsView uses Automatic Reference
Counting (ARC) to handle the lifecycle of offScreenView_. However, this
private member variable is not initialized and its value is undefined.
In some cases, it is initialized to a garbage value, which may cause ARC
to release the value incorrectly, resulting in a crash.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Jinli Wu <wujinli@bytedance.com>
2024-07-17 09:10:00 -05:00
trop[bot]
e3a5895c2b
fix: getUserMedia needs macOS system permissions check ( #42937 )
...
fix: getUserMedia needs macOS system permissions check
Closes https://github.com/electron/electron/issues/42714
Closes https://github.com/electron/electron/issues/29861
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-17 13:08:34 +02:00
Calvin
5951712f2e
build: fix clang format location helper ( #42926 )
...
* build: fix clang format location helper (again)
* use gclient sync in lint workflow for downloading clang-format
2024-07-17 11:30:36 +02:00
trop[bot]
85cb6d9476
fix: BrowserWindow.setBackgroundColor should work with transparency ( #42928 )
...
fix: BrowserWindow.setBackgroundColor should work with transparency
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-17 11:29:22 +02:00
trop[bot]
5029bce65c
fix: iteration issues in hid RevokeEphemeralDevicePermission ( #42901 )
...
fix: iteration issues in hid RevokeEphemeralDevicePermission
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-16 12:32:35 +02:00
trop[bot]
697f468f36
chore: fix npm run lint not working on Windows ( #42906 )
...
* fix: fixed the `npm run lint` not working on Windows.
* chore: more fixes for lint on Windows
* chore: revert change to patch linting
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: reito <cnschwarzer@qq.com>
2024-07-16 12:32:07 +02:00
John Kleinschmidt
9659dab19e
build: remove CircleCI ( #42844 ) ( #42909 )
...
* build: remove CircleCI
* chore: remove remaining CircleCI references
(cherry picked from commit c006e129b3
2024-07-15 16:00:20 -07:00
electron-roller[bot]
398e34967f
chore: bump node to v20.15.1 (31-x-y) ( #42839 )
...
* chore: bump node in DEPS to v20.15.1
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-07-15 17:29:57 -04:00
trop[bot]
9833c7f1e6
build: fixup GHA running on fork PRs ( #42904 )
...
* chore: update build-tools for GHA
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: don't rely on environment variables for source cache location
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-07-15 14:29:41 -04:00
trop[bot]
266b23745b
fix: File System Access API should remember last picked directory ( #42893 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-15 17:22:56 +02:00
trop[bot]
65f431ab78
fix: crash when resolving proxy due to network service restart ( #42897 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2024-07-15 14:50:41 +02:00
trop[bot]
5c2a8b9047
fix: desktopCapturer and screen display ids should match ( #42890 )
...
* fix: `desktopCapturer` and `screen` display IDs should match
Co-authored-by: clavin <clavin@electronjs.org>
* simplify wide-to-utf8 conversion
Co-authored-by: clavin <clavin@electronjs.org>
* remove unnecessary include
Co-authored-by: clavin <clavin@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org>
2024-07-14 18:30:34 +02:00
Samuel Attard
05abc2bab2
build: use new arc runner names ( #42886 )
...
build: use new arc runner names (#42881 )
2024-07-13 12:10:40 -07:00
trop[bot]
c916070300
build: update build-tools for GHA ( #42873 )
...
chore: update build-tools for GHA
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-07-12 11:17:39 +02:00
trop[bot]
f392f558e0
fix: desktopCapturer and screen source ids should match screen ids ( #42861 )
...
* fix: desktopCapturer screen source ids should match screen ids
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* test: add a regression test
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-11 15:47:33 -04:00
trop[bot]
54d920165e
ci: fix Nan test failure on Linux ( #42865 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-11 15:46:42 -04:00
trop[bot]
c3868809df
chore: speed up azcopy on src cache ( #42847 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-07-11 09:46:23 -04:00
trop[bot]
e768a1f228
fix: dangling raw_ptr<Session> in UserDataLink ( #42852 )
...
* fix: dangling raw_ptr<Session> in UserDataLink
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fixup! fix: dangling raw_ptr<Session> in UserDataLink
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-11 14:53:06 +02:00
trop[bot]
217e740791
fix: High Contrast mode not working on Windows ( #42859 )
...
Closes https://github.com/electron/electron/issues/42609
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5324688
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5368321
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-10 16:48:24 -07:00
trop[bot]
dc065dfa5a
fix: potentially closed webContents in BrowserView ( #42810 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-10 15:33:27 +02:00
Shelley Vohr
6a15e168ce
build: remove all publish & build on macOS ( #42827 )
...
* build: remove all publish & build on macOS
* ci: fix CircleCI config (#42829 )
* ci: fix CircleCI config
* ci: fix syntax error
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2024-07-10 14:52:30 +02:00
Keeley Hammond
7084258dd4
build: fix release, add newVersion for tagging ( #42843 )
2024-07-09 11:08:59 -07:00
Shelley Vohr
56c3507ef2
refactor: run Windows SelectFileDialog out of process ( #42825 )
...
refactor: run Windows SelectFileDialog out of process
2024-07-09 19:03:13 +02:00
trop[bot]
650b8e6777
fix: dangling raw_ptr ElectronBrowserContext::extension_system_ ( #42813 )
...
The extension system is freed by the DestroyBrowserContextServices()
call in the destructor, so we need to zero out the pointer to avoid
a dangling raw_ptr error.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-09 11:03:45 +02:00
trop[bot]
7353fa88cd
refactor: minor electron browser context cleanup ( #42815 )
...
* refactor: make DevicePermissionMap private to electron::ElectronBrowserContext
refactor: make PartitionPath private to electron::ElectronBrowserContext
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: remove unused forward declarations of v8 classes
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: forward declare gin::Arguments
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: use unique_ptr operator bool
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-08 13:49:23 -04:00
trop[bot]
50864bcd08
fix: multiple move() calls on the same unique_ptr ( #42821 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-08 13:48:47 -04:00
trop[bot]
e36d79706e
fix: video and audio capture should be separate ( #42809 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-08 16:46:41 +02:00
trop[bot]
342ef8e7e1
feat: enable Windows Control Overlay on Linux ( #42682 )
...
* feat: enable Windows Control Overlay on Linux
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* docs: update documentation for Linux WCO
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: initial symbol painting
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* test: enable WCO tests for Linux
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: add missing Layer include
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: fix gn-check failure
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: enable BrowserWindow.setTitleBarOverlay on Linux
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* test: fix test for maximize event on Linux
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: geometry updating on BrowserWindow.setTitleBarOverlay
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: crash when invalid titleBarStyle set
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: clean up ordering and comments
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update docs/api/structures/base-window-options.md
Co-authored-by: Erick Zhao <erick@hotmail.ca>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* feat: enable customizing symbolColor
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* docs: correct symbolColor reference
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
* chore: remove Chrome-specific padding
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-07-03 16:09:12 -04:00
trop[bot]
89d09922f7
fix: use BlockedRequest struct to handle webRequest data ( #42751 )
...
* refactor: use BlockedRequest model to handle webRequest
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* refactor: finish de-templating
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: address some feedback from review
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-03 14:46:29 +02:00
trop[bot]
339c30f48b
docs(autoUpdater): document static storage strategy ( #42756 )
...
* docs: `autoUpdater` static storage strategy
* summary must be followed by newline
* lint: fix whitespace for code blocks
* lint: `js` -> `javascript`
* bump
* `javascript` -> `js`
* bump
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
2024-07-03 11:49:56 +02:00
trop[bot]
6caad0a5f6
docs(autoUpdater): signing is only a pre-req on macOS ( #42753 )
...
docs: correctly state that signing is a pre-req for autoUpdater only on macOS
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
2024-07-03 11:43:03 +02:00
