mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
28521 commits 1 branch 183 tags 5.3 GiB
Commit graph

510 commits

Author SHA1 Message Date
Tierney Cyren
6df7bd63e4 docs: improve Windows build variable documentation (#20548) 
* docs: improve Windows build variable documentation

Documents an additional and possibly unclear variable, `DRIVE:`, in the example global variables for building with Windows

* docs: update formatting in build-instructions-windows.md to align with styleguide
 2019-12-06 08:53:50 +09:00
Cheng Zhao
0a741670a9
chore: remove native_mate (Part 14) (#21365) 
* chore: remove uses of mate::Dictionary and mate::Handle

* chore: move CreateConstructor to gin_helper

* chore: remove native_mate

* chore: remove unneeded gin patch
 2019-12-05 18:46:34 +09:00
Vlad Hashimoto
601cc6e887 docs: change invalid bash session language tag (#20827) 2019-11-12 12:47:56 +00:00
Samuel Attard
b06a479240
build: remove debug builds (#21016) 
* build: remove debug builds

* Update docs/development/debugging-instructions-macos.md

Co-Authored-By: Robo <hop2deep@gmail.com>
 2019-11-07 11:51:44 -08:00
John Kleinschmidt
04da8a10eb
docs: document JS constant naming (#20892) 2019-11-04 13:25:43 -05:00
Jeremy Apthorp
6781d5e3c8
test: there is only --ci (#20794) 2019-10-30 16:38:21 -07:00
Kerollos Magdy
8efa45d12d docs: fix minor grammar mistakes (#20521) 2019-10-14 14:35:52 +09:00
Jeremy Apthorp
df1d3156a0
docs: remove outdated document about updating chromium (#20490) 2019-10-09 16:07:15 -07:00
Jeremy Apthorp
c75c3ef616
docs: add a dev doc describing the patch system (#20489) 2019-10-09 14:48:09 -07:00
Felix Rieseberg
b3e7657159 docs: Update the sccache name (#20462) 2019-10-08 17:46:01 -04:00
Andrew MacDonald
7f320eef0e docs: Minor fixes to build instructions (#20338) 
* Minor fixes to build instructions

* Direct folks to the unit testing page.
 2019-10-04 10:11:51 -04:00
Erick Zhao
2cac40444b docs: clarify VS installation instructions for Windows builds (#20236) 
* docs: note required step for VS in Windows build

* docs: add instructions for custom VS location

* lint?

* link chromium docs
 2019-09-17 10:23:56 -04:00
Micha Hanselmann
9b1f698770 docs: mention QuickEdit in Windows troubleshooting (#19701) 
* shot a trouble

* change title
 2019-08-14 14:23:12 -07:00
Richard Townsend
58840f39bb docs: document device scaling issue (#19387) 2019-08-08 13:59:44 -07:00
Valentin Hăloiu
0732da1b4a build: remove GConf and dconf dependencies on linux (#19498) 2019-07-29 08:33:47 -04:00
Richard Townsend
9711fc895e docs: describe how to install Meiryo (#19308) 
Fixes #19201
 2019-07-18 10:51:34 -07:00
Shelley Vohr
3d2eb8360a chore: remove tls check script (#19280) 2019-07-16 12:04:02 -07:00
Thiago de Arruda
d0ece2bc93 docs: Add command to quickly fix the SMBv2 cache (#19210) 
Running this command is more convenient than manually editing regedit.
 2019-07-15 17:57:33 +09:00
Charles Kerr
c9bc4aeb90 docs: remove redundant 'set origin' section (#19243) 
* docs: fix remote push origin docs

* docs: remove redundant section

the 'git remote' text in the 'Getting the Code' section is better
 2019-07-15 17:42:11 +09:00
小菜
641e1d6587 doc: change pyobjc link in macos build instruction (#18471) 2019-06-03 18:57:13 -07:00
Richard Townsend
3c8acf3687 build: bring in a later compiler for Windows on Arm (#18591) 
* build: allow pulling in a later version of Clang

Due to a code-generation defect related to virtual method thunks in the
official compiler used for Chromium M76, it's necessary to build for WoA
with a later version of Clang. When running gclient sync, setting
ELECTRON_BUILD_WOA=1 in the environment will download a corrected
compiler which doesn't have this defect.

* docs: add a note about building for Windows on Arm
 2019-06-03 17:29:25 -04:00
Shelley Vohr
8759e30f04
build: linux needs java on GN (#18211) 
The linux builds fails with ./bin/sh java not found unless this is installed.
 2019-05-08 15:28:55 -07:00
Michelle Tilley
4808f30538
fix: revert to previous documentation folder structure (#18127) 2019-05-02 15:17:17 -07:00
Shelley Vohr
5ed11aa1f3
docs: remove obsolete releasing document (#18072) 2019-05-01 09:14:14 -07:00
Shelley Vohr
6530c99cfa
docs: add azure vm spinup tutorial (#17958) 2019-04-25 15:42:45 -07:00
Shelley Vohr
2108044bdb
docs: move organizational info docs to new directory (#17865) 
* docs: move organizational info docs to new directory

* fix some markdown lint issues
 2019-04-25 15:14:19 -07:00
Milan Burda
0b0f677432 docs: make gclient config command Windows friendly (#17900) 2019-04-23 05:11:35 -04:00
Samuel Attard
50b9933705 build: update circle base image and mac docs for 10.13 SDK 2019-04-02 14:43:03 -07:00
Milan Burda
a82bbd010e build: strip trailing whitespace in docs (#17488) 2019-03-20 13:12:47 -07:00
Seba Kerckhof
b7fc50b7ca docs: Add information on packaging a build (#17086) 
* docs: Add information on packaging a build

* Stripping only applies to linux
 2019-03-08 15:24:00 -08:00
Jeremy Apthorp
5a88d9e6fc
docs: add troubleshooting note about pywin32 (#17216) 2019-03-05 10:40:52 -08:00
Jeremy Apthorp
67f04c0370 docs: remove dead link to chromiumdev slack (#17161) 
* docs: remove dead link to chromiumdev slack

Closes #17154

* Update chromium-development.md
 2019-02-28 16:43:55 -05:00
Tomas Rycl
1db4dd68a7 Troubleshooting for Windows Driver Kit (#16405) 2019-01-23 12:34:18 -08:00
SamvelRaja
34c1727cb3 docs: fix typo in build instructions for windows (#16414) 2019-01-15 21:58:39 -08:00
John Kleinschmidt
50010934d1
docs: Update reference to xcode 8.3.3 (#16267) 
* Update reference to xcode

* Update to reflect use of 10.12 SDK
 2019-01-04 13:05:12 -05:00
Michelle Tilley
46c2953edb doc: Update Windows build instructions to include debugging tools (#15765) 2018-11-20 01:08:25 -05:00
Simone Cattaneo
f2d3d55e95 docs: changed German link with English one for Windows SDK Archive (#15764) 2018-11-20 01:03:03 -05:00
Jeremy Apthorp
ec4212cce1
docs: add troubleshooting section for win toolchain prompt (#15761) 2018-11-19 11:53:28 -08:00
Milan Burda
8ba271efba refactor: eliminate brightray (#15240) 2018-10-24 12:49:10 +02:00
Martin Mädler
a4fefbe836 docs: update Windows build instructions (#14797) 2018-10-22 16:40:39 -04:00
Felix Rieseberg
ca826d49a5 docs: Add instructions on how to pull/push (#14903) 
* docs: Add instructions on how to pull/push

* docs: Implement feedback <3

* fix: typo s/glient/gclient
 2018-10-10 15:48:37 +11:00
Samuel Attard
e86298d5d9
chore: fix relative links in docs and enforce we dont break them again (#14832) 2018-09-28 13:16:38 +10:00
Samuel Attard
55765424f9 chore: fix test command in docs 2018-09-28 11:19:00 +10:00
Samuel Attard
2adb44a402 chore: remove unused files to simply out_dir replacements 2018-09-28 11:16:37 +10:00
Shelley Vohr
e9549a89bb
docs: update releasing info (#14675) 
* docs: update releasing info

* update more release and upload files

* address feedback from review
 2018-09-24 09:12:16 -07:00
Samuel Attard
6b50dc8745
docs: add python-dbusmock to the linux requirements (#14727) 
Refs #14726
 2018-09-20 21:41:00 +10:00
Jeremy Apthorp
b8a8bf82ac
docs: update "upgrading node" guide (#14649) 
I think there's more to do here, and I'll continue to add to & update this documentation as I go through the process of upgrading node in the context of the GN build.
 2018-09-19 11:08:39 -07:00
Samuel Attard
558fff69e7
chore: update to standard 12 2018-09-14 14:57:01 +10:00
Jeremy Apthorp
9e85bdb02c docs: prefer out/Debug to out/Default in build docs 2018-09-13 15:08:31 -07:00
Jeremy Apthorp
ebbaa4f89b docs: simplify git cache instructions (#14562) 2018-09-12 12:06:55 +10:00
Jeremy Apthorp
b35c8e4e1e docs: update instructions for building win32 target (#14560) 2018-09-12 12:05:51 +10:00
Jeremy Apthorp
0ab95b76a7
docs: add note about origin URLs to GN build docs (#14530) 2018-09-10 12:31:41 -07:00
Jeremy Apthorp
72526927d9 build: remove gyp build files (#14097) 
* build: remove gyp build files

* docs: update build instructions

* build: temporary restore electron.gyp

* build: do not update Electron version in the electron.gyp

* chore: remove unused submodules

* ci: remove obsolete CI scripts and configs

* chore: remove obsolete scripts

* chore: remove obsolete functions from lib/util.py

* ci: send Slack notification for nightly build results
 2018-09-09 10:15:32 +09:00
Charles Kerr
2b4dbe409f fix: doc recipe for debug build (#14355) 2018-08-29 09:31:06 -07:00
Charles Kerr
e315e4d308 build: use electron-frameworks sccache (#14171) 
* build: update-external-binaries fetches sccache

* build: add util.add_exec_bit in scripts/

* build: use util.add_exec_bit in create-dist

* build: use util.add_exec_bit in update-external-binaries

this is needed to work around a bug in python's zipfile module that doesn't preserve the exec bit

https://bugs.python.org/issue18262

* fix: linting errors

* build: vsts, circleci use patched sccache

* build: always look for the x64 sccache

as it's the only arch we have it on

* fix: windows-specific errors in updaste-external-binaries

* fix: tyop

* fix: set SCCACHE_BUCKET, SCCACHE_TWO_TIER on circleci

* fix: syntax error in circleci yaml

* fix: keep churning

* chore: add tracer to file downloader

* docs: add sccache instructions for GN builds

* build: pull down the darwin sccache on mas builds

* build: use gn sync verbosely on circleci and vsts

* docs: copyediting

* build: remove unnecessary cache-dir arg

* docs: fix shell quoting in gn build instructions

* fix: invoke gclient without -verbose in circleci

* refactor: remove debug tracer

* fix: invoke gclient without -verbose in appveyor

* fix: invoke gclient without -verbose in vsts

* fix: pull add_exec_bit from correct source

* fix: remove 'SCCACHE_TWO_TIER' from CI scripts

* refactor: remove SCCACHE_BUCKET from ci scripts

this environment variable will be set via the CI UI instead

* refactor: clarify log message

* fix: set SCCACHE_PATH correctly for Windows CI
 2018-08-21 15:40:06 -04:00
Charles Kerr
51b76f0635 build: use GIT_CACHE_PATH (#14165) 
* build: add GIT_CACHE_PATH

The merge at https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1105473 was to specify git cache entirely from the environment variable  [and] removal of the general --cache-dir option from gclient

* docs: document GIT_CACHE_PATH in GN build

* fix: try to fix appveyor-gn env syntax
 2018-08-17 09:20:20 -07:00
John Kleinschmidt
dda6bb135a
Merge pull request #14017 from electron/node-gn 
build: build node with GN
 2018-08-14 14:29:17 -07:00
Shelley Vohr
c0959bd534
refactor: add 'npm run bootstrap', 'npm run build' (#14034) 
* docs: update package.json and build docs

* fix build release

* address feedback from review

* whoops forgot one

* fix build script

* address feedback from review
 2018-08-12 14:01:46 -07:00
Jeremy Apthorp
ae79fd1bb3 docs: update GN developer docs (#14018) 2018-08-11 12:20:19 -05:00
Jeremy Apthorp
6d277ec784 [wip] build: try building node with GN 2018-08-10 10:06:27 -07:00
Jeremy Apthorp
2551837ffb
docs: min windows server version for building is 2012 (#13935) 2018-08-03 17:32:07 -07:00
Jeremy Apthorp
379998e2f6
docs: recommend windows 10 as the minimum build OS 
I'm pretty sure building on windows 7 doesn't work.
 2018-08-03 15:42:12 -07:00
deepak1556
e0735baff2 docs: [gn] update build instructions 2018-08-03 11:54:21 -07:00
Shelley Vohr
48ae9b7a9c
docs: update node upgrade doc (#13891) 
Updates the node upgrade doc to take path changes into account as well as to incorporate the new `get-patch` script which simplifies work significantly.
 2018-08-01 23:33:37 -07:00
Jeremy Apthorp
0efb5853d6 build: [gn] centralize GN args under build/args/*.gn 
Devs can still locally override or add settings by adding lines after
the `import` statement in args.gn.

This will help make sure that everyone has a common set of build args,
and will allow us to update everyone's build args in git.
 2018-07-25 14:24:45 -07:00
Tiago Danin
1fd6d38a0a docs: Improved documentation (#13403) 2018-07-20 10:58:19 -07:00
Jeremy Apthorp
16b66db9c7 build: [gn] working on 32bit windows 2018-07-19 17:04:44 -07:00
Samuel Attard
f26880db03 Update docs on semantic requirements for #13359 (#13365) 2018-07-18 10:41:58 -05:00
John Kleinschmidt
05538aa32c
Merge pull request #13629 from electron/use-dot-env 
docs: use .env (and .env.example) for tokens used in release
 2018-07-17 11:57:42 -04:00
John Kleinschmidt
cc03213b62
Merge pull request #13664 from electron/tweak-release-docs 
docs: update release docs from Fri 13 release session
 2018-07-16 16:22:30 -04:00
John Kleinschmidt
5764d76efa Fix formatting 
Add alternate url for security token (depends on whether you are using new or old navigation on VSTS)
 2018-07-16 10:39:31 -04:00
John Kleinschmidt
87f34ccda4 Update Windows VS2017 requirement (#13663) 2018-07-13 17:43:27 -05:00
Charles Kerr
3653730cba Add post-publish 'npm dist-tag ls electron' step 2018-07-13 16:17:02 -05:00
John Kleinschmidt
6ea0e73b47
Merge branch 'master' into use-dot-env 2018-07-13 16:02:49 -04:00
Charles Kerr
da92abf964 document ELECTRON_S3_ tokens 2018-07-13 14:42:36 -05:00
Charles Kerr
452b5f342c add note about multiple calls to validateRelease 2018-07-13 14:17:31 -05:00
Charles Kerr
02d072ed9d fix VSTS token generation URL 2018-07-13 13:47:40 -05:00
John Kleinschmidt
6b5ccec0c6 chore: Updates for release process (#13632) 
* Fix Appveyor URL

* Update docs to reflect current process

Also added troubleshooting steps.
 2018-07-12 07:53:07 -05:00
Zeke Sikelianos
849cddf4be update tokens portion of releasing docs 2018-07-11 11:02:41 -07:00
Jeremy Apthorp
4f8acb0cdd docs: add link to Chromium windows debugging docs 
I found this tidbit in particular helpful: 

```sh
> devenv /debugexe out\Debug\chrome.exe <options to Chromium can go here>
```
 2018-06-27 23:06:30 +02:00
Samuel Attard
28d148b475
docs: add native_mate to source code directory structure doc (#13451) 2018-06-27 17:46:14 +10:00
Jeremy Apthorp
57d365a9f4 Update build-instructions-windows.md 2018-06-21 12:10:33 -07:00
Vlad Hashimoto
a67c992c36 docs: fix broken link to commit message guidelines (#13233) 
* docs: fix broken link  to commit message guidelines

* Fix another broken links
 2018-06-15 19:43:03 -05:00
Zeke Sikelianos
cb9ab213bb
Merge pull request #13005 from nornagon/gn-docs 
docs: dev instructions for GN build
 2018-05-29 15:17:16 -07:00
Maksym Dogadailo
562831ec1a fix tls script path in documentation (#13089) 2018-05-29 03:12:27 -05:00
Jeremy Apthorp
8ea864d6eb docs: dev instructions for GN build 2018-05-24 11:46:35 -07:00
Felix Rieseberg
e8735cc005 docs: Document Python TLS requirements (#12276) 
* 🔧 Add simple test script

* 📝 Add documentation

* 🔧 It works, use it

* 🔧 Make the linter happy

* 🔧 Check on bootstrap

* Trivial copyediting

s/operation system/operating system/
 2018-05-16 14:19:49 -07:00
Samuel Attard
0bb29e092d
fix: update docs for the ts parser (#12902) 2018-05-12 18:12:28 +10:00
Zeke Sikelianos
1cc5492784
Merge pull request #12870 from electron/remove-macci-refs 
Remove references to no longer used https://mac-ci.electronjs.org
 2018-05-09 22:25:57 -07:00
John Kleinschmidt
fd8e330760 Remove references to no longer used https://mac-ci.electronjs.org 2018-05-09 16:41:24 -04:00
Charles Kerr
4d078fdb03
Remove more words (#12852) 
* remove 'basically' from docs

* remove 'simply' from docs

* remove most uses of 'just' from docs
 2018-05-08 00:16:09 -05:00
Shelley Vohr
52e3d5e4f0
remove some beginner-unfriendly terms from docs 2018-05-07 08:46:14 -07:00
Charles Kerr
c81dac774a
Fix some broken documentation links (#12794) 2018-05-02 10:33:07 -05:00
Zeke Sikelianos
1957eb9429 summarize semantic commit requirements (#12665) 
* summarize semantic commit requirements

* move semantic commit details into contributing docs

* keep those messages short
 2018-05-02 09:47:26 -05:00
Charles Kerr
37a68aebcf Link issues.md back to support.md 2018-04-30 18:06:29 -05:00
Shelley Vohr
f9ee24f8f0
Merge pull request #12627 from vijaypushkin/patch-1 
Corrected the name of Capitalization Styles
 2018-04-20 09:49:28 -04:00
John Kleinschmidt
717f55b012
Merge pull request #11328 from electron/add-env-to-release-docs 
expanded release docs
 2018-04-18 11:28:16 -04:00
Vijay Pushkin
82cbd4327f
Corrected the name of Capitalization Styles 
Corrected CamelCase to PascalCase and 
mixedCase to camelCase
 2018-04-16 13:14:11 +05:30
Charles Kerr
03d119d539
Address @jkleinsc's 2018-03-21 comments 2018-04-13 16:10:53 -05:00
TiagoDanin
d7a003b0bc
📝 Fix dead urls 2018-04-09 17:58:10 -03:00
OJ Kwon
dabd61bf80 chore(build): support generating compilation db (#12104) 2018-04-09 14:54:14 +09:00
Jeremy Apthorp
95cbd69e48 Update testing docs to reflect --grep syntax (#12400) 
* Update testing docs to reflect --grep syntax

* Use @zeke's suggestion to s/suites/tests/
 2018-03-22 13:19:53 -04:00
bughit
37eccbcd33 Update 3 (of Visual Studio 2017) is leftover from 2015 (#12372) 
does not apply to 2017
it's not clear to me that it's possible to download a non current version of vs2017
but if a specific version is required the directions should explain how to get it
 2018-03-20 16:15:59 -05:00
Zeke Sikelianos
e3dfffb77b add docs/development/README.md (#12373) 2018-03-20 15:36:48 -04:00
Cheng Zhao
42938de973 Build with Visual Studio 2017 2018-03-20 10:13:16 +03:00
Vanessa Yuen
48dd8f96b7 Fix broken links (#12232) 
* Update system-preferences.md

* Fix broken documentation links.
 2018-03-14 08:07:36 +09:00
Charles Kerr
35a512310a Merge branch 'master' into add-env-to-release-docs 2018-03-07 16:38:14 +09:00
Charles Kerr
3b2a494033 Update to master. 2018-03-07 16:32:36 +09:00
Nitish Sakhawalkar
dc29b3add1 Add XCode debugging doc 2018-03-06 00:03:14 +05:30
John Kleinschmidt
78ccfa0612
Merge pull request #11879 from electron/fix-gtk-deprecations 
Fix GTK+ 3 deprecations
 2018-02-16 10:01:01 -05:00
Charles Kerr
4774f32065 replace gtk2 with gtk3 in docs 2018-02-15 15:08:55 -06:00
John Eismeier
8d55334016 Propose fix some typos (#11905) 2018-02-13 00:18:27 -05:00
John Kleinschmidt
12a8d90ef0 Change release process for 2.0 
Tag release as soon as version bumps
No longer use release branch
Remove merge step as it is no longer needed.
 2018-02-12 14:06:09 -05:00
shelley vohr
533dfc42a8 enhance documentation around contributing to electron (#11887) 
* add issues document

* add documentation coding style to doc

* copyediting

* replace `nodejs/node` with `electron/electron`
* fix commasplice
* fix two most important... s/is/are/
* omit unnecessary words

* add pull requests doc

* copyediting

* add general code style to styleguide

* updates to CONTRIBUTING.md

* copyediting

* mark shell blocks as ```sh
* mitigate phrase duplication e.g. 'best practice'
* lots of opinionated changes to omit unnecessary words

* fix numbering & re-apply changes that I overwrote
 2018-02-12 08:09:38 -06:00
shelley vohr
647d04cf92 Add brightray to src code structure (#11878) 
* add brightray to src code structure

* try new code flag
 2018-02-09 13:21:50 -06:00
Vanessa Yuen
4ab13d9e90
Delete upgradeing-chrome.md 2018-02-07 17:11:16 +01:00
John Kleinschmidt
e924781ee5 Improvements to release process 
1. Prompt user to verify version before version is created.
2. Fix validateRelease instructions and usage
3. Fix ci-release-build so that you don't have to pass in --ghRelease=true; just --ghRelease will work.
 2018-02-05 10:57:48 -05:00
Aleš Pergl
c49cb29ddf Disallow launching unknown apps via browser client. 
CVE-2018-1000006
 2018-01-22 16:49:30 -06:00
Tiago Danin
74769da9a7 [Docs] Fix URLs and Paths (#11584) 
* Fix URLs and Paths in docs/

* Avoiding link break to /docs/development/updgrading-chrome.md

* Fix URLs and Paths in docs/ #2

* Removed double spaces in docs
 2018-01-12 10:24:48 -05:00
Felix Rieseberg
5f4b62b6c8 feat: Allow testing of single spec modules (#11409) 
* 🔧 ES6 for the spec

* 👷 Allow testing of single modules

* ❤️ Implement feedback

* 📝 Add a testing doc

* 📝 Link to it

* 📝 Cleanup
 2017-12-28 06:18:33 -05:00
Cheng Zhao
39ec40b901
Merge pull request #11470 from electron/update-node-upgrade-doc 
Update branching steps in upgrading-node.md
 2017-12-20 10:08:09 +09:00
Charles Kerr
6f4e97c53a
(copyediting) renumber steps 2017-12-19 09:09:35 -06:00
Cheng Zhao
90582dfa4f
Merge pull request #11154 from electron/update-release-doc 
Update release process for API invoked release builds
 2017-12-19 15:30:51 +09:00
Shelley Vohr
d602a30bbc
update a few steps in upgrading-node.md 2017-12-12 22:55:37 -05:00
Andrew Scheller
debe77a910
Fix typos 2017-12-13 03:13:41 +00:00
TiagoDanin
079310ab5a
fix formatting in upgrading node doc 2017-12-08 11:49:39 -03:00
TiagoDanin
9314d8925e
fix formatting in upgrading chromium doc 2017-12-08 11:24:05 -03:00
Zeke Sikelianos
fa09ff3cbb update links to versioning doc 2017-12-06 15:01:09 -08:00
Jacob Groundwater
1bce00545d docs: changes based on review 2017-12-05 11:43:59 -08:00
Jacob Groundwater
06371a6082 docs: explain versioning policy 1.x, 2.x, and beyond 2017-12-05 11:38:36 -08:00
Charles Kerr
f0d9b93ede note that 'publish-to-npm' needs node 6 2017-12-05 09:10:26 -06:00
Charles Kerr
f398b5d843 add a tip for testing version number with 'bump-version.py --dry-run' 2017-12-05 08:51:37 -06:00
Charles Kerr
b8259a82c1 note that 'npm run release -- --validateRelease' must be run in release branch 2017-12-05 08:38:16 -06:00
Charles Kerr
7bcea57241 fix tyop 2017-12-04 21:09:12 -06:00
Charles Kerr
3cd6c2e9eb explain using the Electron S3 Bucket environment variables 2017-12-04 20:34:34 -06:00
Charles Kerr
455a61d210 in the npm upload step, explain the needed npm credentials 2017-12-04 20:32:24 -06:00
Charles Kerr
83e94f3de1 fix invocation of validateRelease pass 2017-12-04 20:19:43 -06:00
Charles Kerr
ffdd6ab821 add a troubleshooting note about branch checkout 2017-12-04 10:26:35 -06:00
Charles Kerr
60fe728c0f add section on environment variables 2017-12-04 10:13:22 -06:00
Charles Kerr
b209620514 trim whitespace 2017-12-04 09:51:12 -06:00
Charles Kerr
e5f4916e31 fix numbering of 'Edit the release draft' steps 2017-12-04 09:50:24 -06:00
Charles Kerr
5212b98c87 wrap lines at 80 characters 2017-12-04 09:48:06 -06:00
Charles Kerr
295945b806 copyediting 2017-11-26 08:44:37 +01:00
Charles Kerr
81bc0efc75 fix styleguide errors 2017-11-26 08:38:58 +01:00
Charles Kerr
a75a85449d sync with master 2017-11-26 08:28:27 +01:00
Charles Kerr
22c15082a3 partial doc update from my sprint notes 2017-11-24 14:21:41 +01:00
shelley vohr
6941f93627
Merge pull request #11247 from electron/use_sh_in_docs 
prefer `sh` to `bash` in the docs
 2017-11-24 11:38:10 +01:00
Charles Kerr
b59557569c oops, the upgrading-chrome.md changes belonged in a separate PR 2017-11-24 11:19:53 +01:00
Charles Kerr
3e3cac6f1b prefer sh to bash in the docs 2017-11-24 11:17:43 +01:00
Shelley Vohr
bd70ec5e97
finalize node upgrade doc 2017-11-24 11:15:07 +01:00