Charles Kerr
5904d31264
perf: hold V8FunctionInvoker args in a std::array ( #43752 )
...
perf: hold V8FunctionInvoker args in a std::array
2024-09-18 16:23:29 -05:00
Charles Kerr
d897359b82
perf: hold Emit() arg arrays in a std::array ( #43750 )
...
* refactor: CallMethodWithArgs() now takes a span of value handles
* perf: use std::array instead of std::vector to hold Emit arg parameter packs
* chore: remove unused gin_helper::EmitEvent(iso, obj, name, span<Local>)
2024-09-18 09:40:14 -05:00
Charles Kerr
233724fe00
chore: iwyu mojom-forward header files ( #43741 )
...
* chore: iwyu mojom.h headers
* fixup! chore: iwyu mojom.h headers
make previously-indirect include dependency direct
* fixup! fixup! chore: iwyu mojom.h headers
make previously-indirect include dependency direct
2024-09-17 12:58:56 -07:00
Charles Kerr
5a76655fb8
fix: in Emit(), don't leak converted Arg Local<Values> into caller's scope ( #43729 )
...
fix: Emit() should not leak converted arg handles into caller's HandleScope
2024-09-17 09:00:52 -05:00
Charles Kerr
b6bf277b6f
refactor: reduce code duplication in gin_helper::Promise ( #43716 )
...
* refactor: move scope scaffolding into SettletScope
idea stolen from SpellCheckScope
* refactor: move impl of PromiseBase::RejectPromise() to the cc file
* chore: remove unused #include
2024-09-16 23:08:40 -05:00
Charles Kerr
45bae950d5
chore: remove unused base/ includes ( #43688 )
2024-09-12 16:05:37 +02:00
Charles Kerr
5718ea4e1e
fix: out-of-scope Local handle in node::CallbackScope ( #43622 )
...
refactor: use an EscapableHandleScope
2024-09-09 12:14:40 -05:00
Charles Kerr
2844e346b9
refactor: use std::optional in MicrotasksScope ( #43621 )
...
avoid an unnecessary heap allocation/free
2024-09-09 12:51:42 -04:00
Charles Kerr
0568686340
perf: avoid redundant Promise.GetContext calls ( #43609 )
...
refactor: avoid redundant Promise.GetContext calls
Several Promise methods call `GetContext()` multiple times. From looking
at the assembly in obj/electron/electron_lib/promise.o, these redundant
calls are actually being made -- they aren't optmized out.
This PR keeps the return value in a local variable to avoid extra calls.
2024-09-07 23:39:42 -05:00
Charles Kerr
0467790aee
chore: migrate to v8::Object::SetPrototypeV2() ( #43535 )
...
chore: migrate to v8::Object::SetPrototypeV2().
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5600627
[api] Mark v8::Object::GetPrototype() for deprecation
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-09-04 20:30:54 -05:00
Charles Kerr
8ae5aacc8c
refactor: declare gin::Wrapper subclasses as final ( #43527 )
...
As per the gin docs: "Wrappable<T> explicitly does not support further
subclassing of T. Subclasses of Wrappable<T> should be declared final."
2024-09-04 18:40:02 -05:00
David Sanders
56829f75c1
chore: cleanup include groupings ( #43478 )
2024-08-26 10:44:20 -04:00
Alexander Cyon
ca0837c852
chore: fix typos in 'shell/' folder. ( #43373 )
2024-08-22 19:48:32 -05:00
Charles Kerr
4fbf18a021
refactor: move impl functions into private namespace ( #43372 )
2024-08-21 15:26:06 -05:00
Charles Kerr
6877671390
fix: gin_helper::MicrotasksScope instantiation ( #43185 )
2024-08-05 08:24:27 -05:00
Charles Kerr
7e9eb9e3f1
perf: avoid duplicate calculations in gin_helper::Dictionary getters ( #43073 )
...
* perf: cache the dictionary handle
* refactor: prefer result.IsJust() over !result.IsNothing()
for consistency
* refactor: prefer maybe.FromMaybe() over maybe.IsJust() && maybe.FromJust()
the inlined code is simpler
* refactor: simplify Get() impl
* refactor: add private helper Dictionary::MakeKey()
refactor: add private helper Dictionary::MakeHiddenKey()
2024-07-29 12:43:28 -05:00
Charles Kerr
e70ce89235
chore: more iwyu ( #43063 )
...
* chore: iwyu shell/browser/electron_pdf_document_helper_client.h
* chore: iwyu shell/browser/hid/electron_hid_delegate.h
* chore: iwyu content/public/browser/web_contents.h
* chore: iwyu shell/browser/usb/electron_usb_delegate.h
* chore: iwyu shell/browser/browser_observer.h
* chore: iwyu shell/browser/bluetooth/electron_bluetooth_delegate.h
* chore: iwyu shell/browser/serial/electron_serial_delegate.h
* chore: iwyu shell/browser/api/frame_subscriber.h
* chore: iwyu mojo/public/cpp/bindings/
* chore: iwyu components/
* chore: iwyu extensions/
* chore: iwyu shell/common/gin_helper/
* chore: iwyu v8/
* chore: iwyu base/containers/linked_list.h
* chore: iwyu shell/browser/native_window.h
* chore: iwyu shell/browser/api/electron_api_base_window.h
* chore: iwyu shell/common/node_includes.h
* chore: iwyu gin/handle.h
* chore: iwyu base/functional/callback.h
* chore: iwyu ui/gfx/
* chore: iwyu content/public/browser/render_frame_host.h
* fix: mac
* fix: mac
* fix: win
* chore: iwyu base/files/file_path.h
* chore: iwyu base/unguessable_token.h
* chore: iwyu ui/display/screen.h
* chore: iwyu chrome/browser/predictors/preconnect_manager.h
* chore: iwyu base/observer_list_types.h
* chore: iwyu content/public/browser/web_contents.h
* chore: iwyu chrome/browser/devtools/devtools_eye_dropper.h
* chore: iwyu shell/browser/ui/inspectable_web_contents.h
* chore: iwyu content/public/browser/keyboard_event_processing_result.h
* chore: iwyu net/cookies/canonical_cookie.h
* chore: iwyu net/base/address_list.h
* chore: iwyu net/cert/x509_certificate.h
* chore: iwyu net/cookies/cookie_change_dispatcher.h
* chore: iwyu net/dns/public/host_resolver_results.h
* fix: mac
* Revert "chore: iwyu net/cert/x509_certificate.h"
This reverts commit 002896f71146e90f1e29e090a1d6eede48cee11e.
2024-07-29 12:42:57 -05:00
Charles Kerr
60c4c9fec6
chore: remove unused #includes ( #42971 )
...
* chore: iwyu buildflags.h
* chore: iwyu dictionary.h
* chore: iwyu arguments.h
* chore: iwyu values.h
* chore: iwyu compiler_specific.h
* chore: iwyu binder_map.h
* chore: iwyu <vector>
* chore: iwyu <set>
* chore: iwyu raw_ptr
* chore: iwyu gfx/canvas.h
* chore: iwyu gfx/color_utils.h
* chore: iwyu base/strings/stringprintf.h
* chore: iwyu base/task/thread_pool.h
* chore: iwyu base/no_destructor.h
* chore: iwyu base/path_service.h
* chore: iwyu base/files/file_pathh
* chore: iwyu base/strings/sys_string_conversions.h
* chore: iwyu base/logging.h
* chore: iwyu base/command_line.h
* chore: iwyu base/files/file_util.h
* chore: iwyu base/files/scoped_file.h
* chore: iwyu base/strings/utf_string_conversions.h
* chore: iwyu base/environment.h
* chore: iwyu base/scoped_observation.h
* chore: iwyu base/strings/string_split.h
* chore: iwyu base/strings/pattern.h
* chore: iwyu base/json/string_escape.h
* chore: iwyu base/json/json_reader.h
* chore: iwyu base/memory/singleton.h
* chore: iwyu base/observer_list.h
* chore: iwyu base/timer/timer.h
* fixup! chore: iwyu values.h
* chore: iwyu shell/browser/browser.h
* chore: iwyu base/stl_util.h
* chore: iwyu base/strings/string_util.h
* chore: iwyu shell/browser/javascript_environment.h
* chore: iwyu base/memory/ref_counted.h
* chore: iwyu base/environment.h
* chore: iwyu content/public/browser/browser_thread.h
* chore: remove unused typedef gin_helper::EventEmitter::ValueArray
* chore: iwyu gin/wrappable.h
* chore: iwyu shell/common/gin_helper/function_template_extensions.h
* chore: iwyu shell/common/gin_converters/login_item_settings_converter.h
* chore: iwyu shell/common/gin_helper/arguments.h
* chore: iwyu ui/gfx/skia_util.h
* chore: iwyu ui/gfx/geometry/rect.h
* chore: iwyu ui/gfx/image/image.h
* chore: iwyu base/strings/strcat.h
* chore: iwyu ui/native_theme/native_theme.h
* fixup! chore: iwyu shell/browser/javascript_environment.h
* fixup! chore: iwyu gfx/canvas.h
* fixup! chore: iwyu content/public/browser/browser_thread.h
* fixup! chore: iwyu ui/native_theme/native_theme.h
* fixup! chore: iwyu ui/native_theme/native_theme.h
2024-07-22 11:31:32 +02:00
Charles Kerr
8c8a7709e6
chore: remove unused WrappableBase::AfterInit() ( #42974 )
...
last caller removed in 6159066c#22916 )
2024-07-22 10:44:21 +02:00
electron-roller[bot]
8a8241163d
chore: bump chromium to 128.0.6558.0 (main) ( #42413 )
...
* chore: bump chromium in DEPS to 127.0.6526.0
* chore: update network_service_allow_remote_certificate_verification_logic.patch
manually apply patch due to minor upstream shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5598454
* chore: update fix_move_autopipsettingshelper_behind_branding_buildflag.patch
No manual changes; patch applied with fuzz 1
* chore: update refactor_expose_file_system_access_blocklist.patch
No manual changes; patch applied with fuzz 2
* chore: update revert_heap_add_checks_position_info.patch
No manual changes; patch applied with fuzz 1
* chore: e patches all
* chore: bump chromium in DEPS to 127.0.6527.0
* chore: update patches
* chore: bump chromium in DEPS to 127.0.6529.0
* chore: bump chromium in DEPS to 127.0.6531.0
* chore: update patches
* 5596349: Remove PDF OCR toggle from settings.
https://chromium-review.googlesource.com/c/chromium/src/+/5596349
* 5585932: [video-pip] Add minimize button to video picture-in-picture window
https://chromium-review.googlesource.com/c/chromium/src/+/5585932
* 5604487: Reland "[api] Deprecate v8::FunctionCallbackInfo::Holder() for real"
https://chromium-review.googlesource.com/c/v8/v8/+/5604487
* 5581721: [DEPS] Update clang-format location
https://chromium-review.googlesource.com/c/chromium/src/+/5581721
* 5597904: [Windows] Remove ConvertToLongPath from Sandbox Utilities.
https://chromium-review.googlesource.com/c/chromium/src/+/5597904
ResolveNTFunctionPtr was removed in this CL.
* fix: visibility state specs on macOS
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5605407
* Revert "fix: visibility state specs on macOS"
This reverts commit 1eee30a33dfafeec86cdd09526a07b01abca2ed6.
* temp: disable occlusion checker on macOS
* chore: bump chromium in DEPS to 128.0.6535.0
* chore: update patches
* [Extensions] Move some scriptings files out of the API directory.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5606682
* fix[node]: do not use soon-to-be-deprecated V8 API
* fix: update api_remove_allcan_read_write.patch
* chore: update patches
* chore: update patches
* chore: fix lf mismatch in api_remove_allcan_read_write.patch
* chore: update patches
* chore: bump chromium in DEPS to 128.0.6538.0
* chore: update v8 patches
* chore: update patches
* ui/gl/features.gni: Set use_egl=true unconditionally.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5569748
Refs https://issues.chromium.org/issues/344606399
* chore: bump chromium in DEPS to 128.0.6540.0
* chore: bump chromium in DEPS to 128.0.6541.0
* chore: update patches
* chore: fix nan read/write patch
* chore: bump chromium in DEPS to 128.0.6543.0
* 5626254: Use sandbox_type instead of process_type | https://chromium-review.googlesource.com/c/chromium/src/+/5626254
* chore: update patches
* rework nan patches
* 5621488: Apply consistent naming conventions to zoom values | https://chromium-review.googlesource.com/c/chromium/src/+/5621488
* chore: bump chromium in DEPS to 128.0.6544.0
* 5605693: Remove files from third_party/ninja | https://chromium-review.googlesource.com/c/chromium/src/+/5605693
* chore: update patches
* chore: maybe fix nan patch, part 3
* chore: delete nan patch
* chore: re-add nan patch (attempt 2)
* chore: add test patch
* fixup! add test patch
* chore: bump chromium in DEPS to 128.0.6549.0
* chore: bump chromium in DEPS to 128.0.6551.0
* 5637699: Add command line to ASAN Additional Info section | https://chromium-review.googlesource.com/c/chromium/src/+/5637699
* chore: update patches
* chore: bump chromium in DEPS to 128.0.6553.0
* chore: bump chromium in DEPS to 128.0.6555.0
* fix: add property query interceptors
* chore: bump chromium in DEPS to 128.0.6557.0
* 5583182: Automatic Fullscreen: Prototype Permissions API query support | https://chromium-review.googlesource.com/c/chromium/src/+/5583182
* 5613297: Move render input router and related dependencies to //components/input | https://chromium-review.googlesource.com/c/chromium/src/+/5613297
* chore: update patches
* test: skip methodswithdata-test.js nan test
* chore: bump chromium in DEPS to 128.0.6558.0
* chore: update patches
* build: reference correct ninja cipd ref
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5605693
* update libcxx filenames
* refactor: CursorManager moved to //components/input
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5613297
* refactor: spanify mojo Read/WriteData methods
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5619291
* refactor: remove constexpr from KeyboardCodeFromKeyIdentifier
Ref: unknown
Added TODO to investigate after
* chore: update patches
* refactor: improve type safety of a11y ids
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5614590
* chore: disable tls node tests that don't apply given boringssl tls configuration
Ref: https://boringssl-review.googlesource.com/c/boringssl/+/68487
* chore: add patch to fix nan v8 incompat with NamedPropertyHandlerConfiguration and IndexedPropertyHandlerConfiguration
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/5630388
* fix: limit subspan length per feedback
* Fix incorrect CalculateInsetsInDIP check
* 5645742: Reland "Reland "Add toolchains without PartitionAlloc-Everywhere for dump_syms et al""
https://chromium-review.googlesource.com/c/chromium/src/+/5645742
* chore: more Windows logging
* 5617471: Add NPU blocking to chromium blocklist
https://chromium-review.googlesource.com/c/chromium/src/+/5617471
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: Alice Zhao <alice@makenotion.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-02 09:51:33 +02:00
Milan Burda
003c32331d
chore: add/fix interface comments for sections of methods ( #42566 )
2024-06-20 10:49:07 +02:00
electron-roller[bot]
c3b4cd987c
chore: bump chromium to 127.0.6521.0 (main) ( #42118 )
...
* chore: bump chromium in DEPS to 126.0.6470.0
* 5492605: Migrate TODOs referencing old crbug IDs to the new issue tracker IDs | https://chromium-review.googlesource.com/c/chromium/src/+/5492605
* 5513277: Move subresource-filter-ruleset to GCS | https://chromium-review.googlesource.com/c/chromium/src/+/5513277
* 5512656: Remove CustomizeChromeSupportsChromeRefresh2023 | https://chromium-review.googlesource.com/c/chromium/src/+/5512656
* 5516009: Accept mouse events in inactive window for Top Chrome WebUIs | https://chromium-review.googlesource.com/c/chromium/src/+/5516009
* 5376861: Change references to RWHVB in RWHIER and RenderWidgetTargeter to RWHVI. | https://chromium-review.googlesource.com/c/chromium/src/+/5376861
* 5490530: Use partition_alloc PA_BUILDFLAG(...) outside PA. #cleanup | https://chromium-review.googlesource.com/c/chromium/src/+/5490530
* 5296870: network: Allow trusted loaders to learn the sent request cookies. | https://chromium-review.googlesource.com/c/chromium/src/+/5296870
* 5453438: Delegate delegated ink trails to RWHI from RWHIER. | https://chromium-review.googlesource.com/c/chromium/src/+/5453438
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6472.0
* chore: bump chromium in DEPS to 126.0.6474.0
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6476.0
* chore: bump chromium in DEPS to 126.0.6478.0
* chore: bump chromium in DEPS to 126.0.6478.3
* chore: bump chromium in DEPS to 126.0.6478.8
* update patches
* only disable enterprise_cloud_content_analysis
* 5403888: [api] support v8::Data in v8::TracedReference and v8::EmbedderGraph
https://chromium-review.googlesource.com/c/v8/v8/+/5403888
* chore: bump chromium in DEPS to 127.0.6484.0
* chore: bump chromium in DEPS to 127.0.6485.0
* 5539004: Use NOTREACHED_IN_MIGRATION() in remaining chrome/ | https://chromium-review.googlesource.com/c/chromium/src/+/5539004
* src: cast to v8::Value before using v8::EmbedderGraph::V8Node | https://github.com/nodejs/node/pull/52638/files
* chore: update patches
* chore: update v8 patches
* chore: bump chromium in DEPS to 127.0.6486.0
* chore: bump chromium in DEPS to 127.0.6488.0
* chore: bump chromium in DEPS to 127.0.6490.0
* chore: bump chromium in DEPS to 127.0.6492.0
* chore: update patches
For some reason, `feat_expose_raw_response_headers_from_urlloader.patch` got messed up in an earlier commit.
* chore: update patches
printing.patch was updated due to https://chromium-review.googlesource.com/c/chromium/src/+/5535938
* 5527572: Move Connectors prefs files to components/enterprise/connectors/
https://chromium-review.googlesource.com/c/chromium/src/+/5527572
* chore: bump chromium in DEPS to 127.0.6494.0
* chore: bump chromium in DEPS to 127.0.6495.0
* chore: bump chromium in DEPS to 127.0.6496.0
* 5465511: [api] Mark v8::ObjectTemplate::SetAccessor(..) for deprecation
https://chromium-review.googlesource.com/c/v8/v8/+/5465511
* chore: revert v8 deprecation
See patch message for more details.
https://chromium-review.googlesource.com/c/v8/v8/+/5526611
* chore: update patches
* 5538771: Remove srcdoc else-if block in CalculateOrigin()
https://chromium-review.googlesource.com/c/chromium/src/+/5538771
* 5522321: [devtools] Support saving base64 encoded files via host bindings
https://chromium-review.googlesource.com/c/chromium/src/+/5522321
* 5376861: Change references to RWHVB in RWHIER and RenderWidgetTargeter to RWHVI.
https://chromium-review.googlesource.com/c/chromium/src/+/5376861
* 5530163: [media] Use VideoFrame::Plane typed enum instead of nameless enum
https://chromium-review.googlesource.com/c/chromium/src/+/5530163
* 5463431: iwa: Only create IsolatedWebAppURLLoaderFactory for subresources in IWAs
https://chromium-review.googlesource.com/c/chromium/src/+/5463431
* fixup! 5465511: [api] Mark v8::ObjectTemplate::SetAccessor(..) for deprecation https://chromium-review.googlesource.com/c/v8/v8/+/5465511
* 5512176: Remove OnEnvironmentEstimationComplete()
https://chromium-review.googlesource.com/c/chromium/src/+/5512176
* 5528282: Move Web Speech API .mojom files to //media/mojo/mojom
https://chromium-review.googlesource.com/c/chromium/src/+/5528282
* 5513740: Reland "[Extensions] Restructure extensions::ProcessMap"
https://chromium-review.googlesource.com/c/chromium/src/+/5513740
* 5483406: [PEPC] Make PEPC permission subscription take into account device status
https://chromium-review.googlesource.com/c/chromium/src/+/5483406
* 5526034: [DoH] Remove kDnsOverHttps feature flag
https://chromium-review.googlesource.com/c/chromium/src/+/5526034
The title is a bit misleading. They removed handling for the feature flag and generally intend to remove it but haven't yet.
I only changed our code to address the flag that was removed. A quick search on GitHub for `DnsOverHttpsFallback` yielded a few results, but they were all C++ chromium code or patches, 0 app code or discussion results. Since I couldn't find any evidence of this flag being used in developer applications, I've chosen to exclude this change from the breaking changes docs.
* chore: revert v8 removal
https://chromium-review.googlesource.com/c/v8/v8/+/5497515
See patch message for more details.
* chore: cherry-pick Node.js patch for V8 API removal fix
Node.js PR: https://github.com/nodejs/node/pull/52996
V8 API Removal CL: https://chromium-review.googlesource.com/c/v8/v8/+/5539888
See the patch description for more details.
* 5492183: Extensions: CodeHealth: Give enums some class
https://chromium-review.googlesource.com/c/chromium/src/+/5492183
* fixup! 5528282: Move Web Speech API .mojom files to //media/mojo/mojom https://chromium-review.googlesource.com/c/chromium/src/+/5528282
* 5514687: Reland "Add a secret handshake to the base::Feature constructor"
https://chromium-review.googlesource.com/c/chromium/src/+/5514687
* fixup! 5530163: [media] Use VideoFrame::Plane typed enum instead of nameless enum https://chromium-review.googlesource.com/c/chromium/src/+/5530163
* 5466238: PDF Viewer: add metrics to record if PDF is opened with a11y
https://chromium-review.googlesource.com/c/chromium/src/+/5466238
* 5502081: Migrate OnDisplayRemoved to OnDisplaysRemoved
https://chromium-review.googlesource.com/c/chromium/src/+/5502081
* 5539888: [api] Remove several APIs deprecated in version 12.6
https://chromium-review.googlesource.com/c/v8/v8/+/5539888
This commit essentially only removes the `only_terminate_in_safe_scope` isolate creation parameter. This undoes some work that was originally done in #35766 .
* 5498236: Make browser_tests force full async initialization for OSCrypt Async
https://chromium-review.googlesource.com/c/chromium/src/+/5498236
* fixup! 5528282: Move Web Speech API .mojom files to //media/mojo/mojom https://chromium-review.googlesource.com/c/chromium/src/+/5528282
* 5545807: Migrate most remaining NOTREACHED()
https://chromium-review.googlesource.com/c/chromium/src/+/5545807
I took a systematic approach to modifying all of our uses of `NOTREACHED` that were causing errors:
* If there was a `return` or `break` (etc.) immediately after `NOTREACHED`, I removed the control flow instruction and left the `NOTREACHED` unmodified
* All other instances were migrated to `NOTREACHED_IN_MIGRATION`
We should revisit pretty much all usage of `NOTREACHED` as an upgrade follow-up item.
* fixup! 5526034: [DoH] Remove kDnsOverHttps feature flag https://chromium-review.googlesource.com/c/chromium/src/+/5526034
Turns out the feature flags were removed in the `.cc` file, but not the
`.h` feature list file. This means that the feature flags are pretty
much officially gone. (The leftover symbols in the header are likely an
oversight from what I can gather.)
We may potentially decide to put this in the breaking changes doc if we
decide this feature flag is important enough to highlight.
* chore: bump chromium in DEPS to 127.0.6498.3
* chore: bump chromium in DEPS to 127.0.6500.0
* chore: bump chromium in DEPS to 127.0.6502.0
* chore: bump chromium in DEPS to 127.0.6504.0
* chore: bump chromium in DEPS to 127.0.6505.0
* chore: bump chromium in DEPS to 127.0.6508.0
* build: use Sha256Sum in script/sysroots.json
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5506275
* chore: update chore_add_electron_deps_to_gitignores.patch
Xref: no manual changes; patch applied with fuzz 2
* chore: update feat_allow_code_cache_in_custom_schemes.patch
Xref: no manual changes; patch applied with fuzz 1
* chore: e patches all
* fixup! build: use Sha256Sum in script/sysroots.json
`sync` succeeds now
* chore: replace absl::optional with std::optional
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5253843
* chore: update CalculatePreferredSize() to new upstream semantics
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5459174
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5541220
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5514708
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5504212
Xref: https://chromium-review.googlesource.com/516542
* chore: replace absl::optional with std::optional
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5296147
* chore: add kPip to enumeration as a no-op
https://chromium-review.googlesource.com/c/chromium/src/+/5546257
* [Autofill] Remove RenderFrame::ElementBoundsInWindow()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5553982
* chore: fix feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch
need new header to pick up definition of BLINK_PLATFORM_EXPORT macro
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5463143
* chore: bump chromium in DEPS to 127.0.6510.0
* chore: update patches
* chore: fix include path for native_web_keyboard_event.h
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5541976
* chore: add currently-unused should_include_device_status arg to GetPermissionStatusForCurrentDocument()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5545382
* chore: bump chromium in DEPS to 127.0.6512.0
* chore: update mas_avoid_private_macos_api_usage.patch.patch
No manual changes; patch applied with fuzz 1
* chore: update feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch
No manual changes; patch applied with fuzz 1
* chore: update webview_fullscreen.patch
No manual changes; patch applied with fuzz 1
* chore=: remove cherry-pick-22db6918bac9.patch
already present upstream
* chore: remove nonexistent patchfiles from .patches
* chore: remove cherry-pick-3e037e195e50.patch
no longer needed; merged upstream
* Update namespace for files moved to //components/input
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5563251
* Require client for InitParams to always specify an ownership mode.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5532482
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5578714
* chore: e patches all
* fixup! Update namespace for files moved to //components/input
* chore: remove profile_keyed_service_factory, profile_selections from chromium_src
already being linked in via chrome browser for printing
* chore: bump chromium in DEPS to 127.0.6515.0
* chore: bump chromium in DEPS to 127.0.6516.0
* chore: update render_widget_host_view_base.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5547803
patch applied manually due to simple upstream shear
* chore: update feat_allow_code_cache_in_custom_schemes.patch
No manual changes; patch applied with fuzz 1
* chore: e patches all
* Pull RWHIER and RWT to //content/common/input.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5397681
* chore: bump chromium in DEPS to 127.0.6517.0
* chore: update patches
* fixup: Update namespace for files moved to //components/input
* Remove 0-arg (default) constructor for views::Widget::InitParams.
https://chromium-review.googlesource.com/c/chromium/src/+/5578714
* fixup: only disable enterprise_cloud_content_analysis
The original commit a5480accc2https://chromium-review.googlesource.com/c/chromium/src/+/5527572
* chore: bump chromium in DEPS to 127.0.6519.0
* chore: update patches
* src: do not use deprecated V8 API
https://github.com/nodejs/node/pull/53084
* src: remove dependency on wrapper-descriptor-based cpp heap
https://github.com/nodejs/node/pull/53086
* 5344413: [DevTools] Add `getHostConfig` UI binding for sending status of `base::Features` to DevTools
https://chromium-review.googlesource.com/c/chromium/src/+/5344413
* 5585788: Extensions: ManifestHandler: Separate Registry like ExtensionRegistry
https://chromium-review.googlesource.com/c/chromium/src/+/5585788
* chore: update filenames.libcxx.gni
* 5506857: Reland "Migrate clang-format to gcs first class deps"
https://chromium-review.googlesource.com/c/chromium/src/+/5506857
* fixup: 5539888: [api] Remove several APIs deprecated in version 12.6
* fixup: 5506857: Reland Migrate clang-format to gcs first class deps
* chore: bump chromium in DEPS to 127.0.6521.0
* chore: update patches
* spec: update navigator.keyboard should lock the keyboard
* Block or allow all MIDI using the existing SysEx permission
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5154368
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5499157
* spec: update test/parallel/test-v8-stats
* views: remove CalculatePreferredSize()
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5504212
* chore: update patches after rebase
* 5560288: Re-enable ChromeOS XNNPack on Intel only
https://chromium-review.googlesource.com/c/chromium/src/+/5560288
* chore: add nan patches for v8 changes
Refs
5539888: [api] Remove several APIs deprecated in version 12.6 | https://chromium-review.googlesource.com/c/v8/v8/+/5539888
and
5539852: [heap][api] Remove deprecated v8::Isolate::IdleNotificationDeadline | https://chromium-review.googlesource.com/c/v8/v8/+/5539852
* 5573603: Modularize //chrome/browser/themes
https://chromium-review.googlesource.com/c/chromium/src/+/5573603
* 5539888: [api] Remove several APIs deprecated in version 12.6
https://chromium-review.googlesource.com/c/v8/v8/+/5539888
* chore: update patches
* test: fixup navigator.keyboard.lock on Windows
* chore: remove unneeded profile target
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2024-06-07 17:18:35 -04:00
Shelley Vohr
7f3dc7d4ce
fix: utilityProcess exit codes ( #42297 )
2024-06-07 10:06:00 +02:00
Charles Kerr
0346e0a8bf
refactor: use std::erase() ( #41881 )
...
* refactor: use std::erase() in WebContentsPreferences::~WebContentsPreferences()
* refactor: use std::erase() in WindowList::RemoveWindow()
* refactor: use std::erase() in ElectronBindings::EnvironmentDestroyed()
* refactor: use std::erase() in CleanedUpAtExit::~CleanedUpAtExit()
* refactor: use std::erase_if() in ElectronBrowserContext::RevokeDevicePermission()
* refactor: use std::erase_if() in UsbChooserController::GotUsbDeviceList()
* refactor: move DoesDeviceMatch() out of class into anonymous namespace
2024-04-19 10:55:59 -05:00
Shelley Vohr
8c427253b3
refactor: update gin_helper/function_template ( #41534 )
...
* refactor: update gin_helper/function_template
* fix: crash in Node.js Worker threads
2024-03-25 10:01:54 +01:00
Shelley Vohr
62331f5ac1
chore: add missing gin::Wrappable GetTypeName overrides ( #41512 )
...
chore: add missing gin::Wrappable GetTypeName overrides
2024-03-06 12:45:28 +01:00
Charles Kerr
5686f88bd2
refactor: KeyWeakMap cleanup ( #41242 )
...
* refactor: make KeyWeakMap::KeyObject private
* perf: avoid redundant map lookup
* refactor: remove unused KeyWeakMap::Has()
* refactor: make KeyWeakMap dtor nonvirtual
no inheritance used, so no need for virtual dtor?
* chore: fix KeyWeakMap code comment
* refactor: use if statement in KeyWeakMap::Get()
* refactor: use better variable names in KeyWeakMap::Values()
2024-02-06 09:18:05 -06:00
Shelley Vohr
8104c7908a
fix: potential async_hooks crash in NotifyWindowRestore on Windows ( #40576 )
...
* fix: potential async_hooks crash in NotifyWindowRestore on Windows
* fix: don't use CallbackScope for Error objects
2024-01-26 12:53:07 -06:00
Charles Kerr
f36ceae024
chore: migrate base::StringPiece to std::string_view ( #40915 )
...
* chore: migrate from base::StringPiece to std::string_view in keyboard_util.cc
* chore: migrate from base::StringPiece to std::string_view in error_thrower.cc
* chore: migrate from base::StringPiece to std::string_view in electron_api_web_contents.cc
* chore: migrate from base::StringPiece to std::string_view in gin_helper/dictionary.h
* chore: migrate from base::StringPiece to std::string_view in electron_api_url_loader.cc
* chore: phase out internal use of base:::StringPiece
`base::StringPiece` is being phased out upstream. Its code has been
removed upstream and it's just a typedef for `std::string_view`.
They haven't removed the typedef yet, so this PR tries to get ahead
of future breakage by migrating "internal" use (i.e. leaving alone the
places where the `base::StringPiece` name is coming from an upstream
method that we override).
Xref: https://bugs.chromium.org/p/chromium/issues/detail?id=691162
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4294483
Xref: https://docs.google.com/document/d/1d4RnD1uAE2t4iANR0nXy82ASIPGsPuw2mpO6v6T7JKs
2024-01-10 19:00:37 -06:00
Milan Burda
892c9d78a3
chore: replace absl::optional<T> with std::optional<T> ( #40928 )
...
* chore: replace absl::optional<T> with std::optional<T>
* IWYU
2024-01-10 16:23:35 -06:00
Jeremy Rose
15c6014324
feat: replace BrowserView with WebContentsView ( #35658 )
2023-12-13 13:01:03 -08:00
David Sanders
cf5f0419f1
chore: fix some typos ( #40506 )
2023-11-12 19:51:56 -08:00
electron-roller[bot]
9d0e6d09f0
chore: bump chromium to 119.0.6043.0 (main) ( #40045 )
...
* chore: bump chromium in DEPS to 119.0.6036.0
* chore: bump chromium in DEPS to 119.0.6037.0
* chore: bump chromium in DEPS to 119.0.6039.0
* chore: bump chromium in DEPS to 119.0.6041.0
* chore: update chromium patches
* 4765230: Move //content/browser/renderer_host/event_with_latency_info.h to //content/common/input | https://chromium-review.googlesource.com/c/chromium/src/+/4765230
* 4890325: ScopedRunLoopTimeout: add custom timeout callback handler for testing | https://chromium-review.googlesource.com/c/chromium/src/+/4890325
* chore: update all patches
* chore: bump chromium in DEPS to 119.0.6043.0
* 4898682: [api] Add Error.cause to V8 API
https://chromium-review.googlesource.com/c/v8/v8/+/4898682
* 4837192: Plumb origin through for drags.
https://chromium-review.googlesource.com/c/chromium/src/+/4837192
* Prevent content analysis on web pages that don't accept drag and drop.
https://chromium-review.googlesource.com/c/chromium/src/+/4814086
* Make getting displayed notifications work with notification attribution.
https://chromium-review.googlesource.com/c/chromium/src/+/4738935
* 4898682: [api] Add Error.cause to V8 API
https://chromium-review.googlesource.com/c/v8/v8/+/4898682
* lib,test: do not hardcode Buffer.kMaxLength
https://github.com/nodejs/node/pull/49876
* chore: remove Goma warning from mksnapshot_args
* 4776412: Remove Windows-specific wstring variants of StringPrintf() etc.
https://chromium-review.googlesource.com/c/chromium/src/+/4776412
* [dPWA] Prevent WebAppInstallInfo from being included on Android
https://chromium-review.googlesource.com/c/chromium/src/+/4886594
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2023-10-02 18:01:07 -04:00
Milan Burda
fb6b92076e
fix: prevent gin_helper::Locker heap allocation ( #39847 )
...
fix: prevent gin_helper::Locker heap allocation
2023-09-14 15:48:43 -04:00
Charles Kerr
f6e8a42c48
refactor: remove unused fields, methods in gin_helper::Locker ( #39803 )
...
* refactor: remove unused field gin_helper::Locker::g_is_browser_process
refactor: remove unused field gin_helper::Locker::g_is_renderer_process
refactor: make field const gin_helper::Locker::locker_
* refactor: remove unused declaration gin_helper::Locker::new()
refactor: remove unused declaration gin_helper::Locker::delete()
* refactor: make field const electron::JavascriptEnvironment::locker_
* refactor: remove unused #include gin_helper/locker.h
2023-09-12 16:53:20 -07:00
Samuel Attard
ac031bf8de
feat: I guess it's esm ( #37535 )
...
* fix: allow ESM loads from within ASAR files
* fix: ensure that ESM entry points finish loading before app ready
* fix: allow loading ESM entrypoints via default_app
* fix: allow ESM loading for renderer preloads
* docs: document current known limitations of esm
* chore: add patches to support blending esm handlers
* refactor: use SetDefersLoading instead of JoinAppCode in renderers
Blink has it's own event loop so pumping the uv loop in the renderer is not enough, luckily in blink we can suspend the loading of the frame while we do additional work.
* chore: add patch to expose SetDefersLoading
* fix: use fileURLToPath instead of pathname
* chore: update per PR feedback
* fix: fs.exists/existsSync should never throw
* fix: convert path to file url before importing
* fix: oops
* fix: oops
* Update docs/tutorial/esm-limitations.md
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* windows...
* windows...
* chore: update patches
* spec: fix tests and document empty body edge case
* Apply suggestions from code review
Co-authored-by: Daniel Scalzi <d_scalzi@yahoo.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* spec: add tests for esm
* spec: windows
* chore: update per PR feedback
* chore: update patches
* Update shell/common/node_bindings.h
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* chore: update patches
* rebase
* use cjs loader by default for preload scripts
* chore: fix lint
* chore: update patches
* chore: update patches
* chore: fix patches
* build: debug depshash
* ?
* Revert "build: debug depshash"
This reverts commit 0de82523fb93f475226356b37418ce4b69acdcdf.
* chore: allow electron as builtin protocol in esm loader
* Revert "Revert "build: debug depshash""
This reverts commit ff86b1243ca6d05c9b3b38e0a6d717fb380343a4.
* chore: fix esm doc
* chore: update node patches
---------
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: electron-patch-conflict-fixer[bot] <83340002+electron-patch-conflict-fixer[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Daniel Scalzi <d_scalzi@yahoo.com>
2023-08-30 17:38:07 -07:00
Milan Burda
09190085c0
refactor: add gin_helper::Dictionary::CreateEmpty() helper ( #39547 )
2023-08-21 10:43:41 +09:00
Shelley Vohr
c7bdd907d7
fix: set prototype names on gin::Constructible classes ( #39006 )
...
* fix: set prototype names on gin::Constructible classes
* test: add tests
2023-07-10 11:49:20 +02:00
Charles Kerr
30e992dec4
chore: bump chromium to 115.0.5786.0 (main) ( #38301 )
...
* chore: bump chromium in DEPS to 115.0.5772.0
* chore: update disable_color_correct_rendering.patch
no manual changes; patch succeeded with fuzz 2.
* chore: update chromium/build_libc_as_static_library.patch
no manual changes; patch succeeded with fuzz 2 (offset 1 line).
* chore: update chromium/feat_configure_launch_options_for_service_process.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4518747
patch manually reapplied due to upstream code shear
* chore: update chromium/chore_patch_out_profile_methods_in_profile_selections_cc.patch
https://chromium-review.googlesource.com/c/chromium/src/+/4502965
patch manually reapplied due to upstream code shear
* chore: update bundle_locations #include location
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4525355
* chore: Remove `extension_name` from DesktopStreamsRegistry
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4514081
* chore: bump chromium in DEPS to 115.0.5778.0
* chore: add chromium/chore_patch_out_profile_methods_in_chrome_browser_pdf.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4482679
Another instance of patching out upstream references to Profile code
* refactor: add WebViewGuestDelegate::GetGuestDelegateWeakPtr()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4515455
This approach copied from GuestViewBase::GetGuestDelegateWeakPtr() approach in that same commit.
* fixup! chore: update bundle_locations #include location
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4525355
Sync namespace use to upstream base::mac -> base::apple changes
* fixup! chore: update bundle_locations #include location
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4525355
Sync namespace use to upstream base::mac -> base::apple changes
* chore: update chromium/mas_disable_remote_accessibility.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4530546
patch manually reapplied due to upstream code shear
* chore: update chromium/printing.patch
no manual changes; patch succeeded with fuzz
* chore: update chromium/build_add_electron_tracing_category.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4517872
no manual changes; patch succeeded with fuzz
* chore: update chromium/feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4529098
patch manually reapplied due to upstream code shear
* chromium/build_only_use_the_mas_build_config_in_the_required_components.patch
https://chromium-review.googlesource.com/c/chromium/src/+/4529098
patch manually reapplied due to upstream code shear
* chore: update chromium/mas-cgdisplayusesforcetogray.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4529475
no manual changes; patch succeeded with fuzz
* chore: update chromium/build_only_use_the_mas_build_config_in_the_required_components.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4429011
no manual changes; patch succeeded with fuzz
* chore: remove chromium/cherry-pick-48a136e77e6d.patch
already present upstream
* chore: remove chromium/cherry-pick-e6e23ba00379.patch
already present upstream
* [Code Health] Remove value based RegisterPref for Dict and List
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4533537
* Remove `cxx17_backports.h` and adjust unittest file
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4534916
Notes: mostly just removing #include and s/base::clamp/std::clamp/
* refactor: add FakeBrowserProcess helper class
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4424072
Used in ElectronBrowserMainParts' fake_browser_process_ field. Previously
this was an BrowserProcessImpl instance, but upstream 4424072 makes that
an abstract base class. `FakeBrowserProcess` is a thin subclass with the
minimum code needed to make it concrete.
`ElectronBrowserMainParts::fake_browser_process_` is now a `shared_ptr`
instead of a `unique_ptr` so we can avoid exposing `FakeBrowserProcess`
in the header.
* fixup! refactor: add FakeBrowserProcess helper class
remove unnecessary unique_ptr
* fix: Browser::SetDockIcon() when !Browser.is_ready()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4410741
An alternative fix for https://github.com/electron/electron/pull/36279 .
The previous fix was to call `SetSupportedScales()` ourselves (1b1609ahttps://chromium-review.googlesource.com/c/chromium/src/+/4517404
patch manually reapplied due to upstream code shear
* chore: update patches
* chore: add dep: resource_coordinator:mojo_bindings
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4521464
* fixup! chore: add dep: resource_coordinator:mojo_bindings
chore: make lint happy
* chore: patch out Profile methods in titlebar_config
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4508143 (primary)
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4534461 (followup)
* chore: bump chromium in DEPS to 115.0.5780.0
* chore: update chromium/disable_hidden.patch
no manual changes; patch succeeded with fuzz
* chore: update chromium/sysroot.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4535715
no manual changes; patch succeeded with fuzz
* chore: update chromium/feat_enable_offscreen_rendering_with_viz_compositor.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4403623
patch manually reapplied due to upstream code shear
* chore: update chromium/refactor_expose_cursor_changes_to_the_webcontentsobserver.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4547380
patch manually reapplied due to upstream code shear
* chore: update patches
* fixup! fix: Browser::SetDockIcon() when !Browser.is_ready()
chore: iwyu image.h
* chore: bump chromium in DEPS to 115.0.5782.0
* chore: bump chromium in DEPS to 115.0.5784.0
* 4514181: CR2023: Update filled cr-input styles.
https://chromium-review.googlesource.com/c/chromium/src/+/4514181
* 4521894: Remove SiteInstanceDeleting usage outside of tests.
https://chromium-review.googlesource.com/c/chromium/src/+/4521894
* 4525355: Move backup_util and bundle_locations to base/apple
https://chromium-review.googlesource.com/c/chromium/src/+/4525355
* 4484743: webauthn: add underlying support for calling iCloud Keychain on macOS.
https://chromium-review.googlesource.com/c/chromium/src/+/4484743
* chore: fixup patch indices
* 4546398: Convert /chrome/browser to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4546398
* chore: bump chromium in DEPS to 115.0.5786.0
* chore: update patches
* 4540682: Initialize PDF SDK with policy in chrome_pdf::RenderPDFPageToDC()
https://chromium-review.googlesource.com/c/chromium/src/+/4540682
* Don't import ObjC++ fn headers into electron_api_app
* 4535715: Refactor sysroot-creator.sh
https://chromium-review.googlesource.com/c/chromium/src/+/4535715
* fixup! refactor: add FakeBrowserProcess helper class
* 4531903: [string][test] Create/Copy strings to old space before externalization
https://chromium-review.googlesource.com/c/v8/v8/+/4531903
* 59645: Add APIs to support RSA keys with large e.
https://boringssl-review.googlesource.com/c/boringssl/+/59645
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2023-05-23 21:58:58 +02:00
John Kleinschmidt
3dbc0a365f
chore: enable check raw ptr fields ( #38167 )
2023-05-11 16:07:39 -04:00
David Sanders
08593fd2bd
chore: fix clang-tidy warnings ( #38079 )
...
* chore: fix clang-tidy warnings
* refactor: avoid need for NOLINTNEXTLINE
2023-04-26 10:09:54 -04:00
Robo
0240f6664e
fix: crash in utilityProcess when generating code from strings ( #38014 )
2023-04-20 09:27:02 +09:00
Jeremy Rose
fda8ea9277
feat: add protocol.handle ( #36674 )
2023-03-27 10:00:55 -07:00
Jeremy Rose
71944f2c3b
refactor: simplify events ( #37099 )
2023-02-13 13:39:18 -08:00
Jeremy Rose
67dc178e70
refactor: move gin_helper::Constructible methods to prototype ( #37087 )
2023-02-06 12:59:49 -08:00
electron-roller[bot]
d02c9f8bc6
chore: bump chromium to 111.0.5544.3 (main) ( #36820 )
...
* chore: bump chromium in DEPS to 111.0.5522.0
* chore: bump chromium in DEPS to 111.0.5524.0
* chore: bump chromium in DEPS to 111.0.5526.0
* chore: bump chromium in DEPS to 111.0.5528.0
* chore: update patches/chromium/mas_avoid_usage_of_private_macos_apis.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4132807
Fix simple code shear
* chore: update patches/chromium/unsandboxed_ppapi_processes_skip_zygote.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4130675
Fix simple code shear
* chore: update patches/chromium/hack_plugin_response_interceptor_to_point_to_electron.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4144281
Fix simple code shear; applied cleanly w/patch-fuzz
* chore: update patches/chromium/disable_unload_metrics.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4126173
Fix simple code shear; applied cleanly w/patch-fuzz
* chore: update patches/chromium/feat_add_data_parameter_to_processsingleton.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4144281
Fix simple code shear; applied cleanly w/patch-fuzz
* chore: update patches/chromium/preconnect_manager.patch
https://chromium-review.googlesource.com/c/chromium/src/+/4144281
Fix simple code shear; applied cleanly w/patch-fuzz
* chore: update patches/v8/force_cppheapcreateparams_to_be_noncopyable.patch
https://chromium-review.googlesource.com/c/v8/v8/+/3533019
Fix simple code shear; applied cleanly w/patch-fuzz
* chore: update patches
* chore: update patches/chromium/add_maximized_parameter_to_linuxui_getwindowframeprovider.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4128765
Upstream added a new call to HeaderContext(), whose signature we have patched
* chore: bump chromium in DEPS to 111.0.5530.0
* chore: update patches
* Move ChildProcessHost* from content/common to content/browser
Xref: Move ChildProcessHost* from content/common to content/browser
* Remove RenderViewHostChanged
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4134103
[upstream removal of RenderViewHostChanged]
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4092763
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4093234
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133892
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4134103
[examples of upstream code adjusting to the change]
Upstream handles this change in roughly two approaches:
1. Move the code over to RenderFrameHostChanged(old_host, new_host)
but test for new_host->IsInPrimaryMainFrame() before acting
2. Migrate to the PrimaryPageChanged(page) API and use
page.GetMainDocument() to get the RenderFrameHost.
I've chosen 1. because electron_api_web_contents needed that pointer
to old_host to call RemoveInputEventListener(), but I may be missing
some context & would appreciate review on this commit.
* Make electron/shell/browser/relauncher_win.cc use <winternl.h>
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4129135
Many internal Windows types are now available in winternl.h
so upstrem no longer defines the types themselves.
* Move ChildProcessHost* from content/common to content/browser
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4134795
* fixup! Make electron/shell/browser/relauncher_win.cc use <winternl.h>
winternl.h does not define the field we need, so clone the struct Chromium was using into unnamed namespace
* fixup! Move ChildProcessHost* from content/common to content/browser
chore: update #includes too
* chore: bump chromium in DEPS to 111.0.5532.0
* chore: sync patches/chromium/pepper_plugin_support.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133323
manually reync patch; no code changes
* chore: sync patches/chromium/mas_no_private_api.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4143865
the content/common/pseudonymization_salt.cc patch is no longer needed
* chore: sync patches/chromium/mas_disable_remote_accessibility.patch
patch-fuzz update; no manual changes
* chore: sync patches/chromium/build_do_not_depend_on_packed_resource_integrity.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4111725
manually reync patch; no code changes
* chore: sync patches/chromium/create_browser_v8_snapshot_file_name_fuse.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133323
manually reync patch; no code changes
* chore: sync patches/v8/fix_build_deprecated_attribute_for_older_msvc_versions.patch
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/4127230
patch-fuzz update; no manual changes
* chore: rebuild patches
* fixup! Remove RenderViewHostChanged
Use PrimaryPageChanged()
* chore: remove unused method TabsUpdateFunction::OnExecuteCodeFinished()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133991
This private, already-unused function showed up as a FTBFS because it
took a base::ListValue parameter and ListValue was removed upstream.
* task posting v3: remove includes of runner handles and IWYU task runners
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133323
* chore: lint
* chore: more lint
* fixup! task posting v3: remove includes of runner handles and IWYU task runners
macOS, too
* fixup! task posting v3: remove includes of runner handles and IWYU task runners
* chore: bump chromium in DEPS to 111.0.5534.0
* chore: sync patches/chromium/allow_new_privileges_in_unsandboxed_child_processes.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4141862
patch-fuzz update; no manual changes
* chore: sync patches/chromium/logging_win32_only_create_a_console_if_logging_to_stderr.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4153110
Sync to minor upstream changes. Add const correctness.
* chore: sync electron/patches/chromium/feat_configure_launch_options_for_service_process.patch
https://chromium-review.googlesource.com/c/chromium/src/+/4141862
patch-fuzz update; no manual changes
* chore: patches/v8/fix_build_deprecated_attribute_for_older_msvc_versions.patch
sync https://chromium-review.googlesource.com/c/v8/v8/+/4147787
patch-fuzz update; no manual changes
* chore: update patches
* chore: bump chromium in DEPS to 111.0.5536.0
* chore: sync patches/chromium/allow_new_privileges_in_unsandboxed_child_processes.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4141863
Sync with upstream code changes. Minor code golf for readability.
Note: upstream is laying groundwork for being able to work off of env vars
instead of switches. Doesn't affect us yet but worth being aware of.
> + // Environment variables could be supported in the future, but are not
> + // currently supported when launching with the zygote.
* chore: update patches/chromium/feat_expose_raw_response_headers_from_urlloader.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4126836
patch-fuzz update; no manual changes
* chore: sync electron/patches/chromium/feat_configure_launch_options_for_service_process.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4141863
manual sync
* chore: sync electron/patches/v8/fix_build_deprecated_attribute_for_older_msvc_versions.patch
https://chromium-review.googlesource.com/c/v8/v8/+/4147788
fuzz-patch
* chore: rebuild patches
* chore: bump chromium in DEPS to 111.0.5538.0
* chore: bump chromium in DEPS to 111.0.5540.0
* chore: update patches
* Remove sdk_forward_declarations
https://chromium-review.googlesource.com/c/chromium/src/+/4166680
* task posting v3: Remove task runner handles from codebase entirely
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4150928
* Cleanup child_process_launcher_helper*
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4141863
* fix: utilityprocess spec on macOS
* fix: build on windows
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4141863
* chore: fix lint
* chore: bump chromium 111.0.5544.3
* chore: gen filenames.libcxx.gni
* Add check for Executable+Writable handles in renderer processes.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3774416
* fixup! Add check for Executable+Writable handles in renderer processes.
* 4143761: [110] Disable SwiftShader for WebGL on M1 Macs.
https://chromium-review.googlesource.com/c/chromium/src/+/4143761
(cherry picked from commit 2f74db3c2139424c416f92d9169aeaa8a2f9c1ec)
* chore: bump chromium to 111.0.5555.0
* 56085: Remove hmac.h include from ssl.h.
https://boringssl-review.googlesource.com/c/boringssl/+/56085
* 4167020: Remove forwarding headers
https://chromium-review.googlesource.com/c/chromium/src/+/4167020
* chore: bump chromium to 111.0.5559.0
* 4181044: Restrict WebCursor usage to RenderWidgetHostViewAura
https://chromium-review.googlesource.com/c/chromium/src/+/4181044
* 4189437: views: rename ink_drop_host_view to ink_drop_host
https://chromium-review.googlesource.com/c/chromium/src/+/4189437
* chore: bump chromium to 111.0.5560.0
* 4167016: win7dep: remove non aeroglass code
https://chromium-review.googlesource.com/c/chromium/src/+/4167016
* fixup after rebase: Remove forwarding header
s https://chromium-review.googlesource.com/c/chromium/src/+/4167020
* 4125755: Reland "Reject getDisplayMedia calls without user activation"
https://chromium-review.googlesource.com/c/chromium/src/+/4125755
* test: add workaround
* chore: update patches
* fix: alter coreModuleRegExp to prevent arm crash
* Revert "fix: alter coreModuleRegExp to prevent arm crash"
This reverts commit 7e50630c98137831a711c5abdbc8809e60cf1d73.
* 4218354: Disable the use of preserve_most on arm64 Windows
https://chromium-review.googlesource.com/c/v8/v8/+/4218354
* chore: review changes
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2023-02-03 12:43:42 +01:00
Robo
fefb22a83d
chore: enable microtask queue per window agent ( #36870 )
...
* chore: enable microtask queue per window agent
* chore: switch policies on context microtask queue
* fix: ensure node::Environment is valid
2023-01-12 01:59:32 +09:00
David Sanders
5d120359f6
chore: used nested namespaces ( #34737 )
2022-06-29 12:55:47 -07:00
Josh Soref
ea4278754c
chore: fix spelling errors in multiple files ( #34574 )
...
* chore: fix spelling in .circleci
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in BUILD.gn
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in appveyor.yml
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in build
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in docs
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in lib
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in script
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in shell
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in spec
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in spec-main
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-06-16 16:46:11 +09:00
electron-roller[bot]
61374019c0
chore: bump chromium to 103.0.5046.0 (main) ( #33906 )
...
* chore: bump chromium in DEPS to 103.0.5020.0
* chore: bump chromium in DEPS to 103.0.5022.0
* chore: bump chromium in DEPS to 103.0.5024.0
* chore: update patches
* 3587410: [Printing] Remove JobEventDetails
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3587410
* chore: bump chromium in DEPS to 103.0.5026.0
* chore: update patches
* 3577218: WebUI: Delete webui_resources.grd and related GN targets.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3577218
* chore: bump chromium in DEPS to 103.0.5028.0
* chore: update patches
* 3579297: Convert UpdatePrintSettings() to use non-deprecated base::Value APIs.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3579297
* 3560622: serial: Add SerialPort.forget() method
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3560622
* 3581708: Restore original display when moving from tab-fullscreen to browser-fullscreen.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3581708
* chore: fix authorization flags lint error
* 3583363: Remove net wrappers around base/strings/escape.h
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3583363
* fixup! 3560622: serial: Add SerialPort.forget() method
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3560622
* 3587589: Reland "Propagate the MIME type from DownloadTargetDeterminer to DownloadItem"
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3587589
* 3584006: Remove IsRenderViewLive from content public
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3584006
* 3596174: [api] Remove APIs for resurrecting finalizers
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/3596174
* 3368244: Hook SnapshotForContentAnalysis renderer API to scan system prints
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3368244
* chore: bump chromium in DEPS to 103.0.5030.0
* chore: update patches
* chore: bump chromium in DEPS to 103.0.5032.0
* chore: bump chromium in DEPS to 103.0.5034.0
* chore: bump chromium in DEPS to 103.0.5036.0
* chore: update patches
* 3586363: Introduce PrintRenderFrame.PrintWithParams() for batch printing to PDF
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3586363
* 3593199: Remove content::PermissionType references and replace them with blink::PermissionType
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3593199
* 3368244: Hook SnapshotForContentAnalysis renderer API to scan system prints
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3368244
* chore: lint
* chore: bump chromium in DEPS to 103.0.5038.0
* chore: update patches
* fixup! 3560622: serial: Add SerialPort.forget() method
* 3606495: mac screen capture: add metric
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3606495
* chore: bump chromium in DEPS to 103.0.5040.0
* chore: update patches
* 3590840: Add IPs to DnsOverHttpsServerConfig
https://chromium-review.googlesource.com/c/chromium/src/+/3590840
* stub functions for ElectronSerialDelegate and SerialChooserController to fix link
* 3566412: [base] Remove base/android dependency on post_task.h and officially remove post_task.h!
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3566412
* 3347944: [content] No longer hand-off whole MainFunctionParams to BrowserMainParts
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3347944
* fixup! 3566412: [base] Remove base/android dependency on post_task.h and off…
e3ea3e1
…icially remove post_task.h!
* chore: update process_singleton patches for content::GetIOThreadTaskRunner({})
Ref: 2015655: [BrowserThread] Migrate co/pub/br and co/br/scheduler to the new API | https://chromium-review.googlesource.com/c/chromium/src/+/2015655
* chore: migrate base::DeleteSoon to content::GetUIThreadTaskRunner({})->DeleteSoon
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3566412
* chore: remove duplicate functions for RevokePortPermissionWebInitiated & GetPortInfo
* chore: migrate Linux/Windows methods off of post_task.h
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3566412
* 64908: Stop building legacy SwiftShader GL in Chromium
https://swiftshader-review.googlesource.com/c/SwiftShader/+/64908
* 3573245: Added Themed versions of RoundedRectBackground and RoundedRectBorder.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3573245
* chore: bump chromium in DEPS to 103.0.5042.0
* chore: update patches
* 3571804: [api] Advance API deprecation for V8 version v10.2
https://chromium-review.googlesource.com/c/v8/v8/+/3571804
* fixup! 3571804: [api] Advance API deprecation for V8 version v10.2
* build: fix run-clang-format extension matching
* lint
* fix windows build
* how is clang-format still not working for me
* chore: update patches
* 3623985: Replace ad-hoc SetPublicFirstPartySets calls with method in ContentBrowserClient.
https://chromium-review.googlesource.com/c/chromium/src/+/3623985
* no need to implement WillProvidePublicFirstPartySets; the default is false
* 3601036: [QT] Introduce ui/views/linux_ui/linux_ui_factory.*
https://chromium-review.googlesource.com/c/chromium/src/+/3601036
* 3583363: Remove net wrappers around base/strings/escape.h
https://chromium-review.googlesource.com/c/chromium/src/+/3583363
* lint
* chore: bump chromium in DEPS to 103.0.5044.0
* fix conflicts
* chore: update patches
* upgrade nan
* pin version of nan in tests
* replace my hacky deprecated override fix with the fix from upstream
* revert runtime dcheck in v8
* pin nan version at root too
* refactor: tell gyp to use c++17 when building with our node
* Revert "refactor: tell gyp to use c++17 when building with our node"
This reverts commit 41a03a5799a8f40f31555d73d20ea865acfcd192.
* Undo the reversion of 41a03a5799a8f40f31555d73d20ea865acfcd192.
This reverts commit 54440abc598153bd7e259be4a908f0ecc0b33348.
* disable sequential/test-cpu-prof-kill for now
* also sequential/test-diagnostic-dir-cpu-prof
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: Jeremy Rose <japthorp@slack-corp.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2022-05-17 12:48:40 -04:00
