Samuel Attard
186301e126
feat: enable context isolation by default ( #26890 )
...
* feat: enable context isolation by default
* chore: set default in ctx iso getter
* spec: make all specs work with the new contextIsolation default
* spec: fix affinity specs
* spec: update tests for new ctx iso default
* spec: update tests for new ctx iso default
* spec: update tests for new ctx iso default
* spec: update tests for new ctx iso default
* chore: move stray prod deps to dev deps
* spec: update tests for new ctx iso default
* turn off contextIsolation for visibility tests
* turn off contextIsolation for <webview> tag nodeintegration attribute loads native modules when navigation happens
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2021-03-01 16:52:29 -05:00
Cheng Zhao
399216580d
test: fix flaky did-change-theme-color test ( #27739 )
...
* test: move did-change-theme-color test to main
* test: enable did-change-theme-color test for WOA
2021-02-16 17:21:40 -05:00
Shelley Vohr
9063e84b7c
fix: crash in crypto.createDiffieHellman ( #27674 )
2021-02-10 16:10:40 -06:00
Milan Burda
4a5c5843c4
fix: <webview> not working with Trusted Types ( #27445 )
2021-01-25 10:29:25 +09:00
John Kleinschmidt
034a792df1
ci: enable arm64 macOS tests ( #24832 )
...
* ci: enable arm64 macOS tests
2021-01-21 18:36:52 -05:00
John Kleinschmidt
c5a41defbd
fix: enable navigator.setAppBadge/clearAppBadge ( #27067 )
2021-01-21 14:45:06 +09:00
Milan Burda
00d4baa0e2
test: skip media-started-playing media-paused events test when media not supported ( #27215 )
2021-01-07 14:43:20 -08:00
Avi Vahl
9b02d94e97
fix(asar): readdir(withFileTypes) fails on deep directory ( #26865 )
...
when using readdirSync on a deep directory within the archive, the code fails to get the stats of child paths.
2020-12-15 11:21:49 +09:00
Vadim
efca7007b6
fix: internalModuleReadJSON for unpacked JSON ( #26749 )
2020-12-01 21:33:39 -08:00
Milan Burda
19954126e0
chore: remove deprecated extension APIs ( #26696 )
2020-11-30 14:40:56 -08:00
Milan Burda
09d7b2bc91
chore: remove deprecated shell.moveItemToTrash() ( #26723 )
2020-11-30 23:25:03 +03:00
Cheng Zhao
cc136f2acd
fix: LC_ALL env should not be changed ( #26507 )
2020-11-18 11:13:01 +09:00
David Sanders
2b4ce387bc
test: support for adding extra module paths ( #26490 )
2020-11-17 12:05:10 -08:00
loc
0b85fdf26c
feat: add webContents.setWindowOpenHandler API ( #24517 )
...
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2020-11-10 09:06:03 -08:00
Cheng Zhao
d3f32c7502
fix: set app locale after user's script is loaded ( #26185 )
...
* fix: set app locale after user's script is loaded
* fix: set LC_ALL env on Linux
2020-10-28 12:18:47 -04:00
John Kleinschmidt
4ce7ca6cfb
test: disable flaky arm tests ( #26046 )
...
* tests: disable flaking test on all arm platforms
* tests: disable flaky did-change-theme-color tests on WOA
2020-10-19 20:11:30 -04:00
Electron Bot
46f3491c7d
chore: bump chromium to 6b9fa6b352d824d052222e1abe541 (master) ( #25558 )
...
* chore: bump chromium in DEPS to d5c9bf9e2a18fa508201a88e5803bec1d107b1ae
* chore: bump chromium in DEPS to 45f1316afae33e52c92480b34bf4f7fe4a7db898
* update patches
* WillCreateURLLoaderFactory now gets a ukm_source_id
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2346803
* ink_drop_visible_opacity -> GetInkDropVisibleOpacity
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2415368
* chore: bump chromium in DEPS to ddb5b6db5e35ab1a7b5adbd9f15373af6c35ea2a
* 2418471: PDF Viewer update: Add missing aria-labels to various buttons.
https://chromium-review.googlesource.com/c/chromium/src/+/2418471
* update printing.patch given print settings mojoification
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2409467
* update patches
* content::BluetoothChooser::Event -> content::BluetoothChooserEvent
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2387901
* set_ink_drop_base_color -> SetInkDropBaseColor
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2419388
* chore: bump chromium in DEPS to ecf7c9ee830d4d85f300b461a2fa13aa40c79a4c
* update patches
* gfx::ConvertPointToPixel -> gfx::ConvertPointToPixels
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2418568
* remove ContentSettingsObserver::AllowStorage()
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2401847
* service_manager::kCrashDumpSignal -> kCrashDumpSignal
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2417073
* chore: bump chromium in DEPS to abdb7ebe5f8c8328b8f435283df90d0a3ecff7bd
* chore: bump chromium in DEPS to 2a7e138ab1066534ceb2622e8a9d2c8ebf574215
* chore: bump chromium in DEPS to ab1884e75ced904e4276851eb4e1ad89919ca93b
* chore: bump chromium in DEPS to a12413902380dcc2a73ac74d582328280a8af686
* Fixup printing patch
https://chromium-review.googlesource.com/c/chromium/src/+/2428623
* Fixup OSR patch
https://chromium-review.googlesource.com/c/chromium/src/+/2415128
* Make ExtensionURLLoaderFactory always owned by its |receivers_|.
https://chromium-review.googlesource.com/c/chromium/src/+/2357523
* Add deprecated_default_sources_assignment_filter variable
https://chromium-review.googlesource.com/c/chromium/src/+/2416496
* Fixup patch indices
* Remove several references to BrowserPlugin from content
https://chromium-review.googlesource.com/c/chromium/src/+/2401031
* Remove SurfaceEmbeddingTime and LocalSurfaceIdAllocation
https://chromium-review.googlesource.com/c/chromium/src/+/2415128
* Add DragOperation and AllowedDragOperations Mojo types
https://chromium-review.googlesource.com/c/chromium/src/+/2196167
* chore: bump chromium in DEPS to 378450342cf6aa160663d0ce3a178a11b570c25a
* Fixup patch indices
* Remove SurfaceEmbeddingTime and LocalSurfaceIdAllocation
https://chromium-review.googlesource.com/c/chromium/src/+/2415128
* Add DragOperation and AllowedDragOperations Mojo types
https://chromium-review.googlesource.com/c/chromium/src/+/2196167
* 2426564: Remove global sources assignment filter value
https://chromium-review.googlesource.com/c/chromium/src/+/2426564
* Fixup blink_local_frame.patch
* [XProto] Remove a subset of ui/gfx/x/x11.h
https://chromium-review.googlesource.com/c/chromium/src/+/2430328
* Fixup patch indices
* Remove several references to BrowserPlugin from content
https://chromium-review.googlesource.com/c/chromium/src/+/2401031
* Remove lossy ConvertSizeToPixel() methods
https://chromium-review.googlesource.com/c/chromium/src/+/2419534
* serial: Use USB driver name to disambiguate ports
https://chromium-review.googlesource.com/c/chromium/src/+/2413176
* Remove set_sources_filter import
* Fix ModMask usage
* [XProto] Remove usage of all Xlib headers
https://chromium-review.googlesource.com/c/chromium/src/+/2392140
* [XProto] Remove usage of Xlib Visuals
https://chromium-review.googlesource.com/c/chromium/src/+/2429933
* Skip Angle manifest file
https://chromium-review.googlesource.com/c/angle/angle/+/2425197
* Add whole src\third_party\angle\.git directory
This directory is needed in order to properly generate gen/angle/angle_commit.h
* [libvpx] Fix HighBD config on Windows ARM64
https://chromium-review.googlesource.com/c/chromium/src/+/2437745
* update patches
* fix: correct calling convention for Windows on Arm
https://chromium-review.googlesource.com/c/v8/v8/+/2440717
* Add third_party/angle/.git to the archive before adding the rest of the source
* fixup source caching on Windows
* Fixup erroneous close paren
* fixup for goma issues
* This should work
* chore: bump chromium roll manually
https://chromium-review.googlesource.com/c/chromium/src/+/2435142
This landed the day after we paused roller-bot and may resolve the
visibility test flakes that we're seeing. h/t to @jkleinsc for
finding this with me.
* chore: remove obsoleted cherry-pick fix for libvpx
https://chromium-review.googlesource.com/c/chromium/src/+/2437745
* chore: remove obsoleted cherry-pick libvpx patch
https://chromium-review.googlesource.com/c/chromium/src/+/2437745
* chore: re-export patches
* chore: add tracer comment to visibility-stat-spec.
The line numbers between the source and the CI runs don't seem to match
up, so this temp tracer is to help track the source of that difference.
* chore: bump chromium in DEPS to 7c2b8cc3b8638aee8abeb013042a6c1d15b2da6b
* update patches
* impl SortingLSH service
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2425327
* 2446525: [Flash] Remove some Flash APIs
https://chromium-review.googlesource.com/c/chromium/src/+/2446525
* 2440974: Reland "Delete service_manager/embedder/switches.h"
https://chromium-review.googlesource.com/c/chromium/src/+/2440974
* 2359402: Remove ContentBrowserClient::NonNetworkURLLoaderFactoryDeprecatedMap.
https://chromium-review.googlesource.com/c/chromium/src/+/2359402
* 2250506: Implement tabs.removeCSS
https://chromium-review.googlesource.com/c/chromium/src/+/2250506
* 2429143: Remove implicit-conversion-to-integer ConvertRectToPixel() methods.
https://chromium-review.googlesource.com/c/chromium/src/+/2429143
* 2444430: Remove DataElementType::kBlob
https://chromium-review.googlesource.com/c/chromium/src/+/2444430
* 2441964: Clean up WebView public API
https://chromium-review.googlesource.com/c/chromium/src/+/2441964
* 2357523: Make ExtensionURLLoaderFactory always owned by its |receivers_|.
https://chromium-review.googlesource.com/c/chromium/src/+/2357523
* 2461606: Use blink::mojom::PreferredColorScheme instead of blink::PreferredColorScheme
https://chromium-review.googlesource.com/c/chromium/src/+/2461606
* 2461235: a11y inspect reorg: move PropertyFilter struct to a new location
https://chromium-review.googlesource.com/c/chromium/src/+/2461235
* remove flash support
* fix frame_host_manager patch
* fix lint
* remove flash info from docs
* fix build
* fix osr
* chore: bump chromium in DEPS to 9269f9eb1d98d29564c2b2ab97f30c6e148c4e11
* fix visibilityState tests
* 2463049: Replace all uses of web_pref::AutoplayPolicy with mojom::AutoplayPolicy
https://chromium-review.googlesource.com/c/chromium/src/+/2463049
* update patches
* fix tests harder
* 2414921: Add Group and Ungroup functions to Tabs extension API
https://chromium-review.googlesource.com/c/chromium/src/+/2414921
* more test fix
* Remove all keyboard related usage of Xlib
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2436787
* fix linux build
* 2453807: [XProto] Remove usage of Xlib error handling
https://chromium-review.googlesource.com/c/chromium/src/+/2453807
* lint
* fixup! 2453807: [XProto] Remove usage of Xlib error handling
* disable CalculateNativeWinOcclusion on win ci
* remove UploadBlob from docs
* Update appveyor.yml
Co-authored-by: Andy Locascio <andy@slack-corp.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Electron Bot <anonymous@electronjs.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2020-10-15 18:30:41 -07:00
Jeremy Rose
cbe751d349
fix: NativeImage.getScaleFactors returns correct scales ( #25832 )
...
* fix: NativeImage.getScaleFactors returns correct scales
* fix tests
2020-10-13 10:59:18 +09:00
Cheng Zhao
57dc170e81
fix: no more need to hijack process.stdout on Win32 ( #25765 )
2020-10-05 10:10:38 -07:00
Jeremy Rose
485adae94c
fix: nativeImage.crop().toBitmap() returning garbage ( #25757 )
2020-10-05 10:15:16 +09:00
Charles Kerr
515e85079f
chore: fix minor script warnings ( #25575 )
2020-09-23 13:21:34 -07:00
bitdisaster
2cfa41e6e0
feat: read/write Toast Activator CLSID in shortcuts ( #25493 )
...
* read/write Toast Activator CLSID
* docs
* tests
* tweaks
2020-09-17 15:17:44 -07:00
Shelley Vohr
77038b7bda
chore: upgrade to Node.js v14.9.0 ( #25249 )
2020-09-17 16:08:57 -06:00
Samuel Attard
b1d8057ec9
chore: update dependencies ( #25456 )
2020-09-14 14:00:15 -07:00
Jeremy Rose
9f4a097e03
feat: remove getMediaSourceIdForWebContents() ( #25414 )
...
This reverts commit 204f001c5d
.
2020-09-14 10:38:05 -07:00
Charles Kerr
7f885bd266
chore: remove unused code from our js scripts ( #25419 )
2020-09-14 10:22:13 -07:00
John Kleinschmidt
acf5d487d2
fix: crash on nativeImage on Windows on ARM ( #25396 )
...
* fix: nativeImage on WOA
* Remove old ldflag
* maybe this will work ¯\_(ツ)_/¯
2020-09-10 14:42:41 -04:00
Shelley Vohr
f6df79b927
fix: bind fake mojo service for badging ( #25294 )
...
* fix: bind fake mojo service for badging
* Add a test
2020-09-08 11:13:56 -04:00
John Kleinschmidt
7c10f86c6e
ci: cleanup up test app directories ( #25145 )
...
* ci: cleanup up test app directories
* ci: use electron prefix for a testing apps so that the can be cleaned up
* Revert "ci: cleanup up test app directories"
This reverts commit a47daba812ee95f506cac0f1bfedda8be7b4e2f0.
* fixup test due to app name change
2020-08-31 14:07:12 -04:00
John Kleinschmidt
d8fe7af703
ci: fix WOA failing tests ( #25018 )
...
* tests: fix failing WOA tests
tests: fix startDrag for WOA
tests: fix early-in-memory-session-create crash test on WOA
ci: cleanup user app data directories on WOA
* tests: disable nativeImage.createFromBuffer tests on WOA
* disable failing nativeImage.createFromPath on WOA
* disable another nativeImage test for WOA
2020-08-24 12:58:55 -04:00
George Xu
beaf60de0a
feat: add nativeImage.createThumbnailFromPath API ( #24802 )
...
* initial commit, mac implementation
* add documentation
* convert createThumbnailFromPath to async function
* windows impl protoype
* add tests
* added test
* fix
* fix test
* clean up
* update docs
* cleaning up code
* fix test
* retrigger CI
* retrigger CI
* refactor from app to native_image
* windows build
* lint
* lint
* add smart pointers, fix test
* change tests and update docs
* fix test, remove nolint
* add renderer-main process routing to fix tests
* lint
* thanks sam
* thanks sam
2020-08-24 09:36:13 -07:00
Samuel Attard
433956ce4f
build: remove the tools folder ( #24880 )
2020-08-07 14:13:09 -07:00
Shelley Vohr
6cb23e1d36
fix: use non-symbols in isURLInstance check ( #24831 )
2020-08-05 15:05:36 -07:00
Robo
b6321cc22d
fix: crash when navigating from a page with webview that has inherited zoom level ( #24757 )
...
* fix: cleanup webview zoom level observers on navigation
* add spec
* webview should be on same partition
* wait for webview to finish loading
2020-07-28 13:00:44 -07:00
Electron Bot
2f02a469f4
chore: bump node to v12.18.3 (master) ( #24707 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2020-07-27 09:12:29 -07:00
Samuel Attard
b500294c1d
feat: add worldSafe flag for executeJS results ( #24114 )
...
* feat: add worldSafe flag for executeJS results
* chore: do not log warning for webContents.executeJS
* Apply suggestions from code review
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* chore: apply PR feedback
* chore: split logic a bit
* chore: allow primitives through the world safe checl
* chore: clean up per PR feedback
* chore: flip boolean logic
* chore: update per PR feedback
* chore: fix typo
* chore: fix spec
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2020-07-23 14:32:20 -07:00
Robo
7dd365784d
fix: clipboard.readBuffer returning empty value ( #24454 )
2020-07-08 15:02:42 -07:00
Milan Burda
4c449fbc75
test: convert more tests to async / await ( #24373 )
2020-07-01 15:14:38 -04:00
Milan Burda
c6db47182a
test: make sure tests fail properly instead of timing out ( #24316 )
2020-07-01 00:10:36 +02:00
Samuel Attard
16a3f41fd3
chore: add deprecation warning for the default of contextIsolation ( #23507 )
...
* chore: add deprecation warning for the default of contextIsolation
* chore: add to breaking changes
* Update docs/breaking-changes.md
Co-authored-by: Jeremy Apthorp <jeremya@chromium.org>
* chore: fix specs on windows
Co-authored-by: Jeremy Apthorp <jeremya@chromium.org>
2020-06-25 10:55:17 -07:00
Shelley Vohr
659e79fc08
refactor: prevent consistent early exception ( #24191 )
...
* refactor: prevent consistent early exception
* Use _linkedBinding where possible
* Remove dead electronBinding
2020-06-22 20:32:45 -07:00
Robo
7cc780d077
fix: let Node.js perform microtask checkpoint in the main process ( #24131 )
...
* fix: let Node.js perform microtask checkpoint in the main process
* fix: don't specify v8::MicrotasksScope for explicit policy
* fix: remove checkpoint from some call-sites
We already perform checkpoint at the end of a task,
either through MicrotaskRunner or through NodeBindings.
There isn't a need to add them again when calling into JS
except when dealing with promises.
* fix: remove checkpoint from some call-sites
We already perform checkpoint at the end of a task,
either through MicrotaskRunner or through NodeBindings.
There isn't a need to add them again when calling into JS
except when dealing with promises.
* fix incorrect specs
* default constructor arguments are considered for explicit mark
* add regression spec
2020-06-17 10:08:10 -07:00
Shelley Vohr
66744ecb4d
fix: fs.readdir should support withFileTypes ( #24062 )
2020-06-12 08:32:59 -07:00
Paul Frazee
c6c022dc46
feat: add {stream} opt to custom protocol registry to configure media player ( #22955 )
2020-06-08 09:49:36 -07:00
Shelley Vohr
ac81a39e09
fix: compensate for lazy-loaded circular deps ( #23890 )
2020-06-03 10:29:08 -07:00
Samuel Attard
d3fa5ed1e8
docs: move protocol-ns to protocol.md ( #23883 )
...
* docs: move protocol-ns to protocol.md
* chore: fix up tests and implement missing pieces required for tests
2020-06-02 09:46:18 -07:00
Cheng Zhao
5918dd6e65
test: wait for beforeunload handler to be installed ( #23874 )
2020-06-02 11:32:39 +09:00
Alexey Kuzmin
3a7775fa73
test: refactor how spec files are collected ( #23774 )
2020-05-28 00:21:02 +02:00
Jeremy Judeaux
204f001c5d
feat: add desktopCapturer.getMediaSourceIdForWebContents() to get stream source id from web contents ( #22701 )
...
* feat: add desktopCapturer.getMediaSourceIdForWebContents() to get stream source id from web contents
* Cleanup from #22701 PR comments
2020-05-26 16:34:24 -04:00
Cheng Zhao
08f288faf1
test: use WebContents event to test beforeunload ( #23699 )
2020-05-26 09:21:38 -04:00