Cheng Zhao
06cf0406fe
Dereference remote objects with native code
...
Previously we rely on the v8util.setDestructor to dereference the remote
objects in JavaScript, however as documented in V8, it is forbidden to
call V8 APIs in object's destructor (e.g. the weak callback), and doing
so would result in crashs.
This commit removes the JavaScript setDestructor method, and avoids
doing the dereference work with V8.
2016-04-26 16:16:22 +09:00
Cheng Zhao
aa29dc0c8a
Merge pull request #5199 from Mr0grog/5183-disambiguate-loading-from-main-frame-loading
...
Add `isLoadingMainFrame()` to WebContents
2016-04-20 20:49:56 +09:00
Cheng Zhao
ff1b7d18f6
Cleanup the code determining value's type
2016-04-20 14:26:49 +09:00
Rob Brackett
64a84dee3b
Add isLoadingMainFrame
method to WebContents.
...
Also switch `webContents.executeJavaScript` to check it instead of `isLoading`.
There doesn’t seem to be a reasonable public way to get this information out of Chromium, so it’s synthesized here based on WebContentsObserver callbacks.
Fixes #5183 .
2016-04-18 10:37:08 -07:00
Cheng Zhao
31eb793fb0
Avoid adding a new option to webPreferences
2016-04-14 10:50:07 +09:00
Cheng Zhao
8f0e594007
Fix lint warnings
2016-04-13 23:10:31 +09:00
Cheng Zhao
43c44da50b
Correctly set initial visibilityState
2016-04-13 23:07:28 +09:00
Cheng Zhao
07a4c52919
Reduces the IPC messages used for visibilityState
2016-04-13 21:36:43 +09:00
Rob Brackett
15b042b5f6
Add support/tests for did-get-response-details
event on <WebView>
2016-04-08 12:55:20 -07:00
Kevin Sawicki
8d8d5878a3
Rename ATOM_ ipc event prefix to ELECTRON_
2016-04-07 09:04:55 -07:00
Rob Brackett
f12f87d6f0
Add isMainFrame
as last argument to WebContents did-fail-load
event.
...
Fixes #5013 .
2016-04-04 19:26:06 -07:00
Cheng Zhao
39d2b95a33
Reference the remote object in its prototype chain's methods
2016-04-01 15:46:01 +09:00
Cheng Zhao
4ebb01f8c9
Remote object's members should reference itself
2016-04-01 15:26:30 +09:00
Robo
7016fbe258
browser: fix disposition value for new-window event
2016-04-01 08:14:29 +05:30
Cheng Zhao
7353fb4296
Merge pull request #4955 from atom/remove-node-integration-disable-path
...
Remove path for nodeIntegration value of 'disable'
2016-04-01 11:14:30 +09:00
Kevin Sawicki
f033f259b4
Only check for nodeIntegration being true
2016-03-31 08:33:38 -07:00
Zeke Sikelianos
252121ac70
give anonymous function a name
2016-03-30 17:00:35 -07:00
Zeke Sikelianos
9efd29d059
fix a minor style issue
2016-03-30 17:00:35 -07:00
Zeke Sikelianos
d5e8bb7f12
derp
2016-03-30 17:00:35 -07:00
Zeke Sikelianos
7c58f7fb02
eradicate all per-file eslint globals
2016-03-30 17:00:34 -07:00
Zeke Sikelianos
47a61e9f27
use window.location instead of location
2016-03-30 17:00:34 -07:00
Zeke Sikelianos
4e2f1311e0
replace __proto__ with Object.setPrototype
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
e6698102c9
standardize by hand
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
cfdfdc8ccc
standardize by hand
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
fd0f9519f1
remove useless constructors
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
c4b6cf4a8e
do more manual cleanup and specify globals
2016-03-30 17:00:32 -07:00
Zeke Sikelianos
3855a774ab
autoformat more easy files
2016-03-30 17:00:31 -07:00
Kevin Sawicki
ad67070f23
Merge pull request #4861 from OctoHuman/master
...
Fix alert()
2016-03-30 12:40:41 -07:00
Kevin Sawicki
2d32956903
Destructure objects
2016-03-22 13:11:42 -07:00
Kevin Sawicki
cbfe8b9228
Add minWidth and maxWidth to ints array
2016-03-21 09:12:47 -07:00
OctoHuman
116d61185a
Refix alert()
2016-03-20 03:40:12 -05:00
OctoHuman
9f6541228d
Fix alert()
2016-03-20 02:09:30 -05:00
Kevin Sawicki
a53c7529c1
Remove unneeded slice call
2016-03-18 11:54:34 -07:00
Kevin Sawicki
8889c29866
Use rest parameters
2016-03-18 11:51:02 -07:00
Kevin Sawicki
90d815ce6c
Add todo about removing hyphenated options
2016-03-17 13:37:08 -07:00
Kevin Sawicki
3e7501579f
Add camel case versions to ints array
2016-03-17 13:37:08 -07:00
Kevin Sawicki
a14380ed01
Set webPrereferences from features tring
2016-03-17 13:37:07 -07:00
Cheng Zhao
e50ba35871
Merge pull request #4777 from deepak1556/webview_background_patch
...
webview: allow setting background color
2016-03-15 21:12:04 +09:00
Robo
f8f3fba433
webview: allow setting background color
2016-03-14 15:01:36 +05:30
Cheng Zhao
b2059ec8af
Merge pull request #4774 from twolfson/dev/add.location.to.window.open.sqwished
...
Added support for window.location on window.open windows
2016-03-13 22:22:48 +09:00
Todd Wolfson
7569d180c9
Added support for window.location on window.open windows
2016-03-12 18:05:01 -06:00
Kevin Sawicki
3556507ab9
Use arrow functions for this binding
2016-03-11 14:08:14 -08:00
Kevin Sawicki
28e9d87d86
Add back return in getter
2016-03-11 11:25:56 -08:00
Kevin Sawicki
a3f08c9b51
Use arrow functions to replace old CoffeeScript => this wrappers
2016-03-11 11:25:56 -08:00
Kevin Sawicki
5ed6c7714b
Don't return attributes from from WebViewImpl::setupWebViewAttributes
2016-03-11 08:55:47 -08:00
Cheng Zhao
6aec1e6949
Merge pull request #4714 from atom/chrome49
...
Upgrade to Chrome 49
2016-03-11 21:39:52 +09:00
Arek Sredzki
c1267b2320
Added 'show' & 'hide' events to browser-window, fixed visibilitychange event in renderer
2016-03-10 13:51:31 -08:00
Arek Sredzki
ee61ab2d26
Cache browser visibility state & emit visibilitychange event on change
...
Fixes #3788
2016-03-10 13:51:31 -08:00
Cheng Zhao
6de9c4332f
Fix passing Promise with remote
...
Somehow using value.then.bind(value) would result in infinite loop,
could be bug of Chromium.
2016-03-10 17:06:22 +09:00
Kevin Sawicki
418efbe660
Remove unneeded resolve calls
2016-03-08 11:14:22 -08:00