Nitish Sakhawalkar
e77d065875
chore: node_includes header no longer needs to be at the end of the list ( #17090 )
...
Until one of the latest version of node, the definition of the DISALLOW_COPY_AND_ASSIGN macro in node was different than in chromium. That is no longer the case, so just undefining the macro in node_includes.h works.
2019-03-11 17:13:43 -07:00
Jeremy Apthorp
69bf9aa605
fix extra-semi warnings
2019-03-08 15:10:52 -08:00
Robo
5afb7dc715
refactor: load electron builtin modules with process._linkedBinding ( #17247 )
...
* refactor: load electron builtin modules with process._linkedBinding
NODE_BUILTING_MODULE_CONTEXT_AWARE and process.binding are
removed in https://github.com/nodejs/node/pull/25829 . This changes
uses the alternative available without any functionality change.
* chore: roll node
2019-03-08 10:29:52 -08:00
deepak1556
b2bd9ffd70
Downloads : Adding metered network info and retry count to download item
...
https://chromium-review.googlesource.com/c/chromium/src/+/1352628
2019-02-14 23:59:22 +05:30
Jeremy Apthorp
d01db5a656
migrate to non-deprecated v8 functions
...
https://bugs.chromium.org/p/v8/issues/detail?id=8238
https://bugs.chromium.org/p/v8/issues/detail?id=7295
https://chromium-review.googlesource.com/c/v8/v8/+/1352273
2019-01-22 10:32:03 -08:00
Heilig Benedek
ca2d74e118
feat: add methods to allow customization of save dialog during will-download event ( #15497 )
...
* feat: add method to DownloadItem that allows customization of dialog options
* docs: add docs for get/setSaveDialogOptions
* add missing copy constructor for DialogSettings on mac and linux
* fix: don't filter dialog options for mas build, don't return properties
* test: add test for get/setSaveDialogOptions
* fix: remove openDevtools added for debugging
* test: fix failing test because of new event parameter
* docs: use SaveDialogOptions instead of Object
2018-11-08 10:51:06 -04:00
Aleksei Kuzmin
4e580d5b39
Move download_item.h from content/public to components/download
...
https://chromium-review.googlesource.com/907687
2018-06-19 11:49:40 +10:00
Jeremy Apthorp
a635f078c6
[chromium-style] auto variable type must not deduce to a raw pointer type
2018-04-19 11:10:52 -07:00
Shelley Vohr
c6f4bbd143
also format missing .cc files
2018-04-18 20:48:45 -04:00
shelley vohr
0e5b6f9300
Upgrade to node v9.3.0 ( #11507 )
...
* update submodule refs for node v9.3.0
* Define "llvm_version" for Node.js build
* NODE_MODULE_CONTEXT_AWARE_BUILTIN -> NODE_BUILTIN_MODULE_CONTEXT_AWARE
* update NodePlatform to MultiIsolatePlatform
* fix linting error
* update node ref
* REVIEW: Explicitly register builtin modules
https://github.com/nodejs/node/pull/16565
* update libcc ref
* switch libcc to c62
* REVIEW: Address node api changes
- Always start the inspector agent for https://github.com/nodejs/node/pull/17085
- Set the tracing controller for node https://github.com/nodejs/node/pull/15538
- Isolate data creation now requires plaform https://github.com/nodejs/node/pull/16700
2018-02-23 10:22:00 +09:00
liusi
ff513f2a84
remove the call to download_item_->Remove() on cancel
2017-02-24 14:08:21 +08:00
liusi
d56c1909df
only emit download-item done
event once.
2017-02-14 14:39:33 +08:00
Cheng Zhao
497f5a1199
Update files for Chrome 54 API changes
2017-01-19 09:05:59 +02:00
deepak1556
86961d0f44
session: add api to create interrupted downloads
2016-12-09 09:37:46 -08:00
deepak1556
94faaf7d58
provide a default file name for downloads
2016-09-16 16:02:57 +05:30
Cheng Zhao
6d8f900916
Fix building on Windows
2016-09-14 16:22:43 +09:00
Cheng Zhao
844f32aa36
Set prototype of constructor directly
2016-08-02 20:38:35 +09:00
Cheng Zhao
8c3232dc56
Every native class now gets a name
2016-08-02 19:28:12 +09:00
Cheng Zhao
cb19efe49c
Pass FunctionTemplate in BuildPrototype
2016-08-02 18:08:12 +09:00
Cheng Zhao
e1152ae96c
Remove usages of linked_ptr
...
It is no longer needed since we now have move semantic.
2016-08-01 20:26:06 +09:00
Cheng Zhao
dcad25c98c
Add isPaused and canResume
2016-06-09 20:51:01 +09:00
Cheng Zhao
0321e23c7a
Add DownloadItem.getState
2016-06-09 20:27:39 +09:00
Cheng Zhao
993695af07
Remove unneeded cleanup code
2016-04-25 10:23:36 +09:00
Cheng Zhao
2ae52d0ff4
Make Wrappable a template class
2016-04-25 10:17:54 +09:00
Cheng Zhao
5fae63a2f5
Fix compilation errors on OS X
2016-03-10 17:06:21 +09:00
Paul Betts
4503aafe64
int32 => int32_t
2016-03-10 17:06:21 +09:00
Cheng Zhao
50d69fd9bb
Get rid of SavePathData
2016-02-02 20:11:39 +08:00
Cheng Zhao
eaa60e9c17
Destroy the item once item is downloaded
2016-02-02 19:54:41 +08:00
Cheng Zhao
12d311fd29
Gracefully destroy downloadItem
2016-02-02 19:52:09 +08:00
Cheng Zhao
65cf85808f
Calling cancel() should destroy the downloadItem
2016-02-02 19:05:58 +08:00
Cheng Zhao
f1f91828ba
Rely on OnDownloadDestroyed to destroy downloadItem
2016-02-02 18:49:43 +08:00
Robo
2819af9586
fix lifetime of downloadItem class when defaultdownload canceled
2016-02-02 15:54:51 +05:30
Cheng Zhao
a15f9fab5b
Use BuildPrototype to build prototype
...
This saves the step of manually keeping the global template object,
which is easy to forget then leak.
2015-12-03 16:04:46 +08:00
Cheng Zhao
6795bd1d96
Do not manually manage native resources
...
We should rely on the destructor to cleanup everything, instead of
putting them in the Destroy method.
2015-12-03 15:38:43 +08:00
Cheng Zhao
fbb8e61958
Replace "Url" in API names with "URL"
2015-11-13 16:03:40 +08:00
Cheng Zhao
75f49477ca
Cleanup wrapper function when app has done quitting
...
The app may still do something when quitting, we need to make sure the
wrapper function is still there at that time.
2015-11-04 16:54:36 +08:00
Haojian Wu
4a64d1d946
📝 fix a typo
...
interrputed => interrupted
2015-09-25 13:13:11 +08:00
Haojian Wu
1879392c7b
Reimplement downloadItem.getFilename API.
...
Previously, the suggested file name(Always 'empty') returned by
'download_item->GetSuggestedFilename' is not the same with the default one saved
in local disk.
The patch reimplement this API allowing it to return the default file name, which
is more expected from user.
2015-09-24 16:39:02 +08:00
Haojian Wu
0861d5d44b
Redefine 'will-download' design.
2015-09-24 16:04:44 +08:00
Haojian Wu
57bf0cb615
Refractor in completed
event in DownloadItem.
...
* Rename `completed` to `done`, making it align with Chromium's style.
* Add 'state' in `done` event's result. It can check the download item final
status: cancelled, completed, interrupted.
2015-09-21 14:00:38 +08:00
Haojian Wu
997ac91fe0
Add donwloadItem.getContentDisposition()
API.
2015-09-21 09:38:38 +08:00
Haojian Wu
d0ee30101d
Fix cpplint warnings.
2015-09-21 09:34:49 +08:00
Haojian Wu
5ec74451ef
Introduce DownloadItem for supporting more downloading features.
2015-09-20 18:56:10 +08:00