shelley vohr
0f0cc51b35
refactor: return null when passing empty menu templates ( #23364 )
2020-05-04 08:19:21 -07:00
shelley vohr
f50f725a9c
fix: prevent Menu.buildFromTemplate with empty array ( #23308 )
...
Prevent issues with menu creation and subsequent pane focus from menu bar by preventing menus from being created from an empty array. I can't conceive a valid use case for this, since if one wants to remove a menu they should be be passing null to win.setMenu() or calling win.removeMenu(). This issue is also specific to top-level menus, and not submenus, so the new check and exception is scoped to top-level menus.
2020-04-30 08:29:02 -07:00
Samuel Attard
5d657dece4
build: enable JS semicolons ( #22783 )
2020-03-20 13:28:31 -07:00
Micha Hanselmann
06d48514c6
add toolTip property for MenuItem ( #19099 )
2019-07-11 17:56:22 +09:00
Shelley Vohr
544d8a423c
feat: allow MenuItems to work optionally when hidden ( #16853 )
...
* feat: allow MenuItems to work optionally when hidden
* fix: actually include forward_declaration
2019-02-28 17:00:54 +00:00
Heilig Benedek
0242818f39
feat: add registerAccelerator flag to allow menu items to optionally skip accelerator registration ( #15723 )
...
* feat: add registerAccelerator flag to allow menu items to skip registration
* docs: add docs for registerAccelerator
* docs: re-add accidentally removed line
2018-11-26 10:43:55 -08:00
Milan Burda
3ad3ade828
refactor: add prefer-const to .eslintrc + fix errors ( #14880 )
2018-10-02 11:56:31 +10:00
Samuel Attard
54ef906832
[RFC] perf: use an internal module resolver to improve require performance ( #14633 )
...
* perf: use an internal module resolver instead of relative requires
* perf: memoize the results of getting exported Electron properties
* perf: make internal module changes consistent across sandboxed / bundled files
2018-09-20 13:43:26 +10:00
Samuel Attard
558fff69e7
chore: update to standard 12
2018-09-14 14:57:01 +10:00
Zhuo Lu
b8ec84c761
Fix syntax
2018-01-01 02:23:32 +08:00
Zhuo Lu
d45914c3f7
MenuItem roles camelCase-compatible
2017-12-28 13:28:20 +08:00
mst128256
8aba640250
added default menu items for 'Edit' and 'Window' #2814
2017-03-09 16:01:33 +01:00
Zeke Sikelianos
b575055d7e
inherit user-specific MenuItem properties more safely
2016-10-10 14:40:49 -07:00
Zeke Sikelianos
b7e078e98d
sanitize MenuItem options
2016-10-06 14:37:13 -07:00
Zeke Sikelianos
16b3962b66
preserve custom properties passed to MenuItem constructor
2016-10-05 12:24:08 -07:00
Kevin Sawicki
f9a8bd3ea5
Call role method on focused web contents
2016-07-13 14:16:56 -07:00
Cheng Zhao
6381f44f26
mac: Pass useDefaultAccelerator to getAcceleratorForCommandId
2016-07-07 11:50:19 -07:00
Kevin Sawicki
58c1d38c96
Remove lint errors
2016-06-22 14:13:12 -07:00
Kevin Sawicki
c6dc6a8905
Specify focused window to execute call
2016-06-22 14:02:31 -07:00
Kevin Sawicki
66f2fb2fe4
Add execute helper to roles file
2016-06-22 13:48:26 -07:00
Kevin Sawicki
13a6d32ee9
Add default label/accelerator to role menu items
2016-06-22 13:09:48 -07:00
Kevin Sawicki
ad110fc806
Make commandId a read only property
2016-06-22 10:07:02 -07:00
Kevin Sawicki
50a62429e4
Add back event param
2016-06-22 09:35:11 -07:00
Kevin Sawicki
4e8d4dfda9
Move click variable near this.click
2016-06-22 09:21:46 -07:00
Kevin Sawicki
93cbe6539f
Add spec for invalid menu item type
2016-06-22 09:21:46 -07:00
Kevin Sawicki
ca57f8a391
Remove CoffeeScript class wrapper
2016-06-22 09:21:46 -07:00
Cheng Zhao
8d08e215b2
Add "event" parameter for "click" handler of MenuItem
2016-06-22 11:22:14 +09:00
Kevin Sawicki
3505e98a46
Access function in methodInBrowserWindow
2016-06-21 10:08:30 -07:00
Kevin Sawicki
e3e1ed41ca
Add togglefullscreen role
2016-06-21 09:31:17 -07:00
Kevin Sawicki
fbfac6d49b
Fix lint errors
2016-06-21 09:08:13 -07:00
Kevin Sawicki
32ea5a5e27
Remove CoffeeScript ref variables
2016-06-21 09:08:13 -07:00
Kevin Sawicki
2d8ec60eed
Use const/let instead of var
2016-06-21 09:08:13 -07:00
Kevin Sawicki
a16d907684
Add quit role
2016-06-21 09:08:12 -07:00
Daniel Pham
bd1eae86a1
Add 'delete' and 'pasteandmatchstyle' roles
2016-06-05 21:50:37 -04:00
Felix Rieseberg
bef6748c06
🎨 Implement JS Standard Code Style 7
...
Updates Standard Code Style to 7 (latest major) and ensures that code
is conform.
* camelCase is now enforced
* No assignments in return statements
2016-05-25 16:20:49 -07:00
Zeke Sikelianos
42e7ee2b4a
finish standardizing!
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
4794385fac
first pass at standardizing; suite still passing!
2016-03-30 17:00:30 -07:00
Kevin Sawicki
a3f08c9b51
Use arrow functions to replace old CoffeeScript => this wrappers
2016-03-11 11:25:56 -08:00
Kevin Sawicki
70aa9b06ee
Move JavaScript to root lib/ folder
2016-03-08 11:14:21 -08:00
