mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
28539 commits 1 branch 183 tags 5.3 GiB
Commit graph

986 commits

Author SHA1 Message Date
Tomasz
a0effaf9b8
fix: promise resolved to early when browser initiated in-page navigation (#39260) 2023-08-09 16:06:39 +02:00
Milan Burda
3d45429667
refactor: use for-of instead of for simple array iteration (#39338) 2023-08-07 11:30:15 +02:00
Milan Burda
724f90a2a7
refactor: throw errors directly in async functions (#39233) 2023-07-31 10:39:37 +02:00
Milan Burda
455f57322f
refactor: use TypeError instead of generic Error when appropriate (#39209) 
refactor: use TypeError instead of generic Error when appropriate
 2023-07-25 12:08:46 -04:00
Milan Burda
2c52eb7e1c
refactor: replace .indexOf() with .includes() (#39195) 2023-07-24 12:32:54 +02:00
Shelley Vohr
b142fce229
fix: protocol.handle not intercepting file protocol (#39048) 
fix: protocol.handle not intercepting file protocol
 2023-07-12 11:42:49 +02:00
Samuel Attard
499d893040
feat: add support for keyboard initialized menu popup (#38903) 
* feat: add support for keyboard initialized menu popup

* Update docs/api/menu.md

Co-authored-by: Erick Zhao <erick@hotmail.ca>

* fix: add patch to chromium for keyboard accessibility menu behavior

* refactor: s/initiatedByKeyboard/sourceType

* fix: ignore initial mouse event to retain keyboard initiated focus

* Update docs/api/menu.md

Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>

---------

Co-authored-by: Erick Zhao <erick@hotmail.ca>
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
 2023-06-29 15:54:06 -07:00
Milan Burda
607e71d563
refactor: replace Object.prototype.hasOwnProperty() with Object.hasOwn() (#38929) 2023-06-27 16:57:33 -04:00
Milan Burda
81a454d148
chore: re-enable node/no-deprecated-api linting (#38899) 
* chore: re-enable node/no-deprecated-api linting

* chore: re-enable no-global-assign linting
 2023-06-26 13:51:59 -04:00
Shelley Vohr
10852b3fd5
fix: preferCSSPageSize error type (#38761) 
fix: preferCSSPageSize error type
 2023-06-14 10:49:00 -04:00
Shelley Vohr
c0d9764de9
fix: webContents.print parameter validation error (#38614) 2023-06-09 21:41:01 +02:00
Shelley Vohr
c5972ba43c
fix: bad error passing webContents.print(null) (#38612) 
fix: bad error passing webContents.print(null)
 2023-06-07 19:18:26 +02:00
Shelley Vohr
86824c070e
fix: validate response in protocol.handle() (#38587) 
fix: validate response in protocol.handle()
 2023-06-07 09:29:04 +02:00
Milan Burda
71fb19ea14
chore: upgrade to eslint v8 (#38472) 
chore: upgrade to eslint@8
 2023-05-30 13:10:22 +02:00
Milan Burda
470b1d9e9d
refactor: split clipboard module implementation for browser / renderer (#38429) 2023-05-25 20:36:12 +09:00
Milan Burda
82af000a37
chore: cleanup eslint suppressions (#38417) 
* chore: cleanup eslint suppressions

* address feedback

* revert script/lib/azput.js

* revert spec/fixtures/apps/remote-control/main.js

* address feedback

* revert typings/internal-ambient.d.ts
 2023-05-25 10:09:17 +09:00
Milan Burda
06cc9caeaa
build: remove enable_desktop_capturer flag (#38412) 
feat: remove enable_desktop_capturer flag

Co-authored-by: Milan Burda <miburda@microsoft.com>
 2023-05-24 15:32:31 -04:00
Shelley Vohr
9bd9d312f8
fix: enable BrowserWindow.id access post-destruction (#38241) 
fix: enable BrowserWindow id access post-destruction
 2023-05-16 09:29:00 +02:00
David Sanders
a26343f3e0
fix: falsy transparent shouldn't affect webContents background (#36914) 2023-05-02 14:44:34 -07:00
Fedor Indutny
c548f8f59e
feat: net.resolveHost (#37853) 2023-05-02 09:53:00 +02:00
Jeremy Rose
ba835ddac1
feat: add thermal states to powerMonitor (#37935) 
* feat: add thermal states to powerMonitor

* update docs
 2023-04-19 11:46:55 +02:00
Jeremy Rose
fef1b04238
feat: remove on(ready) requirement from powerMonitor (#37937) 2023-04-12 15:37:52 -07:00
Mikael Finstad
e8c87859c4
fix: showAboutPanel also on linux (#37828) 
showAboutPanel also on linux
 2023-04-06 14:50:24 -04:00
Jeremy Rose
fda8ea9277
feat: add protocol.handle (#36674) 2023-03-27 10:00:55 -07:00
George Joseph
e0c348a2f8
feat: Allow usage of an absolute path for partitions used in a session (#37604) 
* Allow an absolute path to be used for creating sessions

Allows an absolute path to be used for creating sessions
by adding the session.fromPath() API.

* Fixup! Clarify that an emptry string is not permitted as a parameter to fromPath()
 2023-03-20 10:34:49 -04:00
Jeremy Rose
6bd9ee6988
feat: net.fetch() supports custom protocols (#36606) 2023-03-02 15:47:45 -08:00
Milan Burda
edf887bdc5
refactor: use _loadURL(url, options ?? {}); (#37337) 2023-02-27 10:05:58 +01:00
Jeremy Rose
872d1fe05a
feat: implement net.fetch (#36733) 2023-02-20 12:57:38 -08:00
Cheng Zhao
0de1012280
feat: add BrowserWindow.set/getWindowButtonPosition APIs (#37094) 2023-02-17 19:06:32 +09:00
Shelley Vohr
889859df5b
feat: include all standard paper sizes for webContents.print() (#37159) 2023-02-14 11:44:34 +01:00
Jeremy Rose
71944f2c3b
refactor: simplify events (#37099) 2023-02-13 13:39:18 -08:00
Jeremy Rose
8dc98aeeae
chore: remove load-url event (#37174) 2023-02-09 14:40:37 +09:00
Eugene Nesvetaev
ce56d614a3
chore: fix typo in promise rejection (#36763) 2023-01-12 12:32:56 +01:00
Jeremy Rose
8f23b1527b
fix: use chrome headers in net.request for everything except cookie (#36666) 2022-12-21 14:53:29 -08:00
Michał Zarach
6a798b1c58
feat: added username to IAP purchaseProduct method (#35902) 2022-12-12 10:11:48 -08:00
Jeremy Rose
625b4619d6
fix: resolve loadURL properly for in-page navigations (#36129) 2022-10-26 13:57:39 -07:00
Robo
da0fd286b4
feat: UtilityProcess API (#34980) 
* chore: initial scaffolding

* chore: implement interface and docs

* chore: address code style review

* fix: cleanup of utility process on shutdown

* chore: simplify NodeBindings::CreateEnvironment

* chore: rename disableLibraryValidation => allowLoadingUnsignedLibraries

* chore: implement process.parentPort

* chore(posix): implement stdio pipe interface

* chore(win): implement stdio interface

* chore: reenable SetNodeOptions for utility process

* chore: add specs

* chore: fix lint

* fix: update kill API

* fix: update process.parentPort API

* fix: exit event

* docs: update exit event

* fix: tests on linux

* chore: expand on some comments

* fix: shutdown of pipe reader

Avoid logging since it is always the case that reader end of
pipe will terminate after the child process.

* fix: remove exit code check for crash spec

* fix: rm PR_SET_NO_NEW_PRIVS for unsandbox utility process

* chore: fix incorrect rebase

* fix: address review feedback

* chore: rename utility_process -> utility

* chore: update docs

* chore: cleanup c++ implemantation

* fix: leak in NodeServiceHost impl

* chore: minor cleanup

* chore: cleanup JS implementation

* chore: flip default stdio to inherit

* fix: some api improvements

* Support cwd option
* Remove path restriction for modulePath
* Rewire impl for env support

* fix: add tests for cwd and env option

* chore: alt impl for reading stdio handles

* chore: support message queuing

* chore: fix lint

* chore: new UtilityProcess => utilityProcess.fork

* fix: support for uncaught exception exits

* chore: remove process.execArgv as default

* fix: windows build

* fix: style changes

* fix: docs and style changes

* chore: update patches

* spec: disable flaky test on win32 arm CI

Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
 2022-10-19 22:49:49 -07:00
Yusoo
dde513b0d3
fix: printToPDF default margins (#36060) 
printToPDF default margins

The document printToPDF has a 1cm margin and this default value has been added in the code.
 2022-10-19 10:16:28 +02:00
Shelley Vohr
ee7cf5a6d4
fix: webContents.printToPDF option plumbing (#35975) 
fix: contents.printToPDF option plumbing
 2022-10-11 16:06:34 -07:00
Jeremy Rose
f82a863f65
feat: replace scroll-touch* with generic input-event (#35531) 2022-09-27 12:47:46 -07:00
Samuel Maddock
c09c94fc98
feat: add WebContents.opener and webContents.fromFrame() (#35140) 
* feat: add WebContents.opener

* feat: add webContents.fromFrame(frame)

* fix: unknown type name

* test: fix and add more fromFrame cases

* docs: clarified terminology
 2022-09-26 12:37:08 -04:00
Milan Burda
f62aab76b3
fix: potential exception when calling webFrameMainBinding.fromIdOrNull() (#35785) 
* fix: potential exception when calling webFrameMainBinding.fromIdOrNull()

* replace try/catch in getWebFrameForEvent

Co-authored-by: Milan Burda <miburda@microsoft.com>
 2022-09-24 12:19:07 -07:00
Milan Burda
b3a744db8a
fix: potential "Object has been destroyed" error in BrowserWindow.getFocusedWindow (#35520) 2022-09-12 14:46:05 -07:00
Milan Burda
e85450b21a
fix: IPC emit order in -ipc-ports handler (#35320) 
Co-authored-by: Milan Burda <miburda@microsoft.com>
 2022-08-16 11:21:56 +09:00
Milan Burda
8424779906
refactor: don't expose deprecate as an internal module (#35311) 2022-08-15 17:09:33 +09:00
Milan Burda
8646bf8d30
chore: remove deprecated 'new-window' event (#34526) 2022-08-09 17:57:05 -04:00
Milan Burda
34b985c556
refactor: use optional chaining / nullish coalescing operator (#35217) 2022-08-08 10:11:04 +02:00
Jeremy Rose
6d859dcd7f
feat: add WebContents.ipc (#34959) 2022-08-03 16:55:12 -07:00
Jeremy Rose
3c63f075bd
chore: remove unused WebContents._sendToFrameInternal (#35010) 2022-07-21 10:25:54 -07:00
Joan Xie
afd08c9450
feat: Enable APNS registration + notification delivery in macOS apps (#33574) 2022-07-12 08:38:49 -07:00
David Sanders
98cd16d336
chore: fix typos (#34731) 2022-07-05 11:49:56 -04:00
Milan Burda
f3f327823e
chore: move main process only accessible API bindings away from common (#34634) 2022-06-21 16:34:56 +09:00
Milan Burda
0f528c1e43
chore: let result: ReturnType<typeof this._callWindowOpenHandler>; (#34628) 2022-06-21 10:39:41 +09:00
Josh Soref
ea4278754c
chore: fix spelling errors in multiple files (#34574) 
* chore: fix spelling in .circleci

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* chore: fix spelling in BUILD.gn

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* chore: fix spelling in appveyor.yml

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* chore: fix spelling in build

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* chore: fix spelling in docs

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* chore: fix spelling in lib

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* chore: fix spelling in script

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* chore: fix spelling in shell

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* chore: fix spelling in spec

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* chore: fix spelling in spec-main

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
 2022-06-16 16:46:11 +09:00
Shelley Vohr
bed38e0985
fix: crash when setWindowOpenHandler callback throws (#34523) 
* fix: crash when setWindowOpenHandler throws

* refactor: throw as process uncaughtException event
 2022-06-14 12:22:23 -04:00
Shelley Vohr
93b39b92b5
refactor: printToPDF should be headless (#33654) 2022-05-31 08:21:25 +02:00
Milan Burda
2091343b78
refactor: initialize member variables directly (#34046) 2022-05-04 16:30:05 +02:00
Robo
16f8d713ab
fix: apply senderFrame details to ipcMain port event (#33756) 2022-04-13 21:01:00 -07:00
electron-roller[bot]
59dd17f2cf
chore: bump chromium to 102.0.4989.0 (main) (#33557) 
* chore: bump chromium in DEPS to 102.0.4975.0

* chore: bump chromium in DEPS to 102.0.4977.0

* chore: update patches

* Remove parameter of OnGpuProcessCrashed()

https://chromium-review.googlesource.com/c/chromium/src/+/3543396

* hid: Add exclusionFilters option to requestDevice

https://chromium-review.googlesource.com/c/chromium/src/+/3478175

* chore: bump chromium in DEPS to 102.0.4979.0

* chore: bump chromium in DEPS to 102.0.4981.0

* chore: update patches

* Deny notification/push permission for documents in non-standard StoragePartitions

https://chromium-review.googlesource.com/c/chromium/src/+/3257305

* Improve FrameTreeNode tracking in URLLoaderNetworkContext

https://chromium-review.googlesource.com/c/chromium/src/+/3341866

* fixup! Remove parameter of OnGpuProcessCrashed()

* chore: fix lint

* Reland "Use gfx::Insets[F]::TLBR() and gfx::Insets[F]::VH() in the rest of Chrome"

https://chromium-review.googlesource.com/c/chromium/src/+/3554236

* chore: bump chromium in DEPS to 102.0.4983.0

* Ensure EyeDropperView does not access a destroyed window

https://chromium-review.googlesource.com/c/chromium/src/+/3561542

* ci: don't delete dawn .git directory

83901: Adds a generated file with the dawn git hash encoded at build time. | https://dawn-review.googlesource.com/c/dawn/+/83901

* ci: update Windows toolchain

3550827: New toolchain for Windows 10 20348 SDK | https://chromium-review.googlesource.com/c/chromium/src/+/3550827

* chore: bump chromium in DEPS to 102.0.4985.0

* chore: update patches

* chore: bump chromium in DEPS to 102.0.4987.0

* chore: update patches

* 3563432: codehealth: remove uses of DictionaryValue in cbui/webui

https://chromium-review.googlesource.com/c/chromium/src/+/3563432

* chore: update patches after rebase

* Use gfx::Insets[F]::TLBR() and gfx::Insets[F]::VH() in the rest of Chrome

https://chromium-review.googlesource.com/c/chromium/src/+/3554236

* 3565724: Preserve "proper method names" as-is in error.stack.

https://chromium-review.googlesource.com/c/v8/v8/+/3565724

* chore: bump chromium in DEPS to 102.0.4989.0

* chore: update patches

* fixup ci: don't delete dawn .git directory for Windows

* 3560843: Remove multi-parameter version of gfx::Rect[F]::Inset()

https://chromium-review.googlesource.com/c/chromium/src/+/3560843

* 3572711: Remove unused IDS_PDF_TOOLTIP_ROTATE_CW resource.

https://chromium-review.googlesource.com/c/chromium/src/+/3572711

* 3572926: Reland "[Sysroot] Switch to Debian Bullseye stable"

https://chromium-review.googlesource.com/c/chromium/src/+/3572926

* build: fixup sysroots with electron specific dependencies

* fixup Remove multi-parameter version of gfx::Rect[F]::Inset()

* fixup 3565724: Preserve "proper method names" as-is in error.stack.

* fixup Remove multi-parameter version of gfx::Rect[F]::Inset()

* test: add spec for navigator.hid.requestDevice({ exclusionFilters: [...] }

* fixup 3565724: Preserve "proper method names" as-is in error.stack.

* ci: use python3 to get the windows toolchain profile

3525960: Explicitly run everything with python3 | https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3525960

* chore: add diagnostic logging

* fix: try calling process.crash()

* chore: remove logging

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2022-04-12 13:19:14 +02:00
Shelley Vohr
d1ea62c3e8
fix: getting focused window with destroyed webContents (#33404) 
* fix: getting focused window with destroyed webContents

* fix: add extra safeguards
 2022-03-29 12:22:58 -04:00
David Sanders
df8fd1b269
build: fix build by removing usage of removed preloadUrl (#33319) 2022-03-17 00:13:48 -07:00
Jeremy Rose
27527fe5ca
feat: warn that preloads will be sandboxed by default in v20 (#32868) 2022-03-08 15:39:53 -08:00
t57ser
41b2945ced
feat: add ability to configure if window should close when opener closes (#31314) 
* feat: Added ability to configure if window should close when opener closes

* fix: check if embedder is destroyed

* fix: correctly take over closeWithOpener property

* chore: Added documentation

* Update docs/api/window-open.md

Co-authored-by: John Kleinschmidt <jkleinsc@github.com>

* chore: refactor

Co-authored-by: Jeremy Rose <nornagon@nornagon.net>

* chore: changed property name from `closeWithOpener` to `outlivesOpener`

* dummy change to kick lint

* undo above

Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
 2022-02-23 16:59:50 +09:00
David Sanders
1e8da899a3
chore: fix typos (#32985) 2022-02-21 10:27:45 +01:00
Milan Burda
db9ab80694
chore: update to latest TypeScript (#32596) 2022-01-31 20:37:40 +09:00
Matthew Rayermann
d26d337bb8
feat: add rawHeaders to IncomingMessage (#31853) 
* Add response.rawHeaders to docs for IncomingMessage

* Remove trailing spaces

* Implement raw headers, add tests

* Fix lint issues

* Add example from NodeJS docs

* Fix lint issue in doc example

* Add missing #
 2022-01-24 11:46:15 -05:00
Jeremy Rose
a015332342
fix: drop nativeWindowOpen deprecation warning (#32370) 2022-01-06 12:01:55 -08:00
Mitchell Cohen
5af6b898d9
feat: add Substitutions menu roles on macOS (#32024) 2022-01-06 10:41:28 -08:00
Jeremy Rose
d44a187d0b
feat: remove nativeWindowOpen option (#29405) 
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com>
 2022-01-06 09:28:03 -08:00
Milan Burda
2f9fd06534
chore: deprecate nativeWindowOpen in Electron 17 (#32116) 2022-01-06 05:08:59 -08:00
Keeley Hammond
ffbaa1d83f
fix: check for single bluetooth listener (#32240) 2021-12-17 16:55:43 -08:00
Samuel Attard
a11f5cbb27
fix: ensure bluetooth devices are not returned by default (#32178) 2021-12-15 11:46:48 -08:00
Cheng Zhao
35ac7fb8e6
fix: window.open not overriding parent's webPreferences (#32057) 
* fix: window.open not overriding parent's webPreferences

* test: remove "nativeWindowOpen: false" from renderer tests
 2021-12-06 12:54:14 +09:00
Milan Burda
18cc33055d
chore: move libs only used in browser out of common (#31780) 2021-11-10 08:54:51 -08:00
Darshan Sen
8f51d3e1bf
feat: add webContents.getPrintersAsync() (#31023) 
This deprecates the synchronous and blocking `webContents.getPrinters()`
function and introduces `webContents.getPrintersAsync()`, which is
asynchronous and non-blocking.

Signed-off-by: Darshan Sen <darshan.sen@postman.com>
 2021-10-25 14:16:58 -04:00
Milan Burda
5592652504
feat: warn when ipcRenderer.sendSync() called with no listeners for channel (#31344) 2021-10-14 14:24:04 -04:00
Keeley Hammond
bff20bd769
fix: reset render_frame_disposed_ after render frame host change (#31401) 
* fix: reset render_frame_disposed_ after hang

* fix: handle exception in webContents.send
 2021-10-14 09:44:44 -07:00
Samuel Attard
014ebbd6fa
feat: add commandLine.removeSwitch (#30933) 
* feat: add commandLine.removeSwitch

In some cases apps may want to remove Chromium command line switches to avoid certain Chromium behaviors being used, E.g. remote-debugging-port or gpu-launcher

* fix: add missing removeSwitch to app.ts

Co-authored-by: Milan Burda <milan.burda@gmail.com>
 2021-10-06 16:45:58 -04:00
Jeremy Rose
4fd7c2adcd
feat: make desktopCapturer main-process-only (#30720) 
* feat: make desktopCapturer main-process-only

* remove --enable-api-filtering-logging

* remove test

* merge lib/browser/api/desktop-capturer.ts with lib/browser/desktop-capturer.ts

* remove desktop-capturer-get-sources event

* fix specs

* getSources needs to be async

Co-authored-by: Milan Burda <milan.burda@gmail.com>
 2021-10-04 12:16:00 +09:00
Milan Burda
77579614e0
feat: add width option to dialog.showMessageBox() (#30474) 2021-09-23 19:56:14 +09:00
Keeley Hammond
bb6dc99d9d
chore: clarify new-window fix comment (#31069) 2021-09-22 15:30:55 -07:00
Keeley Hammond
4fcc0884f8
fix: propagate window.open settings to child window (#31031) 2021-09-21 09:06:20 -07:00
Milan Burda
8b7631228f
chore: move native-image.ts back into common (#30838) 2021-09-06 11:06:27 +02:00
Samuel Maddock
352ac21413
feat: add webContents.fromDevToolsTargetId() (#29399) 
* feat: add webContents.fromDevToolsTargetId()

* refactor: avoid using FromOrCreate
 2021-08-27 14:01:24 -07:00
George Xu
bc508c6113
feat: add electron.safeStorage encryption API (#30020) 
* feat: add SafeStorage api; first commit

* chore: rename files to fit semantically

* chore: add linkedBindings

* chore: fix function signatures

* chore: refactor eisCookieEncryptionEnabled() fuse

* chore: create test file

* chore: add tests and documentation

* chore: add copyright and lint

* chore: add additional tests

* chore: fix constructor

* chore: commit for pair programming

* wip: commit for keeley pairing

* chore: docs change and code cleanup

* chore: add linux import

* chore: add description to documentation

* chore: fixing tests

* chore: modify behaviour to not allow unencrypted strings as decyption input

* fix add patch for enabling default v11 encryption on Linux

* chore: remove file after each test

* chore: fix patch

* chore: remove chromium patch

* chore: add linux specific tests

* chore: fix path

* chore: add checker for linuux file deletion

* chore: add dcheck back

* chore: remove reference to headless mode

* chore: remove tests for linux

* chore: edit commit message

* chore: refactor safeStorage to not be a class

* chore: remove static variable from header

* chore:  spec file remove settimeout

Co-authored-by: VerteDinde <keeleymhammond@gmail.com>
 2021-08-05 15:12:54 -07:00
Jeremy Rose
888ac65c72
fix: toggleDevTools menu role closes devtools window (#29922) 2021-08-02 10:58:28 +09:00
Cheng Zhao
05ba6359d0
feat: add signal option to dialog.showMessageBox (#26102) 
* mac: add dialog.closeMessageBox API

* win: Implement dialog.closeMessageBox

* mac: Return cancelId with closeMessageBox

* gtk: Implement dialog.closeMessageBox

* win: Fix 32bit build

* win: Reduce the scope of lock

* fix: Build error after rebase

* feat: Use AbortSignal to close message box

* chore: silently handle duplicate ID

* win: Add more notes about the threads

* chore: apply reviews

* fix: base::NoDestructor should be warpped in function

* chore: fix style on windows
 2021-07-15 07:59:27 +09:00
Samuel Attard
da9261497e
feat: add MenuItem.userAccelerator property (#26682) 
* feat: add MenuItem.userAccelerator property

This allows folks to read the user-assigned accelerator that macOS users can provide in system preferences. Useful for showing in-app shortcut help dialogs, you need to know if the accelerator you provided is not being used in favor of a user assigned one.

* chore: update syntax

* chore: add safety check for command index being -1
 2021-06-29 16:28:16 -07:00
Jeremy Rose
ebf54d7cc0
refactor: use PathProvider for user-data-dir and others (#29649) 
* refactor: use PathProvider for user-data-dir and others

* consolidate logic for DIR_RECENT and DIR_APP_LOGS into path provider

* fix bad include

* remove debugging code

* fix build on mac

* fix build on win

* create app logs dir on both mac and non-mac
 2021-06-15 09:32:56 +09:00
Milan Burda
8d0ed05c99
refactor: replace a few usages of V8 hidden properties (#29400) 2021-06-03 14:59:56 +09:00
Milan Burda
44491b023a
refactor: eliminate duplicate C++ / JavaScript implementation of app.isPackaged (#29464) 2021-06-02 12:17:08 -07:00
Robo
77297f37a3
fix: adjust initial webContents focus calculation (#29204) 
* fix: adjust initial webContents focus calculation

* fix: active window check on mac

* fix: about:blank focus behavior

* chore: add spec

Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>
 2021-05-19 02:27:35 -07:00
Milan Burda
c68c65f383
refactor: implement <webview> using contextBridge (#29037) 
* refactor: implement <webview> using contextBridge

* chore: address PR feedback

* chore: address PR feedback

* fix: check for HTMLIFrameElement instance in attachGuest
 2021-05-15 16:42:07 +09:00
Tabish Mahfuz
5ceec9189e
fix: Menu.setApplicationMenu can return a useless array 29088 (#29118) 2021-05-12 12:02:30 -07:00
Milan Burda
42e5421276
refactor: remove unnecessary setupDialogProperties (#28982) 2021-05-05 16:00:41 +09:00
Milan Burda
961b74b2ac
refactor: use "as const" for constant mappings (#28980) 2021-05-04 14:12:49 -07:00
Samuel Attard
791eddd541
fix: provide no-op implementation of app.setUserModelId (#28915) 2021-04-28 18:41:03 -07:00
Samuel Attard
0a1b26b1d5
refactor: remove internal navigation controller (#28839) 2021-04-27 16:11:18 -07:00
Samuel Attard
79077f6df9
chore: remove app.allowRendererProcessReuse (#26874) 2021-04-21 13:59:11 -07:00
Shelley Vohr
11199d8824
feat: add BrowserWindow.isFocusable() (#28642) 2021-04-21 12:32:19 +02:00