trop[bot]
484cf26787
fix: don't destroy BrowserView webContents when owning BrowserWindow hasn't been closed ( #42371 )
...
fix: don't destroy BrowserView webContents when owning BrowserWindow hasn't been closed (#42353 )
* fix: moves bv webContents close to closed event
* chore: adds unit tests
* chore: test that bv webContents are destroyed when parent bw closed
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Anny Yang <anny@electronjs.org>
2024-06-05 12:00:30 +02:00
trop[bot]
05ae671d83
fix: webContents.navigationHistory
should be enumerable ( #42181 )
...
fix: webContents.navigationHistory should be enumerable
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-05-14 17:46:59 -07:00
Samuel Attard
1872411ae8
test: add tests for electron fuses ( #42148 )
...
test: add tests for electron fuses (#42129 )
* spec: add tests for electron fuses
* spec: fix tests for windows
* spec: handle weird crash codes on win32
* spec: disable fuse tests on arm64 windows
2024-05-13 13:35:52 -07:00
trop[bot]
fb54883e26
fix: BrowserView autoresizing conversion error ( #42137 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-05-13 13:02:57 +02:00
trop[bot]
08abef64f4
fix: View reordering on re-addition to same parent ( #42115 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-05-13 13:01:05 +02:00
trop[bot]
0650ffc715
fix: CHECK when adding view as its own child ( #42107 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-05-09 12:33:21 -04:00
trop[bot]
e76787ead1
fix: requestFullscreen
from WebContentsView
( #41996 )
...
fix: requestFullscreen from WebContentsView
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-05-03 11:28:00 -04:00
electron-roller[bot]
ddcb2b7183
chore: bump chromium to 124.0.6367.118 (30-x-y) ( #42015 )
...
* chore: bump chromium in DEPS to 124.0.6367.118
* chore: update patches
* chore: disable tests that require nut.js (#42006 )
* chore: disable tests that require nut.js
* fixup! chore: disable tests that require nut.js
(cherry picked from commit 4dff815f479880537c66f29a7571091ebfc417a1)
* test: revert inadvertent winreg change
winreg 1.2.5 breaks the following tests:
app module setAsDefaultProtocolClient(protocol, path, args) creates a registry entry for the protocol class
app module setAsDefaultProtocolClient(protocol, path, args) only unsets a class registry key if it contains other data
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-05-02 17:40:21 -05:00
electron-roller[bot]
90f03d728e
chore: bump chromium to 124.0.6367.78 (30-x-y) ( #41959 )
...
* chore: bump chromium in DEPS to 124.0.6367.78
* chore: update patches
* Revert "[Clipboard] Don't add meta charset tag for async write() method on Mac."
https://chromium-review.googlesource.com/c/chromium/src/+/5455853
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-04-25 09:11:00 -04:00
trop[bot]
8d69c95ee0
fix: data corruption in protocol.handle
( #41933 )
...
* fix: data corruption in protocol.handle
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* slice instead of subarray
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2024-04-23 11:23:19 -04:00
trop[bot]
91f257044d
fix: nativeImage.createThumbnailFromPath
and shell.openExternal
in renderer ( #41909 )
...
* fix: nativeImage.createThumbnailFromPath in renderer
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* also fix shell.openExternal
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2024-04-19 10:56:43 -05:00
trop[bot]
cf1087badd
feat: implement File System API support ( #41827 )
...
* feat: implement File System API support
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* test: add a test for writable permission checking
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: gn check include issues
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: feedback from review
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: cleanup feedback from review
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* refactor: namespace to electron
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fixup! chore: cleanup feedback from review
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: address more feedback from review
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 5301485: Add content analysis to File System Access Javascript API.
https://chromium-review.googlesource.com/c/chromium/src/+/5301485
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* docs: improve typing of details object
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: address outstanding todo
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* refactor: use Chrome's file system access blocklist
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* lint
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: Windows build
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* test: clarify test verbiage
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-04-15 12:22:17 -07:00
trop[bot]
1b6e7768fe
fix: do not activate app when showing a panel on Mac ( #41844 )
...
* fix: do not activate app when showing or focusing a panel on Mac
Co-authored-by: Mitchell Cohen <mitch.cohen@me.com>
* restored panel activation test
Co-authored-by: Mitchell Cohen <mitch.cohen@me.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Mitchell Cohen <mitch.cohen@me.com>
2024-04-13 16:55:42 +02:00
trop[bot]
3ea26fb9d0
fix: move BrowserWindow's WebContentsView to be a child of rootview ( #41802 )
...
fix: move BrowserWindow's WebContentsView to be a child of rootview (#41256 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2024-04-10 13:20:44 +02:00
Alice Zhao
9056dd728a
feat: add navigationHistory.getEntryAtIndex(int index)
method ( #41662 )
...
* feat: add `navigationHistory.getEntryAtIndex(int index)` method (#41577 )
* test: fix flaky tests by replacing real urls with data urls
* test: remove hardcoded url
2024-04-05 13:59:46 -04:00
trop[bot]
8a47acebe7
docs: add missing headers option to ClientRequest options ( #41732 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2024-04-01 12:05:56 -04:00
trop[bot]
7031c930fd
fix: Storage.{get|set|clear}Cookies
via CDP not working ( #41740 )
...
* fix: Storage.{get|set|clear}Cookies via CDP not working
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: simplify BrowserContext plumbing
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-03-28 20:52:08 -05:00
trop[bot]
b5c9945692
test: disable flaky <webview>.capturePage()
specs ( #41737 )
...
test: disable flaky <webview>.capturePage() specs
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-03-28 20:51:57 -05:00
trop[bot]
5655b68c37
test: add tests for Storage Access API ( #41719 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-03-27 15:47:44 -05:00
trop[bot]
ba1e7fcaa7
test: add test and api_feature
definition for chrome.scripting.globalParams
( #41700 )
...
chore: add test and api_feature for chrome.scripting.globalParams
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-03-27 10:21:04 +01:00
trop[bot]
0f1e52fafe
fix: app.setLoginItemSettings
error getting swallowed by gin conversion ( #41667 )
...
* fix: errors getting swallowed by gin conversion
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: Windows build
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* test: re-enable disabled test
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-03-22 16:59:51 +01:00
trop[bot]
21341a56a7
ci: use CircleCI hosted macOS arm64 runners for testing ( #41654 )
...
* ci: use CircleCI hosted macOS arm64 runners for testing
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* test: disable transparency tests on macOS arm64 (#41580 )
(cherry picked from commit 6cb84ddbfb
)
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-03-22 10:57:35 +01:00
trop[bot]
d3b182f8b9
fix: chrome://process-internals
failing to load ( #41540 )
...
fix: chrome://process-internals failing to load
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-03-12 20:35:58 +01:00
trop[bot]
b45f579eda
test: disable CapturableScreen tests on Windows x64 ( #41547 )
...
* test: disable CapturableScreen tests on Windows x64
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* test: disable js-execute-iframe" case should not crash on win 32-bit
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-03-08 09:32:34 -05:00
trop[bot]
058c6b4af7
chore: bump chromium to 124.0.6331.0 (30-x-y) ( #41515 )
...
* chore: bump chromium in DEPS to 124.0.6329.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* 5319449: Activate popups after async opener fullscreen exit transitions | https://chromium-review.googlesource.com/c/chromium/src/+/5319449
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* 5321532: [//ui] Remove ContextFactory::SharedMainThreadContextProvider() | https://chromium-review.googlesource.com/c/chromium/src/+/5321532
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* fixup! 5319449: Activate popups after async opener fullscreen exit transitions | https://chromium-review.googlesource.com/c/chromium/src/+/5319449
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* 5319141: [OOPIF PDF] Create PdfNavigationThrottle for main frame navigations | https://chromium-review.googlesource.com/c/chromium/src/+/5319141
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* test: disable webview.capturePage test for mac arm64
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* chore: bump chromium in DEPS to 124.0.6337.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
* build: roll back DEPS to 124.0.6331.0
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
2024-03-06 13:07:52 -05:00
trop[bot]
17856cf91a
fix: webContents.print options should be optional ( #41480 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-03-02 11:24:36 -05:00
trop[bot]
56dfcc5468
chore: bump chromium to 124.0.6323.0 (30-x-y) ( #41475 )
...
* chore: bump chromium in DEPS to 124.0.6315.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* 5279678: Stream AIDA responses
https://chromium-review.googlesource.com/c/chromium/src/+/5279678
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* 5276439: Remove non_network_url_loader_factory_remotes_
https://chromium-review.googlesource.com/c/chromium/src/+/5276439
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* 5310165: Add DevTools API to show search results
https://chromium-review.googlesource.com/c/chromium/src/+/5310165
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: bump chromium in DEPS to 124.0.6317.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Remove Setup.Install.CumulativeDiskUsage2 and supporting code
https://chromium-review.googlesource.com/c/chromium/src/+/5314269
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* browser: Make cmd line non-const in process singleton callback
https://chromium-review.googlesource.com/c/chromium/src/+/5311256
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: bump chromium in DEPS to 124.0.6319.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 124.0.6321.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 124.0.6323.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* 5318335: Roll src/third_party/boringssl/src 23824fa0f..4fe29ebc7
https://chromium-review.googlesource.com/c/chromium/src/+/5318335
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 5318051: [CBE Watermarking] Hoist `watermark_view` to a member variable.
https://chromium-review.googlesource.com/c/chromium/src/+/5318051
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: fixup patch indices
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 4946553: Delegate HID permission to Chrome App in webview
https://chromium-review.googlesource.com/c/chromium/src/+/4946553
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 5310001: DevTools UI binding for reporting client events to AIDA
https://chromium-review.googlesource.com/c/chromium/src/+/5310001
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Refactor the predicate taking variant of `__cxx_atomic_wait`
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: fix browser_view patch harder
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 5293937: Reland "[gUM] Use preferred device if more than one is eligible"
https://chromium-review.googlesource.com/c/chromium/src/+/5293937
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: filter {video|audio} devices by eligible device id
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 5267921: enable speak content under the pointer on PWA and WV2
https://chromium-review.googlesource.com/c/chromium/src/+/5267921
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* 5310195: heap: Remove Blink's GCTaskRunner
https://chromium-review.googlesource.com/c/chromium/src/+/5310195
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-02-29 09:50:27 -05:00
trop[bot]
105acec227
test: disable flaky macOS panel test & refactor screen capture testing ( #41461 )
...
* Disable flaky test
Co-authored-by: clavin <clavin@electronjs.org>
* Add helper for storing test artifacts
Co-authored-by: clavin <clavin@electronjs.org>
* Refactor screen capture tests
We have a pattern for inspecting a screen capture, so this refactor codifies that pattern into a helper. This gives us shorter test code, consistency (previously, the display in test code and the display captured could theoretically be different), and better debugging/observability on failure.
Co-authored-by: clavin <clavin@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org>
2024-02-28 14:55:15 +09:00
trop[bot]
174aedf54c
chore: remove deprecated inputFieldType
( #41440 )
...
chore: remove deprecated inputFieldType
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com>
2024-02-28 14:52:01 +09:00
trop[bot]
ef40e551cf
feat: add support for configuring system network context proxies ( #41417 )
...
* feat: add support for configuring system network context proxies
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: add specs
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: fix lint
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* fix: address review feedback
Co-authored-by: deepak1556 <hop2deep@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2024-02-23 14:56:06 -06:00
Keeley Hammond
136d7e7e6a
fix: check for draggable regions outside of main frame ( #41377 )
2024-02-20 19:10:43 -08:00
Henrik Gaßmann
80906c0adb
fix: properly stream uploadData
in protocol.handle()
( #41052 )
...
* refactor(protocol): extract file stream factory
Increase readability by moving the file stream creation logic out of the
`uploadData` to request body conversion function.
* fix: properly flatten streams in `protocol.handle()`
Refs: electron/electron#39658
* fix: `protocol.handle()` filter null origin header
Refs: electron/electron#40754
* fix: remove obsolete TODO comment
Refs: electron/electron#38929
* fix: forward `Blob` parts in `protocol.handle()`
Refs: electron/electron#40826
* fix: explicitly error out on unknown chunk parts
2024-02-16 14:29:29 -05:00
electron-roller[bot]
0dad99561b
chore: bump chromium to 123.0.6296.0 (main) ( #41204 )
...
* chore: bump chromium in DEPS to 123.0.6273.0
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6274.0
* chore: update patches
* chore: bump chromium in DEPS to 123.0.6276.0
* chore: update patches
* WIP: 5239586: Change View::Layout() to take a PassKey.
https://chromium-review.googlesource.com/c/chromium/src/+/5239586
* WIP: 5239586: Change View::Layout() to take a PassKey.
https://chromium-review.googlesource.com/c/chromium/src/+/5239586
* chore: bump chromium in DEPS to 123.0.6278.0
* chore: bump chromium in DEPS to 123.0.6280.0
* chore: update patches
* chore: use net::CanonicalCookie::SecureAttribute()
renamed from IsSecure()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5245913
* refactor: handle multiple requested device ids
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5132210
* refactor: trigger View layouts async with View::InvalidateLayout()
Upstream has introduced a PassKey to restrict who can call Layout()
directly. I've opted for calling `InvalidateLayout()` which is the
approach that upstream recommends.
If for some reason this approach doesn't work for us, we could use
`DeprecatedLayoutImmediately()` as a stopgap.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5239586
Xref: https://chromium.googlesource.com/chromium/src/+/main/ui/views/view.h#809
Xref: https://chromium.googlesource.com/chromium/src/+/main/docs/ui/learn/bestpractices/layout.md?pli=1#don_t-invoke-layout_directly
* chore: bump chromium in DEPS to 123.0.6282.0
* chore: bump chromium in DEPS to 123.0.6284.0
* chore: update patches
* refactor: remove use of blink::MainThreadIsolate() pt 1/3
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5249640
* refactor: remove use of blink::MainThreadIsolate() pt 2/3
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5249640
* refactor: remove use of blink::MainThreadIsolate() pt 3/3
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5249640
* chore: update enum name to ui::AXMode::kPDFPrinting
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5270301
* chore: rebuild filenames.libcxx.gni
* chore: sync with upstream rename of PortProvider.TaskForHandle()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5259103
* chore: bump chromium in DEPS to 123.0.6286.0
* chore: bump chromium in DEPS to 123.0.6288.0
* WebPreferences: Initialize in declaration.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5277099
* chore: update webview_fullscreen.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5053508
Simple update to fix patch shear
* chore: update feat_configure_launch_options_for_service_process.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5254861
Simple update to fix patch shear
* chore: add IWC::Delegate::RecordResize() stub to fix FTBFS
https://chromium-review.googlesource.com/c/chromium/src/+/5268963
* chore: add FormControlType::kButtonPopover to the FormControlType converter
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5230929
* chore: e patches all
* chore: node script/gen-libc++-filenames.js
* chore: bump chromium in DEPS to 123.0.6290.0
* chore: bump chromium in DEPS to 123.0.6291.0
* chore: bump chromium in DEPS to 123.0.6292.0
* chore: bump chromium in DEPS to 123.0.6294.0
* chore: update fix_aspect_ratio_with_max_size.patch
Xref: fix_aspect_ratio_with_max_size.patch
note: simple absl::optional -> std::optional conversion
* chore: update feat_filter_out_non-shareable_windows_in_the_current_application_in.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5272337
* chore: update add_maximized_parameter_to_linuxui_getwindowframeprovider.patch
No manual changes; just adjusting line patch offsets
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5258688
* chore: update feat_configure_launch_options_for_service_process.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5281322
* chore: update fix_select_The_first_menu_item_when_opened_via_keyboard.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5279376
note: simple absl::optional -> std::optional conversion
* chore: update feat_allow_code_cache_in_custom_schemes.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5268792
* chore: script/export_all_patches.py
* chore: bump chromium in DEPS to 123.0.6296.0
* chore: update patches
* fixup! chore: update feat_allow_code_cache_in_custom_schemes.patch
* fix: restore MessagePort close event
* spec: fix CORB testing
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5231506
* fix: use sync layout when content view changes
* fixup! chore: update feat_configure_launch_options_for_service_process.patch
* Add remote-cocoa support for context menus.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5259806
* Rename //net/base/mac directory to //net/base/apple (1/n)
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5211389
* fixup! Add remote-cocoa support for context menus.
* [Clipboard] Don't add meta charset tag for async write() method on Mac.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5187335
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2024-02-14 12:33:32 -05:00
Shelley Vohr
5f785f213e
revert: add BrowserWindow.isOccluded()
...
This reverts commit 768ece6b54
.
2024-02-12 09:35:34 +01:00
Shelley Vohr
768ece6b54
feat: add BrowserWindow.isOccluded()
( #38982 )
...
feat: add BrowserWindow.isOccluded()
2024-02-06 11:30:35 +01:00
Shelley Vohr
5dfa9e3317
fix: original-fs
import replacement ( #41209 )
...
fix: original-fs import replacement
2024-02-05 09:51:04 +01:00
wujinli
fb888a6989
fix: crash problem with message_port close event ( #41201 )
...
When worker_thread shutdown, it will destory context and close
message_port. In this case, it should not dispatch close event.
Because it forbid script running during NotifyContextDestroyed in
ContextLifecycleNotifier.
Now chromium has implemented close_event and will not crash,
so we remove the patch with #22532 and add one test.
2024-02-05 16:38:30 +09:00
marekharanczyk
398ca2a019
fix: make sure invalid URL loads promises are fulfilled. ( #41194 )
...
* fix: make sure invalid URL loads promisses are fulfilled.
* fixup! fix: make sure invalid URL loads promisses are fulfilled.
2024-02-05 16:36:51 +09:00
electron-roller[bot]
bccb7b572a
chore: bump chromium to 123.0.6272.0 (main) ( #41130 )
...
* chore: bump chromium in DEPS to 123.0.6265.0
* chore: bump chromium in DEPS to 123.0.6266.0
* chore: update feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5232280
reverts the revert *and* undoes the rewrites 😵
* chore: update chromium/disable_hidden.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5148491
minor manual intervention
* chore: update patches
* chore: Rename mouse lock to pointer lock
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5148491
* refactor: fix use of newly-removed QuitCurrentWhenIdleClosureDeprecated()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4710351
Xref: https://github.com/electron/electron/pull/26022
This usage was added in #26022 as part of Wayland support and some
simple fiddles WfM with this patch on Wayland, but I'm unsure what
to be testing for & would like a second opinion on this commit.
* chore: bump chromium in DEPS to 123.0.6268.0
* chore: update patches
* 5235021: WebUI: Migrate accessibility and bluetooth internals to WebUIConfig
https://chromium-review.googlesource.com/c/chromium/src/+/5235021
* address review comment for 5196547
See: https://chromium-review.googlesource.com/c/chromium/src/+/5196547
Review comment: https://github.com/electron/electron/pull/41130#discussion_r1468973786
* 5075962: Introduce URLLoaderFactoryBuilder
https://chromium-review.googlesource.com/c/chromium/src/+/5075962
* chore: bump chromium in DEPS to 123.0.6270.0
* the missing semicolon strikes again
* chore: update chromium patches
* chore: update v8 patches
* 5242326: Some followup cleanup to Fuchia files in chrome | https://chromium-review.googlesource.com/c/chromium/src/+/5242326
* chore: bump chromium in DEPS to 123.0.6272.0
* chore: update patches
* chore: update patch after rebase
* 5247339: [Clipboard] Remove ClipboardContentType enum.
https://chromium-review.googlesource.com/c/chromium/src/+/5247339
* Reland: "Allow content shell to enable the built-in DNS resolver"
https://chromium-review.googlesource.com/c/chromium/src/+/5232354
* 5018206: [accessibility] Migrate to ScopedAccessibilityMode
https://chromium-review.googlesource.com/c/chromium/src/+/5018206
* 5246669: [Default Nav Transition]Add GetBackForwardTransitionAnimationManager on WebContentsView | https://chromium-review.googlesource.com/c/chromium/src/+/5246669
* fix: move nut-js to optional spec deps (#41199 )
* chore: bump chromium in DEPS to 123.0.6265.0
* chore: bump chromium in DEPS to 123.0.6266.0
* chore: update feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5232280
reverts the revert *and* undoes the rewrites 😵
* chore: update chromium/disable_hidden.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5148491
minor manual intervention
* chore: update patches
* chore: Rename mouse lock to pointer lock
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5148491
* refactor: fix use of newly-removed QuitCurrentWhenIdleClosureDeprecated()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4710351
Xref: https://github.com/electron/electron/pull/26022
This usage was added in #26022 as part of Wayland support and some
simple fiddles WfM with this patch on Wayland, but I'm unsure what
to be testing for & would like a second opinion on this commit.
* chore: bump chromium in DEPS to 123.0.6268.0
* chore: update patches
* 5235021: WebUI: Migrate accessibility and bluetooth internals to WebUIConfig
https://chromium-review.googlesource.com/c/chromium/src/+/5235021
* address review comment for 5196547
See: https://chromium-review.googlesource.com/c/chromium/src/+/5196547
Review comment: https://github.com/electron/electron/pull/41130#discussion_r1468973786
* 5075962: Introduce URLLoaderFactoryBuilder
https://chromium-review.googlesource.com/c/chromium/src/+/5075962
* chore: bump chromium in DEPS to 123.0.6270.0
* the missing semicolon strikes again
* chore: update chromium patches
* chore: update v8 patches
* 5242326: Some followup cleanup to Fuchia files in chrome | https://chromium-review.googlesource.com/c/chromium/src/+/5242326
* chore: bump chromium in DEPS to 123.0.6272.0
* chore: update patches
* chore: update patch after rebase
* 5247339: [Clipboard] Remove ClipboardContentType enum.
https://chromium-review.googlesource.com/c/chromium/src/+/5247339
* Reland: "Allow content shell to enable the built-in DNS resolver"
https://chromium-review.googlesource.com/c/chromium/src/+/5232354
* 5018206: [accessibility] Migrate to ScopedAccessibilityMode
https://chromium-review.googlesource.com/c/chromium/src/+/5018206
* 5246669: [Default Nav Transition]Add GetBackForwardTransitionAnimationManager on WebContentsView | https://chromium-review.googlesource.com/c/chromium/src/+/5246669
* fix: typescript error for optional dependency
(cherry picked from commit ea17105c8c01bd1f4c1df5e72190a687d92f93cc)
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Sam Maddock <smaddock@slack-corp.com>
2024-01-31 17:04:13 -06:00
Sam Maddock
12870cafb7
fix: move nut-js to optional spec deps ( #41199 )
2024-02-01 07:35:09 +13:00
Shelley Vohr
6df3443617
fix: validate printToPDF
margins
against pageSize
( #41157 )
...
fix: validate margins against pageSize
2024-01-31 10:48:41 +01:00
Sam Maddock
85bebfb180
test: draggable region allows moving window ( #41127 )
...
* chore: add nut.js
* test: dragging window updates position
* instantly move mouse position
* limit platforms to run drag tests on
* defer loading nut-js
2024-01-31 10:29:17 +01:00
Shelley Vohr
6786fde576
docs: document printToPDF
generateDocumentOutline
option ( #41156 )
...
* doc: document printToPDF generateDocumentOutline option
* doc: ready event to whenReady
2024-01-30 09:55:03 -06:00
Shelley Vohr
8104c7908a
fix: potential async_hooks
crash in NotifyWindowRestore
on Windows ( #40576 )
...
* fix: potential async_hooks crash in NotifyWindowRestore on Windows
* fix: don't use CallbackScope for Error objects
2024-01-26 12:53:07 -06:00
Cheng Zhao
db2bf1a0d1
fix: apply module search paths restriction on worker and child process ( #41118 )
2024-01-26 17:29:04 +09:00
electron-roller[bot]
1a0991a9b9
chore: bump chromium to 122.0.6261.6 (main) ( #40949 )
...
* chore: bump chromium in DEPS to 122.0.6239.2
* chore: update patches
* refactor: extensions replaced StringPiece with string_view
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5171926
* chore: bump chromium in DEPS to 122.0.6240.0
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6241.5
* chore: bump chromium in DEPS to 122.0.6245.0
* chore: bump chromium in DEPS to 122.0.6247.0
* chore: bump chromium in DEPS to 122.0.6249.0
* chore: bump chromium in DEPS to 122.0.6251.0
* 5192010: Rename {absl => std}::optional in //chrome/
https://chromium-review.googlesource.com/c/chromium/src/+/5192010
* 5109767: CodeHealth: Fix leaked raw_ptr in Linux ProcessSingleton
https://chromium-review.googlesource.com/c/chromium/src/+/5109767
* 5105227: [media_preview] Show requested device in permission bubble
https://chromium-review.googlesource.com/c/chromium/src/+/5105227
* chore: bump chromium in DEPS to 122.0.6253.0
* chore: update patches
* 5180720: Polish tiled browser window UI on Linux | https://chromium-review.googlesource.com/c/chromium/src/+/5180720
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6255.0
* chore: update patches
* 5186276: [autopip] Make "allow once" per navigation | https://chromium-review.googlesource.com/c/chromium/src/+/5186276
* chore: bump chromium in DEPS to 122.0.6257.0
* chore: bump chromium in DEPS to 122.0.6259.0
* chore: update patches
* 5190661: Automated T* -> raw_ptr<T> rewrite "refresh" | https://chromium-review.googlesource.com/c/chromium/src/+/5190661
* 5206106: Make sure RenderFrameHosts are active when printing | https://chromium-review.googlesource.com/c/chromium/src/+/5206106
* 5202674: Reland "Automated T* -> raw_ptr<T> rewrite 'refresh'"
https://chromium-review.googlesource.com/c/chromium/src/+/5202674
* fixup CodeHealth: Fix leaked raw_ptr in Linux ProcessSingleton
https://chromium-review.googlesource.com/c/chromium/src/+/5109767
* fixup 5206106: Make sure RenderFrameHosts are active when printing
* Make legacy ToV8() helpers private to ScriptPromiseResolver, their only user
https://chromium-review.googlesource.com/c/chromium/src/+/5207474
* fixup CodeHealth: Fix leaked raw_ptr in Linux ProcessSingleton
* fixup 5186276: [autopip] Make "allow once" per navigation
https://chromium-review.googlesource.com/c/chromium/src/+/5186276
* chore: update patches after rebase
* chore: bump chromium in DEPS to 122.0.6260.0
* 5191363: Mark LOG(FATAL) [[noreturn]]
https://chromium-review.googlesource.com/c/chromium/src/+/5191363
* fixup 5186276: [autopip] Make "allow once" per navigation
https://chromium-review.googlesource.com/c/chromium/src/+/5186276
* fixup Make legacy ToV8() helpers private to ScriptPromiseResolver
https://chromium-review.googlesource.com/c/chromium/src/+/5207474
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6261.0
* chore: update patches
* chore: restore patch that was mistakenly removed
* 5181931: Improve LoginHandler (Part 9 / N)
https://chromium-review.googlesource.com/c/chromium/src/+/5181931
* Dispatch SiteInstanceGotProcess() only when both process and site are set.
https://chromium-review.googlesource.com/c/chromium/src/+/5142354
* 5171446: [AsyncSB] Pass navigation_id into CreateURLLoaderThrottles
https://chromium-review.googlesource.com/c/chromium/src/+/5171446
* 5213708: Move DownloadTargetInfo into components/download
https://chromium-review.googlesource.com/c/chromium/src/+/5213708
* extensions: Add a loader for Controlled Frame embedder scripts
https://chromium-review.googlesource.com/c/chromium/src/+/5202765
* [CSC][Zoom] Add initial_zoom_level to DisplayMediaInformation
https://chromium-review.googlesource.com/c/chromium/src/+/5168626
* chore: bump chromium in DEPS to 123.0.6262.0
* chore: bump chromium in DEPS to 122.0.6261.6
* fix: suppress clang -Wimplicit-const-int-float-conversion
* fixup 5191363: Mark LOG(FATAL) [[noreturn]] for Windows
https://chromium-review.googlesource.com/c/chromium/src/+/5191363
* 5167921: Remove Widget::IsTranslucentWindowOpacitySupported
https://chromium-review.googlesource.com/c/chromium/src/+/5167921
Also
5148392: PinnedState: Support pinned state in PlatformWindowState | https://chromium-review.googlesource.com/c/chromium/src/+/5148392
* fixup: 5180720: Polish tiled browser window UI on Linux
https://chromium-review.googlesource.com/c/chromium/src/+/5180720
* 5170669: clipboard: Migrate DOMException constructors to RejectWith-
https://chromium-review.googlesource.com/c/chromium/src/+/5170669
* 5178824: [Fullscreen] Record UKM data
https://chromium-review.googlesource.com/c/chromium/src/+/5178824
* chore: update patches after rebase
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-01-25 12:46:30 -05:00
John Kleinschmidt
3dafb318a8
test: fixup assertNotWindows ( #41045 )
...
* chore: fixup assertNotWindows
* remove logging
2024-01-18 14:04:43 -05:00
Shelley Vohr
7e6fb97a2f
fix: crash when dialog.showMessageBoxSync
with missing buttons ( #40996 )
...
* fix: crash when dialog.showMessageBoxSync missing buttons
* chore: feedback from review
2024-01-18 13:21:15 +01:00
Shelley Vohr
6803624576
fix: check for Node.js-created module when contextIsolation
disabled ( #40993 )
2024-01-16 14:29:00 +01:00
Shelley Vohr
d5d162b622
fix: InAppPurchase pre-emptive deallocation ( #40938 )
...
* fix: InAppPurchase pre-emptive deallocation
* test: try re-enabling IAP tests
2024-01-11 13:32:29 +01:00