trop[bot]
e92eb210bb
refactor: declare gin::Wrapper subclasses as final ( #43565 )
...
As per the gin docs: "Wrappable<T> explicitly does not support further
subclassing of T. Subclasses of Wrappable<T> should be declared final."
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-04 21:26:25 -05:00
Charles Kerr
e70ce89235
chore: more iwyu ( #43063 )
...
* chore: iwyu shell/browser/electron_pdf_document_helper_client.h
* chore: iwyu shell/browser/hid/electron_hid_delegate.h
* chore: iwyu content/public/browser/web_contents.h
* chore: iwyu shell/browser/usb/electron_usb_delegate.h
* chore: iwyu shell/browser/browser_observer.h
* chore: iwyu shell/browser/bluetooth/electron_bluetooth_delegate.h
* chore: iwyu shell/browser/serial/electron_serial_delegate.h
* chore: iwyu shell/browser/api/frame_subscriber.h
* chore: iwyu mojo/public/cpp/bindings/
* chore: iwyu components/
* chore: iwyu extensions/
* chore: iwyu shell/common/gin_helper/
* chore: iwyu v8/
* chore: iwyu base/containers/linked_list.h
* chore: iwyu shell/browser/native_window.h
* chore: iwyu shell/browser/api/electron_api_base_window.h
* chore: iwyu shell/common/node_includes.h
* chore: iwyu gin/handle.h
* chore: iwyu base/functional/callback.h
* chore: iwyu ui/gfx/
* chore: iwyu content/public/browser/render_frame_host.h
* fix: mac
* fix: mac
* fix: win
* chore: iwyu base/files/file_path.h
* chore: iwyu base/unguessable_token.h
* chore: iwyu ui/display/screen.h
* chore: iwyu chrome/browser/predictors/preconnect_manager.h
* chore: iwyu base/observer_list_types.h
* chore: iwyu content/public/browser/web_contents.h
* chore: iwyu chrome/browser/devtools/devtools_eye_dropper.h
* chore: iwyu shell/browser/ui/inspectable_web_contents.h
* chore: iwyu content/public/browser/keyboard_event_processing_result.h
* chore: iwyu net/cookies/canonical_cookie.h
* chore: iwyu net/base/address_list.h
* chore: iwyu net/cert/x509_certificate.h
* chore: iwyu net/cookies/cookie_change_dispatcher.h
* chore: iwyu net/dns/public/host_resolver_results.h
* fix: mac
* Revert "chore: iwyu net/cert/x509_certificate.h"
This reverts commit 002896f71146e90f1e29e090a1d6eede48cee11e.
2024-07-29 12:42:57 -05:00
Charles Kerr
aa23198ad8
chore: remove more unused #include calls ( #43000 )
...
* chore: in shell/renderer/renderer_client_base.h, remove include media/base/key_systems_support_registration.h
last use removed in c670e38b
2024-07-25 11:25:45 +02:00
Charles Kerr
ae0c55c0b1
refactor: inherit Observer classes privately, pt. 2 ( #42237 )
...
* refactor: use private inheritance in PushNotifications
* refactor: use private inheritance in electron::api::App
* refactor: use private inheritance in electron::api::BrowserWindow
* refactor: use private inheritance in electron::api::NativeTheme
* refactor: use private inheritance in electron::api::Tray
* refactor: use private inheritance in electron::api::Session
* refactor: use private inheritance in electron::api::WebContents
* refactor: use private inheritance in electron::api::DownloadItem
* refactor: use private inheritance in electron::api::MenuBar
* refactor: use private inheritance in ClearDataOperation
* refactor: use private inheritance in electron::api::Screen
* refactor: use private inheritance in electron::ElectronDesktopWindowTreeHostLinux
* refactor: use private inheritance in SpellCheckerHolder
* refactor: use private inheritance in electron::api::PowerMonitor
* refactor: use private inheritance in electron::api::BaseWindow
* refactor: use private inheritance in electron::api::AutoUpdater
* refactor: use private inheritance in electron::api::Menu
* refactor: use private inheritance in electron::api::NativeWindowViews
* refactor: use private inheritance in electron::ElectronBrowserClient
* refactor: use private inheritance in electron::AutofillPopupView
* refactor: use private inheritance in GtkMessageBox
* refactor: use private inheritance in electron::OffScreenRenderWidgetHostView
* refactor: use private inheritance in electron::InspectableWebContents
* refactor: use private inheritance in electron::ElectronUsbDelegate
* refactor: use private inheritance in electron::LoginHandler
* refactor: use private inheritance in WebFrameRenderer
* refactor: use private inheritance in electron::ElectronSerialDelegate
* refactor: use private inheritance in electron::ClientFrameViewLinux
* refactor: use private inheritance in electron::ElectronHidDelegate
* refactor: use private inheritance in IPCRenderer
* refactor: use private inheritance in electron::WinCaptionButtonContainer
* refactor: use private inheritance in electron::ElectronApiIPCHandlerImpl
* refactor: use private inheritance in electron::api::ServiceWorkerContext
* refactor: use private inheritance in ui::FileSelectHelper
* refactor: use private inheritance in electron::api::WebContentsView
* refactor: use private inheritance in electron::api::SimpleURLLoaderWrapper
* refactor: use private inheritance in electron::api::InAppPurchase
* refactor: use private inheritance in electron::api::Debugger
* refactor: use private inheritance in electron::ElectronWebContentsUtilityHandlerImpl
* refactor: use private inheritance in electron::OffScreenWebContentsView
2024-05-29 13:07:02 -05:00
Milan Burda
892c9d78a3
chore: replace absl::optional<T> with std::optional<T> ( #40928 )
...
* chore: replace absl::optional<T> with std::optional<T>
* IWYU
2024-01-10 16:23:35 -06:00
Tomasz
689d1b76de
feat: add middle click event to tray ( #39926 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2023-09-27 14:21:15 -04:00
Shelley Vohr
c7bdd907d7
fix: set prototype names on gin::Constructible classes ( #39006 )
...
* fix: set prototype names on gin::Constructible classes
* test: add tests
2023-07-10 11:49:20 +02:00
Jeremy Rose
67dc178e70
refactor: move gin_helper::Constructible methods to prototype ( #37087 )
2023-02-06 12:59:49 -08:00
David Sanders
5d120359f6
chore: used nested namespaces ( #34737 )
2022-06-29 12:55:47 -07:00
Shelley Vohr
c5a2af7811
fix: tray garbage collection ( #33040 )
2022-02-24 20:03:59 +01:00
Milan Burda
c4ea33d1bf
chore: add ELECTRON_ prefix to C++ include guards ( #31925 )
2021-11-22 16:34:31 +09:00
Milan Burda
65a980c673
refactor: replace deprecated DISALLOW_COPY_AND_ASSIGN ( #31633 )
2021-11-03 20:41:45 +09:00
David Sanders
f6531166ae
chore: clean up forward declarations ( #29904 )
2021-07-02 09:51:37 +09:00
electron-roller[bot]
8532e1239e
chore: bump chromium to 93.0.4530.0 (master) ( #29256 )
...
* chore: bump chromium in DEPS to 92.0.4512.6
* 2887336: [CaptureHandle][#2 ] Propagate CaptureHandleConfig in browser process
https://chromium-review.googlesource.com/c/chromium/src/+/2887336
* refactor: base::Optional -> absl::optional
* chore: fixup patch indices
* chore: bump chromium in DEPS to 92.0.4514.0
* 2899417: Make build work when enable_pdf is set to false.
https://chromium-review.googlesource.com/c/chromium/src/+/2899417
* 2904731: use BrowserContext instead of Profile in PreconnectManager
https://chromium-review.googlesource.com/c/chromium/src/+/2904731
* 2295749: fix: check IsSecureEventInputEnabled in constructor before setting SetPasswordInputEnabled to true
https://chromium-review.googlesource.com/c/chromium/src/+/2295749
* 2893803: Add a GetWebView to RenderFrame.
https://chromium-review.googlesource.com/c/chromium/src/+/2893803
* 2892345: Implement WebContents::ForEachRenderFrameHost
https://chromium-review.googlesource.com/c/chromium/src/+/2892345
* chore: fixup patch indices
* 2892048: Real instance methods for BrowserContext: remaining 5 methods.
https://chromium-review.googlesource.com/c/chromium/src/+/2892048
* 2902821: [mojo] Don't require full header includes for referenced interfaces
https://chromium-review.googlesource.com/c/chromium/src/+/2902821
* 2496500: Remove last deprecated extension Event ctor.
https://chromium-review.googlesource.com/c/chromium/src/+/2496500
* chore: fixup malformed pepper support patch
* chore: bump chromium in DEPS to 92.0.4515.0
* 2908461: Add CreateEmptyPrintPagesParamsPtr() inside print_view_manager_base.cc.
https://chromium-review.googlesource.com/c/chromium/src/+/2908461
* 2880838: viz: add optional HDRMetadata to TransferableResource
https://chromium-review.googlesource.com/c/chromium/src/+/2880838
* chore: fixup patch indices
* chore: bump chromium in DEPS to 92.0.4515.5
* chore: update patches
* chore: bump chromium in DEPS to 92.0.4515.7
* chore: bump chromium in DEPS to 92.0.4515.9
* chore: bump chromium in DEPS to 93.0.4522.0
* chore: bump chromium in DEPS to 93.0.4523.0
* chore: bump chromium in DEPS to 93.0.4524.0
* chore: update patches
* chore: enable_pak_file_integrity_checks was reverted
* chore: update patches
* refactor: base/optional was replaced with absl::optional
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* refactor: replace all usages of base::nullopt with absl::nullopt
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* chore: add missing base::Contains include
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* refactor: replace all usages of base::make_optional with
absl::make_optional
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* refactor: replace WorldScriptContext() with GetScriptContextFromWorldId
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2893213
* chore: clean up left over opening namespace
Refs: 95bfe6d08fhttps://chromium-review.googlesource.com/c/chromium/src/+/2910202
* refactor: replace GetCurrentDisplayIterator with the hard checker
GetCurrentDisplay
This code looks suspicious but if the iterator was invalid before it
will also be invalid now.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2893191
* refactor: headers are now passed directly in extensions client
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2918906
* refactor: base::DictionaryValue::empty() has been removed
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2912424
* chore: add missing includes for network URLLoaderFactory
Refs: unknown, probably a side effect of header changes
* refactor: make convenience wrapper around AppendArg
There is no converter FromV8 for base::StringPiece (apparently its not
possible). So we now take in an std::string and use the construct for
StringPiece to do implicit conversion.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2905544
* chore: add patch
* chore: bump chromium in DEPS to 93.0.4525.0
* chore: update patches
* refactor: CanResize has been de-virtualized
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2485774
* chore: update resource integrity patch
* chore: add character encoding idl patch
* chore: bump chromium in DEPS to 93.0.4526.0
* chore: update patches
* chore: bump chromium in DEPS to 93.0.4527.0
* chore: bump chromium in DEPS to 93.0.4528.0
* chore: update patches
* chore: update idl encoding patch
* chore: bump chromium in DEPS to 93.0.4529.0
* chore: update patches
* chore: bump chromium in DEPS to 93.0.4530.0
* chore: update patches
* fix: only SetCanResize after the widget has been initialized
* chore: add patch for vr on windows gn gen
* spec: fix focus related tests on linux due to delay in focus swap
* chore: remove new usages of base::Optional from main
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <sattard@slack-corp.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2021-06-03 01:05:04 -07:00
Shelley Vohr
3455136e9d
refactor: remove path from nativeImage converter ( #26546 )
2021-01-04 12:58:31 -08:00
Alfred Xing
a23c66e4e1
feat: allow monospaced font styles to be specified for macOS tray titles ( #25059 )
...
* feat: add optional font type to macOS tray title
* test: add tests for tray font type
* docs: update API reference for Tray setTitle
* review: change API to use an options object
* review: fix string enum in docs
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* review: return after throwing errors
* review: don't need thrower anymore now that we have args
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2020-08-23 14:39:29 -07:00
shelley vohr
ac5c30a707
fix: missing handlescopes in event emission ( #23140 )
...
* fix: missing event emitter handlescopes
* refactor: add static getter to js env
2020-04-27 11:38:43 -07:00
Jeremy Apthorp
0a78ab4b98
refactor: ginify DownloadItem ( #22924 )
2020-04-02 17:22:46 -07:00
Jeremy Apthorp
a3e28788ce
refactor: ginify Tray ( #22822 )
...
* refactor: ginify Tray
* lint
* improve argument parsing logic
* remove redundant imports from tray.js
* new Tray produces an instanceof Tray
* make Constructible generic
* lint
* clean up on exit
2020-03-30 10:32:02 +09:00
Jeremy Apthorp
d9321f4df7
chore: rename atom -> electron ( #21986 )
2020-02-04 12:19:40 -08:00
