trop[bot]
e92eb210bb
refactor: declare gin::Wrapper subclasses as final ( #43565 )
...
As per the gin docs: "Wrappable<T> explicitly does not support further
subclassing of T. Subclasses of Wrappable<T> should be declared final."
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-04 21:26:25 -05:00
Charles Kerr
bff298987f
chore: remove unused Notification fields icon_path_, has_icon_ ( #43286 )
...
Last use of `icon_path_` was removed on May 29, 2017 (c741b5845048425e
2024-08-12 09:55:54 +02:00
Charles Kerr
e70ce89235
chore: more iwyu ( #43063 )
...
* chore: iwyu shell/browser/electron_pdf_document_helper_client.h
* chore: iwyu shell/browser/hid/electron_hid_delegate.h
* chore: iwyu content/public/browser/web_contents.h
* chore: iwyu shell/browser/usb/electron_usb_delegate.h
* chore: iwyu shell/browser/browser_observer.h
* chore: iwyu shell/browser/bluetooth/electron_bluetooth_delegate.h
* chore: iwyu shell/browser/serial/electron_serial_delegate.h
* chore: iwyu shell/browser/api/frame_subscriber.h
* chore: iwyu mojo/public/cpp/bindings/
* chore: iwyu components/
* chore: iwyu extensions/
* chore: iwyu shell/common/gin_helper/
* chore: iwyu v8/
* chore: iwyu base/containers/linked_list.h
* chore: iwyu shell/browser/native_window.h
* chore: iwyu shell/browser/api/electron_api_base_window.h
* chore: iwyu shell/common/node_includes.h
* chore: iwyu gin/handle.h
* chore: iwyu base/functional/callback.h
* chore: iwyu ui/gfx/
* chore: iwyu content/public/browser/render_frame_host.h
* fix: mac
* fix: mac
* fix: win
* chore: iwyu base/files/file_path.h
* chore: iwyu base/unguessable_token.h
* chore: iwyu ui/display/screen.h
* chore: iwyu chrome/browser/predictors/preconnect_manager.h
* chore: iwyu base/observer_list_types.h
* chore: iwyu content/public/browser/web_contents.h
* chore: iwyu chrome/browser/devtools/devtools_eye_dropper.h
* chore: iwyu shell/browser/ui/inspectable_web_contents.h
* chore: iwyu content/public/browser/keyboard_event_processing_result.h
* chore: iwyu net/cookies/canonical_cookie.h
* chore: iwyu net/base/address_list.h
* chore: iwyu net/cert/x509_certificate.h
* chore: iwyu net/cookies/cookie_change_dispatcher.h
* chore: iwyu net/dns/public/host_resolver_results.h
* fix: mac
* Revert "chore: iwyu net/cert/x509_certificate.h"
This reverts commit 002896f71146e90f1e29e090a1d6eede48cee11e.
2024-07-29 12:42:57 -05:00
Charles Kerr
60c4c9fec6
chore: remove unused #includes ( #42971 )
...
* chore: iwyu buildflags.h
* chore: iwyu dictionary.h
* chore: iwyu arguments.h
* chore: iwyu values.h
* chore: iwyu compiler_specific.h
* chore: iwyu binder_map.h
* chore: iwyu <vector>
* chore: iwyu <set>
* chore: iwyu raw_ptr
* chore: iwyu gfx/canvas.h
* chore: iwyu gfx/color_utils.h
* chore: iwyu base/strings/stringprintf.h
* chore: iwyu base/task/thread_pool.h
* chore: iwyu base/no_destructor.h
* chore: iwyu base/path_service.h
* chore: iwyu base/files/file_pathh
* chore: iwyu base/strings/sys_string_conversions.h
* chore: iwyu base/logging.h
* chore: iwyu base/command_line.h
* chore: iwyu base/files/file_util.h
* chore: iwyu base/files/scoped_file.h
* chore: iwyu base/strings/utf_string_conversions.h
* chore: iwyu base/environment.h
* chore: iwyu base/scoped_observation.h
* chore: iwyu base/strings/string_split.h
* chore: iwyu base/strings/pattern.h
* chore: iwyu base/json/string_escape.h
* chore: iwyu base/json/json_reader.h
* chore: iwyu base/memory/singleton.h
* chore: iwyu base/observer_list.h
* chore: iwyu base/timer/timer.h
* fixup! chore: iwyu values.h
* chore: iwyu shell/browser/browser.h
* chore: iwyu base/stl_util.h
* chore: iwyu base/strings/string_util.h
* chore: iwyu shell/browser/javascript_environment.h
* chore: iwyu base/memory/ref_counted.h
* chore: iwyu base/environment.h
* chore: iwyu content/public/browser/browser_thread.h
* chore: remove unused typedef gin_helper::EventEmitter::ValueArray
* chore: iwyu gin/wrappable.h
* chore: iwyu shell/common/gin_helper/function_template_extensions.h
* chore: iwyu shell/common/gin_converters/login_item_settings_converter.h
* chore: iwyu shell/common/gin_helper/arguments.h
* chore: iwyu ui/gfx/skia_util.h
* chore: iwyu ui/gfx/geometry/rect.h
* chore: iwyu ui/gfx/image/image.h
* chore: iwyu base/strings/strcat.h
* chore: iwyu ui/native_theme/native_theme.h
* fixup! chore: iwyu shell/browser/javascript_environment.h
* fixup! chore: iwyu gfx/canvas.h
* fixup! chore: iwyu content/public/browser/browser_thread.h
* fixup! chore: iwyu ui/native_theme/native_theme.h
* fixup! chore: iwyu ui/native_theme/native_theme.h
2024-07-22 11:31:32 +02:00
Charles Kerr
ffec3127d5
refactor: inline simple getters ( #41125 )
2024-01-29 20:43:28 -06:00
Shelley Vohr
c7bdd907d7
fix: set prototype names on gin::Constructible classes ( #39006 )
...
* fix: set prototype names on gin::Constructible classes
* test: add tests
2023-07-10 11:49:20 +02:00
John Kleinschmidt
3dbc0a365f
chore: enable check raw ptr fields ( #38167 )
2023-05-11 16:07:39 -04:00
Jeremy Rose
67dc178e70
refactor: move gin_helper::Constructible methods to prototype ( #37087 )
2023-02-06 12:59:49 -08:00
David Sanders
5d120359f6
chore: used nested namespaces ( #34737 )
2022-06-29 12:55:47 -07:00
Milan Burda
c4ea33d1bf
chore: add ELECTRON_ prefix to C++ include guards ( #31925 )
2021-11-22 16:34:31 +09:00
Milan Burda
65a980c673
refactor: replace deprecated DISALLOW_COPY_AND_ASSIGN ( #31633 )
2021-11-03 20:41:45 +09:00
David Sanders
ba26580f23
chore: use consistent parameter names ( #29361 )
2021-06-01 10:46:25 +09:00
David Sanders
93c9374e95
chore: trim unused STL includes ( #29414 )
2021-06-01 10:34:44 +09:00
John Kleinschmidt
22d8f22cfb
2757472: Reland "Reland "[LSC] Remove base::string16 alias""
...
https://chromium-review.googlesource.com/c/chromium/src/+/2757472
2021-03-16 12:18:45 -04:00
David Sanders
d8167ce138
chore: use consistent parameter names ( #26162 )
2020-10-27 10:18:36 -05:00
bitdisaster
b43859f098
feat: custom toast xml and failure reporting for notifications ( #25401 )
...
* allow custom toast xml and report failures
* docs
* tests
* don't use namespaces
* lint doesn't like trailing commas
* addressing feedback
2020-09-29 12:20:10 -07:00
Jeremy Apthorp
765c08c600
refactor: ginify Notification ( #22821 )
2020-03-31 11:42:32 -07:00
Jeremy Apthorp
d9321f4df7
chore: rename atom -> electron ( #21986 )
2020-02-04 12:19:40 -08:00
