Commit graph

12 commits

Author SHA1 Message Date
Haojian Wu
e80a9bbb93 Move title_ to InspectableWebContentsViewVies to get rid of cast. 2017-04-01 15:10:52 +02:00
Haojian Wu
ee1f3acf7b Don't use anonymous namespace in header file.
Anonymous namespace should be forbidden in header files even for the
forward declarations:

* As declarations defined in anonymous namespace are internal linkage, each
translation unit which includes this header will get unique copy, which
wastes space.
* It is easy to violate C++ ODR rule.

Consider the following "foo.h":

```cpp
namespace { class Foo; }
class Bar {
  public:
    Foo* getFoo();
    Foo* foo;
}
```

If the 'foo.h' is included in multiple `.cc` files, the compiler will
put `Foo` into a different anonymous namespace in each `.cc`, which
means there are different definitions of `Foo` in the program (a
violation of the ODR).
2017-04-01 08:57:34 +02:00
Kevin Sawicki
be0c0e278a Remove cpplint errors 2017-03-23 12:48:27 -07:00
Cheng Zhao
1a80cb22b7 Show label for offscreen webview 2016-08-04 16:35:09 +09:00
Cheng Zhao
851ef398fb Adapt to changes of Chrome 51 API changes 2016-05-23 10:59:07 +09:00
Cheng Zhao
c30f458d4f Add IsDevToolsViewFocused method 2015-09-15 11:04:46 +08:00
Robo
1f65b47e8e allow updating devtools title in undocked mode 2015-08-07 14:30:49 +05:30
Cheng Zhao
95d28c398e Update cpplint 2015-06-05 12:07:27 +08:00
Cheng Zhao
f809fef22d OVERRIDE => override 2014-10-23 11:10:39 +08:00
Cheng Zhao
a080d2c5bb Remove GetNativeView() when compiled with views toolkit. 2014-07-11 23:32:00 +08:00
Cheng Zhao
4fb4b2d7ba views: Implement undocked devtools. 2014-07-09 10:26:01 +08:00
Cheng Zhao
e574bf6d0f views: Initial docked devtools implementation. 2014-07-09 10:26:01 +08:00
Renamed from brightray/browser/linux/inspectable_web_contents_view_linux.h (Browse further)