Milan Burda
b5bfd9867b
Don't pass preloadPath via ELECTRON_BROWSER_SANDBOX_LOAD for security reasons ( #13031 ) ( #14026 )
2018-08-11 12:53:33 -05:00
Cheng Zhao
0abbedcdae
Fix error caused by refactor
2018-03-22 15:21:56 +09:00
Cheng Zhao
6df2326a30
Cleanup the static methods of WebContentsPreferences
...
The static methods are totally unnecessary, and it makes code harder to
understand since we are using different ways to do the same things.
2018-03-22 15:21:56 +09:00
Cheng Zhao
001275339b
Hide WebContentPreferences::GetWebContentsFromProcessID from public
2018-03-22 15:20:03 +09:00
Cheng Zhao
3d47a8a2fd
Remove the static getter methods from WebContentsPreferences
2018-03-22 15:20:03 +09:00
Cheng Zhao
887bc12350
Add WebContentsPreferences::From that checks parameter
2018-03-22 15:16:26 +09:00
Cheng Zhao
9772777919
web_prefrences() => dict()
...
Having property name being the same with class name is making code
harder to understand, and dict is much shorter.
2018-03-22 15:15:30 +09:00
Charles Kerr
c2673aa970
Set appropriate defaults for webview options ( #12271 )
...
* Persist defaults to webPreferences object to JS land can read the inferred values instead of just user defined values
* Test inherited default propogation
* Refactor to remove coupling from fetching values and defaults
* Test description type
* Fix up tests
2018-03-15 13:56:46 +09:00
Cheng Zhao
7516b059fe
Code style fixes
2018-03-06 11:31:56 +09:00
Samuel Attard
795447f61a
Implement dialog (alert/confirm) blocking as a user switch after the first dialog
...
* This is to enable more browser-like behavior so that users who run third-party code
will not be DOS'ed with alerts and confirms. This is already handled like this
in most major browsers so this will greatly help these developers
2018-03-06 11:19:15 +09:00
Cheng Zhao
affa21600c
Remove unnecessary methods on WebContentsPreferences
2018-02-13 15:57:54 +09:00
Emmanuel Kimmerlin
9c1b47361f
Add an "affinity" option to webPreferences
2018-02-13 15:18:55 +09:00
Cheng Zhao
cb3a9c69ab
Add a SessionPreferences to manage session related data
...
By design the BrowserClient should not be aware of the api:: classes.
2017-12-05 15:59:15 +09:00
Kevin Sawicki
dbd240a7cb
Return null from native window.open when allowpopups is unset
2017-05-26 10:10:36 -07:00
rreimann
25015c4c63
Fix naming and formatting
2017-05-22 14:14:59 -07:00
rreimann
791486433d
Extract common code into IsPreferenceEnabled method
2017-05-22 14:14:59 -07:00
rreimann
1b75e45a62
Suppress pdf plugin dispatch if plugins are disabled
2017-05-22 14:14:59 -07:00
Ryohei Ikegami
a1f9a45276
Use native window.open implementation
2017-03-19 17:41:20 +09:00
Ryohei Ikegami
f7935b429a
Add WebContentsPreferences::IsNativeWindowOpenEnabled
2017-03-19 17:12:25 +09:00
Kevin Sawicki
4de637779b
Make int converter helper an instance method
2017-02-07 09:13:42 -08:00
Tan Wang Leng
42f65c52fb
🐛 Fix webpreferences not accepting numeric options
...
The webpreferences attribute values are parsed as strings instead
of numbers. Therefore, a conversion is required.
2017-02-07 09:05:55 -08:00
Thiago de Arruda
c783ec72bc
Add "sandboxed" option to "webPreferences".
...
When "sandboxed" is passed as a web preference for `BrowserWindow`, the newly
created renderer won't run any node.js code/integration, only communicating with
the system via the IPC API of the content module. This is a requirement for
running the renderer under chrome OS-level sandbox.
Beyond that, certain behaviors of AtomBrowserClient are modified when dealing
with sandboxed renderers:
- `OverrideSiteInstanceNavigation` no longer create a new `SiteInstance` for
every navigation. Instead, it reuses the source `SiteInstance` when not
navigating to a different site.
- `CanCreateWindow` will return true and allow javascript access.
2016-09-27 06:01:46 -03:00
Cheng Zhao
7eab259d92
Make it possible to only set preferences for BrowserWindow
2016-05-27 09:20:46 +09:00
Cheng Zhao
bfc6d77bb3
Pending renderer process no longer has render view attached
2016-03-10 17:06:22 +09:00
Cheng Zhao
ba457681b2
Avoid storing unrelated things in WebContentsPreferences
2015-11-11 10:37:34 +08:00
Cheng Zhao
de41890196
Inherit parent window's options in window.open
2015-09-22 22:32:10 +08:00
Cheng Zhao
24bbe5dabf
No need to define WebContentsPreferences::From
2015-09-07 16:16:34 +08:00
Cheng Zhao
3773f81fd5
Pass partition name instead of path to BrowserContext
2015-09-06 10:53:39 +08:00
Cheng Zhao
9c235509a6
Read guest view's info from WebContentsPreferences
2015-09-06 10:53:03 +08:00
Cheng Zhao
880dce950d
Move OverrideWebkitPrefs to WebContentsPreferences
2015-09-06 10:53:03 +08:00
Cheng Zhao
39975378bb
Move AppendExtraCommandLineSwitches to WebContentsPreferences
2015-09-06 10:53:03 +08:00
Cheng Zhao
96771c7098
NPAPI has been removed, remove related option
2015-09-06 10:53:03 +08:00
Cheng Zhao
dd871812b7
Add WebContentsPrefrences class
2015-09-06 10:53:03 +08:00