Samuel Attard
ed1f8d3646
Add missing network:: for net log switches
2018-06-19 11:52:17 +10:00
Aleksei Kuzmin
f4a9575193
Drop support of Mac OS 10.9
...
- set minimum deployment target to 10.10
- set minimum system version to 10.10
2018-06-19 11:49:45 +10:00
Aleksei Kuzmin
622544a902
Check embedder_message_dispatcher_ before sending a message
...
HandleMessageFromDevToolsFrontend() might be called
after the WebContentsDestroyed() is.
2018-06-19 11:49:45 +10:00
Tomas Rycl
40bf582c81
Use /guard:cf during both compile and link parts of the build on Windows
...
Thanks jack-teng1 for info.
2018-06-19 11:49:44 +10:00
Heilig Benedek
65b8dd48d8
Update OSR code
2018-06-19 11:49:44 +10:00
Nitish Sakhawalkar
ca8843102a
Fix duplicate RTCDispatcher console error for debug build.
...
The solution was to call CreateScreenCapturer from content, and not link the static library in.
2018-06-19 11:49:44 +10:00
Nitish Sakhawalkar
58b9203b9b
Update link lib in brightray
2018-06-19 11:49:44 +10:00
Aleksei Kuzmin
5656cb34b8
Use libpdfium_skia_shared.a
2018-06-19 11:49:44 +10:00
deepak1556
8f00240c73
chrome style plugin: remove check-auto-raw-pointer option
...
This is always enabled now, so the corresponding flag can be removed.
https://chromium-review.googlesource.com/734132
2018-06-19 11:49:43 +10:00
Aleksei Kuzmin
a45862c93f
Link against device_service and viz_service libs
2018-06-19 11:49:43 +10:00
Aleksei Kuzmin
000bbd45b8
Add ForceFeedback to the frameworks list on Mac
2018-06-19 11:49:43 +10:00
Aleksei Kuzmin
28f6e10e5a
Add "-fno-exceptions" to "cflags_cc" on linux
2018-06-19 11:49:43 +10:00
deepak1556
c97706de50
Remove deps on libcommon.a and libjavascript.a
2018-06-19 11:49:43 +10:00
deepak1556
2047929cb5
Convert ax_enums.idl to mojom.
...
https://chromium-review.googlesource.com/c/chromium/src/+/877417
2018-06-19 11:49:41 +10:00
deepak1556
6d241e972b
Clean up net::HttpAuthPreferences.
...
https://chromium-review.googlesource.com/c/chromium/src/+/727399
2018-06-19 11:49:40 +10:00
deepak1556
83632f15a9
Fix session restore with network service.
...
https://chromium-review.googlesource.com/c/chromium/src/+/818486
2018-06-19 11:49:40 +10:00
deepak1556
bbb2393031
Remove base::SizeTToString
...
https://chromium-review.googlesource.com/c/chromium/src/+/799550
2018-06-19 11:49:40 +10:00
deepak1556
c31d7ef70a
Implement SpecialStoragePolicy::ShouldDeleteCookieOnExit
...
https://chromium-review.googlesource.com/c/chromium/src/+/926369
2018-06-19 11:49:40 +10:00
deepak1556
3666935c06
[DevTools] Make Inspect Element work for OOPIF
...
https://chromium-review.googlesource.com/c/chromium/src/+/881522
2018-06-19 11:49:40 +10:00
deepak1556
8e125b2953
REVIEW: Remove the notification close-closure in favour of an explicit method
...
https://chromium-review.googlesource.com/c/chromium/src/+/744205
2018-06-19 11:49:40 +10:00
deepak1556
026e7bff40
Update NetworkDelegate
...
* Remove Deprecated OnResponseStarted.
https://chromium-review.googlesource.com/c/chromium/src/+/763193
* Replace cookie lines with CanonicalCookie in CanSetCookie delegates.
https://chromium-review.googlesource.com/c/chromium/src/+/775606
* Reporting: Check upload permissions asynchronously
https://chromium-review.googlesource.com/c/chromium/src/+/937566
2018-06-19 11:49:40 +10:00
deepak1556
bf55d856d2
Cookie Store: Extract change notifications to separate classes.
...
https://chromium-review.googlesource.com/c/chromium/src/+/919159
2018-06-19 11:49:40 +10:00
deepak1556
806acbdf12
Move content/network to services/network.
...
https://chromium-review.googlesource.com/891646
2018-06-19 11:49:40 +10:00
deepak1556
01fdfc4574
Remove Permission manager from brightray
...
Electron manages its own implementation, this was
missed out when merging the brightray/ component.
2018-06-19 11:46:59 +10:00
deepak1556
f6665edc73
Convert ColorChooser from ipc to mojo.
...
https://chromium-review.googlesource.com/c/chromium/src/+/800350
https://chromium-review.googlesource.com/c/chromium/src/+/821954
2018-06-19 11:46:59 +10:00
deepak1556
c29f08c53e
DevTools: remove the 'forced' attribute from the AgentHostClosed in DevToolsAgentHost.
...
https://chromium-review.googlesource.com/c/chromium/src/+/745301
2018-06-19 11:46:59 +10:00
deepak1556
bf620363b9
Devtools: Remove session_id in browser
...
https://chromium-review.googlesource.com/c/chromium/src/+/866213
2018-06-19 11:46:59 +10:00
deepak1556
f32e59d4b2
Update devtools_file_system_indexer
...
* Switch DevToolsFileSystemIndexer to use SequencedTaskRunner
https://chromium-review.googlesource.com/c/chromium/src/+/545200
* Remove dead code from devtools_file_system_indexer.cc
https://codereview.chromium.org/2508443002
* Fix DCHECKs and a crash in DevToolsFileSystemIndexer
https://chromium-review.googlesource.com/c/chromium/src/+/553958
* reset trigram cache when devtools window closes
https://chromium-review.googlesource.com/c/chromium/src/+/969969
* Directly use base::File instead of FileProxy in DevToolsFileSystemIndexer
https://chromium-review.googlesource.com/c/chromium/src/+/544793
2018-06-19 11:46:59 +10:00
Aleksei Kuzmin
7c95100180
Rename ProxyService class to ProxyResolutionService
...
https://chromium-review.googlesource.com/857421
2018-06-19 11:46:59 +10:00
Aleksei Kuzmin
079e5df740
Adds ability for BrowserMainParts::PreEarlyInitialization() to fail
...
https://chromium-review.googlesource.com/862964
2018-06-19 11:46:59 +10:00
Aleksei Kuzmin
cb604026d6
DevTools: move remote debugging hosted URL to single location.
...
https://chromium-review.googlesource.com/905983
2018-06-19 11:46:59 +10:00
Aleksei Kuzmin
8020cd9994
Use the same GOOGLE_PROTOBUF_* defines for "brightray" as for Electron
2018-06-19 11:46:59 +10:00
Aleksei Kuzmin
70cc5d87af
ResourceBundle → ui::ResourceBundle
...
Fixes "error: use of undeclared identifier 'ResourceBundle';
did you mean 'ui::ResourceBundle'?".
2018-06-19 11:46:59 +10:00
Aleksei Kuzmin
408b62bcc2
Move net/proxy to net/proxy_resolution
...
https://chromium-review.googlesource.com/868176
Also includes changes from:
Rename files relating to PAC (proxy auto config).
https://chromium-review.googlesource.com/836927
2018-06-19 11:46:58 +10:00
Aleksei Kuzmin
5a2de2108e
Add ".../third_party/protobuf/src" to the include_dirs list
...
Fixes "fatal error: 'google/protobuf/stubs/common.h' file not found".
2018-06-19 11:46:58 +10:00
Zhuo Lu
ab24a1e36d
feat: netLog API for dynamic logging control ( #13068 )
...
* Introduce `net.{start|stop}Logging()`
- Slight regression right now as Electron won't automatically start logging net-logs at launch, will soon be fixed
- To implement callback for async controls
* Add `net.isLogging` & optional callback param for `net.stopLogging()`
* Fix small regression on --log-net-log
--log-net-log should work again
* Error on empty file path
* Only start with valid file path
* Remove unused var
* Allow setting log file path before URLRequestContextGetter starts logging
* Add net log tests
* Remove redundant checks
* Use brightray::NetLog
* Clean up code
* Should automatically stop listening
* 🎨 Attempt to fix styles
* Only run non-null callback
* Dump file to tmpdir
* Simplify net log spec
Spawned Electron process on Linux CI can fail to launch
* Separate netLog module
* Remove net logging test from net spec
* Add tests for netLog
* Fix header guard
* Clean up code
* Add netLog.currentlyLoggingPath
* Callback with filepath
* Add test for case when only .stopLogging() is called
* Add docs
* Reintroduce error on invalid arg
* Update copyright
* Update error message
* Juggle file path string types
2018-06-19 11:45:58 +10:00
Cheng Zhao
18dde0a0bd
load all pak files on macOS
2018-06-18 16:51:36 +09:00
Zhuo Lu
fd25f594cd
Do not capture cookies and credentials ( #13065 )
2018-05-24 14:46:54 -07:00
Cheng Zhao
5f461cd5cd
fix release build on arm
2018-05-18 10:50:31 +09:00
Jeremy Apthorp
b160093b91
refactor: GN builds on linux ( #12957 )
2018-05-16 12:51:11 -07:00
Cheng Zhao
874af5c982
Merge pull request #12837 from nornagon/build-gn
...
GN build
2018-05-15 14:02:51 +09:00
Jeremy Apthorp
9aa18d29a5
Merge pull request #12885 from nornagon/is-desktop-unity
...
Don't declare IsDesktopEnvironmentUnity on non-Linux
2018-05-10 14:41:29 -07:00
Jeremy Apthorp
87d0175c76
Require !OS_MACOSX as well as TOOLKIT_VIEWS for views code
2018-05-10 14:11:19 -07:00
Jeremy Apthorp
f2b1b3f6b8
Add GN build
2018-05-10 14:03:02 -07:00
Jeremy Apthorp
26f5390ac0
Don't declare IsDesktopEnvironmentUnity on non-Linux
2018-05-10 13:59:48 -07:00
Shelley Vohr
21e5a2e071
Add clang-format script and precommit hook ( #12651 )
...
* add second arg to hook
* fix clang-format script
* remove format script
* help
* first pass at only checking formatting for changed files
* ensure clang-format only runs against changes
* add quiet option for print output
* fix script outputs for clang-format
* wrap conditional for exit error
* remove cpplint include ordering from brightray
* fix python style errors
* add clang-format to linting
* fix var error and add mm extension
* fix diff checking for commit hook
* show incorrectly formatted lines when linting fails
* don't try to check formatting for deleted files
2018-04-27 13:01:12 -04:00
Shelley Vohr
12a57ff1c2
clang-format objc files ( #12673 )
2018-04-20 11:47:04 -07:00
Cheng Zhao
28b85762fd
Merge pull request #12660 from electron/mac-views
...
Refactor NativeWindow (Part 8): Prepare work for using views::Widget on macOS
2018-04-20 21:31:28 +09:00
Robo
ff571f3b5d
Part I: Move from base::Bind to base::BindOnce and remove unneeded base::Passed ( #12661 )
2018-04-20 19:55:05 +09:00
Cheng Zhao
1c6c75da4f
Merge the logic of managing ViewsDelegate
2018-04-20 19:10:37 +09:00
deepak1556
6d0ac6593c
[chromium-style] Complex class/struct needs an explicit out-of-line copy constructor.
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
f3c00e96aa
Bring mac code into conformance with -Wunguarded-availability
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
27cee90e5e
[chromium-style] move methods out of headers
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
f1587da480
[chromium-style] out-of-line default constructors and destructors
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
6c26bb1cf8
[chromium-style] destructors of ref-counted objects should be private
2018-04-19 11:12:10 -07:00
Jeremy Apthorp
e6695cf2ec
[chromium-style] override / virtual warnings
2018-04-19 11:12:10 -07:00
Jeremy Apthorp
a635f078c6
[chromium-style] auto variable type must not deduce to a raw pointer type
2018-04-19 11:10:52 -07:00
Shelley Vohr
49c8c31220
format previously misses .cc files
2018-04-17 21:56:12 -04:00
Shelley Vohr
284aca68c0
clang-format brightray
2018-04-17 21:46:27 -04:00
Shelley Vohr
d722008367
remove unnecessary ptr_util.h include
2018-04-12 22:34:26 -04:00
Shelley Vohr
b05932310b
replace base::MakeUnique with std::make_unique
2018-04-12 08:48:32 -04:00
Robo
171230e45d
Cleanup destruction of URLRequestContextGetter ( #12305 )
...
- Add Leak detector
- Indicate shutdown of request context from Browser Context
- Change stored references to URLRequestContextGetter to use BrowserContext
- Destroy session properties explicitly
2018-03-30 08:24:55 -05:00
Cheng Zhao
c70150847d
Ignore warning LNK4199
...
We are now sharing the /DELAYLOAD settings between configurations.
2018-03-20 10:13:17 +03:00
deepak1556
f5e1ee010b
FIXME: disable pdf viewer feature
2018-03-20 10:13:17 +03:00
deepak1556
c3f8f6bc42
re-use request context from IOThread
2018-03-20 10:13:17 +03:00
Cheng Zhao
246f6318e4
Fix release build on Windows
2018-03-20 10:13:16 +03:00
Cheng Zhao
ecefe41728
Linker behaves differently on arm
2018-03-20 10:13:16 +03:00
Cheng Zhao
34cb9cf1fe
Use lld for linking on both Debug/Release builds
...
This follows Chromium's config, otherwise we get linking error:
/usr/bin/ld: shared_library/libmirclient.so.9: __cxa_finalize: invalid needed version 2
shared_library/libmirclient.so.9: error adding symbols: Bad value
2018-03-20 10:13:16 +03:00
Tomas Rycl
f2116c50c0
Unity detection now works in all OSes - returns false.
2018-03-20 10:13:15 +03:00
Tomas Rycl
c15e09b71e
rtc_base_approved renamed to generic
2018-03-20 10:13:15 +03:00
deepak1556
b9bb4dfc06
FIXME: re-enable guest webcontents based on OOPIF feature
2018-03-20 10:13:15 +03:00
deepak1556
b552ad7065
add taskpriority when creating sequences task runners
2018-03-20 10:13:15 +03:00
Aleksei Kuzmin
fa3d9d32ae
Use XDG_CURRENT_DESKTOP to determine if the desktop environment is Unity
...
https://chromium-review.googlesource.com/682615
2018-03-20 10:13:15 +03:00
deepak1556
007ea500d0
REVIEW: Re-use devtools network throttling from content layer
...
https://chromium-review.googlesource.com/c/chromium/src/+/664356
2018-03-20 10:13:15 +03:00
Samuel Attard
78266db427
Fix webrtc linking issues
2018-03-20 10:13:15 +03:00
Samuel Attard
9181db1304
Disable tautological check for chromium code
2018-03-20 10:13:15 +03:00
Samuel Attard
e65815e34c
Implement GetBackgroundFetchDelegate in brightray::BrowserContext
2018-03-20 10:08:58 +03:00
Samuel Attard
de2981a767
Move proxy constructor to ProxyService namespace
2018-03-20 10:08:58 +03:00
Samuel Attard
6f695b93d5
Fix system proxy config resolver constructor
2018-03-20 10:08:58 +03:00
Samuel Attard
f2edd5d068
v8 proxy service has been removed
2018-03-20 10:08:58 +03:00
Samuel Attard
f0ef11b856
BlockingPool has been removed
2018-03-20 10:08:58 +03:00
Samuel Attard
12066a60f3
make_scoped_refptr --> WrapRefCounted
2018-03-20 10:08:58 +03:00
Samuel Attard
461e33104e
HandleCommand now takes session_id and returns success boolean. It is assumed a nullptr from the handler means failure
2018-03-20 10:08:57 +03:00
Ales Pergl
84ce3a9ea1
Use same delay-load settings in both debug and release
2018-03-16 17:10:38 +01:00
Charles Kerr
dd2c2660b9
Fix desktop-id notification edge case ( #12216 )
...
* Fix desktop-id notification edge case
* Extract-method platform_util::GetDesktopName()
This removes duplicated code from libnotify_notifications.cc
and atom/common/linux/application_info.cc.
* Check for empty case in GetDesktopName().
* Move GetDesktopName() to brightray::util
* Remove unnecessary changes in platform_util
* Add a brightray::platform_util namespace
2018-03-12 16:02:47 +09:00
Charles Kerr
86af20ded0
Linux named notifications ( #12192 )
...
* Set name & desktop-entry on Linux notifications
* DBusMock now honors verbose mode flag
* Disable DBus Notification tests on ia32
2018-03-12 09:33:06 +09:00
Cheng Zhao
51f89048d6
Use bundled freetype from Chromium
2018-03-08 10:47:19 -05:00
Cheng Zhao
cc6bcb6c81
Fix some flaky tests in CI ( #12153 )
...
* Guard whole InitPrefs with ScopedAllowIO
Saw a crash:
0 0x7f8d2f7d918d base::debug::StackTrace::StackTrace()
1 0x7f8d2f7d755c base::debug::StackTrace::StackTrace()
2 0x7f8d2f867caa logging::LogMessage::~LogMessage()
3 0x7f8d2fa157c7 base::ThreadRestrictions::AssertIOAllowed()
4 0x7f8d2f83453a base::OpenFile()
5 0x7f8d2f82a967 base::ReadFileToStringWithMaxSize()
6 0x7f8d2f82ad44 base::ReadFileToString()
7 0x7f8d2f846f73 JSONFileValueDeserializer::ReadFileToString()
8 0x7f8d2f84738c JSONFileValueDeserializer::Deserialize()
9 0x7f8d35a5d1f6 <unknown>
10 0x7f8d35a5c217 JsonPrefStore::ReadPrefs()
11 0x7f8d35a87d3e PrefService::InitFromStorage()
12 0x7f8d35a87c60 PrefService::PrefService()
13 0x7f8d35a91a10 PrefServiceFactory::Create()
14 0x000000e86e1b brightray::BrowserContext::InitPrefs()
15 0x000000c2bd64 atom::AtomBrowserContext::AtomBrowserContext()
16 0x000000c320db atom::AtomBrowserContext::From()
17 0x000000b4b8b5 atom::api::Session::FromPartition()
* Fix done being called twice in setInterval test
The callback passed to browser process is called asyncly, so it is
possible that multiple callbacks has already been scheduled before we
can clearInternval.
* Fix failing test when dir name has special chars
The pdfSource is not escaped while parsedURL.search is.
* Call done with Error instead of string
* Fix crash caused by not removing input observer
Solve crash:
0 libcontent.dylib content::RenderWidgetHostImpl::DispatchInputEventWithLatencyInfo(blink::WebInputEvent const&, ui::LatencyInfo*) + 214
1 libcontent.dylib content::RenderWidgetHostImpl::ForwardMouseEventWithLatencyInfo(blink::WebMouseEvent const&, ui::LatencyInfo const&) + 1350
2 libcontent.dylib content::RenderWidgetHostViewMac::ProcessMouseEvent(blink::WebMouseEvent const&, ui::LatencyInfo const&) + 44
3 libcontent.dylib content::RenderWidgetHostInputEventRouter::RouteMouseEvent(content::RenderWidgetHostViewBase*, blink::WebMouseEvent*, ui::LatencyInfo const&) + 1817
* Print detailed error
* Run tests after server is ready
2018-03-07 14:40:27 +09:00
Cheng Zhao
53229e3d6c
Fix network delegate race condition ( #12044 )
...
* Fix race condition when getting network delegate
* Remove the evil URLRequestContextGetter::network_delegate
* Move the arguments instead of const referrencing
Safer and more efficient.
2018-02-26 06:23:59 -08:00
Cheng Zhao
b25175a19a
Fix assertion when get X11 error in new thread
2018-02-23 10:22:00 +09:00
Cheng Zhao
b7b40d9c3a
Fix linking error with atomic
2018-02-23 10:22:00 +09:00
Aleksei Kuzmin
0ec2eba2a3
Add init_webrtc lib to the list of static libraries
2018-02-23 10:21:24 +09:00
deepak1556
041b32b01f
remove invalid cookie_details.h filename from brightray
2018-02-23 10:21:24 +09:00
deepak1556
cdab073614
FIX: add chrome-devtools:// to list of WebUI schemes
...
https://chromium-review.googlesource.com/c/chromium/src/+/617598
2018-02-23 10:21:24 +09:00
deepak1556
5eb0a89579
REVIEW: let browser context manage cookie change sub list
2018-02-23 10:21:24 +09:00
deepak1556
f52f752acd
fxedit is removed and pdfwindow renamed to pwl
...
https://pdfium-review.googlesource.com/c/pdfium/+/8552
https://pdfium-review.googlesource.com/c/pdfium/+/8791
2018-02-23 10:21:24 +09:00
deepak1556
248d572077
REVIEW: Subscribe to cookie store for changes in place of CookieMonsterDelegate
2018-02-23 10:21:23 +09:00
Tomas Rycl
8d6c7955ad
Add path to skia gpu
2018-02-23 10:21:23 +09:00
Shelley Vohr
233679865b
fix some more compilation errors
2018-02-23 10:21:23 +09:00
Tomas Rycl
6a61ec7763
Add path to khrplatform.h file
2018-02-23 10:21:23 +09:00