Milan Burda
44491b023a
refactor: eliminate duplicate C++ / JavaScript implementation of app.isPackaged ( #29464 )
2021-06-02 12:17:08 -07:00
Robo
77297f37a3
fix: adjust initial webContents focus calculation ( #29204 )
...
* fix: adjust initial webContents focus calculation
* fix: active window check on mac
* fix: about:blank focus behavior
* chore: add spec
Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>
2021-05-19 02:27:35 -07:00
Milan Burda
c68c65f383
refactor: implement <webview> using contextBridge ( #29037 )
...
* refactor: implement <webview> using contextBridge
* chore: address PR feedback
* chore: address PR feedback
* fix: check for HTMLIFrameElement instance in attachGuest
2021-05-15 16:42:07 +09:00
Tabish Mahfuz
5ceec9189e
fix: Menu.setApplicationMenu can return a useless array 29088 ( #29118 )
2021-05-12 12:02:30 -07:00
Milan Burda
42e5421276
refactor: remove unnecessary setupDialogProperties ( #28982 )
2021-05-05 16:00:41 +09:00
Milan Burda
961b74b2ac
refactor: use "as const" for constant mappings ( #28980 )
2021-05-04 14:12:49 -07:00
Samuel Attard
791eddd541
fix: provide no-op implementation of app.setUserModelId ( #28915 )
2021-04-28 18:41:03 -07:00
Samuel Attard
0a1b26b1d5
refactor: remove internal navigation controller ( #28839 )
2021-04-27 16:11:18 -07:00
Samuel Attard
79077f6df9
chore: remove app.allowRendererProcessReuse ( #26874 )
2021-04-21 13:59:11 -07:00
Shelley Vohr
11199d8824
feat: add BrowserWindow.isFocusable() ( #28642 )
2021-04-21 12:32:19 +02:00
Samuel Attard
b8c2481edb
fix: do not handle write errors after request is aborted ( #28682 )
...
This fixes a flake on linux CI which started recently where the "write"
promise is being rejected after the request has been aborted /
cancelled. In this case we should drop the error to the floor but
instead we pass it down the stack where it eventually emits a now
unhandled error event.
Example failure: https://app.circleci.com/pipelines/github/electron/electron/38072/workflows/c1faf19b-aa41-4f99-a564-165729222859/jobs/838813
Verified fix by running the test that caused it 10000 times before fix
and 10000 times after. ~50 failures before, 0 after.
2021-04-19 09:50:14 -04:00
Jeremy Rose
dba4df9326
feat: add more info in setWindowOpenHandler details ( #28518 )
...
* fix: invoke the window open handler for _blank links
* feat: add disposition to setWindowOpenHandler details
* fix: pass postData to new-window event
* postData can be heterogeneous
* fix type of postBody
* fix type of UploadFile and UploadRawData to be discriminated unions
* exclude the empty string from additionalFeatures
* add a test
* add postBody and referrer to setWindowOpenHandler args
* appease typescript
* Update api-browser-window-spec.ts
* update snapshots
2021-04-13 15:35:27 -04:00
Jeremy Rose
62b38812b6
fix: invoke the window open handler for _blank links ( #28498 )
...
* fix: invoke the window open handler for _blank links
* add test
2021-04-06 01:04:14 -07:00
Shelley Vohr
7c36463085
fix: window.print() in pdf plugin ( #28328 )
2021-03-23 10:40:37 -04:00
Jeremy Rose
502d4c19ce
feat: allow omitting submitURL when uploadToServer is false ( #28105 )
2021-03-18 14:15:19 -07:00
Samuel Attard
089ac8180f
fix: ensure child window transparency works ( #28054 )
...
* fix: ensure child window transparency works
Windows opened via window.open and intecepted via setWindowOpenHandler
or the `new-window` event should (a) have the correct background color
and (b) that background color should be transparent if specified.
The changes in api_web_contents fix (a) and the changes in
web_contents_preferences fix (b).
Notes: Child windows with specified background colors or transpency now
work as intended
* fix: set background_color in blink prefs apply logic
* chore: update for PR comments
2021-03-10 12:44:36 -08:00
Milan Burda
5b205731f6
chore: remove deprecated remote module ( #25734 )
...
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2021-03-09 17:12:40 -08:00
liulun
54bc71da34
chore: Add a condition to crashReporter deprecate log ( #27953 )
...
* Add a condition to crashReporter deprecate log
When developer set submitURL to '' crash reports will be saved at `...\AppData\Roaming\...\Crashpad\reports`, will not be uploaded to the server.
So at this time `deprecate.log('Sending uncompressed crash reports....')` is unnecessary.
* Update lib/browser/api/crash-reporter.ts
change to check uploadToServer
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
2021-03-05 10:13:17 +09:00
Electron Bot
ca75bca667
chore: bump chromium to 90.0.4415.0 (master) ( #27694 )
...
* chore: bump chromium in DEPS to 520c02b46668fc608927e0fcd79b6a90885a48bf
* chore: bump chromium in DEPS to 90.0.4414.0
* resolve chromium conflicts
* resolve v8 conflicts
* fix node gn files
* 2673502: Remove RenderViewCreated use from ExtensionHost.
https://chromium-review.googlesource.com/c/chromium/src/+/2673502
* 2676903: [mojo] Remove most legacy Binding classes.
https://chromium-review.googlesource.com/c/chromium/src/+/2676903
* 2644847: Move self-deleting URLLoaderFactory base into //services/network.
https://chromium-review.googlesource.com/c/chromium/src/+/2644847
* 2664006: Remove from mojo::DataPipe.
https://chromium-review.googlesource.com/c/chromium/src/+/2664006
* 2674530: Remove CertVerifierService feature
https://chromium-review.googlesource.com/c/chromium/src/+/2674530
* 2668748: Move OnSSLCertificateError to a new interface.
https://chromium-review.googlesource.com/c/chromium/src/+/2668748
* 2672923: Remove RAPPOR reporting infrastructure.
https://chromium-review.googlesource.com/c/chromium/src/+/2672923
* 2673502: Remove RenderViewCreated use from ExtensionHost.
https://chromium-review.googlesource.com/c/chromium/src/+/2673502
* 2655126: Convert FrameHostMsg_ContextMenu and FrameMsg_ContextMenuClosed|CustomContextMenuAction to Mojo
https://chromium-review.googlesource.com/c/chromium/src/+/2655126
* 2628705: Window Placement: Implement screen.isExtended and change event
https://chromium-review.googlesource.com/c/chromium/src/+/2628705
* 2643161: Refactor storage::kFileSystem*Native*
https://chromium-review.googlesource.com/c/chromium/src/+/2643161
* fix build
* only remove the biggest subdir of //ios
* chore: bump chromium in DEPS to 90.0.4415.0
* update patches
* update sysroots
* 2686147: Remove WebContentsObserver::RenderViewCreated().
https://chromium-review.googlesource.com/c/chromium/src/+/2686147
* 2596429: Fixing how extension's split and spanning modes affect OriginAccessList.
https://chromium-review.googlesource.com/c/chromium/src/+/2596429
* 2686026: [mojo] Delete AssociatedInterfacePtr (replaced by AssociatedRemote)
https://chromium-review.googlesource.com/c/chromium/src/+/2686026
* 2651705: Move ui/base/dragdrop/file_info to ui/base/clipboard
https://chromium-review.googlesource.com/c/chromium/src/+/2651705
* 358217: drawBitmap is deprecated
https://skia-review.googlesource.com/c/skia/+/358217
* fix gn check
* 2678098: Use gen/front_end as input to generate_devtools_grd
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2678098
* 2674530: Remove CertVerifierService feature
https://chromium-review.googlesource.com/c/chromium/src/+/2674530
* fixup 2664006: Remove from mojo::DataPipe.
https://chromium-review.googlesource.com/c/chromium/src/+/2664006
* fixup build_add_electron_tracing_category.patch
* 2673415: [base] Prepare CrashReporterClient for string16 switch
https://chromium-review.googlesource.com/c/chromium/src/+/2673415
* 2673413: Add CursorFactoryWin to handle Cursors on Windows
https://chromium-review.googlesource.com/c/chromium/src/+/2673413
* 2668748: Move OnSSLCertificateError to a new interface.
https://chromium-review.googlesource.com/c/chromium/src/+/2668748
* fix mas gn check
* update patch after merge
* Update node for .mjs files
* build: load v8_prof_processor dependencies as ESM
* chore: add patch to fix linux 32bit
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2021-03-04 09:27:05 -08:00
Erick Zhao
2d0ad0b96a
fix: make TouchBarPopover and TouchBarGroup work ( #27901 )
...
* fix: use correct `orderedItem` touchbar property
* fix: correct parent in touchbar group and popover
* fix: preserve property hook order
2021-03-01 13:34:00 -08:00
Emil Pettersson
a9b25dda85
fix: race-condition in electron.net ( #27898 )
2021-02-26 13:18:46 -08:00
Tony
b181dae146
fix: isFullScreen typo ( #27823 )
...
* fix isFullScreen typo
* Update lib/browser/api/base-window.ts
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
Co-authored-by: Tony Wu <tonywoo@fb.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
2021-02-22 15:33:46 -05:00
Shelley Vohr
e46446e7e4
chore: bump chromium to e836cbe709f3cd703f233de8eb6cc6ec99b72c9d ( #27475 )
...
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
2021-02-09 12:16:21 -08:00
Milan Burda
79b3393768
chore: remove bunch of usages of any ( #27512 )
2021-01-29 12:41:59 -08:00
Milan Burda
70190ec2b1
chore: update to latest TypeScript, which has built-in WeakRef declarations ( #27425 )
2021-01-22 11:25:47 -08:00
Milan Burda
2be3d03630
feat: add webFrameMain.send() / webFrameMain.postMessage() ( #26807 )
2021-01-15 09:00:37 +09:00
Jeremy Rose
da3d21e5e3
fix: make webContents.id work even after destroy ( #27038 )
2020-12-17 12:10:29 -08:00
Cheng Zhao
998f17ee59
fix: make protocol wrapper remote-friendly again ( #27009 )
2020-12-16 16:56:53 +09:00
Milan Burda
6932e17088
chore: remove deprecated systemPreferences methods ( #26849 )
2020-12-16 08:34:24 +09:00
Milan Burda
cec6378881
feat: add event.senderFrame property returning the originating webFrameMain ( #26764 )
2020-12-09 15:34:06 -08:00
Jeremy Rose
07a1c2a3e5
fix: restrict sendToFrame to same-process frames by default ( #26875 )
2020-12-09 12:48:16 -08:00
Milan Burda
ee0550efca
fix: systemPreferences.effectiveAppearance returning systemPreferences.getAppLevelAppearance() ( #26852 )
2020-12-08 16:07:04 +09:00
Shelley Vohr
b788ceb7bd
fix: screen EventEmitter methods with remote ( #26809 )
...
* fix: screen EventEmitter methods with remote
* Review feedback
2020-12-08 13:47:48 +09:00
Alexey Kuzmin
e89b3ca1d1
fix: add a "set" trap to the "screen" module proxy ( #26818 )
2020-12-07 09:20:50 -08:00
Jeremy Rose
d3b1566181
chore: remove unused _replyInternal method ( #26825 )
2020-12-07 09:19:26 -08:00
Milan Burda
b37982987a
chore: remove unused sendToAll + related APIs ( #26771 )
...
* chore: remove unused sendToAll + related APIs
* refactor: no need to args.ShallowClone() anymore
2020-12-03 15:55:50 +09:00
Milan Burda
022bafc485
chore: remove deprecated crashReporter APIs ( #26695 )
2020-11-26 22:07:40 +03:00
Anders Kaseorg
b1b25607ee
fix: make screen wrapper remote-friendly again ( #26620 )
...
This restores accessibility of screen methods via remote.screen.
Fixes #26610 .
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2020-11-23 16:44:54 -05:00
LuoJinghua
e1cc78f275
feat: allow setting the Origin header and Sec-Fetch-* headers in net.request() ( #26135 )
2020-11-17 14:25:41 -08:00
Jeremy Rose
92643a5a1c
refactor: consolidate WebContents::{Create,New} ( #26521 )
2020-11-17 14:14:33 -08:00
Jeremy Rose
a303813d15
refactor: move GetPrinterList off WebContents ( #26518 )
2020-11-17 14:14:09 -08:00
Jeremy Rose
7c2ac6b7c1
fix: BrowserWindow.fromBrowserView in multiple-BrowserView windows ( #26493 )
2020-11-17 11:12:02 -08:00
Jeremy Rose
a9924e1c32
feat: add powerMonitor.onBatteryPower ( #26494 )
2020-11-16 16:31:46 -08:00
Cheng Zhao
bb3fb548d8
feat: add APIs to enable/disable spell checker ( #26276 )
...
* feat: add APIs to enable/disable bulitin spell checker
* feat: add togglespellchecker menu item role
2020-11-11 10:29:18 -05:00
loc
0b85fdf26c
feat: add webContents.setWindowOpenHandler API ( #24517 )
...
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2020-11-10 09:06:03 -08:00
Milan Burda
0c2e2bca92
refactor: don't send ipcRenderer.sendSync() returnValue as an array ( #26178 )
2020-10-28 18:48:20 +03:00
Milan Burda
df1432a315
feat: add net.online / net.isOnline() ( #21004 )
2020-10-20 19:55:06 -07:00
Cheng Zhao
6b6ffbdd10
feat: add support for share menu on macOS ( #25629 )
2020-10-19 18:33:06 -07:00
Milan Burda
321395d96e
refactor: use Map instead of Object for better semantics ( #25982 )
2020-10-19 03:24:51 +03:00
Milan Burda
2c68bad631
refactor: create IPC_MESSAGES enum for IPC message channels ( #25694 )
2020-10-14 00:11:06 +03:00