Kevin Sawicki
94cb605993
Use strictEqual for global variable asserts
2017-01-30 10:08:12 -08:00
Kevin Sawicki
e99b1709d9
Redeclare process/global as strings
2017-01-30 09:58:44 -08:00
Kevin Sawicki
4e5b8ac3ee
Remove throws and assert object directly
2017-01-30 09:38:15 -08:00
James Ide
0430380de1
Update the Node submodule to use the new module wrapper
...
See the fixed issue for the context. This pulls in a vendored copy of Node that includes the described patch.
Fixes #8358
Test Plan: Built Electron and verified it loaded the sample app correctly and that the module wrapper is the new one by viewing Node's source code in the Blink Inspector.
Added specs and tested with `npm test -- --grep "global variables"`
2017-01-30 09:37:14 -08:00
leethomas
edbb786fb4
use kCGMinimumWindowLevelKey to get the minimum level
2017-01-26 19:12:10 -08:00
Kevin Sawicki
76e5589a31
Schedule function after executeJavaScript completes
2017-01-26 16:15:10 -08:00
Kevin Sawicki
e683f28e32
Require a non-empty drag image to prevent crash
2017-01-26 15:46:04 -08:00
Kevin Sawicki
8ce1930f0d
Add specs for missing startDrag options
2017-01-26 15:46:04 -08:00
Kevin Sawicki
06c025050e
Fix typo in spec description
2017-01-26 14:46:51 -08:00
Kevin Sawicki
1004d205d8
Add spec for unhandledRejection event in main process
2017-01-26 14:46:50 -08:00
Kevin Sawicki
24fb560a9d
Add failing spec for uncaught main process errors
2017-01-26 14:46:50 -08:00
Kevin Sawicki
2cfa67bdff
Remove linter warning
2017-01-26 09:59:07 -08:00
Kevin Sawicki
a851695bb9
Clear interval before setting new one
2017-01-26 09:57:53 -08:00
Kevin Sawicki
e2e33a8cf0
Guard against destroyed window or web contents
2017-01-26 09:57:00 -08:00
Kevin Sawicki
515f689814
Use helper function to show last dev tools panel
2017-01-26 09:42:45 -08:00
leethomas
9e189b9d2d
fix js lint errors
2017-01-26 07:14:47 -08:00
leethomas
1234b61fa6
spec to ensure an error is thrown when relativeLevel is set out of bounds
2017-01-25 19:39:57 -08:00
Kevin Sawicki
104cae8f68
Only call getNativeHandle on macOS
2017-01-25 14:26:05 -08:00
Kevin Sawicki
2ad46f1842
Add failing spec for empty image crashes
2017-01-25 14:26:05 -08:00
Kevin Sawicki
8e69f94df0
Merge pull request #8357 from electron/remote-events-error-message
...
Don't crash when calling stale remote listeners
2017-01-25 14:23:57 -08:00
Kevin Sawicki
330ac5f266
Fix standard linting error
2017-01-25 12:36:55 -08:00
Kevin Sawicki
56a8eb3a94
Check that sender is a WebContents instance
2017-01-25 12:36:55 -08:00
Charlie Hess
f6410d3b77
Assert that listener count decreases after a remove event.
2017-01-25 12:36:55 -08:00
Charlie Hess
c213971a2d
Write a warning instead of crashing.
2017-01-25 12:36:55 -08:00
Kevin Sawicki
45986405b8
Assert remote event names
2017-01-25 12:36:55 -08:00
Charlie Hess
b04db2e546
Add a spec for the "renderer window closed" error.
2017-01-25 12:36:55 -08:00
Kevin Sawicki
f104e019be
Run crash reporter server specs on CI
2017-01-25 10:36:16 -08:00
Kevin Sawicki
8e39aea34a
Merge pull request #8478 from deepak1556/load_url_max_char_patch
...
WebContents: emit did-fail-load event when url exceeds character limit
2017-01-25 09:46:40 -08:00
deepak1556
d8a16a8ffb
fix spec
2017-01-25 14:20:33 +05:30
Kevin Sawicki
170c51ae85
Add spec for crashing node process
2017-01-24 13:49:45 -08:00
Kevin Sawicki
6bb331356e
Finish spec when full screen is left
2017-01-24 11:55:13 -08:00
Kevin Sawicki
284ca3114b
Wait for window to transition before leaving full screen
2017-01-24 11:55:13 -08:00
Kevin Sawicki
2762ead5a4
Upgrade to ffi@2.2.0
2017-01-24 11:25:21 -08:00
Kevin Sawicki
33820ffb85
Upgrade multiparty for os.tmpdir fix
2017-01-23 09:22:08 -08:00
deepak1556
593a3de850
add spec
2017-01-23 19:57:47 +05:30
Kevin Sawicki
1b036a284d
Add basic inspectElement spec
2017-01-19 09:05:59 +02:00
Kevin Sawicki
cc183524fd
Only remove webview when non-null
2017-01-19 09:05:59 +02:00
Kevin Sawicki
b0ee46f862
Use === in specs
2017-01-19 09:05:59 +02:00
Kevin Sawicki
017df93ffa
Add failing spec for insertCSS
2017-01-19 09:05:59 +02:00
Kevin Sawicki
2f5acfedcd
Add spec for denying perm requests when handler is cleared
2017-01-19 09:05:59 +02:00
Kevin Sawicki
977680d00b
Add spec for midi without sysex permission
2017-01-19 09:05:59 +02:00
Kevin Sawicki
2f26dbf39e
Update type to level in debugger message spec
2017-01-19 09:05:59 +02:00
Kevin Sawicki
873e6e5e6b
Append form to body before submitting
2017-01-19 09:05:59 +02:00
Kevin Sawicki
f7bdf5d04e
Merge pull request #8399 from watilde/feature/fixes-8338
...
save a fullscreen state when Kiosk mode is called
2017-01-17 13:03:51 -08:00
Kevin Sawicki
dcbc10ac38
Merge pull request #8417 from electron/flaky-travis-specs
...
Disable flaky specs on Travis
2017-01-17 08:48:59 -08:00
Kevin Sawicki
1d824d4645
Assert document visibility in main context
2017-01-16 13:03:38 -08:00
Kevin Sawicki
37b7dda3c5
Remove use of now private guestId
2017-01-16 12:38:16 -08:00
Kevin Sawicki
fbcbfbda6a
Add back BrowserWindowProxy location property
2017-01-16 12:38:16 -08:00
Kevin Sawicki
3f7b3c4bd7
Implement window overrides in main context
2017-01-16 12:38:16 -08:00
Kevin Sawicki
95054f443f
Enable context isolation on child windows
2017-01-16 12:38:16 -08:00
Kevin Sawicki
33b6ab11f2
Assert context state after reload
2017-01-16 12:38:16 -08:00
Kevin Sawicki
14a1e673c6
Add spec for webview context isolation
2017-01-16 12:38:16 -08:00
Kevin Sawicki
802ed62d5b
Remove trailing comma
2017-01-16 12:38:16 -08:00
Kevin Sawicki
b348cdeae8
Set page variable using webFrame.executeJavaScript
2017-01-16 12:38:16 -08:00
Kevin Sawicki
ea2273dde5
Assert built-in prototype isolation
2017-01-16 12:38:16 -08:00
Kevin Sawicki
ad3b837ad5
Rename option to contextIsolation
2017-01-16 12:38:16 -08:00
Kevin Sawicki
2928fe5c43
Add initial isolated world spec
2017-01-16 12:38:16 -08:00
Kevin Sawicki
b6c5e9a126
Disable disableguestresize spec that times out on Travis
2017-01-16 11:48:20 -08:00
Daijiro Wachi
b97db68f0c
add tests to fullScreen and Kiosk
2017-01-14 00:05:04 +01:00
Kevin Sawicki
726bab0293
Add specs for process.versions.electron/chrome
2017-01-12 13:50:19 -08:00
Kevin Sawicki
97dd680b32
Remove linter errors
2017-01-12 10:28:08 -08:00
Kevin Sawicki
8098ca3b66
Remove unneeded nextTick and assert array
2017-01-12 10:28:08 -08:00
Kevin Sawicki
c5da330cdf
Add failing spec for sandboxed window.open
2017-01-12 10:28:08 -08:00
Kevin Sawicki
d8366115f5
Add spec for resizable frameless window
2017-01-09 10:01:38 -08:00
Kevin Sawicki
1f07977f09
Remove lint errors
2017-01-06 09:58:40 -08:00
Kevin Sawicki
fd23c7bf76
Assert duplicate objects are supported
2017-01-06 09:58:40 -08:00
Kevin Sawicki
1944fdc962
Track visited parents and null out cycles
2017-01-06 09:58:40 -08:00
Kevin Sawicki
12382f064b
Add failing spec for cycle in options
2017-01-06 09:58:40 -08:00
Kevin Sawicki
b942c54bea
Use closeWindow helper
2017-01-06 09:58:40 -08:00
Kevin Sawicki
e788b9f959
Merge pull request #8258 from deepak1556/net_header_patch
...
net: disallow cookies from cookie store
2017-01-05 16:47:44 -08:00
Kevin Sawicki
abea1196de
Add spec for closing from will-navigate listener
2016-12-28 13:40:07 -08:00
Zeke Sikelianos
6995b51f2c
set webview spec timeout to three minutes
2016-12-22 13:31:30 -08:00
Zeke Sikelianos
c989ea43f5
bump webview spec timeout to two minutes
2016-12-22 12:30:34 -08:00
Zeke Sikelianos
b0c4c79c49
remove unused webview fixture
2016-12-22 10:41:05 -08:00
Zeke Sikelianos
1085c28612
rename all web-view files to webview
2016-12-22 10:41:05 -08:00
deepak1556
41c352c306
add failing spec
2016-12-21 11:52:27 +05:30
Kevin Sawicki
2a8b36c761
Merge pull request #8134 from deepak1556/empty_client_certificate_patch
...
app: select-client-certificate event callback can accept certificate optionally
2016-12-15 08:31:12 -08:00
Kevin Sawicki
cd067bca37
Merge pull request #8175 from gerhardberger/createfrombuffer-bitmap
...
Add bitmap support to nativeImage.createFromBuffer
2016-12-14 13:24:45 -08:00
Kevin Sawicki
8680a08a8d
Add deprecated comment to scaleFactor parameter
2016-12-14 10:18:01 -08:00
Kevin Sawicki
7a5ec96d53
Prevent input event from main process
2016-12-13 15:54:13 -08:00
Kevin Sawicki
5ae80d541b
Remove will-navigate spec
2016-12-13 15:54:13 -08:00
Birunthan Mohanathas
a3b65ad481
Add before-input-event event for webContents ( fixes #7586 )
...
Embedding arbitrary web content is problematic when it comes to keyboard
shortcuts because:
* Web content can steal app shortcuts (see e.g. brave/browser-laptop#4408 )
* Blocked web content (e.g. a focused <webview> performing expensive
computation) will also prevent app shortcuts from firing immediately
The new before-input-event event can be used to overcome these issues by
always handle certain keyboard events in the main process.
Note that this requires electron/brightray#261 to compile.
2016-12-13 15:54:13 -08:00
gellert
9d2c9df992
adds empty bitmap test for createFromBuffer
2016-12-14 00:24:57 +01:00
gellert
7ceb8d1ab8
additional tests for createFromBuffer
2016-12-14 00:18:24 +01:00
gellert
a609e52a14
moves bitmap parameters to options object
2016-12-13 21:32:17 +01:00
gellert
39875c90f1
adds bitmap support to createFromBuffer
2016-12-13 21:32:17 +01:00
Kevin Sawicki
c108088110
Test with some null/undefined windows
2016-12-12 16:25:14 -08:00
Kevin Sawicki
cb7715a572
Merge pull request #8187 from electron/optional-buttons
...
Allow buttons to be optional in 'showMessageBox'
2016-12-12 13:52:17 -08:00
Kevin Sawicki
b08bc02cde
Merge pull request #8137 from deepak1556/media_device_id_patch
...
session: reset media device id salt when cookies are cleared
2016-12-12 13:34:24 -08:00
Kevin Sawicki
04e873f78e
Make deviceIds const
2016-12-12 13:33:18 -08:00
Kevin Sawicki
04da9257ef
Catch any close window errors
2016-12-12 13:32:27 -08:00
Kevin Sawicki
f2aabeefd5
Merge pull request #8085 from deepak1556/protocol_http_session_patch
...
protocol: support custom session with interceptHttpProtocol
2016-12-12 13:07:14 -08:00
Kevin Sawicki
1d288b69e2
Merge pull request #7947 from beakerbrowser/register-standard-secure-schemes
...
Add {secure:} opt to protocol.registerStandardSchemes
2016-12-12 12:52:28 -08:00
Paul Frazee
99ea50649a
finish implementation of {secure:true} opt on protocol.registerStandardScehesm, and add working test
2016-12-12 12:49:57 -08:00
Daniel Pham
4b53cd9c3c
🐛 Allow buttons to be optional in 'showMessageBox'
2016-12-12 13:25:32 -05:00
Kevin Sawicki
2fa9ca1f6d
Merge pull request #8156 from sindresorhus/remove-dock-window-level
...
🍎 Document that the `dock` window level is deprecated
2016-12-12 09:39:08 -08:00
Kevin Sawicki
1a0fbf84f9
Merge pull request #8165 from geoff-addepar/geoff/fix-sandbox-printing
...
Fix printing with the sandbox enabled
2016-12-12 09:26:52 -08:00
deepak1556
4085ba309a
fix spec
2016-12-09 09:56:16 -08:00
deepak1556
21be9a3309
add spec
2016-12-09 09:55:55 -08:00
Kevin Sawicki
d705f4cbac
Fix issue where actual/expected was same variable
2016-12-09 09:37:46 -08:00
deepak1556
5d94221c61
fix code style
2016-12-09 09:37:46 -08:00
deepak1556
f124732431
add spec
2016-12-09 09:37:46 -08:00
Sindre Sorhus
3dde669ee8
🍎 Remove deprecated dock
window level
...
According to the Apple docs, the `NSDockWindowLevel` constant is deprecated: https://developer.apple.com/reference/appkit/nsdockwindowlevel?language=objc
2016-12-09 12:46:49 +01:00
Geoff Lywood
5345b08d24
Fix printing with the sandbox enabled
...
Closes #7984
2016-12-07 17:40:18 -08:00
deepak1556
2b8b76a527
protocol: support custom session with interceptHttpProtocol
2016-12-07 16:22:34 +05:30
deepak1556
cbddbdb296
fix code style
2016-12-07 15:33:56 +05:30
deepak1556
1c45285fe3
add spec
2016-12-07 13:26:06 +05:30
Kevin Sawicki
63bffbc460
Don't show window
2016-12-06 13:25:46 -08:00
Kevin Sawicki
03263bb5b6
Add failing BrowserWindow.fromDevToolsWebContents spec
2016-12-06 10:36:59 -08:00
Kevin Sawicki
b0a1e2988b
Add spec for BrowserWindow.fromWebContents
2016-12-06 10:36:59 -08:00
Kevin Sawicki
b29f7b9acb
Clear interval before assert
2016-12-06 09:25:55 -08:00
Kevin Sawicki
c2f516067f
Add missing r in variable name
2016-12-06 09:22:29 -08:00
Kevin Sawicki
58cae1d8de
Clear interval before destroying window
2016-12-06 09:22:08 -08:00
deepak1556
e043dabcb8
add spec
2016-12-04 00:22:57 +05:30
Kevin Sawicki
c1a02d6556
Add spec for render-view-deleted issue
2016-12-02 10:42:09 -08:00
Kevin Sawicki
b61e1fd69f
Add spec for error on removing all IPC listeners
2016-12-01 14:56:00 -08:00
Kevin Sawicki
36371357cd
buttonLabel -> Button label for consistency
2016-12-01 14:16:33 -08:00
Kevin Sawicki
750bd9a88b
Add initial dialog specs
2016-12-01 14:15:34 -08:00
Kevin Sawicki
eaa5d071ef
Remove unneeded timeout call
2016-11-29 16:27:18 -08:00
Kevin Sawicki
d86f0a1686
Add missing call to done
2016-11-29 14:52:47 -08:00
Kevin Sawicki
f0566f3790
isCi -> isCI
2016-11-29 14:48:28 -08:00
Kevin Sawicki
f5f790863d
Use 1 or 2 minute timeout for long specs
2016-11-29 14:31:57 -08:00
Kevin Sawicki
10386edea5
Default timeout to 30 seconds on CI and 10 seconds locally
2016-11-29 14:29:35 -08:00
Kevin Sawicki
4ccc3d9fb3
Remove unneeded return
2016-11-29 14:19:20 -08:00
Kevin Sawicki
77fa7ce977
Run more crashReporter specs on CI
2016-11-29 14:18:42 -08:00
Kevin Sawicki
2c8ab72269
Merge pull request #8084 from poiru/systempreferences-setuserdefault
...
Add systemPreferences.setUserDefault for macOS
2016-11-29 14:07:35 -08:00
Kevin Sawicki
df179ed28d
Merge pull request #8092 from poiru/setcursorautohide
...
Add BrowserWindow.setCursorAutoHide
2016-11-29 13:36:58 -08:00
Kevin Sawicki
cc2936cfdf
closeWindow in an afterEach block
2016-11-29 12:30:40 -08:00
Kevin Sawicki
d20e664ea8
Close window in an afterEach
2016-11-29 12:13:33 -08:00
Kevin Sawicki
fee7683b86
Reuse window variable and only close from root afterEach
2016-11-29 11:52:31 -08:00
Kevin Sawicki
d7e7c2b17f
Assert single window from closeWindow helper
2016-11-29 11:29:20 -08:00
Kevin Sawicki
1afa41477d
Don't use this.skip() since after hooks won't be run
2016-11-29 10:56:58 -08:00
Kevin Sawicki
217848ca52
Assert windows are not leaking across tests
2016-11-29 10:56:17 -08:00
Birunthan Mohanathas
486b6b9096
Add systemPreferences.setUserDefault for macOS
...
This API can be used to e.g. enable key repeat by setting
`ApplePressAndHoldEnabled` to `false` (see also #47 ).
2016-11-29 09:46:32 -08:00
Birunthan Mohanathas
18c49285a8
Add BrowserWindow.setAutoHideCursor for macOS
...
The `disableAutoHideCursor` BrowserWindow option can be used to control
auto-hiding behavior when the window is created. This new API is needed
to dynamically change the behavior after the fact.
2016-11-29 09:46:00 -08:00
Kevin Sawicki
1c6e166af5
Value should be true on non-macOS platforms
2016-11-28 15:08:28 -08:00
Kevin Sawicki
f4be3782a2
Add spec for get/setUploadToServer
2016-11-28 15:08:28 -08:00
Kevin Sawicki
774b2f99f2
Merge pull request #8038 from electron/danhp/close-file-preview
...
Add 'win.closeFilePreview()'
2016-11-28 14:47:06 -08:00
Kevin Sawicki
a7395118af
Merge pull request #7952 from the-ress/window-setappid
...
Added BrowserWindow.setAppDetails to set user model id, icon and relaunch command
2016-11-28 14:46:14 -08:00
Kevin Sawicki
3897a88082
Use skip for setAppDetails spec
2016-11-28 14:43:18 -08:00
Kevin Sawicki
0a61aad499
Add initial previewFile/closeFilePreview test
2016-11-28 14:32:15 -08:00
Kevin Sawicki
145e40c2f6
Add more origin comparison specs
2016-11-28 10:56:23 -08:00
Kevin Sawicki
41dea03007
window.opener location should be webview src URL
2016-11-28 10:56:23 -08:00
Kevin Sawicki
0799317ff5
Add failing specs window.opener from <webview> opened window
2016-11-23 12:01:09 -08:00
Kevin Sawicki
e356168c9a
Merge pull request #8047 from electron/fix-incorrect-window-size
...
Fix incorrect window size after restore on Windows
2016-11-22 14:01:50 -08:00
Kevin Sawicki
6f29d7211e
Move restore/unmaximize specs near state ones
2016-11-22 13:32:39 -08:00
Kevin Sawicki
63eec70350
Assert bounds when restoring
2016-11-22 13:22:30 -08:00
Kevin Sawicki
c0d9175bc3
Try specs without setTimeout calls
2016-11-22 13:14:17 -08:00
Kevin Sawicki
89965aa5db
Check runner.hasOnly for focused spec check
2016-11-22 13:06:18 -08:00
Kevin Sawicki
238beb72ee
Remove .only call
2016-11-22 11:41:02 -08:00