Cheng Zhao
411da169ac
Repect old logic in windowWillUseStandardFrame
2018-03-06 16:54:20 +09:00
Cheng Zhao
78468098c5
Don't store WebContents in NativeWindow
2018-03-06 16:21:18 +09:00
Cheng Zhao
9000bd6679
views: Explicitly set initially focused view
2018-03-06 16:21:18 +09:00
Cheng Zhao
413fdc6f0d
views: Show menu on window's content view
2018-03-06 16:21:18 +09:00
Cheng Zhao
9c7854aef6
NativeWindow is no longer WebContentsObserver
2018-03-06 16:21:18 +09:00
Cheng Zhao
bf862d1d07
views: Focus webContents in BrowserWindow
2018-03-06 16:21:17 +09:00
Cheng Zhao
8bbe28e998
No need to get BrowserContext from NativeWindow
2018-03-06 16:21:17 +09:00
Cheng Zhao
702f1631a3
Remove NativeWindow::FromWebContents
2018-03-06 16:21:17 +09:00
Cheng Zhao
eea4e60b73
Remove NativeWindow's webview APIs
2018-03-06 16:20:37 +09:00
Cheng Zhao
5a4c2fb61d
mac: Pass the view to install
2018-03-06 16:20:37 +09:00
Cheng Zhao
498f5d65fd
mac: UninstallView is not used
2018-03-06 16:20:37 +09:00
Cheng Zhao
3b3e69f8b2
Save browser_view_ in the NativeWindow
...
No need to store it separately in subclasses.
2018-03-06 16:20:37 +09:00
Cheng Zhao
503b0ba1b1
mac: Move draggable region code to BrowserWindow
...
On macOS current draggable region implementation highly relies on
WebContents, the code is only meaningful for BrowserWindow.
2018-03-06 16:20:37 +09:00
Cheng Zhao
bc34ca9e25
mac: Call setMouseDownCanMoveWindow in BrowserWindow
2018-03-06 16:20:37 +09:00
Cheng Zhao
7d4ff3b061
mac: Call SetBackgroundOpaque in BrowserWindow
2018-03-06 16:20:37 +09:00
Cheng Zhao
8a1884c407
mac: AcceleratedWidget should be window's content view
2018-03-06 16:20:37 +09:00
Cheng Zhao
e7f175d578
Only mac needs to call SetActive
2018-03-06 16:20:37 +09:00
Cheng Zhao
4c7b48e596
mac: Window's native view should be its content view
2018-03-06 16:20:37 +09:00
Cheng Zhao
1681ee35db
Set WebContents background color in BrowserWindow
2018-03-06 16:20:37 +09:00
Cheng Zhao
7b8890a4c9
web_contents can't be null
2018-03-06 16:20:37 +09:00
Cheng Zhao
2eaa6d0874
Move StoreFocus/RestoreFocus to BrowserWindow
2018-03-06 16:20:37 +09:00
Cheng Zhao
cad3d694ab
mac: Remove access to webContents in windowWillUseStandardFrame
2018-03-06 16:20:37 +09:00
Cheng Zhao
ca42325ade
Make OnMessageBoxCallback a method since it is accessing members
2018-03-06 11:35:53 +09:00
Cheng Zhao
7516b059fe
Code style fixes
2018-03-06 11:31:56 +09:00
Samuel Attard
7dec3c9320
Fixup cpplint
2018-03-06 11:19:15 +09:00
Samuel Attard
731240e0e9
Use USER_WANTS_NO_MORE_DIALOGS constant for -1 magic number
2018-03-06 11:19:15 +09:00
Charles Kerr
a5a068b2ee
fix cpplint errors
...
atom/browser/atom_javascript_dialog_manager.cc:39: Lines should be <= 80 characters long [whitespace/line_length] [2]
atom/browser/atom_javascript_dialog_manager.cc:39: If/else bodies with multiple statements require braces [readability/braces] [4]
atom/browser/atom_javascript_dialog_manager.cc:62: Lines should be <= 80 characters long [whitespace/line_length] [2]
atom/browser/atom_javascript_dialog_manager.cc:89: If/else bodies with multiple statements require braces [readability/braces] [4]
2018-03-06 11:19:15 +09:00
Charles Kerr
2435ffaf09
fix cpplint error
...
atom/browser/atom_javascript_dialog_manager.h:9: Include "map" not in alphabetical order [build/include_alpha] [4]
2018-03-06 11:19:15 +09:00
Samuel Attard
795447f61a
Implement dialog (alert/confirm) blocking as a user switch after the first dialog
...
* This is to enable more browser-like behavior so that users who run third-party code
will not be DOS'ed with alerts and confirms. This is already handled like this
in most major browsers so this will greatly help these developers
2018-03-06 11:19:15 +09:00
Shelley Vohr
199cf31b9e
deprecate screen.getMenuBarHeight
2018-03-05 19:45:51 -05:00
Aleksei Kuzmin
52c0864cb8
Use version 0.0.0-dev everywhere
2018-03-05 16:24:48 +01:00
Shelley Vohr
bf491de9fe
fix styling and add spec
2018-02-28 00:22:42 -08:00
Shelley Vohr
2abc69780e
move native-mate back into the api layer
2018-02-27 13:00:42 -08:00
Shelley Vohr
837a2d4bbd
appease the linter
2018-02-26 22:25:09 -08:00
Samuel Attard
b722150d87
Don't cast manually for NativeWindow*
2018-02-27 16:13:17 +11:00
Samuel Attard
5336b4a89c
Pass arguments instance through the chain in order to throw error
2018-02-27 16:11:58 +11:00
Shelley Vohr
e84d7c0cda
add warning when addTabbedWindow is called on self
2018-02-26 14:47:36 -08:00
Cheng Zhao
53229e3d6c
Fix network delegate race condition ( #12044 )
...
* Fix race condition when getting network delegate
* Remove the evil URLRequestContextGetter::network_delegate
* Move the arguments instead of const referrencing
Safer and more efficient.
2018-02-26 06:23:59 -08:00
Cheng Zhao
f7786a9e48
Merge pull request #11230 from electron/upgrade-to-chromium-62
...
Upgrade to Chromium 62
2018-02-26 14:20:21 +09:00
kaylie
da9f12d1e2
restore old cb
2018-02-25 14:19:40 -08:00
Cheng Zhao
39e0433570
Fix build error after rebasing
2018-02-23 10:22:00 +09:00
shelley vohr
0e5b6f9300
Upgrade to node v9.3.0 ( #11507 )
...
* update submodule refs for node v9.3.0
* Define "llvm_version" for Node.js build
* NODE_MODULE_CONTEXT_AWARE_BUILTIN -> NODE_BUILTIN_MODULE_CONTEXT_AWARE
* update NodePlatform to MultiIsolatePlatform
* fix linting error
* update node ref
* REVIEW: Explicitly register builtin modules
https://github.com/nodejs/node/pull/16565
* update libcc ref
* switch libcc to c62
* REVIEW: Address node api changes
- Always start the inspector agent for https://github.com/nodejs/node/pull/17085
- Set the tracing controller for node https://github.com/nodejs/node/pull/15538
- Isolate data creation now requires plaform https://github.com/nodejs/node/pull/16700
2018-02-23 10:22:00 +09:00
Aleksei Kuzmin
f5d207f8f0
Improve process launch handle sharing API.
...
https://codereview.chromium.org/2950153002
2018-02-23 10:21:24 +09:00
deepak1556
5eb0a89579
REVIEW: let browser context manage cookie change sub list
2018-02-23 10:21:24 +09:00
Aleksei Kuzmin
9fa08fdbc0
Merge views::CustomButton into views::Button.
...
https://chromium-review.googlesource.com/617407
2018-02-23 10:21:24 +09:00
Aleksei Kuzmin
6f00e4a014
REVIEW: Implements core logic for Pixel Canvas
...
https://codereview.chromium.org/2877483003
2018-02-23 10:21:24 +09:00
deepak1556
25d966110e
FIXME: PDF component IPC should be converted to Mojo.
...
https://codereview.chromium.org/2455543002
2018-02-23 10:21:23 +09:00
deepak1556
62635f43f4
base::LaunchOptions fds_to_remap is no longer a pointer
...
https://codereview.chromium.org/2950153002
2018-02-23 10:21:23 +09:00
deepak1556
248d572077
REVIEW: Subscribe to cookie store for changes in place of CookieMonsterDelegate
2018-02-23 10:21:23 +09:00
Aleksei Kuzmin
412b9e9ad8
Move IDMap to base namespace.
...
https://chromium-review.googlesource.com/618801
2018-02-23 10:21:23 +09:00