Ryohei Ikegami
4a7eec8f2d
Pass app path as command line argument
2017-04-04 09:36:01 +09:00
Kevin Sawicki
e85e483c71
Parse setting response to surface thrown errors
2017-04-03 12:16:51 -07:00
Ryohei Ikegami
001d03c859
Do not add search paths in devtools
2017-04-03 22:40:36 +09:00
Ryohei Ikegami
50c99e4507
Search for module under the app directory
2017-04-03 20:19:10 +09:00
Ryohei Ikegami
6f9dbd4e04
Merge branch 'master' into native-window-open
2017-03-24 00:11:43 +09:00
Cheng Zhao
bb5ad4ac05
Correctly initialize Node environment in worker
2017-03-20 12:52:45 -07:00
Kevin Sawicki
286f529968
Merge pull request #8890 from twolfson/dev/proxy.to.string.sqwished
...
🐛 Add toString support to remote functions
2017-03-20 09:35:51 -07:00
Ryohei Ikegami
a1f9a45276
Use native window.open implementation
2017-03-19 17:41:20 +09:00
Kevin Sawicki
c50b518493
Check toString after loading remote properties
2017-03-17 10:29:07 -07:00
Todd Wolfson
818738ce84
🐛 Add toString support to remote functions
2017-03-17 08:21:37 -07:00
Thiago de Arruda
f6befbe764
Expose lib/renderer/api/remote.js to sandboxed renderer
2017-03-16 14:21:23 -03:00
deepak1556
bd9a9657aa
disable node integration for chrome scheme
2017-03-14 00:26:27 +05:30
deepak1556
a2db14476a
create webui message handler
2017-03-14 00:25:59 +05:30
deepak1556
fdd574cea5
browser: implement pdf renderer as webui
2017-03-14 00:25:59 +05:30
Thiago de Arruda
dda2288541
Remove lib/renderer/api/ipc-renderer-setup.js
...
This file is no longer required since sandboxed renderer directly imports
ipc-renderer.js.
2017-03-09 20:40:32 -03:00
Thiago de Arruda
44bd93589a
Refactor electron exports to keep module list in separate files
2017-03-09 19:08:01 -03:00
Kevin Sawicki
dbe9893d29
Assign Promise.resolve to constant
2017-03-07 12:10:09 -08:00
Kevin Sawicki
79b17c2cd9
Expose TouchBar on remote module
2017-03-03 14:00:39 -08:00
Kevin Sawicki
e8a79cb88d
Don't require browser process module from renderer
...
This can cause issues when it is accessed from the
require cache or module tree since the getters throw
errors when called.
2017-02-28 08:45:39 -08:00
Kevin Sawicki
1d84d83fd4
Forward webview visibility change events from browser process
2017-02-28 08:23:00 -08:00
Kevin Sawicki
7564a9973b
Use const instead of var
2017-02-28 08:23:00 -08:00
Kevin Sawicki
f4717b34e9
Register visibility change listener when attached
2017-02-28 08:23:00 -08:00
deepak1556
403e7681c1
add basic webview zoom specs
2017-02-18 01:34:32 +05:30
Kevin Sawicki
2a18e3f9ea
Remove Buffer global on load
2017-02-14 08:42:34 -08:00
deepak1556
e3fe3cc490
map webframe zoom api to use HostZoomMap
2017-02-12 00:49:17 +05:30
deepak1556
63c0e4cbb1
Add ZoomController to manager zoom changes for webcontents
2017-02-12 00:49:17 +05:30
Greg Nolle
e29b64a18a
modify CertVerifier Class
...
* respond to multiple similar verification requests.
* accept net error result as callback response.
2017-02-08 11:59:43 -08:00
Cheng Zhao
c72438f09f
WebInspector has been split up
2017-02-06 10:34:29 -08:00
Kevin Sawicki
6bcfd0630c
Document implemented APIs at the top
2017-01-16 12:38:16 -08:00
Kevin Sawicki
fbcbfbda6a
Add back BrowserWindowProxy location property
2017-01-16 12:38:16 -08:00
Kevin Sawicki
f3852c57fc
Use empty string for comparison
2017-01-16 12:38:16 -08:00
Kevin Sawicki
2e6d08c652
Remove unneeded this prefix
2017-01-16 12:38:16 -08:00
Kevin Sawicki
bb260343de
Move more functions to outer scope
2017-01-16 12:38:16 -08:00
Kevin Sawicki
3f7b3c4bd7
Implement window overrides in main context
2017-01-16 12:38:16 -08:00
Javan Makhmali
a64bdbd306
Add "context-menu" DOM event to <webview>
2017-01-13 17:04:09 -05:00
Kevin Sawicki
1278e8cebc
Remove unused variable
2016-12-02 13:40:31 -08:00
Kevin Sawicki
635c909aab
Implement window.alert/confirm/close in main process
2016-12-02 13:40:31 -08:00
Kevin Sawicki
f894da13b0
Pass args array instead of arguments object
2016-12-02 13:40:31 -08:00
Kevin Sawicki
af555bd879
Use spread syntax instead of apply
2016-12-01 14:56:00 -08:00
Kevin Sawicki
c8ff67ab75
Use spread syntax instead of function apply
2016-12-01 14:56:00 -08:00
Kevin Sawicki
477ac313ab
Merge pull request #8086 from deepak1556/devtools_remove_workspace_patch
...
override window.confirm in devtools
2016-11-29 13:31:21 -08:00
Kevin Sawicki
72e559458f
Inline buttons and cancelId values
2016-11-29 13:30:28 -08:00
Kevin Sawicki
6f6c5c07f0
Remove unintended returns
2016-11-28 10:56:23 -08:00
Kevin Sawicki
3a29555772
Access URL through webContents directly
2016-11-28 10:56:23 -08:00
deepak1556
3ac9858726
override window.confirm in devtools
2016-11-28 01:08:48 +05:30
Cheng Zhao
bbaab755e3
Merge pull request #8049 from electron/prevent-remove-all-ipc
...
Throw an error when users attempt to remove all listeners from the IPC modules
2016-11-27 14:29:49 +08:00
Kevin Sawicki
9a5df9da41
Expose setVisualZoomLevelLimits on webContents and <web-view>
2016-11-22 08:07:55 -08:00
Samuel Attard
db729b5b52
Throw an error when users attempt to remove all listeners from the IPC modules
2016-11-22 18:30:58 +11:00
Paul Betts
e2649ce7d8
Add new method to set layout-based zoom level limit
2016-11-21 14:59:55 -05:00
Cheng Zhao
3834f0c6a6
Merge pull request #7974 from electron/chrome-runtime-response-callback
...
Implement chrome.runtime.onMessage response callback
2016-11-17 13:01:38 +09:00
Samuel Attard
7c26ec8bd4
Remove semicolon
2016-11-17 14:56:44 +11:00
Kevin Sawicki
5167ccd147
Guard against missing members in setObjectMembers
2016-11-16 07:45:34 -08:00
Birunthan Mohanathas
2986b7bc4a
Allow webview guests to be resized manually
...
This adds the `disableguestresize` property for webviews to prevent the
webview guest from reacting to size changes of the webview element. This
also partially documents the `webContents.setSize` function in order to
manually control the webview guest size.
These two features can be combined to improve resize performance for
e.g. webviews that span the entire window. This greatly reduces the lag
described in #6905 .
2016-11-15 11:00:09 -08:00
Samuel Attard
01005688b6
Implement chrome.runtime.onMessage response callback
2016-11-15 21:30:40 +11:00
Jhen
b86dff45d7
Add support remove / clear for chrome.storage
2016-11-12 02:16:51 +08:00
Kevin Sawicki
6fda4fc45c
Guard against attachedCallback firing while handling detachedCallback
2016-11-07 13:42:36 -08:00
Kevin Sawicki
0485069c7b
Use spread operator
2016-11-07 08:25:01 -08:00
Kevin Sawicki
e4d6aa30a1
Do truthy check in if block
2016-11-07 08:25:01 -08:00
Kevin Sawicki
89a26684e5
Return webContents directly
2016-11-07 08:25:01 -08:00
Kevin Sawicki
0e1c2b0fcb
Use for/of and remove loop variables
2016-11-07 08:25:01 -08:00
Kevin Sawicki
6eab14359c
Use ES6 style class for WebViewImpl
2016-11-07 08:25:01 -08:00
Kevin Sawicki
76f96bd99c
Destructure requires
2016-11-07 08:25:01 -08:00
Kevin Sawicki
48bcad87c2
Use template strings
2016-11-07 08:25:01 -08:00
Kevin Sawicki
712b15286c
Use let/const instead of var
2016-11-07 08:25:01 -08:00
Kevin Sawicki
3053be345b
Remove unneeded returns
2016-11-07 08:25:01 -08:00
Kevin Sawicki
e0afb814aa
Only call browserify when one of sandbox sources change
2016-11-07 08:19:59 -08:00
Samuel Attard
9f18a6e65c
Use ES6 template strings, fix docs and remove _ERROR_ IPC event
2016-11-03 09:33:47 -07:00
Samuel Attard
857e1da6a3
Make executeJavaScript return a Promise so that caught errors can be sent to the caller
2016-11-03 09:33:47 -07:00
Samuel Attard
75b010ce63
Add sync executeJavaScript test
2016-11-03 09:33:47 -07:00
Samuel Attard
124fbdbd74
Allow web frame methods to return async promises
2016-11-03 09:33:47 -07:00
Kevin Sawicki
68c2c9825f
Remove lint warnings
2016-10-25 10:36:43 +09:00
Paul Frazee
f35536bdc5
factor out parse-features-string.js
2016-10-24 20:21:42 -05:00
Paul Frazee
e7962c7ba2
fixes and tests for webview 'webpreferences' attr
2016-10-14 18:04:33 -05:00
Paul Frazee
194b14100e
add the 'webpreferences' attribute to webviews
2016-10-14 17:16:39 -05:00
Michael Vasseur
c811188e22
Updated required code to handle missing additional features for popup windows
2016-10-04 14:38:32 +09:00
Cheng Zhao
458c4dd129
Merge branch 'support-chromium-sandbox' of https://github.com/tarruda/electron into tarruda-support-chromium-sandbox
2016-09-27 20:02:23 +08:00
Thiago de Arruda
0f7652dc85
Move code that defines ipcRenderer methods into another file.
2016-09-27 06:01:46 -03:00
Zeke Sikelianos
56d62ff589
add html doctype
2016-09-22 14:47:20 -07:00
Zeke Sikelianos
62375663ab
add type to webview style tag
2016-09-22 14:34:03 -07:00
Cheng Zhao
e3e450613d
Merge pull request #7157 from Mossop/moveguest
...
Allow moving a webcontents to a different webview
2016-09-20 14:28:42 +09:00
Kevin Sawicki
eef42770c6
Don't load remote properties until they are accessed
2016-09-14 13:29:49 -07:00
Kevin Sawicki
359ab2f9b3
Only set members when members exist
2016-09-14 10:54:23 -07:00
Dave Townsend
313b2faa3c
Add a guestinstance attribute to webviews reflecting their current guest
...
instance ID and allowing moving a guest instance to a new webview.
2016-09-09 10:32:05 -07:00
Cheng Zhao
693ba1375b
Merge pull request #7146 from electron/resolve-empty-url-values
...
Tweak how empty URLs are resolved
2016-09-09 19:58:41 +09:00
Kevin Sawicki
daf1eec5ec
Use === for string comparison
2016-09-08 17:11:10 -07:00
Kevin Sawicki
1dbaf4987e
Don't resolve empty src/preload attribute values
2016-09-08 16:48:30 -07:00
Kevin Sawicki
9829baed46
Open about:blank when window.open is called with no URL
2016-09-08 16:10:21 -07:00
Kevin Sawicki
d476227e16
Remove unneeded return
2016-09-08 10:20:39 -07:00
Kevin Sawicki
902bd0564e
Require Buffer explicitly instead of relying on global
2016-09-08 10:17:06 -07:00
Cheng Zhao
f854b27bfb
Merge pull request #6867 from electron/remote-function-properties
...
Allow accessing remote function properties
2016-08-31 17:28:09 +09:00
Kevin Sawicki
01e69353d5
Don't serialize ArrayBuffer as Array
2016-08-24 15:18:42 -07:00
Kevin Sawicki
ec44a5d198
Add tests for setting remote function properties
2016-08-22 17:07:18 -07:00
Kevin Sawicki
666a668d91
Support remote function keys and property descriptors
2016-08-22 17:07:18 -07:00
Kevin Sawicki
d226b7bc6c
Use Proxy for accessing properties of remote function
2016-08-22 17:07:18 -07:00
Kevin Sawicki
8b38018ab4
Add helper for including function properties
2016-08-22 17:07:17 -07:00
Kevin Sawicki
d333cc5e38
Support remote function properties
2016-08-22 17:07:17 -07:00
Alexey Prokhorov
16f2702495
Apply resolveURL when set a location of a window opened by window.open()
2016-08-16 16:24:49 +05:00
Samuel Attard
5b07e8dd5b
Send isMainFrame as argument to did-navigate-in-page event
2016-08-12 01:27:50 +10:00
Cheng Zhao
8c0a033b6f
Fix lint errors of using __proto__
2016-08-02 21:02:28 +09:00
Cheng Zhao
6e0cde5b24
All native objects have prototype now
2016-08-02 17:12:17 +09:00
Samuel Attard
e4f6083753
Implement asynchronous versions of getZoomFactor and GetZoomLevel on the webContents object
2016-08-02 13:02:55 +10:00
Cheng Zhao
9ddb62c42a
Use Buffer.from instead of deprecated new Buffer
2016-07-25 16:40:22 +09:00
Cheng Zhao
1c9421bc89
Use ArrayBuffer.isView to detect Buffer and ArrayBuffer
2016-07-25 16:39:09 +09:00
haad
fac330fb50
Fix TypedArray check, add check when instanceof doesn't work for TypedArrays.
2016-07-23 12:43:49 +01:00
haad
c717cd9192
🐛 Add support for TypedArrays in IPC.
...
Fixes https://github.com/electron/electron/issues/2104 .
2016-07-22 19:44:19 +01:00
Kevin Sawicki
fa36d2e8c6
Add standard edit items to text context menus
2016-07-12 11:54:45 -07:00
Kevin Sawicki
63b98b1ea0
Use const instead of var
2016-07-12 11:31:40 -07:00
Kevin Sawicki
00f82aaffe
Only check arrays and objects for cycles
2016-07-11 10:39:45 -07:00
Kevin Sawicki
564b0cace5
Maintain visted objects as a stack for cycle detection
2016-07-11 10:33:13 -07:00
Kevin Sawicki
5da0b856f9
Call includes directly on visited array
2016-07-11 10:33:13 -07:00
Kevin Sawicki
2cc2b8a146
Return empty array for circular references
2016-07-11 10:33:04 -07:00
Cheng Zhao
bbfdaf7679
Merge pull request #6355 from electron/webview-capture-page
...
Add <webview>.capturePage([rect,] callback)
2016-07-07 10:09:40 +09:00
Kevin Sawicki
a9b43a0fc9
Use empty string constructor name when missing
2016-07-06 13:06:48 -07:00
Kevin Sawicki
f7b72f0948
Move capturePage to WebContents
2016-07-06 09:21:28 -07:00
Kevin Sawicki
d67dfd09fd
Pass through empty constructor names
2016-07-06 09:18:20 -07:00
Maksim
b444b35215
Update remote.js
2016-07-06 09:11:04 -07:00
Kevin Sawicki
d2d11ce8bd
Invoke callback instead of returning
2016-06-28 13:04:59 -07:00
Ian Ornelas
d6ab353438
Add chrome.storage.local
2016-06-28 07:21:03 -03:00
Jhen
233355ed09
Fix chrome.runtime.sendMessage
...
add a case of not provide extension-id: (message, responseCallback)
2016-06-23 07:40:15 +08:00
gellert
3d010a8988
fixes transformed webview size
2016-06-19 00:41:42 +02:00
Kevin Sawicki
65abaee299
Forward will/did navigate events to extensions
2016-06-16 12:07:59 -07:00
Kevin Sawicki
567622c126
Drop unneeded .js extensions
2016-06-16 09:52:14 -07:00
Kevin Sawicki
3aecb11094
Extract Event clas to own file
2016-06-16 09:51:54 -07:00
Kevin Sawicki
7f9fa92e2d
Add chrome.webNavigation stubs
2016-06-16 09:46:26 -07:00
Cheng Zhao
18a38dbfc1
Fix exception in alert for inavlid parameter
2016-06-14 15:22:01 +09:00
Jessica Lord
c68ca16148
Merge pull request #5974 from electron/chrome-storage-sync
...
Add chrome.storage.sync and chrome.storage.get APIs
2016-06-10 12:20:03 -07:00
Jessica Lord
39e6081a00
🔥 line
2016-06-10 09:59:47 -07:00
Cheng Zhao
4373dc1eac
Merge pull request #5972 from electron/non-writeable-guest-id
...
Make guestId on BrowserWindowProxy non-writeable
2016-06-10 12:02:07 +00:00
Jessica Lord
ede3dbd201
🚿 Lint
2016-06-09 16:39:24 -07:00
Jessica Lord
f121f46a24
Merge branch 'master' into chrome-storage-sync
2016-06-09 16:35:00 -07:00
Jessica Lord
dc10568917
Handle the three get cases
2016-06-09 16:26:42 -07:00
Kevin Sawicki
2efc913222
Remove standard lint warnings
2016-06-09 14:17:54 -07:00
Jessica Lord
41d6ddd588
Add storage file
2016-06-09 14:14:14 -07:00
Kevin Sawicki
01f96fe6af
Default locale to en
2016-06-09 14:00:53 -07:00
Kevin Sawicki
9f64c39f8c
Remove lint warnings
2016-06-09 13:57:08 -07:00
Kevin Sawicki
2367cd574e
Cache extension metadata
2016-06-09 13:57:08 -07:00
Kevin Sawicki
ea9d2dadf8
Add fixme for sync ipc
2016-06-09 13:57:08 -07:00
Kevin Sawicki
d4925e6226
Add initial support for placeholders and substitutions
2016-06-09 13:57:08 -07:00
Kevin Sawicki
d54de73e03
🎨
2016-06-09 13:57:08 -07:00
Kevin Sawicki
84960af793
Add initial chrome.i18n.getMessage API
2016-06-09 13:57:08 -07:00
Kevin Sawicki
2f93735909
Make BrowserWindowProxy guestId non-writeable
2016-06-09 13:41:42 -07:00
Kevin Sawicki
4f0a52628e
Add showDefinitionForSelection to webContents/webview
2016-06-08 10:15:36 -07:00
Kevin Sawicki
cd2041375b
Add missing A in constant name
2016-06-07 16:31:16 -07:00
Kevin Sawicki
ca6e3ed1ef
Add webview support for disabled blink features
2016-06-07 13:49:31 -07:00
Cheng Zhao
3c873736d7
Add update-target-url event
2016-06-07 15:56:19 +09:00
Kevin Sawicki
61ce19ba7e
Set chrome.runtime.id
2016-06-06 14:42:07 -07:00
Cheng Zhao
9f0fc96025
Merge pull request #5711 from electron/extension-code-cleanup
...
Implement partial chrome.* API for devtools extension
2016-05-29 23:29:08 +00:00
Cheng Zhao
de001a9bbf
Use meaningful name for extensionId
2016-05-29 11:57:20 +09:00
Cheng Zhao
ec1944c146
Implement chrome.tab.onCreated/onRemoved APIs
2016-05-29 11:50:14 +09:00
Cheng Zhao
2431d886bf
Current handle sender.tab for background pages
2016-05-29 10:46:48 +09:00
Cheng Zhao
f693b042b5
Fix js lint warnings
2016-05-28 22:46:15 +09:00
Cheng Zhao
30dca2b4e1
Pages in chrome extension should not have node integration
2016-05-28 21:46:53 +09:00
Cheng Zhao
9ed4730cba
Pass sender for chrome.runtime.onMessage
2016-05-28 21:45:23 +09:00
Cheng Zhao
5eb9ed1729
Implement chrome.tabs.sendMessage
2016-05-28 21:35:07 +09:00
Cheng Zhao
62fb4f9820
Implement chrome.runtime.sendMessage
2016-05-28 21:23:43 +09:00
Cheng Zhao
ba315248e0
Use ipcRenderer.sendTo to get rid of routers in main process
2016-05-28 21:13:00 +09:00
Cheng Zhao
ae1f442b02
Add ipcRenderer.sendTo
2016-05-28 20:50:28 +09:00
Cheng Zhao
d55b96fdf5
Clean up the Chrome API implementation code
2016-05-28 20:33:18 +09:00
Cheng Zhao
31628abadc
Implement chrome.tabs.executeScript
2016-05-28 16:41:12 +09:00
Cheng Zhao
db94121360
Implement port.sender
2016-05-28 16:01:16 +09:00
Cheng Zhao
f5b430d9e1
Inject chrome.* to content scripts
2016-05-28 15:37:44 +09:00
Cheng Zhao
d8db695712
Handle port disconnecting
2016-05-28 12:07:08 +09:00
Cheng Zhao
e76c36a9a8
Make simple runtime.connect work
2016-05-28 10:26:41 +09:00
Kevin Sawicki
84f6015037
Call print on webContents
2016-05-27 11:11:55 -07:00
Felix Rieseberg
fa7f084625
📠 Add print() to BrowserWindowProxy
...
Closes #5685
2016-05-27 11:11:19 -07:00
Cheng Zhao
c1facec5a6
No need to hijack setInjectedScriptForOrigin
2016-05-27 15:12:49 +09:00
Cheng Zhao
7e1f159185
Run content scripts at correct phase
2016-05-27 11:12:51 +09:00
Cheng Zhao
49d9446cce
Implement a simple content script injector
2016-05-27 10:29:57 +09:00
Cheng Zhao
93b8237e1f
Merge pull request #5700 from felixrieseberg/standard-7
...
Implement JavaScript Standard Style 7
2016-05-26 04:57:36 +00:00
Cheng Zhao
8a4b7eb062
Merge pull request #5689 from cdaringe/master
...
Support non-native promises
2016-05-26 04:49:40 +00:00
Felix Rieseberg
bef6748c06
🎨 Implement JS Standard Code Style 7
...
Updates Standard Code Style to 7 (latest major) and ensures that code
is conform.
* camelCase is now enforced
* No assignments in return statements
2016-05-25 16:20:49 -07:00
Kevin Sawicki
583bb49f6c
Get hidden state by using parent window directly
2016-05-25 10:13:12 -07:00
Kevin Sawicki
73b07f76a3
Support document visiblity state and events in webviews
2016-05-25 09:12:52 -07:00
cdaringe
32073fa079
🎨 Support non-native promises
2016-05-25 10:11:18 -06:00
Cheng Zhao
28e2058ff1
Merge pull request #5648 from electron/chrome51
...
Update to Chrome 51
2016-05-24 10:59:11 +00:00
Kevin Sawicki
7929daa48c
Pass both callback values to then
2016-05-23 15:07:01 -07:00
Cheng Zhao
9d82041923
Fix js lint warnings
2016-05-23 16:15:39 +09:00
Cheng Zhao
d6f9e57e33
Fix chrome.devtools not available in devtools extensions
2016-05-23 16:04:37 +09:00
Cheng Zhao
8ac93e02c6
Merge pull request #5616 from electron/inherit-zoom
...
Inherit zoomFactor in webview
2016-05-20 00:27:06 +00:00
Kevin Sawicki
cc7395eea8
Remove returns from event listeners
2016-05-19 15:28:08 -07:00
Kevin Sawicki
4754e4aabb
Add zoomFactor to guest params
2016-05-19 14:32:16 -07:00
Kevin Sawicki
fef2f789cd
🎨
2016-05-19 14:30:53 -07:00
Bruno Queiros
046cb0df8d
🎨 Use the same stack trace for both cases
2016-05-18 19:02:42 -03:00
Bruno Queiros
06e3e65c1b
🎨 Improve error message
2016-05-18 11:00:08 -03:00
Cheng Zhao
87c10b3ac2
Make non-public module accesible via remote
2016-05-18 13:57:48 +09:00
Cheng Zhao
c1399f9bdc
Disable webview when nodeIntegration is off
2016-05-17 16:51:06 +09:00
Cheng Zhao
49ac160ff7
Move createIDWeakMap to v8Util
2016-05-11 19:30:06 +09:00
Cheng Zhao
04d59991b0
Use create function instead of IDWeakMap constructor
2016-05-11 16:15:32 +09:00
Kevin Sawicki
2ce4237083
Remove hideInternalModules API
2016-05-06 10:12:54 -07:00
Kevin Sawicki
d988cae16d
Remove deprecated ipc module
2016-05-06 10:12:53 -07:00
Kevin Sawicki
0342db9328
Remove hyphenated options
2016-05-06 10:12:53 -07:00
Kevin Sawicki
dae68be2ce
Remove deprecated APIs
2016-05-06 10:12:53 -07:00
Cheng Zhao
06cf0406fe
Dereference remote objects with native code
...
Previously we rely on the v8util.setDestructor to dereference the remote
objects in JavaScript, however as documented in V8, it is forbidden to
call V8 APIs in object's destructor (e.g. the weak callback), and doing
so would result in crashs.
This commit removes the JavaScript setDestructor method, and avoids
doing the dereference work with V8.
2016-04-26 16:16:22 +09:00
Cheng Zhao
aa29dc0c8a
Merge pull request #5199 from Mr0grog/5183-disambiguate-loading-from-main-frame-loading
...
Add `isLoadingMainFrame()` to WebContents
2016-04-20 20:49:56 +09:00
Cheng Zhao
ff1b7d18f6
Cleanup the code determining value's type
2016-04-20 14:26:49 +09:00
Rob Brackett
64a84dee3b
Add isLoadingMainFrame
method to WebContents.
...
Also switch `webContents.executeJavaScript` to check it instead of `isLoading`.
There doesn’t seem to be a reasonable public way to get this information out of Chromium, so it’s synthesized here based on WebContentsObserver callbacks.
Fixes #5183 .
2016-04-18 10:37:08 -07:00
Cheng Zhao
31eb793fb0
Avoid adding a new option to webPreferences
2016-04-14 10:50:07 +09:00
Cheng Zhao
8f0e594007
Fix lint warnings
2016-04-13 23:10:31 +09:00
Cheng Zhao
43c44da50b
Correctly set initial visibilityState
2016-04-13 23:07:28 +09:00
Cheng Zhao
07a4c52919
Reduces the IPC messages used for visibilityState
2016-04-13 21:36:43 +09:00