trop[bot]
3fb81955bb
fix(reland): allow disabling all NSMenuItems ( #48830 )
...
* fix: allow disabling all `NSMenuItems` (#48598 )
fix: allow disabling all NSMenuItems
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: add guard for type
Co-authored-by: George Xu <george.xu@slack-corp.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: George Xu <george.xu@slack-corp.com>
2025-11-07 10:36:49 +01:00
trop[bot]
81332eaf65
fix: revert allow disabling all NSMenuItems, fix menu crash ( #48800 )
...
Revert "fix: allow disabling all `NSMenuItems` (#48598 )"
This reverts commit 0cb4fdd0f2ae28d7bf3cd753cd2b641947e637aa.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
2025-11-05 20:27:43 -08:00
trop[bot]
f404955dc8
refactor: remove redundant map lookups in browser/api/menu.ts ( #48731 )
...
perf: avoid double map lookup in Menu.prototype._shouldCommandIdWorkWhenHidden
perf: avoid double map lookup in Menu.prototype._isCommandIdVisible
perf: avoid double map lookup in Menu.prototype._shouldRegisterAcceleratorForCommandId
perf: avoid double map lookup in Menu.prototype._getSharingItemForCommandId
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-10-30 09:43:01 -04:00
trop[bot]
eb0f7e6dbf
fix: allow disabling all NSMenuItems ( #48711 )
...
fix: allow disabling all NSMenuItems
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-10-28 13:20:17 -05:00
Gellert Hegyi
b9b96a96f7
feat: add menu item role palette and header ( #45538 )
...
* feat: add menu item role `palette` and `header`
* adds comments
* refactors new role items to new item types
* docs: custom type
* docs: note types only available on mac 14+
---------
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
2025-05-23 12:43:49 -04:00
Samuel Attard
49aba471dc
feat: add support for associating a Menu with a WebFrameMain ( #45138 )
...
* feat: add support for associating a Menu with a WebFrameMain
This allows certain OS level features to activate such as Writing Tools, Autofill.. and Services.
There appears to be a bug in macOS where the responder chain isn't traversed if the menu is not popped up using an event, as such we spoof a fake mouse event at the write coordinates in the right window and use that to open the menu.
* build: fix build on non-mac
* build: oops missed a header
* fix: safely handle optional T* by checking nullptr too
* build: fix gn check and build errors
* docs: suggested changes
* feat: default `frame` to `window.webContents.mainFrame` when possible
* fix: avoid deref nullptr view
* Revert "feat: default `frame` to `window.webContents.mainFrame` when possible"
This reverts commit 2e888368199317d67f6ad931a7e9eff0295c4b1b.
* fix: lint
* Remove redundant scoped objects
This code, including the comments, matches almost exactly the behavior of this argument to the function.
* Add ScopedPumpMessagesInPrivateModes patch
* More null pointer safety
---------
Co-authored-by: clavin <clavin@electronjs.org>
2025-03-28 11:50:07 -07:00
Samuel Attard
122685194a
build: add import/order eslint rule ( #44085 )
...
* build: add import/order eslint rule
* chore: run lint:js --fix
2024-10-02 19:10:44 -07:00
Shelley Vohr
50ce448556
fix: menu should allow focused BaseWindow where possible ( #43404 )
...
fix: menu should allow focused BaseWindow
2024-08-22 14:13:30 -04:00
Milan Burda
0b0707145b
refactor: replace .forEach() with for-of ( #39691 )
...
* refactor: replace `.forEach()` with `for-of`
* refactor docs/fiddles/features/web-hid/renderer.js
2023-08-31 23:36:43 +09:00
Milan Burda
2c52eb7e1c
refactor: replace .indexOf() with .includes() ( #39195 )
2023-07-24 12:32:54 +02:00
Samuel Attard
499d893040
feat: add support for keyboard initialized menu popup ( #38903 )
...
* feat: add support for keyboard initialized menu popup
* Update docs/api/menu.md
Co-authored-by: Erick Zhao <erick@hotmail.ca>
* fix: add patch to chromium for keyboard accessibility menu behavior
* refactor: s/initiatedByKeyboard/sourceType
* fix: ignore initial mouse event to retain keyboard initiated focus
* Update docs/api/menu.md
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca>
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
2023-06-29 15:54:06 -07:00
Milan Burda
607e71d563
refactor: replace Object.prototype.hasOwnProperty() with Object.hasOwn() ( #38929 )
2023-06-27 16:57:33 -04:00
David Sanders
98cd16d336
chore: fix typos ( #34731 )
2022-07-05 11:49:56 -04:00
Milan Burda
8d0ed05c99
refactor: replace a few usages of V8 hidden properties ( #29400 )
2021-06-03 14:59:56 +09:00
Tabish Mahfuz
5ceec9189e
fix: Menu.setApplicationMenu can return a useless array 29088 ( #29118 )
2021-05-12 12:02:30 -07:00
Milan Burda
79b3393768
chore: remove bunch of usages of any ( #27512 )
2021-01-29 12:41:59 -08:00
Cheng Zhao
bb3fb548d8
feat: add APIs to enable/disable spell checker ( #26276 )
...
* feat: add APIs to enable/disable bulitin spell checker
* feat: add togglespellchecker menu item role
2020-11-11 10:29:18 -05:00
Cheng Zhao
6b6ffbdd10
feat: add support for share menu on macOS ( #25629 )
2020-10-19 18:33:06 -07:00
Samuel Attard
3503d3745b
fix: order menu items before filtering excess separators ( #25563 )
2020-09-23 10:39:08 -07:00
Samuel Attard
b02748e607
build: ensure that electron/lib/browser can only use browser or common imports ( #24512 )
...
* build: ensure that electron/lib/browser can only use browser or common imports
* chore: fix linting
2020-07-13 09:58:49 -07:00
Jeremy Rose
71a7e1b2e3
chore: tsify menu ( #24358 )
2020-07-06 13:24:54 -07:00
