Kevin Sawicki
|
82ac4ddf19
|
Large is only 48x48 on Linux
|
2017-02-07 11:20:27 -08:00 |
|
Kevin Sawicki
|
fc1b7431c7
|
Tweak optional syntax
|
2017-02-07 10:35:31 -08:00 |
|
Kevin Sawicki
|
a4277bb616
|
Document sizes
|
2017-02-07 10:33:44 -08:00 |
|
Kevin Sawicki
|
dddc6aec49
|
Tweak spec descriptions
|
2017-02-07 10:21:20 -08:00 |
|
Kevin Sawicki
|
683a758dab
|
Call done instead of skip
|
2017-02-07 10:16:09 -08:00 |
|
Kevin Sawicki
|
ee66776450
|
Update IconManager for Chrome 56 upgrade
|
2017-02-07 10:15:46 -08:00 |
|
Yury Solovyov
|
a9dae243b4
|
Fix large icon spec
|
2017-02-07 09:55:18 -08:00 |
|
Yury Solovyov
|
c810e64fda
|
Fix doc lint
|
2017-02-07 09:55:18 -08:00 |
|
Yury Solovyov
|
bcf0964c61
|
Fix more review
|
2017-02-07 09:55:18 -08:00 |
|
Yury Solovyov
|
2b60df3d8b
|
Fix some feedback
|
2017-02-07 09:55:18 -08:00 |
|
Yury Solovyov
|
29452364f3
|
Use isolate() method to get isolate
|
2017-02-07 09:54:22 -08:00 |
|
Yury Solovyov
|
c36cdb8580
|
Properly skip large size test on macOS
|
2017-02-07 09:54:22 -08:00 |
|
Yury Solovyov
|
1aa4fcae08
|
Lint tests
|
2017-02-07 09:54:22 -08:00 |
|
Yury Solovyov
|
00748889f9
|
Add tests
|
2017-02-07 09:54:22 -08:00 |
|
Yury Solovyov
|
c2bf5bb986
|
Put locker and handle scope to the top of the function. Remove unneeded header
|
2017-02-07 09:53:34 -08:00 |
|
Yury Solovyov
|
11ef2c539b
|
Update docs
|
2017-02-07 09:53:34 -08:00 |
|
Yury Solovyov
|
5794138ed4
|
Normalize path
|
2017-02-07 09:53:34 -08:00 |
|
Yury
|
1b4ee6e0d8
|
Image from icon node-style callback (#2)
* Try implementing node-style callbacks
* Add locker and handle scope
|
2017-02-07 09:53:34 -08:00 |
|
deepak1556
|
2e85ff1f57
|
Fix code style
|
2017-02-07 09:53:34 -08:00 |
|
Yury Solovyov
|
3d47c9b71d
|
Fix lint
|
2017-02-07 09:53:34 -08:00 |
|
Yury Solovyov
|
fe99b255c4
|
Add docs
|
2017-02-07 09:53:34 -08:00 |
|
Yury Solovyov
|
05cb26a174
|
Use object for options
|
2017-02-07 09:53:34 -08:00 |
|
Yury Solovyov
|
bec671bac8
|
Make size optional
|
2017-02-07 09:52:11 -08:00 |
|
deepak1556
|
ff3aaa55f7
|
define icon loader for liunx as separate target
|
2017-02-07 09:52:11 -08:00 |
|
Robo
|
b25b141642
|
create iconmanager as singleton class and cleanup code (#1)
* create iconmanager as singleton class and cleanup code
|
2017-02-07 09:52:11 -08:00 |
|
Yury Solovyov
|
1b3cd87fc9
|
Add icon manager to browser process
|
2017-02-07 09:50:17 -08:00 |
|
Yury Solovyov
|
602aba8723
|
Include proper header
|
2017-02-07 09:48:12 -08:00 |
|
Yury Solovyov
|
eb889b9b86
|
Get it compiling, linking till fails though
|
2017-02-07 09:48:12 -08:00 |
|
Yury Solovyov
|
d118fed5c2
|
Try my own class
|
2017-02-07 09:48:12 -08:00 |
|
Yury Solovyov
|
8e4ed664d9
|
Add icon fetching sources
|
2017-02-07 09:48:12 -08:00 |
|
Yury Solovyov
|
1d24a3a175
|
Add callback converters
|
2017-02-07 09:48:12 -08:00 |
|
Yury Solovyov
|
be5b907179
|
WIP
|
2017-02-07 09:48:12 -08:00 |
|
Kevin Sawicki
|
0f98c9d3fb
|
Use at least OS version checks
|
2017-02-07 09:32:40 -08:00 |
|
Kevin Sawicki
|
c3c5470a7c
|
Merge pull request #8542 from yamgent/webpref-numeric
Fix webpreferences not accepting numeric options
|
2017-02-07 09:15:55 -08:00 |
|
Kevin Sawicki
|
4de637779b
|
Make int converter helper an instance method
|
2017-02-07 09:13:42 -08:00 |
|
Tan Wang Leng
|
7ec88d16a6
|
Use base::StringToInt() instead of std::stringstream
|
2017-02-07 09:05:55 -08:00 |
|
Tan Wang Leng
|
42f65c52fb
|
🐛 Fix webpreferences not accepting numeric options
The webpreferences attribute values are parsed as strings instead
of numbers. Therefore, a conversion is required.
|
2017-02-07 09:05:55 -08:00 |
|
Cheng Zhao
|
84c180ac69
|
Simplify the trick used for referencing symbols
|
2017-02-07 17:09:43 +09:00 |
|
Kevin Sawicki
|
852519a826
|
Bump v1.6.0
|
2017-02-06 16:42:00 -08:00 |
|
Kevin Sawicki
|
e6fe2a93f2
|
Merge pull request #8607 from electron/fix-win32-link
Fix missing of symbols when linking win32 build
|
2017-02-06 16:41:22 -08:00 |
|
Cheng Zhao
|
85e84cc0da
|
Fix missing of symbols when linking win32 build
|
2017-02-07 09:14:50 +09:00 |
|
Kevin Sawicki
|
a2ecef26a2
|
Merge pull request #8606 from electron/fix-broken-link
Fix broken Squirrel.Windows link
|
2017-02-06 16:01:40 -08:00 |
|
Charlie Hess
|
a35424ef25
|
Fix broken Squirrel.Windows link.
|
2017-02-06 15:54:05 -08:00 |
|
Jacob Groundwater
|
b8e12a0d21
|
Update ISSUE_TEMPLATE.md
|
2017-02-06 14:57:04 -08:00 |
|
Kevin Sawicki
|
8359c72347
|
Merge pull request #8501 from electron/chrome56
Upgrade to Chrome 56
|
2017-02-06 11:17:20 -08:00 |
|
Kevin Sawicki
|
dbb81e34e8
|
Upgrade node for modules version bump
|
2017-02-06 10:34:30 -08:00 |
|
Kevin Sawicki
|
997799ad68
|
Update libcc to e0da1e9
|
2017-02-06 10:34:30 -08:00 |
|
Cheng Zhao
|
ec650b3773
|
Update to Chrome 56.0.2924.87
|
2017-02-06 10:34:30 -08:00 |
|
Cheng Zhao
|
864a23f72b
|
Fix print() not working
|
2017-02-06 10:34:30 -08:00 |
|
Cheng Zhao
|
86215d4300
|
Allow filter to use any scheme
|
2017-02-06 10:34:30 -08:00 |
|