electron

Author	SHA1	Message	Date
Shelley Vohr	3392d9a2e7	fix: all children showing when showing child window (#40062 )	2023-10-05 09:19:57 -04:00
Shelley Vohr	b0590b6ee8	fix: failing build with `enable_electron_extensions=false` (#40032 ) * fix: ENABLE_EXTENSIONS -> ENABLE_ELECTRON_EXTENSIONS * fix: extension guard fixes * chore: fix linker errors	2023-10-04 10:40:01 +02:00
Shelley Vohr	713d8c4167	feat: add `tabbingIdentifier` property to `BrowserWindow` (#39980 ) feat: add tabbingIdentifier property to BrowserWindow	2023-10-03 12:27:40 -07:00
Milan Burda	04b2ba84cd	refactor: replace remaining `NULL` with `nullptr` (#40053 ) refactor: use nullptr everywhere	2023-10-03 12:26:35 -07:00
electron-roller[bot]	9d0e6d09f0	chore: bump chromium to 119.0.6043.0 (main) (#40045 ) * chore: bump chromium in DEPS to 119.0.6036.0 * chore: bump chromium in DEPS to 119.0.6037.0 * chore: bump chromium in DEPS to 119.0.6039.0 * chore: bump chromium in DEPS to 119.0.6041.0 * chore: update chromium patches * 4765230: Move //content/browser/renderer_host/event_with_latency_info.h to //content/common/input \| https://chromium-review.googlesource.com/c/chromium/src/+/4765230 * 4890325: ScopedRunLoopTimeout: add custom timeout callback handler for testing \| https://chromium-review.googlesource.com/c/chromium/src/+/4890325 * chore: update all patches * chore: bump chromium in DEPS to 119.0.6043.0 * 4898682: [api] Add Error.cause to V8 API https://chromium-review.googlesource.com/c/v8/v8/+/4898682 * 4837192: Plumb origin through for drags. https://chromium-review.googlesource.com/c/chromium/src/+/4837192 * Prevent content analysis on web pages that don't accept drag and drop. https://chromium-review.googlesource.com/c/chromium/src/+/4814086 * Make getting displayed notifications work with notification attribution. https://chromium-review.googlesource.com/c/chromium/src/+/4738935 * 4898682: [api] Add Error.cause to V8 API https://chromium-review.googlesource.com/c/v8/v8/+/4898682 * lib,test: do not hardcode Buffer.kMaxLength https://github.com/nodejs/node/pull/49876 * chore: remove Goma warning from mksnapshot_args * 4776412: Remove Windows-specific wstring variants of StringPrintf() etc. https://chromium-review.googlesource.com/c/chromium/src/+/4776412 * [dPWA] Prevent WebAppInstallInfo from being included on Android https://chromium-review.googlesource.com/c/chromium/src/+/4886594 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: VerteDinde <vertedinde@electronjs.org> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>	2023-10-02 18:01:07 -04:00
Milan Burda	d301616f60	chore: remove deprecated `app.runningUnderRosettaTranslation()` (#39956 )	2023-10-02 10:55:32 +02:00
Shelley Vohr	5643e86956	chore: update extensions url handling to match upstream (#40038 ) - https://chromium-review.googlesource.com/c/chromium/src/+/4772028 - https://chromium-review.googlesource.com/c/chromium/src/+/4264656 - https://chromium-review.googlesource.com/c/chromium/src/+/4712150	2023-10-02 10:35:00 +02:00
electron-roller[bot]	d6c8ff2e70	chore: bump chromium to 119.0.6029.0 (main) (#39944 ) * chore: bump chromium in DEPS to 119.0.6021.0 * 4727729: Initial ScreenCaptureKit AudioInputStream implementation https://chromium-review.googlesource.com/c/chromium/src/+/4727729 * chore: fixup patch indices * chore: bump chromium in DEPS to 119.0.6023.0 * 4875713: mac: Switch to Xcode 15.0 15A240d with macOS SDK 14.0 23A334 https://chromium-review.googlesource.com/c/chromium/src/+/4875713 * 4831380: [task-attribution] Reland: Move to an implicit GCed task container model https://chromium-review.googlesource.com/c/chromium/src/+/4831380 * 4877868: Remove all gitignore entries for submodules https://chromium-review.googlesource.com/c/chromium/src/+/4877868 * 4824705: Set origin to commit for data: URLs https://chromium-review.googlesource.com/c/chromium/src/+/4824705 * chore: fixup patch indices * 4881382: Expose selection in WebFormControlElement as unsigned https://chromium-review.googlesource.com/c/chromium/src/+/4881382 * 4874216: Portals: Cancel drag-drop in predecessor before activation https://chromium-review.googlesource.com/c/chromium/src/+/4874216 * chore: bump chromium in DEPS to 119.0.6025.0 * chore: bump chromium in DEPS to 119.0.6027.0 * 4884489: Update gitignore to be explicit about directories https://chromium-review.googlesource.com/c/chromium/src/+/4884489 * 4881091: Add debug info about owner document's origin when inheriting https://chromium-review.googlesource.com/c/chromium/src/+/4881091 * chore: fixup patch indices * chore: bump chromium in DEPS to 119.0.6029.0 * chore: update patches * 4881091: Add debug info about owner document's origin when inheriting Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4881091 * 4831380: [task-attribution] Reland: Move to an implicit GCed task container model Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4831380 * 4866732: Extract document.title for installable checks Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4866732 * chore: link to crbug in message port test --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>	2023-09-28 22:26:41 -07:00
ILikeTeaALot	d002f16157	feat: `systemPreferences.getColor` should return RGBA instead of RGB (#38960 ) * fix: return RGBA hex value from `SystemPreferences.getColor` * docs: update docs to match changes of last commit * fix: GetColor on windows now returns RGBA too * fix: update tests for getColor RGBA on Windows --------- Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>	2023-09-28 18:56:16 -04:00
Bruno Pitrus	dd7395ebed	chore: add missing include for std::variant (#40007 )	2023-09-28 12:50:58 -04:00
Bruno Pitrus	e3e793d25b	chore: remove invalid constexpr qualification (#40006 ) GetPathConstant calls base::internal::flat_tree<Key, GetKeyFromValue, KeyCompare, Container>::find(Key const&) const which is not constexpr. GCC 12 and earlier raise a compile error on this.	2023-09-28 12:49:09 -04:00
Cheng Zhao	4cf6884dd4	fix: detect screen readers by testing their existences (#39988 )	2023-09-28 11:17:42 -04:00
marekharanczyk	94585f5889	fix: propagate layout call to all children of `InspectableWebContentsViewViews` (#39994 ) Propagate layout call to all children of InspectableWebContentsViewViews. When BrowserView bounds are set from js, those might not trigger layout immediately, sometimes propagating InvalidateLayout call to parent. View is marked as needing layout, expecting to receive it from parent on next layout call. The problem is that BrowserView's view is added as child of InspectableWebContentsViews which does not call setBounds (which would trigger layout) on all of it's children when doing it's layout, so it skips propagating Layout call to its children BrowserViews views, even though those were marked as needing layout. Call base class View::Layout which will iterate over views' children and call Layout on those that were marked as needing them. Fixes #39993.	2023-09-28 11:17:21 -04:00
Tomasz	689d1b76de	feat: add middle click event to tray (#39926 ) Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>	2023-09-27 14:21:15 -04:00
Robert Günzler	480f48b2fc	feat: enable dark mode on GTK UIs (#38977 ) feat: port DarkModeManagerLinux This is needed after https://bugs.chromium.org/p/chromium/issues/detail?id=998903 and replaces the previous workaround to detect dark mode on GTK. Detect system dark theme preference via xdg settings portal: https://flatpak.github.io/xdg-desktop-portal/#gdbus-org.freedesktop.portal.Settings Closes: https://github.com/electron/electron/issues/38961 Closes: https://github.com/electron/electron/issues/28838 Signed-off-by: Robert Günzler <r@gnzler.io> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>	2023-09-27 14:17:40 -04:00
Bruno Henrique da Silva	f943b8c940	fix: set window contents as opaque to decrease DWM GPU usage (#39895 ) * set window contents as opaque to decrease DWM GPU usage * chore: add more context to ShouldWindowContentsBeTransparent	2023-09-27 10:42:46 -04:00
Shelley Vohr	b7c9c895b5	build: fix with `enable_pdf_viewer = false` (#39990 ) build: fix with enable_pdf_viewer = false	2023-09-27 10:09:53 -04:00
Shelley Vohr	1ba321b733	fix: rounded corners on vibrant macOS modals (#39979 ) Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>	2023-09-27 15:12:37 +02:00
Cheng Zhao	ad57867594	fix: apply size constraints to NSWindow (#39975 )	2023-09-27 11:11:24 +02:00
michal-pichlinski-openfin	2190793fe6	fix: disable background throttling also in the `viz::DisplayScheduler` (#38924 ) * fix: disable background throttling also in the `viz::DisplayScheduler` `viz::DisplayScheduler` is responsible for drawing and swapping frames in the `DisplayScheduler::DrawAndSwap` which is called from the `DisplayScheduler::AttemptDrawAndSwap` if the `DisplayScheduler::ShouldDraw` returns true. `ShouldDraw` depends on the `DisplayScheduler` visibility and when it is not visible then it returns false. In order to keep producing frames, disabling `backgroundThrottling` should also prevent changing `DisplayScheduler` visibility to false. `DisplayScheduler` lives in the `ui::Compositor` where every `electron::NativewWindow` has its own `Compositor`. `electron::NativewWindow` may be host of the multiple `electron::api::WebContents` instances which may have different `WebPreferences` settings. Therefore if at least one of the `WebContents` requires disabling throttling then all other `WebContents` using the same window will have it disabled in the `ui::Compositor`. BREAKING CHANGE: `backgroundThrottling` set to false will disable frames throttling in the `BrowserWindow` for all `WebContents` displayed by it. Close: [#31016](https://github.com/electron/electron/issues/31016) * fixup! fix: disable background throttling also in the `viz::DisplayScheduler` * fixup! fix: disable background throttling also in the `viz::DisplayScheduler` * fixup! fix: disable background throttling also in the `viz::DisplayScheduler` --------- Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>	2023-09-26 16:00:46 -04:00
Milan Burda	d75a852743	refactor: use type enum in file stats for asar archive (#39889 )	2023-09-25 13:17:24 +02:00
Valentin Hăloiu	58fd8825d2	fix: add support for ELECTRON_OZONE_PLATFORM_HINT env var (#39792 ) Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>	2023-09-20 16:21:23 -04:00
Milan Burda	6a8b70639b	fix: `app.runningUnderARM64Translation()` always returning true on Windows ARM64 (#39920 ) fix: app.runningUnderARM64Translation() always returning true on ARM64	2023-09-20 16:15:19 -04:00
electron-roller[bot]	28eda03aba	chore: bump chromium to 119.0.6019.2 (main) (#39925 ) * chore: bump chromium in DEPS to 119.0.6018.4 * chore: update patches * chore: bump chromium in DEPS to 119.0.6019.2 * chore: update patches * 4876292: Roll libc++ from 7cee6b00d34a to 3e8a3b3c5d49 (6 revisions) https://chromium-review.googlesource.com/c/chromium/src/+/4876292 * 4851616: [Extensions] Enable matchOriginAsFallback for dynamic content scripts https://chromium-review.googlesource.com/c/chromium/src/+/4851616 * 4869393: [Extensions UserScripts] Add error messages for script matching errors https://chromium-review.googlesource.com/c/chromium/src/+/4869393 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>	2023-09-20 16:08:26 -04:00
George Xu	7685f27b31	feat: expose app accessibility transparency settings api (#39631 ) * feat: expose app accessibility transparency settings api * docs: fix typo * chore: add doc * change to property * add as property instead of method * chore: fix lint * rename function name in header --------- Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>	2023-09-20 12:48:02 -07:00
electron-roller[bot]	73e33bc876	chore: bump chromium to 119.0.6006.0 (main) (#39774 ) * chore: bump chromium in DEPS to 119.0.5994.0 * chore: update patches * Add some more debugging for navigation origin & process lock mismatch https://chromium-review.googlesource.com/c/chromium/src/+/4829483 * chore: bump chromium in DEPS to 119.0.5996.2 * chore: bump chromium in DEPS to 119.0.5997.0 * chore: bump chromium in DEPS to 119.0.6000.0 * chore: bump chromium in DEPS to 119.0.6002.0 * 4781766: Port remaining control color ids to the color pipeline https://chromium-review.googlesource.com/c/chromium/src/+/4781766 * 4846057: Preloading: Move prefetch_prefs to chrome/browser/preloading/ https://chromium-review.googlesource.com/c/chromium/src/+/4846057 * chore: fixup patch indices * 4848108: Pass v8::Isolate into FromV8Value calls on blink API https://chromium-review.googlesource.com/c/chromium/src/+/4848108 * 4834471: Reland "[api] allow v8::Data as internal field" https://chromium-review.googlesource.com/c/v8/v8/+/4834471 * 4808884: Major overhaul of ExceptionState in the v8 bindings https://chromium-review.googlesource.com/c/chromium/src/+/4808884 * 4791643: [sandbox] Add a TRUSTED_SPACE and TRUSTED_LO_SPACE to the V8 heap https://chromium-review.googlesource.com/c/v8/v8/+/4791643 * chore: bump chromium in DEPS to 119.0.6005.0 * 4776268: [v8][etw] Enables filtering of ETW tracing by URL https://chromium-review.googlesource.com/c/chromium/src/+/4776268 * chore: fixup patch indices * 4673258: WebSQL: Disable WebSQL by default https://chromium-review.googlesource.com/c/chromium/src/+/4673258 * chore: bump chromium in DEPS to 119.0.6006.0 * chore: update patches * 4854732: Reland^2 "[iterator-helpers] Unship due to incompat" https://chromium-review.googlesource.com/c/v8/v8/+/4854732 * 4794133: [AWC] Add `display-state` CSS @media feature https://chromium-review.googlesource.com/c/chromium/src/+/4794133 * fixup! Add some more debugging for navigation origin & process lock mismatch * Revert "fixup! Add some more debugging for navigation origin & process lock mismatch" This reverts commit 38fef075fc5690f7db6d4bbcabbe877a1618a964. * 4858437: Revert "[iOS] Delete GN flags for mach absolute time ticks" https://chromium-review.googlesource.com/c/chromium/src/+/4858437 * refactor: fix_crash_loading_non-standard_schemes_in_iframes.patch (#39879) * chore: 4869108: handle absolute and relative gn imports in autoninja https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4869108 * chore: set GOMA_DIR for autoninja * Revert "chore: 4869108: handle absolute and relative gn imports in autoninja" This reverts commit d94c7720bab96d1de25499383948da2cb8862d90. --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Robo <hop2deep@gmail.com>	2023-09-18 16:44:09 -04:00
Milan Burda	d7e4bb6608	chore: remove no-op `fullscreenWindowTitle` option (#39815 )	2023-09-19 01:55:47 +09:00
Milan Burda	fb6b92076e	fix: prevent `gin_helper::Locker` heap allocation (#39847 ) fix: prevent gin_helper::Locker heap allocation	2023-09-14 15:48:43 -04:00
Charles Kerr	f6e8a42c48	refactor: remove unused fields, methods in gin_helper::Locker (#39803 ) * refactor: remove unused field gin_helper::Locker::g_is_browser_process refactor: remove unused field gin_helper::Locker::g_is_renderer_process refactor: make field const gin_helper::Locker::locker_ * refactor: remove unused declaration gin_helper::Locker::new() refactor: remove unused declaration gin_helper::Locker::delete() * refactor: make field const electron::JavascriptEnvironment::locker_ * refactor: remove unused #include gin_helper/locker.h	2023-09-12 16:53:20 -07:00
Charles Kerr	a1c44a18e2	fix: NodeService order-of-destruction issue (#39783 ) * refactor: make ElectronRendererClient::node_bindings_ a const ptr refactor: make ElectronRendererClient::electron_bindings_ a const ptr * fix: order-of-destruction bug in NodeService js_env_ depends on the uv_loop from node_bindings_, but is destroyed after node_bindings_ * chore: revert unintentional commit	2023-09-12 12:27:14 +02:00
Shelley Vohr	ec9c8476fe	fix: `keyCode`s being incorrectly converted in `webContents.sendInputEvent()` (#39776 ) fix: sendInputEvent keyCodes being incorrectly converted	2023-09-12 11:28:45 +02:00
Samuel Attard	5bff0fe342	feat: add new ElectronSquirrelPreventDowngrades flag (#38625 ) * sketch * feat: add new ElectronSquirrelPreventDowngrades flag * test: remove only * chore: fix lint	2023-09-11 11:54:51 -07:00
Samuel Attard	16aec702b4	fix: ensure app load is limited to real asar files when appropriate (#39788 )	2023-09-11 11:51:14 -07:00
David Sanders	aceb432f45	chore: remove deprecated systemPreferences APIs (#39696 )	2023-09-11 11:34:13 -04:00
Calvin	d182794179	fix: frameless mica/acrylic windows (#39708 ) * fix: backgroundMaterial works with frameless * TODO: fix frameless mica/acrylic windows * update caption color appropriately * set background color properly * refactor translucency method * actualization	2023-09-11 14:51:54 +02:00
Shelley Vohr	ab185c058f	fix: fullscreen crashing with no roundedCorners and no frame (#39747 )	2023-09-11 09:38:10 +02:00
Charles Kerr	792037b338	fix: raw_ptr destruction order in NodeBindings (#39762 )	2023-09-07 18:25:17 -05:00
Samuel Attard	0b44f433c8	fix: make titlebar opaque while fullscreen (#39759 )	2023-09-07 15:55:17 -07:00
Shelley Vohr	75bad34131	fix: prevent errors when extensions listen for `chrome.tabs` events (#39729 ) * fix: prevent errors when extensions listen for chrome.tabs events * chore: mark events unsupported in Electron	2023-09-07 12:41:24 +02:00
Robo	0a064cece9	fix: devtools allow restoring saved dock state on Windows (#39734 ) * fix: devtools allow restoring saved dock state on Windows * chore: address feedback	2023-09-07 17:14:01 +09:00
electron-roller[bot]	d9ba26273a	chore: bump chromium to 118.0.5991.0 (main) (#39714 ) * chore: bump chromium in DEPS to 118.0.5982.0 * chore: bump chromium in DEPS to 118.0.5983.0 * chore: bump chromium in DEPS to 118.0.5985.0 * chore: bump chromium in DEPS to 118.0.5987.0 * chore: update v8 patches * chore: update chromium patches * chore: update patches * [PEPC] Add new structs to contain permission request data Refs https://chromium-review.googlesource.com/c/chromium/src/+/4756727 * Add ThumbnailCapturer interface Refs https://chromium-review.googlesource.com/c/chromium/src/+/4812256 * Reland "[ChromeRefresh2023] Update document pip windows for Chrome Refresh" Refs https://chromium-review.googlesource.com/c/chromium/src/+/4814275 * chore: bump chromium in DEPS to 118.0.5989.0 * chore: bump chromium in DEPS to 118.0.5991.0 * chore: update patches --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: deepak1556 <hop2deep@gmail.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>	2023-09-05 21:17:56 -04:00
David Sanders	c96bb9958f	chore: remove deprecated `webContents.getPrinters()` (#39663 )	2023-09-05 10:16:41 +02:00
Shelley Vohr	54d8402a6c	fix: broken `chrome.scripting` compilation (#39725 ) fix: broken chrome.scripting impl after roll	2023-09-04 16:03:10 +09:00
electron-roller[bot]	89117fdd99	chore: bump chromium to 118.0.5975.0 (main) (#39531 ) * chore: bump chromium in DEPS to 118.0.5951.0 * chore: update printing.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4727894 No logic changes, but patch needed to be manually re-applied due to upstream code shear * chore: update port_autofill_colors_to_the_color_pipeline.patch No manual changes; patch applied with fuzz * chore: update patches * chore: bump chromium in DEPS to 118.0.5953.0 * chore: update patches * chore: bump chromium in DEPS to 118.0.5955.0 * chore: update patches * chore: bump chromium in DEPS to 118.0.5957.0 * chore: update patches * chore: include path of native_web_keyboard_event.h Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4758689 * chore: remove reference to eextensions/browser/notification-types.h Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4771627 * chore: update references to renamed upstream field NativeWebKeyboardEvent.skip_if_unhandled (formerly known as skip_in_browser Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4758689 Need a second pair of eyes on this commit. In particular the reference in content_converter.cc, skipInBrowser, seems to not be set or documented anywhere? Is this unused/vestigal code? * chore: sync signature of ElectronExtensionsBrowserClient::IsValidContext() to upstream change Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4784198 * chore: add auto_pip_setting_helper.[cc,h] to chromium_src build Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4688277 Exiting upstream code used by chromium_src now depends on this new upstream class * chore: bump chromium in DEPS to 118.0.5959.0 * chore: update add_maximized_parameter_to_linuxui_getwindowframeprovider.patch Xref: add_maximized_parameter_to_linuxui_getwindowframeprovider.patch manually adjust patch to minor upstream chagnes * chore: update patches * chore: bump chromium in DEPS to 118.0.5961.0 * chore: bump chromium in DEPS to 118.0.5963.0 * chore: update patches * 4780994: Rename various base files to "apple" since iOS uses them too https://chromium-review.googlesource.com/c/chromium/src/+/4780994 * Many files moved from `mac` -> `apple` This commit follows a handful of CLs that simply rename files/symbols to change `mac` to `apple` to signify their use across both macOS and iOS: - 4784010: Move scoped_nsautorelease_pool to base/apple, leave a forwarding header - 4790744: Move foundation_util to base/apple, leave a forwarding header - 4790741: Move scoped_cftypreref to base/apple, leave a forwarding header - 4787627: Move and rename macOS+iOS base/ files in PA to "apple" - 4780399: Move OSStatus logging to base/apple - 4787387: Remove forwarding headers - 4781113: Rename message_pump_mac to "apple" because iOS uses it too * fixup minor patch update error A function param got dropped from this patch somewhere earlier * chore: bump chromium in DEPS to 118.0.5965.2 * chore: update patches * 4799213: Move ScopedTypeRef and ScopedCFTypeRef into base:🍎: https://chromium-review.googlesource.com/c/chromium/src/+/4799213 * Fix removed include to BrowserContext In crrev.com/c/4767962 an include to BrowserContext was removed, which was necessary for compilation. This broke only for us because "chrome/browser/profiles/profile.h" includes that class, but we remove all references to profiles. * chore: bump chromium in DEPS to 118.0.5967.0 * chore: update patches * chore: bump chromium in DEPS to 118.0.5969.0 * chore: update patches * chore: bump chromium in DEPS to 118.0.5971.0 * chore: bump chromium in DEPS to 118.0.5973.0 * chore: update patches * 4772121: [OOPIF PDF] Replace PDFWebContentsHelper with PDFDocumentHelper https://chromium-review.googlesource.com/c/chromium/src/+/4772121 * 4811164: [Extensions] Do some cleanup in ChromeManagementAPIDelegate. https://chromium-review.googlesource.com/c/chromium/src/+/4811164 * 4809488: Remove duplicate dnd functionality between Web and Renderer prefs https://chromium-review.googlesource.com/c/chromium/src/+/4809488 Given that this is no longer an option of web preferences, we should consider deprecating this option and then removing it. * chore: bump chromium in DEPS to 118.0.5975.0 * chore: update patches * fixup! chore: add auto_pip_settings_helper.{cc\|h} to chromium_src build * Reland "[windows] Remove RegKey::DeleteEmptyKey" Refs https://chromium-review.googlesource.com/c/chromium/src/+/4813255 * Ensure StrCat means StrCat Refs https://chromium-review.googlesource.com/c/chromium/src/+/1117180 * fixup! Remove RegKey::DeleteEmptyKey * Consistently reject large p and large q in DH Refs https://boringssl-review.googlesource.com/c/boringssl/+/62226 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: clavin <clavin@electronjs.org> Co-authored-by: deepak1556 <hop2deep@gmail.com>	2023-09-01 15:54:59 +09:00
Samuel Attard	ac031bf8de	feat: I guess it's esm (#37535 ) * fix: allow ESM loads from within ASAR files * fix: ensure that ESM entry points finish loading before app ready * fix: allow loading ESM entrypoints via default_app * fix: allow ESM loading for renderer preloads * docs: document current known limitations of esm * chore: add patches to support blending esm handlers * refactor: use SetDefersLoading instead of JoinAppCode in renderers Blink has it's own event loop so pumping the uv loop in the renderer is not enough, luckily in blink we can suspend the loading of the frame while we do additional work. * chore: add patch to expose SetDefersLoading * fix: use fileURLToPath instead of pathname * chore: update per PR feedback * fix: fs.exists/existsSync should never throw * fix: convert path to file url before importing * fix: oops * fix: oops * Update docs/tutorial/esm-limitations.md Co-authored-by: Jeremy Rose <jeremya@chromium.org> * windows... * windows... * chore: update patches * spec: fix tests and document empty body edge case * Apply suggestions from code review Co-authored-by: Daniel Scalzi <d_scalzi@yahoo.com> Co-authored-by: Jeremy Rose <jeremya@chromium.org> * spec: add tests for esm * spec: windows * chore: update per PR feedback * chore: update patches * Update shell/common/node_bindings.h Co-authored-by: Jeremy Rose <jeremya@chromium.org> * chore: update patches * rebase * use cjs loader by default for preload scripts * chore: fix lint * chore: update patches * chore: update patches * chore: fix patches * build: debug depshash * ? * Revert "build: debug depshash" This reverts commit 0de82523fb93f475226356b37418ce4b69acdcdf. * chore: allow electron as builtin protocol in esm loader * Revert "Revert "build: debug depshash"" This reverts commit ff86b1243ca6d05c9b3b38e0a6d717fb380343a4. * chore: fix esm doc * chore: update node patches --------- Co-authored-by: Jeremy Rose <jeremya@chromium.org> Co-authored-by: electron-patch-conflict-fixer[bot] <83340002+electron-patch-conflict-fixer[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Daniel Scalzi <d_scalzi@yahoo.com>	2023-08-30 17:38:07 -07:00
Shelley Vohr	f0ad357af2	feat: support `chrome.scripting` extension APIs (#39395 ) feat: support chrome.scripting extension APIs	2023-08-28 10:39:28 -04:00
Milan Burda	5078cae861	chore: remove deprecated `ipcRenderer.sendTo()` (#39087 ) chore: remove deprecated ipcRenderer.sendTo()	2023-08-28 10:29:27 -04:00
Shelley Vohr	f369b144d6	feat: add more extensions manifest key options (#39599 ) feat: add more manifest key options	2023-08-28 10:02:22 -04:00
wanted002	e14964ccd0	feat: add setter and getter apis to specify udp port range for webrtc (#39046 ) * feat:Add setter and getter apis to specify udp port range for webrtc (issue#9042) * lint error fix for PR#39046 * feat: add setter and getter apis to specify udp port range for webrtc (issue#9042) , changed for codereview * fix lint error * fix lint errors in file api-web-contents-spec.ts * feat: add setter and getter apis to specify udp port range for webrtc (issue#9042) , changed for review from itsananderson * feat: add setter and getter apis to specify udp port range for webrtc (issue#9042) , changed for review from jkleinsc * fix lint error * feat: add setter and getter apis to specify udp port range for webrtc (issue#9042) , changed for review from codebyter	2023-08-24 17:21:22 -04:00
Athul Iddya	33000c4b42	feat: enable WaylandWindowDecorations by default (#39582 )	2023-08-24 17:02:05 -04:00
Shelley Vohr	33e66b5cd0	fix: ensure windows respect fullscreenability with different resizability values (#39620 ) * fix: ensure child windows respect fullscreenability/resizability when parent is fullscreen * test: add an extra resize test	2023-08-24 16:54:08 -04:00
Charles Kerr	35969939a1	refactor: node::Environment self-cleanup (#39604 ) * chore: savepoint * chore: turn raw_ptr tests back off	2023-08-23 09:56:16 -04:00
Shelley Vohr	a8999bc529	fix: ensure `BrowserView` bounds are always relative to window (#39605 ) fix: ensure BrowserView bounds are always relative to window	2023-08-23 09:55:31 -04:00
Shelley Vohr	522bba3dc6	chore: cleanup arc migration helpers (#39606 )	2023-08-23 09:54:21 -04:00
Bruno Henrique da Silva	2481f94b4e	fix: instantiate tab video tracks from BrowserCaptureMediaStreamTrack (#39074 ) return BrowserCaptureMediaStreamTrack instead of MediaStreamTrack	2023-08-23 10:49:24 +02:00
Shelley Vohr	e1d63794e5	fix: `chrome.tabs` 'url' and 'title' are privileged information (#39595 ) fix: tabs url and title are privileged information	2023-08-22 14:56:58 +02:00
Milan Burda	c1898c39bf	chore: remove obsolete "simple" object annotations for the remote module (#39486 )	2023-08-22 13:43:30 +09:00
Charles Kerr	3a91d1f1e1	fix: dangling raw_ptr in ElectronBrowserMainParts dtor (#39539 ) * fix: dangling raw_ptr in ElectronBrowserMainParts dtor * fixup! fix: dangling raw_ptr in ElectronBrowserMainParts dtor Browser::WhenReady() holds a reference to JsEnv isolate so must come after	2023-08-21 10:29:25 +02:00
Milan Burda	09190085c0	refactor: add gin_helper::Dictionary::CreateEmpty() helper (#39547 )	2023-08-21 10:43:41 +09:00
tr2-harada	9937a2bbe8	fix: explorer restart does not recreated thumbnail toolbar buttons (#39551 ) fix: explorer restart does not recreated thumbnail toolbar buttons.	2023-08-21 09:43:49 +09:00
Athul Iddya	c75e193a3e	fix: use tiled edges to calculate frame inset sizes in Linux (#39523 ) Adapt to the window frame size calculation changes in CL 3970920 by setting the inset sizes to 0 for tiled edges.	2023-08-17 14:26:49 -04:00
Charles Kerr	213388cd87	refactor: prefer Sorted variant of MakeFixedFlatSet() (#39537 ) perf: prefer Sorted variant of MakeFixedFlatSet() https://chromium-review.googlesource.com/c/chromium/src/+/4660000 says that the sorted version is simpler at compile time because it can skip MakeFixedFlatSet()'s compile-time dynamic sorting.	2023-08-17 08:58:04 -05:00
Shelley Vohr	00746e662b	feat: allow headers to be sent with `webContents.downloadURL()` (#39455 ) feat: allow headers to be sent with webContents.downloadURL()	2023-08-17 14:17:55 +02:00
Charles Kerr	dd8df3b0c4	fix: destruction order of js env fields (#39521 ) isolate_ depends on isolate_holder_ and so must be destroyed first.	2023-08-16 23:06:24 -05:00
Shelley Vohr	1eb398b328	fix: crash when calling `BrowserWindow.moveTop()` on modal children (#39499 ) fix: crash when calling moveTop() on modal children	2023-08-16 13:28:29 +02:00
electron-roller[bot]	0c45d160d6	chore: bump chromium to 118.0.5949.0 (main) (#39505 ) * chore: bump chromium in DEPS to 118.0.5949.0 * chore: update mas_disable_remote_accessibility.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4705386 no manual code changes; existing patch applied with fuzz * chore: update printing.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4779059 no manual code changes; existing patch applied with fuzz * chore: add OffScreenRenderWidgetHostView::InvalidateLocalSurfaceIdAndAllocationGroup() Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4563504 Add an impl for a new pure virtual method that was added upstream. Local impl inspired by upstream implementations in same CL * chore: update patches --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>	2023-08-15 15:44:24 -04:00
Shelley Vohr	22429e2112	refactor: clean up Node.js cli arg parsing (#39465 ) * refactor: clean up Node.js arg parsing * chore: feedback from review	2023-08-15 14:49:21 -04:00
electron-roller[bot]	c3036d4557	chore: bump chromium to 117.0.5938.0 (main) (#39375 ) * chore: bump chromium in DEPS to 117.0.5929.0 * chore: bump chromium in DEPS to 117.0.5931.0 * chore: bump chromium in DEPS to 117.0.5932.0 * chore: update patches * 4728317: Prevent PrintRenderFrameHelper from printing when already printing \| https://chromium-review.googlesource.com/c/chromium/src/+/4728317 * 4739501: Use base::SequenceBound to manage SerialPortManagerImpl \| https://chromium-review.googlesource.com/c/chromium/src/+/4739501 * 4702051: Allow overriding source in install-sysroot.py \| https://chromium-review.googlesource.com/c/chromium/src/+/4702051 * chore: update filenames.libcxx.gni * 4727002: Rename "enable_arc2" to "enable_arc" \| https://chromium-review.googlesource.com/c/chromium/src/+/4727002 * chore: bump chromium in DEPS to 117.0.5934.0 * 4736873: Rename ColorSpaces methods on display::Display \| https://chromium-review.googlesource.com/c/chromium/src/+/4736873 * 4727203: Replace bool with an enum in as suggested in DevtoolsManagerDelegate. \| https://chromium-review.googlesource.com/c/chromium/src/+/4727203 * 4744479: [DevTools] Add 'generateTaggedPDF' option to DevTools Page.printToPDF \| https://chromium-review.googlesource.com/c/chromium/src/+/4744479 * 4735893: Don't share WebUSB permissions with webviews \| https://chromium-review.googlesource.com/c/chromium/src/+/4735893 * revert: update filenames.libcxx.gni * chore: bump chromium in DEPS to 117.0.5936.0 * chore: update patches * 4746465: SAA: Query for embargoed StorageAccess permissions \| https://chromium-review.googlesource.com/c/chromium/src/+/4746465 * 4666325: Move buildtools/third_party/lib/trunk source paths to third_party/lib/src. \| https://chromium-review.googlesource.com/c/chromium/src/+/4666325 * chore: bump chromium in DEPS to 117.0.5938.0 * chore: bump chromium in DEPS to 118.0.5939.0 * chore: update patches * Send line bounds through CursorAnchorInfo on requestCursorUpdate https://chromium-review.googlesource.com/c/chromium/src/+/4394588 * Fixup lint for Move buildtools/third_party/lib/trunk source paths to third_party/lib/src * 4700305: [mac] Fix override of CHILD_PROCESS_EXE https://chromium-review.googlesource.com/c/chromium/src/+/4700305 Needed because of 4729689: Reland "Remove redundant existence check in PathService" \| https://chromium-review.googlesource.com/c/chromium/src/+/4729689 * 4753759: More consistent icon handling for menus. https://chromium-review.googlesource.com/c/chromium/src/+/4753759 * chore: bump chromium in DEPS to 118.0.5941.0 * chore: update patches * chore: bump chromium in DEPS to 117.0.5938.0 * test: update nan-spec-runner cflags * build: fix isystem include path in nan-spec-runner * fixup! 4666325: Move buildtools/third_party/lib/trunk source paths to third_party/lib/src. \| https://chromium-review.googlesource.com/c/chromium/src/+/4666325 fix a few more instances of the old path libc++.a and libc++abi.a are still in buildtools/ --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: VerteDinde <vertedinde@electronjs.org> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: Charles Kerr <charles@charleskerr.com>	2023-08-15 10:49:41 -05:00
Robo	bee5d94886	feat: support dns-result-order Node.js cli flag (#39376 ) * feat: support dns-result-order Node.js cli flag * chore: update docs Co-authored-by: Erick Zhao <erick@hotmail.ca> * chore: remove patch --------- Co-authored-by: Erick Zhao <erick@hotmail.ca>	2023-08-15 12:19:45 +02:00
electron-roller[bot]	ef5d5f888d	chore: bump node to v18.17.1 (main) (#39457 ) * chore: bump node in DEPS to v18.17.1 * chore: update patches * policy: disable process.binding() when enabled `d4570fae35` --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>	2023-08-15 10:06:55 +02:00
wgsheng	127584dc37	feat: add a 'title' parameter to `openDevTools()` (#39047 ) * [Feature Request]: Add a parameter to openDevTools() that sets the DevTools window title bar * all titles->title * add GetDevToolsTitle(),update docs * fix:lint error * fix:lint error * add setDevToolTitle * lint errror * lint errror * ling errror (.md) * build error * build error in mac * build error * build error * change docs * std::string->std::u16string * lint error * build error * build error	2023-08-15 14:32:53 +09:00
Shelley Vohr	8e3dcc8b17	refactor: update `WebContentsZoomController` (#39428 ) refactor: update WebContentsZoomController	2023-08-15 10:33:30 +09:00
David Sanders	d166182865	chore: remove deprecated systemPreferences color scheme events (#39341 )	2023-08-14 10:37:18 +02:00
Cheng Zhao	cf658b700d	fix: use nested run loop in clipboard.readImage (#39466 )	2023-08-14 10:35:37 +02:00
Shelley Vohr	70508b5273	chore: update `_api_features` manifest requirements (#39412 ) chore: update api_resources manifest requirements	2023-08-09 10:38:13 -04:00
Shelley Vohr	d9329042e2	feat: add support for `chrome.tabs.query` (#39330 ) * feat: add support for tabs.query * fix: scope to webContents in current session * test: add test for session behavior	2023-08-09 14:47:19 +02:00
Shelley Vohr	5e59ddca1a	chore: update `chrome.runtime.getPlatformInfo` impl (#39392 ) chore: update chrome.runtime.getPlatformInfo impl	2023-08-08 22:29:03 +02:00
Shelley Vohr	1b3c63145c	chore: remove i18n JSON spec (#39391 )	2023-08-08 14:02:16 -04:00
Robo	eecfaec8c9	fix: crash when closing active macOS native tab (#39394 ) fix: crash when closing current active macOS native tab	2023-08-08 17:45:03 +09:00
Shelley Vohr	8f4f82618c	fix: `removeBrowserView` draggable region removal (#39387 ) fix: removeBrowserView draggable region removal Closes https://github.com/electron/electron/issues/39377.	2023-08-08 10:23:14 +02:00
Shelley Vohr	67523a47b4	fix: `chrome.tabs.update` return value (#39365 ) fix: chrome.tabs.update return value	2023-08-07 10:03:45 +02:00
Shelley Vohr	dc707ee938	fix: macOS tray button selection with VoiceOver (#39352 )	2023-08-07 09:52:18 +02:00
Shelley Vohr	2e0517c0ad	feat: allow more Node.js cli flags in main process (#39344 ) * feat: allow more Node.js cli flags in main process * docs: update cli switch documentation	2023-08-04 19:59:40 +09:00
electron-roller[bot]	c5b9f766f3	chore: bump chromium to 117.0.5923.0 (main) (#39304 ) * chore: bump chromium in DEPS to 117.0.5921.0 * chore: update chromium patches * 4721409: Remove redundant ARC configuration in /components \| https://chromium-review.googlesource.com/c/chromium/src/+/4721409 * 4643750: Add V8_LOW_PRIORITY_TQ for main thread \| https://chromium-review.googlesource.com/c/chromium/src/+/4643750 * 4022621: Re-register status item when owner of status watcher is changed \| https://chromium-review.googlesource.com/c/chromium/src/+/4022621 * chore: update V8/boringssl patches * fixup! 4643750: Add V8_LOW_PRIORITY_TQ for main thread \| https://chromium-review.googlesource.com/c/chromium/src/+/4643750 * chore: bump chromium in DEPS to 117.0.5923.0 * build [debug]: remove assert 4722125: Update enterprise content analysis buildflags usage \| https://chromium-review.googlesource.com/c/chromium/src/+/4722125 * chore: manually rollback to 117.0.5921.0 * build [arc]: ARC conversion in auto_updater * build [arc]: ARC conversion in browser/api * build [arc]: ARC conversion in notifications/mac * build [arc]: ARC conversion in in_app_purchase * build [arc]: ARC conversion in browser/ui * build [arc]: ARC conversion in ui/cocoa * build [arc]: ARC conversion in shell/common * build [arc]: ARC conversion in OSR * build [arc]: ARC conversion in login_helper * build [arc]: ARC conversion in app_mas * build [arc]: fix up ARC syntax (thanks @codebytere!) * 4726946: [Extensions] Work around dangling BrowserContext pointer. \| https://chromium-review.googlesource.com/c/chromium/src/+/4726946 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Keeley Hammond <vertedinde@electronjs.org> Co-authored-by: VerteDinde <keeleymhammond@gmail.com>	2023-08-04 10:47:29 +02:00
Shelley Vohr	6d0e8044eb	fix: update `chrome.tabs` for Manifest v3 (#39317 )	2023-08-03 18:34:02 +02:00
Shelley Vohr	f8b05bc127	feat: support `minimum_chrome_version` manifest key (#39256 ) feat: support minimum_chrome_version extension key	2023-08-03 11:38:31 -04:00
Robo	e96b1613a4	fix: destroy message port backend when JS env exits (#39335 )	2023-08-03 14:30:19 +02:00
Shelley Vohr	303b707fbf	fix: update `chrome.i18n` for Manifest v3 (#39291 ) fix: update chrome.i18n for Manifest v3	2023-08-02 11:02:16 +02:00
Shelley Vohr	1f19a74417	fix: potential crash calling `tray.popUpContextMenu()` (#39231 ) fix: potential crash calling tray.popUpContextMenu	2023-08-01 15:07:30 +09:00
Shelley Vohr	c8f7a0e052	fix: Chrome Extensions service worker host registration (#39290 )	2023-08-01 15:04:38 +09:00
David Sanders	b2c62d6ad1	fix: initial dark mode title bar on Windows 10 (#39287 )	2023-07-31 22:02:23 -07:00
electron-roller[bot]	cfc0826b65	chore: bump chromium to 117.0.5913.0 (main) (#39172 ) * chore: bump chromium in DEPS to 117.0.5899.0 * 4686653: webui: Filter out non-chrome scheme URLs in WebUIConfigMap https://chromium-review.googlesource.com/c/chromium/src/+/4686653 * 4696355: Remove deprecated version of base::CommandLine::CopySwitchesFrom() https://chromium-review.googlesource.com/c/chromium/src/+/4696355 * chore: fixup patch indices * 4603888: Reland "Enable raw_ref check on linux" https://chromium-review.googlesource.com/c/chromium/src/+/4603888 * chore: bump chromium in DEPS to 117.0.5901.0 * chore: update patches * chore: bump chromium in DEPS to 117.0.5903.0 * chore: bump chromium in DEPS to 117.0.5903.2 * chore: bump chromium in DEPS to 117.0.5905.0 * 4706792: Printing: Add debug code for a DispatchBeforePrintEvent() failure https://chromium-review.googlesource.com/c/chromium/src/+/4706792 * 4704786: Refactor libunwind build rules/flags https://chromium-review.googlesource.com/c/chromium/src/+/4704786 * 4701710: [Linux Ui] Set toolkit dark preference based on FDO dark preference https://chromium-review.googlesource.com/c/chromium/src/+/4701710 * chore: fixup patch indices * chore: bump chromium in DEPS to 117.0.5907.0 * chore: bump chromium in DEPS to 117.0.5909.2 * chore: update patches * chore: bump chromium in DEPS to 117.0.5911.0 * chore: update patches * chore: build-what-we-include * fix: set allowFileAccess on devtools extensions correctly Ref: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4714725 * 4670615: Reland "[iterator-helpers] Shipping iterator helpers" https://chromium-review.googlesource.com/c/v8/v8/+/4670615 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>	2023-07-31 10:47:32 -07:00
Shelley Vohr	695fcf3cb2	fix: reparenting after `BrowserWindow.destroy()` (#39062 ) fix: reparenting after BrowserWindow.destroy()	2023-07-26 16:47:32 +02:00
Athul Iddya	fa5b1be6f3	fix: delete desktop capturers when they're not needed (#39194 ) * fix: delete desktop capturers when they're not needed Delete desktop capturer objects by resetting the DesktopMediaList objects that own them after the sources have been collected. Capturers that are not delegated are already being reset via a patch on NativeDesktopMediaList. That is not safe for delegated capturers as thumbnail generation depends on user events. Deleting the DesktopMediaList operation is safe for all capturers and releases OS capture resources as soon as possible. * fix: add a patch to clean up PipeWire resources Adding a patch to workaround a Chromium issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1467060 The patch can be removed when the issue is resolved.	2023-07-26 10:40:19 +02:00
Shelley Vohr	38c3d8df29	fix: traffic lights not working when child windows are restored via parent window (#39225 )	2023-07-26 10:10:34 +02:00
Shelley Vohr	12548294c0	fix: `resizable: false` should disable fullscreen button at start (#39086 ) fix: resizable should disable fullscreen button at start	2023-07-25 12:18:36 -04:00
Milan Burda	3df6d337f3	feat: add `senderIsMainFrame` to messages sent via `ipcRenderer.sendTo()` (#38868 ) * feat: add isMainFrame to events emitted via ipcRenderer.sendTo() * chore: rename isMainFrame to senderIsMainFrame	2023-07-24 14:27:30 +02:00
Athul Iddya	9cd5de7588	fix: use generic capturer to list both screens and windows when possible (#39111 ) Screensharing with PipeWire via XDG Desktop Portal requires explicit user permission via permission dialogs. Chromium has separate tabs for screens and windows and thus its portal implementation requests permissions separately for each. However, the screencast portal has no such limitation and supports both screens and windows in a single request. WebRTC now supports this type of capture in a new method called called `CreateGenericCapturer`. The `desktopCapturer` implementation has been modified to use it. Additionally, Chromium has been patched to use same generic capturer to ensure that the source IDs remain valid for `getUserMedia`.	2023-07-21 16:03:01 -07:00
electron-roller[bot]	e02cf8674d	chore: bump chromium to 117.0.5897.0 (main) (#39147 ) * chore: bump chromium in DEPS to 117.0.5896.0 * chore: update patches * 4622260: [Service Workers] Allow fetches from workers to use auto-picked certs https://chromium-review.googlesource.com/c/chromium/src/+/4622260 * chore: bump chromium in DEPS to 117.0.5897.0 * 4665672: [ProfileSelections] Transition extension keyed factories to use Profile Selections https://chromium-review.googlesource.com/c/chromium/src/+/4665672 * chore: fixup patch indices --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>	2023-07-20 09:36:59 +02:00
Charles Kerr	f2b32af1f6	perf: small perf changes in HidChooserController (#39057 ) * perf: avoid string temporary in HidChooserController::PhysicalDeviceIdFromDeviceInfo() return a const ref instead of a new string * perf: avoid second map lookup in HidChooserController::AddDeviceInfo()	2023-07-19 16:54:30 +02:00
electron-roller[bot]	bbdd037219	chore: bump chromium to 117.0.5892.0 (main) (#39118 ) * chore: bump chromium in DEPS to 117.0.5892.0 * 4670267: Don't send javascript: or empty URLs to browser in CreateNewWindow. https://chromium-review.googlesource.com/c/chromium/src/+/4670267 * 4662090: Add metrics for WebGPU support https://chromium-review.googlesource.com/c/chromium/src/+/4662090 * 4672599: Use set_defaults for mac_app_bundle https://chromium-review.googlesource.com/c/chromium/src/+/4672599 * 4663771: usb: Add connection count tracking methods for UsbDelegate https://chromium-review.googlesource.com/c/chromium/src/+/4663771 * 4664578: Remove unused parameter from ExtensionsGuestViewManagerDelegate ctor https://chromium-review.googlesource.com/c/chromium/src/+/4664578 * 4622253: usb: Create classes for usb system tray icon https://chromium-review.googlesource.com/c/chromium/src/+/4622253 * 4678263: Remove ARC support from scoped_nsobject https://chromium-review.googlesource.com/c/chromium/src/+/4678263 * chore: follow-up ARC changes and missing guard corrections * chore: don't mark 0-param ctor explicit Follow up to https://chromium-review.googlesource.com/c/chromium/src/+/4664578 * chore: fixup patch indices * 4670865: Merge ObjectProxy::CallMethodAndBlock{,WithErrorDetails}. https://chromium-review.googlesource.com/c/chromium/src/+/4670865 * chore: follow-up ARC changes and missing guard corrections * fixup: retain ElectronApplicationDelegate * fix: correct rustc binary --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>	2023-07-19 00:26:27 +02:00
Shelley Vohr	8874306dc0	fix: `window.open` causing occasional Node.js crashes (#38754 ) * fix: window.open causing occasional Node.js crashes * chore: always free isolate data * chore: clear pending ticks in worker thread * fix: UAF crash when creating WebWorkerObserver --------- Co-authored-by: deepak1556 <hop2deep@gmail.com>	2023-07-18 10:41:50 +02:00
electron-roller[bot]	9645f7f6d8	chore: bump chromium to 117.0.5884.1 (main) (#38969 ) * chore: bump chromium in DEPS to 117.0.5866.0 * chore: bump chromium in DEPS to 117.0.5868.0 * chore: update mas_no_private_api.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4634925 Minor manual patch syncing due to upstream code shear * chore: update mas_disable_remote_layer.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4647191 Manually sync patch to minor upstream code shear * chore: update mas_disable_remote_accessibility.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4641746 No manual changes; patch applied with fuzz * chore: update mas_avoid_usage_of_private_macos_apis.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4634925 Manually sync base/process/launch_mac.cc to minor upstream shear Manually sync base/mac/foundation_util.mm to upstream changes: _CFIsObjC use has been removed upstream, so we no longer need to remove it 🎉 * chore: update printing.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4658496 Manually sync patch to minor upstream code shear * chore: update disable_color_correct_rendering.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4625254 Manually sync patch to minor upstream code shear * chore: update feat_expose_raw_response_headers_from_urlloader.patch Xref: services/network/public/cpp/resource_request.cc No manual changes; patch applied with fuzz * chore: update add_electron_deps_to_license_credits_file.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4634961 No manual changes; patch applied with fuzz * chore: update build_only_use_the_mas_build_config_in_the_required_components.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4648411 No manual changes; patch applied with fuzz * chore: update patches * fixup! chore: update add_electron_deps_to_license_credits_file.patch chore: license files must be an array * chore: bump chromium in DEPS to 117.0.5870.0 * chore: update patches * chore: run ./script/gen-libc++-filenames.js * chore: update json_parse_errors_made_user-friendly.patch Xref: https://chromium-review.googlesource.com/c/v8/v8/+/4652014 v8 error message changed upstream; update Node test to match it * chore: bump chromium in DEPS to 117.0.5872.0 * chore: update patches * chore: explicitly cast x11::Window to unsigned int Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4661049 This is an `enum class Window : uint32_t` defined in ui/gfx/x/xproto.h. Previous versions of clang let this implicit cast happen, but it generates a warning in the new clang roll. * chore: remove unused #include Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4650453 header was removed upstream, so FTBFS unless removed here * chore: add include guard patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4628373 h/t @jkleinsc * chore: bump chromium in DEPS to 117.0.5874.0 * chore: update render_widget_host_view_mac.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4661244 Manually sync patch to minor upstream code * chore: update mas_disable_remote_accessibility.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4653209 Manually sync patch to upstream code shear * chore: update build_only_use_the_mas_build_config_in_the_required_components.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4653209 Manually sync patch to minor upstream code shear * chore: update GetInitiatorProcessId() Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4641991 trivial upstream naming change: s/ProcessID/ProcessId/ * chore: sync to upstream SetInputRegion() changes Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4665245 Simple upstream chang: SetInputRegion() used to take a gfx::Rect* where `nullptr` meant "no opaque region". The function signature changed to absl::optional<gfx::Rect> w/the same meaning. * chore: sync to upstream SetOpaqueRegion() changes Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4656738 Simple upstream chang: SetOpaqueRegion() used to take a vector<Rect>* where `nullptr` meant "no opaque region". The function signature changed to absl::optional<std::vector<gfx::Rect>> w/the same meaning. * chore: update patches * chore: bump chromium in DEPS to 117.0.5876.0 * chore: update mas_disable_remote_accessibility.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4658375 We no longer need to patch out a field that's now removed upstream. RenderWidgetHostNSViewBridgeOwner.remote_accessibility_element_ * chore: update feat_filter_out_non-shareable_windows_in_the_current_application_in.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4658680 Manually sync patch to upstream code shear (ARC adoption). * chore: update patches * fix: -Werror,-Wshadow error in Node.js * chore: bump chromium in DEPS to 117.0.5878.0 * chore: bump chromium in DEPS to 117.0.5880.0 * chore: bump chromium in DEPS to 117.0.5880.4 * chore: update patches * 4658680: Convert /content/browser to use ARC https://chromium-review.googlesource.com/c/chromium/src/+/4658680 * 4669995: Remove CFToNSCast and NSToCFCast https://chromium-review.googlesource.com/c/chromium/src/+/4669995 * WIP: 4658680: Convert /content/browser to use ARC https://chromium-review.googlesource.com/c/chromium/src/+/4658680 * chore: update printing patch after rebase * chore: bump chromium in DEPS to 117.0.5882.0 * Revert "WIP: 4658680: Convert /content/browser to use ARC" This reverts commit c8559ea448ad93123865a6fa8af6fe2767e43396. * Revert "4669995: Remove CFToNSCast and NSToCFCast" This reverts commit 38e145f33d844e077b09e1fb119fae9d5d7bbc3e. * chore: bump chromium in DEPS to 117.0.5874.0 * 4661244: Convert /content/browser/renderer_host to use ARC https://chromium-review.googlesource.com/c/chromium/src/+/4661244 * 4653209: Convert /ui/views:views to use ARC https://chromium-review.googlesource.com/c/chromium/src/+/4653209 * chore: fixup mas_disable_remote_accessibility.patch * chore: fixup render_widget_host_view_mac.patch * chore: update to newer clang * chore: bump chromium in DEPS to 117.0.5884.1 (cherry picked from commit a3879acfde8f3d962d58d6ad0632164ccb88ee63) * 4669995: Remove CFToNSCast and NSToCFCast https://chromium-review.googlesource.com/c/chromium/src/+/4669995 (cherry picked from commit 38e145f33d844e077b09e1fb119fae9d5d7bbc3e) (cherry picked from commit b1224ab7e00aedbd0e5dc78ebb3c6162573b28c4) * 4658680: Convert /content/browser to use ARC https://chromium-review.googlesource.com/c/chromium/src/+/4658680 (cherry picked from commit 77039a323b9ebb3e8edb3a92a3b94a8d7d026a32) * Rename and cleanup ExtensionsBrowserClient functions \| https://chromium-review.googlesource.com/c/chromium/src/+/4665670 (cherry picked from commit 677a2e646a8d82da60dc252b08b320c3ddff6be6) * chore: bump chromium in DEPS to 117.0.5886.0 * chore: update patches * Revert "chore: update patches" This reverts commit db9294f9446492d4a3d63f5f3ecc551aeeeb2e26. * Revert "chore: bump chromium in DEPS to 117.0.5886.0" This reverts commit a7de0276e6e0eeecfdbb17f9bbc27c01b4bbfc24. * build: use built toolchains instead of locally installed VSCode * fixup: build: use built toolchains instead of locally installed VSCode * chore: add missing mojo dep --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>	2023-07-16 16:14:43 +02:00
Shelley Vohr	f61425efdb	fix: `clipboard.readImage()` should be synchronous (#39069 ) * feat: clipboard.readImage returns a Promise * chore: update breaking changes doc * fix: make function synchronous * Update docs/api/native-image.md Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> --------- Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>	2023-07-13 16:59:14 -04:00
Robo	34e7c3696a	feat: expose safestorage backend information on linux (#38873 ) * feat: expose safestorage backend information on linux * Remove gnome-keyring Refs https://chromium-review.googlesource.com/c/chromium/src/+/4609704	2023-07-13 11:14:33 +02:00
Charles Kerr	dc671804da	perf: avoid redundant lookup in BluetoothChooser::AddOrUpdateDevice() (#39059 ) perf: avoid redundant map lookup in BluetoothChooser::AddOrUpdateDevice()	2023-07-13 10:16:25 +02:00
Charles Kerr	a8622aed7b	perf: avoid redundant map lookup in NativeImage::GetHICON() (#39058 ) perf: avoid double map lookup in NativeImage::GetHICON()	2023-07-13 15:37:43 +09:00
Shelley Vohr	da3475998f	fix: `BrowserWindow.moveAbove()` not working for child windows (#39034 ) fix: BrowserWindow.moveAbove() not working for child windows	2023-07-12 17:42:24 +02:00
Mikhail Leliakin	f959fb0c96	feat: `browserWindow.getBrowserViews()` to return sorted by z-index array (#38943 )	2023-07-11 11:01:30 +02:00
Athul Iddya	905e41bbdd	fix: use StartUpdating method for PipeWire capturer (#38833 ) * fix: use StartUpdating method for PipeWire capturer Fixed a crash related to PipeWire capturer by adapting to Chromium's interface changes. Chromium expects a call to `NativeDesktopMediaList::StartUpdating` with an implementation of `DesktopMediaListObserver` for delegated capturers like PipeWire. This interface allows listening to user permission events and listing sources only after the user has made a choice on the permission dialog. The interface has been implemented by an inner class to allow listening to screen and window capture permissions concurrently using two instances of the class. A patch that was resetting the capturer on the first refresh has been changed to exclude PipeWire. PipeWire capturer object will follow the lifecycle of `NativeDesktopMediaList`, as is the case in Chromium. Fixes #37463 * fix: wait for thumbnails from PipeWire when necessary The PipeWire stream starts after the dialog is dismissed. If the sources are listed immediately afterwards, the thumbnail may not have been generated by that time. Explicitly wait for both thumbnail generation and a selection on the source dialog before listing sources.	2023-07-11 10:21:11 +02:00
Athul Iddya	3e3152008f	fix: remove types from GTK CSS selectors (#39003 ) Remove types from GTK CSS selectors similar to Chromium's changes in CL 4289229. Fixes #38786 Co-authored-by: Athul Iddya <athul@iddya.com>	2023-07-10 22:52:12 +02:00
Shelley Vohr	c7bdd907d7	fix: set prototype names on `gin::Constructible` classes (#39006 ) * fix: set prototype names on gin::Constructible classes * test: add tests	2023-07-10 11:49:20 +02:00
Mikhail Leliakin	56b5c00312	feat: add `BrowserWindow.showAllTabs()` for macOS (#38965 )	2023-07-10 10:43:37 +02:00
Shelley Vohr	a97028bacf	fix: Notification 'Show' button visible when no actions exist (#38997 )	2023-07-06 15:50:08 -04:00
Shelley Vohr	c7a64ab994	fix: webview crash when removing in close event (#38996 )	2023-07-06 10:20:34 +02:00
Shelley Vohr	5a77c75753	revert: compensate for title bar height when setting bounds on `BrowserView` (#38981 ) This reverts commit `75f9573e53`.	2023-07-06 09:50:08 +02:00
Cheng Zhao	3fa15ebb7e	fix: use Chromium's way to compute min/max sizes (#38974 )	2023-07-05 11:02:05 -04:00
electron-roller[bot]	ccd4531bfb	chore: bump chromium to 117.0.5852.0 (main) (#38891 ) * chore: bump chromium in DEPS to 117.0.5846.0 * chore: update patches * 4628901: Bump the macOS deployment target to 10.15 https://chromium-review.googlesource.com/c/chromium/src/+/4628901 * 4593350: [Private Network Access] Trigger Permission Prompt https://chromium-review.googlesource.com/c/chromium/src/+/4593350 * 4631011: Remove unlaunched "InstallReplacementAndroidApp" Platform App APIs https://chromium-review.googlesource.com/c/chromium/src/+/4631011 * chore: disable API deprecation warnings in NSKeyedArchiver * chore: update libcxx filenames * chore: bump chromium in DEPS to 117.0.5848.2 * chore: update feat_add_set_theme_source_to_allow_apps_to.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4629743 No manual changes; patch succeeded with fuzz * chore: update process_singleton.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4605398 Trivial manual patch adjustments to account for code shear. * chore: remove electron::BrowserContext::GetMediaDeviceIDSalt() Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4608130 upstream tldr: - content::BrowserContext::GetMediaDeviceIDSalt() - content::ContentBrowserClient::ArePersistentMediaDeviceIDsAllowed() + content::ContentBrowserClient::GetMediaDeviceIDSalt() This commit leaves ElectronBrowserContext::GetMediaDeviceIDSalt() in place (now non-virtual, non-override). It is now called by the new function ElectronBrowserClient::GetMediaDeviceIDSalt(). As a followup, we might want to consider using the new upstream media_device_salt::MediaDeviceSaltService and removing our electron::MediaDeviceIDSalt code. CC @MarshallOfSound for 2nd opinion since he has done the most work on MediaDeviceIDSalt and may have more context. * chore: fix iwyu breakage Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4629624 electron_browser_main_parts.cc uses ui::ColorProviderManager but didn't include it. Things worked anyway because we got it indirectly from content/public/browser/web_contents.h until 4629624. * chore: remove call to base::mac::IsAtLeastOS10_14 upstream has bumped minimum version to 10.15 so this call is moot? * chore: remove obsolete API_AVAILABLE calls in IAP upstream has bumped minimum version to 10.15 so this call is moot? * chore: remove obsolete API_AVAILABLE calls in electron_application_delegate upstream has bumped minimum version to 10.15 so this call is moot? * chore: remove broken-before-macOS-10.15 patch in mas_avoid_usage_of_private_macos_apis.patch Upstream has bumped minimum to macOS 10.15 * chore: remove @available(macOS 10.14) check Upstream minimum requirement for macOS is now 10.15 * chore: update patches * chore: bump chromium in DEPS to 117.0.5850.0 * chore: update patches * chore: bump chromium in DEPS to 117.0.5852.0 * chore: update patches * Move two params from NetworkContextParams to NetworkContextFilePaths. https://chromium-review.googlesource.com/c/chromium/src/+/4615930 * WebUSB: Add exclusionFilters to USBRequestDeviceOptions https://chromium-review.googlesource.com/c/chromium/src/+/4614682 * Convert /chrome/browser/ui to use ARC https://chromium-review.googlesource.com/c/chromium/src/+/4615920 * fixup! Bump the macOS deployment target to 10.15 * fixup! Bump the macOS deployment target to 10.15 * chore: update libcxx files * win: Remove 10Glass from Windows10Glass function and var names https://chromium-review.googlesource.com/c/chromium/src/+/4641314 * chore: revert 392e5f43 from chromium * Add an ExecutionContext to ScriptState https://chromium-review.googlesource.com/c/chromium/src/+/4609446 * fixup! Add an ExecutionContext to ScriptState * chore: fix header * Revert "chore: revert 392e5f43 from chromium" This reverts commit b7f782943e4ce83cae8cd35780d8d3618cf0772c. * fix: return correct min/max sizes in WinFrameView * fixup! Revert chore: revert 392e5f43 from chromium * fixup! Add an ExecutionContext to ScriptState * Revert "fixup! Revert chore: revert 392e5f43 from chromium" This reverts commit 7e2c7281abfc4f309255339fdba073d90a9ae3eb. * Revert "fix: return correct min/max sizes in WinFrameView" This reverts commit 3f418b1ab5155686730e087ae6cabe4a21b4bb61. * Revert "Revert "chore: revert 392e5f43 from chromium"" This reverts commit 56296d8b7c434147e032e3c3b08c0e371b6c27ba. --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: deepak1556 <hop2deep@gmail.com> Co-authored-by: Cheng Zhao <zcbenz@gmail.com>	2023-07-01 16:22:55 -04:00
Samuel Attard	499d893040	feat: add support for keyboard initialized menu popup (#38903 ) * feat: add support for keyboard initialized menu popup * Update docs/api/menu.md Co-authored-by: Erick Zhao <erick@hotmail.ca> * fix: add patch to chromium for keyboard accessibility menu behavior * refactor: s/initiatedByKeyboard/sourceType * fix: ignore initial mouse event to retain keyboard initiated focus * Update docs/api/menu.md Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com> --------- Co-authored-by: Erick Zhao <erick@hotmail.ca> Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>	2023-06-29 15:54:06 -07:00
Cheng Zhao	09669f9d21	fix: child window may have opener removed (#38910 )	2023-06-26 17:04:54 -04:00
Charles Kerr	395b608dd5	refactor: more constexpr lookup tables (#38886 ) * refactor: use constexpr lookup table in electron_api_web_contents.cc * refactor: make KeyboardCodeFromStr() private it is only used as a helper to KeyboardCodeFromStr() * chore: savepoint * chore: make lint happy * fixup! refactor: make KeyboardCodeFromStr() private * refactor: use constexpr lookup table in electron_url_loader_factory * refactor: use constexpr lookup table in electron_api_tray * refactor: use constexpr lookup table in web_contents_preferences.cc * refactor: use constexpr lookup table in content_converter	2023-06-22 14:33:44 +02:00
electron-roller[bot]	1eb19f3078	chore: bump chromium to 116.0.5845.0 (main) (#38827 ) * chore: bump chromium in DEPS to 116.0.5835.0 * chore: update patches * chore: bump chromium in DEPS to 116.0.5837.0 * chore: bump chromium in DEPS to 116.0.5839.0 * chore: bump chromium in DEPS to 116.0.5841.0 * chore: bump chromium in DEPS to 116.0.5843.0 * Update patches CLs that affected printing.patch: - 4616791: Refactor PrintViewManagerBase::PrintNow() https://chromium-review.googlesource.com/c/chromium/src/+/4616791 - 4602776: Make PrintNodeUnderContextMenu operation go through PrintViewManager https://chromium-review.googlesource.com/c/chromium/src/+/4602776 * 4506614: geolocation: Add LocationProvider::FillDiagnostics https://chromium-review.googlesource.com/c/chromium/src/+/4506614 * chore: bump chromium in DEPS to 116.0.5845.0 * chore: update patches * fixup! 4506614: geolocation: Add LocationProvider::FillDiagnostics https://chromium-review.googlesource.com/c/chromium/src/+/4506614 * 4609704: Remove gnome-keyring https://chromium-review.googlesource.com/c/chromium/src/+/4609704 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: clavin <clavin@electronjs.org>	2023-06-22 10:51:15 +02:00
Shelley Vohr	a00a25376d	fix: crash calling `BrowserWindow.removeBrowserView()` with destroyed `webContents` (#38842 ) fix: crash calling removeBrowserView() with destroyed webContents https://github.com/electron/electron/issues/37642	2023-06-21 15:20:54 -04:00
Michaela Laurencin	ce6fe040fe	fix: set minimize visibility true with enable (#38860 )	2023-06-21 14:58:33 -04:00
Shelley Vohr	e73edb5481	feat: allow headers to be sent with `session.downloadURL()` (#38785 )	2023-06-21 15:31:28 +02:00
Shelley Vohr	f6bbc34658	fix: set supported scale factors on startup (#38836 )	2023-06-20 12:24:03 -04:00
Milan Burda	2b3902e526	refactor: use content::GlobalRenderFrameHostId (#38843 ) Co-authored-by: Milan Burda <miburda@microsoft.com>	2023-06-20 15:32:31 +02:00
Charles Kerr	97132ece33	refactor: use constexpr lookup tables in gin helper (#38818 ) * feat: add gin_helper::FromV8WithLookup() feat: add gin_helper::FromV8WithLowerLookup() * refactor: use constexpr lookup table in gin Converters	2023-06-19 10:33:09 +02:00
Charles Kerr	41ab5f327f	refactor: remove unused InspectableWebContentsView::GetWebView() (#38799 )	2023-06-16 00:44:19 -05:00
electron-roller[bot]	7219142a54	chore: bump chromium to 116.0.5833.0 (main) (#38809 ) * chore: bump chromium in DEPS to 116.0.5833.0 * chore: update patches * 4530656: Add DeviceLoginScreenWebHidAllowDevicesForUrls policy https://chromium-review.googlesource.com/c/chromium/src/+/4530656 * Split CertDatabase notifications between trust changes and client cert changes https://chromium-review.googlesource.com/c/chromium/src/+/4596317 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>	2023-06-15 16:37:01 -04:00
Charles Kerr	bf1ba4a857	refactor: constexpr lookup tables (#38771 ) * refactor: use a constexpr lookup table in GetPathConstant() * refactor: use a constexpr lookup table in SystemPreferences::GetColor() * refactor: use a constexpr lookup table in SimpleURLLoaderWrapper::Create()	2023-06-14 17:00:46 -04:00
Charles Kerr	5ad8b4b7d1	chore: remove unused std includes (#38767 )	2023-06-14 11:07:18 -07:00
Charles Kerr	167c2b250e	refactor: use compile-time cli arg sets. (#38748 ) We're currently building these on the heap with `std::set<std::string>` but this can be a very small compile-time container instead. Marking as 'refactor' rather than 'perf' since this isn't called often, but moving from heap to compile-time is good and using this container makes the code more readable.	2023-06-13 14:37:59 -05:00
Milan Burda	e37111edcc	build: remove enable_osr build flag (#38703 ) Co-authored-by: Milan Burda <miburda@microsoft.com>	2023-06-13 14:48:53 -04:00
electron-roller[bot]	80a3ba5c68	chore: bump chromium to 116.0.5829.0 (main) (#38726 ) * chore: bump chromium in DEPS to 116.0.5823.0 * chore: update patches * chore: bump chromium in DEPS to 116.0.5825.0 * chore: update patches * chore: bump chromium in DEPS to 116.0.5827.0 * chore: update patches * 4568811: Integrate Search Prefetch with Extensions. https://chromium-review.googlesource.com/c/chromium/src/+/4568811 * 4567511: [DevTools] Add recordCountHistogram API. https://chromium-review.googlesource.com/c/chromium/src/+/4567511 * 4507692: Delete base/guid.h https://chromium-review.googlesource.com/c/chromium/src/+/4507692 * 4589551: Convert some of /base to use ARC https://chromium-review.googlesource.com/c/chromium/src/+/4589551 Also: 4601769: Convert immersive mode controllers to use ARC https://chromium-review.googlesource.com/c/chromium/src/+/4601769 * [viz] Convert MaybeSizeInBytes() to take in SharedImageFormat https://chromium-review.googlesource.com/c/chromium/src/+/4594677 * 4564108: [BRP] Enable check_raw_ptr_fields for Mac https://chromium-review.googlesource.com/c/chromium/src/+/4564108 * chore: bump chromium in DEPS to 116.0.5828.0 * chore: bump chromium in DEPS to 116.0.5829.0 * chore: update patches --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>	2023-06-13 14:45:48 -04:00
Shelley Vohr	678d1aa37d	docs: clarify supported accelerator punctuation (#38740 ) doc: clarify supported accelerator punctuation	2023-06-13 12:42:55 +02:00
Charles Kerr	ab49e98401	perf: prefer base::StringPiece over std::string for build-time strings (#38717 ) * perf: use base::StringPiece in InclusionStatusToString() The strings are all build-time constants and this is a private function * perf: use base::StringPiece in ErrorCodeToString() The strings are all build-time constants and this is a private function * perf: use base::StringPiece in MessageSourceToString() The strings are all build-time constants and this is a private function * perf: use base::StringPiece in CursorTypeToString() The strings are all build-time constants and this is a private function * perf: use base::StringPiece in MediaStreamTypeToString() The strings are all build-time constants and this is a private function * perf: use base::StringPiece in ModifiersToArray() The strings are all build-time constants and this is a private function * perf: use base::StringPiece in WebFrameRenderer::MaybeGetRenderFrame() The strings are all build-time constants and this is a private function	2023-06-12 09:55:22 +02:00
electron-roller[bot]	fd5e6fbc14	chore: bump chromium to 116.0.5817.0 (main) (#38465 ) * chore: bump chromium in DEPS to 116.0.5793.3 * chore: update patches * chore: bump chromium in DEPS to 116.0.5795.0 * chore: update patches * chore: bump chromium in DEPS to 116.0.5797.0 * chore: update patches * chore: bump chromium in DEPS to 116.0.5799.0 * 4522192: [serial] Allow Bluetooth ports to be requested by service class ID. \| https://chromium-review.googlesource.com/c/chromium/src/+/4522192 * 4545385: Create base:🍎:Owned[frameworktype], use it for gfx::NativeEvent \| https://chromium-review.googlesource.com/c/chromium/src/+/4545385 * chore: bump chromium in DEPS to 116.0.5801.0 * chore: update patches * 4562796: Use base:🍎:Owned[frameworktype] for ui::PlatformEvent \| https://chromium-review.googlesource.com/c/chromium/src/+/4562796 * 4559790: Manual raw_ptr rewrite: //base \| https://chromium-review.googlesource.com/c/chromium/src/+/4559790 * chore: bump chromium in DEPS to 116.0.5803.0 * chore: update patches * chore: bump chromium in DEPS to 116.0.5805.2 * chore: update patches * 4547630: Move content/public/common/network_service_util.h to c/p/browser/ \| https://chromium-review.googlesource.com/c/chromium/src/+/4547630 * 4510075: Adding extensions to network response experiment \| https://chromium-review.googlesource.com/c/chromium/src/+/4510075 * 4566552: Auto-generate grd file for chrome://accessibility. \| https://chromium-review.googlesource.com/c/chromium/src/+/4566552 * chore: bump chromium in DEPS to 116.0.5807.0 * chore: update patches * 4533536: [Privacy Hub] Geolocation manager used directly \| https://chromium-review.googlesource.com/c/chromium/src/+/4533536 * chore: patch out ARC support from /chrome/browser 4571955: Convert /chrome/browser to use ARC \| https://chromium-review.googlesource.com/c/chromium/src/+/4571955 * chore: bump chromium in DEPS to 116.0.5809.2 * chore: bump chromium in DEPS to 116.0.5811.0 * chore: update patches * 4573627: Adopt base::NoDestructor for KeyedService factories \| https://chromium-review.googlesource.com/c/chromium/src/+/4573627 * 4576878: Reland "Shared Storage: Add mojo method for observing response headers" \| https://chromium-review.googlesource.com/c/chromium/src/+/4576878 * chore: bump chromium in DEPS to 116.0.5813.0 * chore: update patches * fixup! 4566552: Auto-generate grd file for chrome://accessibility. \| https://chromium-review.googlesource.com/c/chromium/src/+/4566552 * chore: fix up lint * test: (debug) use Promise.all in asan tests * chore: manually roll DEPS to 116.0.5815.0 * chore: update patches * 4585150: Convert /printing to use ARC \| https://chromium-review.googlesource.com/c/chromium/src/+/4585150 * test: (asan) extend timeout, clean up debugging * chore: remove ARC chromium patch * chore: update patches after main sync * 4546398: Convert /chrome/browser to use ARC \| https://chromium-review.googlesource.com/c/chromium/src/+/4546398 * build: add chrome_lib_arc for chromium_src/BUILD.gn sources * fixup! 4559790: Manual raw_ptr rewrite: //base \| https://chromium-review.googlesource.com/c/chromium/src/+/4559790 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: VerteDinde <vertedinde@electronjs.org> Co-authored-by: VerteDinde <keeleymhammond@gmail.com>	2023-06-09 16:08:36 -07:00
Charles Kerr	a3448376a1	refactor: api web contents ownership (#38695 ) * refactor: aggregate api::WebContents::exclusive_access_manager_ directly * refactor: make WebContents::devtools_file_system_indexer_ scoped_refptr const * refactor: make WebContents::file_task_runner_ scoped_refptr const * refactor: make WebContents::print_task_runner_ scoped_refptr const	2023-06-09 15:28:11 -05:00
Samuel Maddock	e8fd5fd3a8	fix: WCO transparent background (#38693 ) * fix: WCO transparency * doc: wco color transparency * fix: transparent buttons when calling setTitleBarOverlay	2023-06-09 09:57:57 -07:00
Charles Kerr	d95ae19edf	refactor: add SessionPreferences::CreateForBrowserContext() (#38656 ) Copy the NativeWindowRelay::CreateForWebContents() idiom to simplify SessionPreferences's constructor and lifecycle.	2023-06-09 11:20:43 -05:00
Milan Burda	05d39d8313	build: remove enable_run_as_node build flag (#38413 ) * feat: remove enable_run_as_node flag * drop features.isRunAsNodeEnabled() * use IsEnvSet() helper in electron_main_linux.cc * cleanup [[maybe_unused]] --------- Co-authored-by: Milan Burda <miburda@microsoft.com>	2023-06-08 16:40:08 -04:00
Charles Kerr	9d8da7839e	fix: dangling pointer warning when updating menus (#38643 )	2023-06-08 09:29:32 -05:00
wgsheng	c8bdd014c8	fix: menu bar visibility when exiting full screen (#38599 )	2023-06-08 12:19:34 +02:00
Shelley Vohr	5ee890fb6f	fix: reparenting UAF crash on macOS (#38603 )	2023-06-08 12:18:37 +02:00
Shelley Vohr	9a9d8ae5ea	refactor: add ARC scaffolding for macOS (#38621 )	2023-06-08 10:26:33 +02:00
Milan Burda	0294debc31	build: remove enable_picture_in_picture build flag (#38620 ) Co-authored-by: Milan Burda <miburda@microsoft.com>	2023-06-07 23:56:31 -07:00
Shelley Vohr	933544d449	chore: clean up `ElectronPermissionManager` (#38636 ) chore: clean up ElectronPermissionManager	2023-06-07 23:55:36 -07:00
Charles Kerr	69790f4b2a	refactor: remove unused OffScreenRenderWidgetHostView fields (#38623 )	2023-06-07 16:28:35 -05:00
Charles Kerr	5931f69f18	fix: sync api::Screen wrapper method sigs to upstream (#38597 ) refactor: sync api::Screen getter sigs to upstream ui::Display GetAllDisplays(), GetPrimaryDisplay(), GetDisplayMatching(), and GetDisplayNearestPoint() methods are all const, so make our wrappers const too. ui::Display GetAllDisplays() returns a const reference, so make our wrapper return a const reference too. This avoids creating a new std::vector<display::Display> each time it's called.	2023-06-07 09:28:50 +02:00
zeeker999	28332c94bf	feat: Allow customizing the default math font (#38514 )	2023-06-06 17:26:32 -04:00
Charles Kerr	5c1321b20a	refactor: remove redundant resizing strategy equality check (#38596 ) * refactor: remove redundant resizing strategy equality check Upstream already checks this.	2023-06-06 14:03:39 -05:00
Shelley Vohr	b2059f288a	fix: account for `BrowserView` bounds in setting autofill popup bounds (#38489 )	2023-06-06 10:21:42 +02:00
Milan Burda	bb2ba35b51	refactor: use `process_util.h` helpers (#38574 ) refactor: use process_util.h helpers	2023-06-06 17:19:13 +09:00
Shelley Vohr	8d689c565a	fix: file selection when disallowed on macOS (#38557 )	2023-06-05 14:08:10 +02:00
Charles Kerr	83d023747c	refactor: use direct aggregation in NativeWindowViews (#38559 ) * refactor: in NativeWindowViews, aggregate root_view_ directly * refactor: in NativeWindowViews, aggregate keyboard_event_handler_ directly * refactor: make NativeWindowClientView::window_ a raw_ref Xref: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++.md\#non_owning-pointers-in-class-fields Prefer const raw_ref<T> whenever the held pointer will never be null * chore: make lint happy	2023-06-05 14:37:46 +09:00
Charles Kerr	05db963f87	chore: remove unused electron::api::View code (#38561 ) chore: remove unused electron::api::View methods Remove code that was added in `2c8dc9e` but never used.	2023-06-03 10:40:44 -05:00
Charles Kerr	f247ca3f62	perf: avoid unnecessary base value clone (#38537 )	2023-06-02 08:38:29 -05:00
Charles Kerr	c14f7b7d0b	refactor: remove unused switches (#38497 ) * refactor: remove unused declaration of electron::kSHA1Certificate usage removed in `13a1d79` * refactor: remove unused declaration of electron::kSHA1MajorDescription usage removed in `13a1d79` * refactor: remove unused declaration of electron::kSHA1MinorDescription usage removed in `13a1d79` * refactor: remove unused declaration of electron::kCertificateError usage removed in `13a1d79` * refactor: remove unused declaration of electron::kValidCertificate usage removed in `13a1d79` * refactor: remove unused declaration of electron::kValidCertificateDescription usage removed in `13a1d79` * refactor: remove unused declaration of electron::kSecureProtocol, kSecureProtocolDescription usage removed in `497f5a1` * refactor: remove electron::options::kPreloadScripts removed in `bad8d5e0` * refactor: remove electron::options::kImageAnimationPolicy removed in `385d0f5`	2023-05-31 15:55:21 -04:00
Shelley Vohr	57147d1b8d	fix: `navigator.connection` not working as intended (#38491 ) * fix: navigator.connection not working as intended * chore: make network quality methods private	2023-05-31 11:06:25 -04:00
Shelley Vohr	663497dc6b	chore: make `contentTracing.stopRecording()` failure clearer (#38488 ) chore: make contentTracing.stopRecording() failure clearer	2023-05-31 09:54:41 -04:00
Shelley Vohr	40e724e5dd	fix: DCHECK minimizing parent window with non-modal child (#38460 )	2023-05-31 11:57:44 +02:00
John Kleinschmidt	b4ec363b3d	feat: add USB protected classes handler (#38263 ) * feat: add USB protected classes handler * chore: apply review suggestions Co-authored-by: Charles Kerr <charles@charleskerr.com> * chore: update docs * chore: apply review suggestions * update doc per suggestion --------- Co-authored-by: Charles Kerr <charles@charleskerr.com>	2023-05-30 12:35:25 -04:00
Charles Kerr	0203bd3305	refactor: prefer base::Contains() over find() + end() (#38443 ) * refactor: use base::Contains() in KeyWeakMap::Has() * refactor: use base::Contains() in WebRequest::RequestFilter::MatchesType() * refactor: use base::Contains() in BaseWindow::AddBrowserView() * refactor: use base::Contains() in DeepFreeze() * refactor: use base::Contains() in Clipboard::Read() * Revert "refactor: use base::Contains() in BaseWindow::AddBrowserView()" This reverts commit 60152359d3978451ebdd7c8eed602c2fb8a9cafa. * refactor: use base::Contains() in BaseWindow::AddBrowserView() * refactor: use base::Contains() in IsDevToolsFileSystemAdded() * refactor: use base::Contains() in MessagePort::DisentanglePorts() * refactor: use base::Contains() in PowerSaveBlocker::IsStarted() * refactor: use base::Contains() in SpellCheckClient::OnSpellCheckDone() * refactor: use base::Contains() in ShowTaskDialogWstr() * refactor: use base::Contains() in PrintViewManagerElectron::ScriptedPrint() * refactor: use base::Contains() in PrintViewManagerElectron::DidGetPrintedPagesCount() * refactor: use base::Contains() in NativeWindow::AddDraggableRegionProvider() * refactor: use base::Contains() in ElectronBindings::ActivateUVLoop() * refactor: use base::Contains() in NativeWindowViews::IsVisibleOnAllWorkspaces() * refactor: use base::Contains() in HidChooserController::OnDeviceAdded() * refactor: use base::Contains() in ElectronSandboxedRendererClient::WillReleaseScriptContext() * refactor: use base::Contains() in ElectronRendererClient::WillDestroyWorkerContextOnWorkerThread() * refactor: use base::Contains() in GlobalShortcut::OnKeyPressed()	2023-05-30 10:28:43 +02:00
Shelley Vohr	56138d879e	fix: Windows FrameView always appearing inactive (#38468 )	2023-05-28 18:39:13 -04:00
Charles Kerr	a20896f519	refactor: remove InspectableWebContents::GetAll() (#38442 ) It is unused and also keeps a persistent std::list<>, so remove it.	2023-05-25 17:23:19 +09:00
Milan Burda	06cc9caeaa	build: remove enable_desktop_capturer flag (#38412 ) feat: remove enable_desktop_capturer flag Co-authored-by: Milan Burda <miburda@microsoft.com>	2023-05-24 15:32:31 -04:00
Milan Burda	2f8e68f8b3	chore: remove ViewsDelegate::IsWindowInMetro() override (#38409 ) Co-authored-by: Milan Burda <miburda@microsoft.com>	2023-05-24 20:00:52 +02:00
Shelley Vohr	16cd486356	fix: `MediaDevices` missing `DisplayMediaInformation` (#38390 ) fix: MediaDevices missing DisplayMediaInformation	2023-05-24 11:17:08 -04:00
Milan Burda	b6ef4a3929	build: remove unused enable_tts build flag (#38420 ) chore: remove unused enable_tts build flag Co-authored-by: Milan Burda <miburda@microsoft.com>	2023-05-24 10:18:43 +02:00
Cheng Zhao	dec9a1d9db	chore: remove dead draggable region code (#38404 )	2023-05-24 10:03:07 +02:00
Charles Kerr	b6c80ba646	fix: `dangling_raw_ptr` warning in `electron_api_web_contents` (#38403 ) fix: dangling_raw_ptr warning in electron_api_web_contents	2023-05-23 21:52:07 -04:00
Charles Kerr	30e992dec4	chore: bump chromium to 115.0.5786.0 (main) (#38301 ) * chore: bump chromium in DEPS to 115.0.5772.0 * chore: update disable_color_correct_rendering.patch no manual changes; patch succeeded with fuzz 2. * chore: update chromium/build_libc_as_static_library.patch no manual changes; patch succeeded with fuzz 2 (offset 1 line). * chore: update chromium/feat_configure_launch_options_for_service_process.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4518747 patch manually reapplied due to upstream code shear * chore: update chromium/chore_patch_out_profile_methods_in_profile_selections_cc.patch https://chromium-review.googlesource.com/c/chromium/src/+/4502965 patch manually reapplied due to upstream code shear * chore: update bundle_locations #include location Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4525355 * chore: Remove `extension_name` from DesktopStreamsRegistry Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4514081 * chore: bump chromium in DEPS to 115.0.5778.0 * chore: add chromium/chore_patch_out_profile_methods_in_chrome_browser_pdf.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4482679 Another instance of patching out upstream references to Profile code * refactor: add WebViewGuestDelegate::GetGuestDelegateWeakPtr() Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4515455 This approach copied from GuestViewBase::GetGuestDelegateWeakPtr() approach in that same commit. * fixup! chore: update bundle_locations #include location Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4525355 Sync namespace use to upstream base::mac -> base::apple changes * fixup! chore: update bundle_locations #include location Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4525355 Sync namespace use to upstream base::mac -> base::apple changes * chore: update chromium/mas_disable_remote_accessibility.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4530546 patch manually reapplied due to upstream code shear * chore: update chromium/printing.patch no manual changes; patch succeeded with fuzz * chore: update chromium/build_add_electron_tracing_category.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4517872 no manual changes; patch succeeded with fuzz * chore: update chromium/feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4529098 patch manually reapplied due to upstream code shear * chromium/build_only_use_the_mas_build_config_in_the_required_components.patch https://chromium-review.googlesource.com/c/chromium/src/+/4529098 patch manually reapplied due to upstream code shear * chore: update chromium/mas-cgdisplayusesforcetogray.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4529475 no manual changes; patch succeeded with fuzz * chore: update chromium/build_only_use_the_mas_build_config_in_the_required_components.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4429011 no manual changes; patch succeeded with fuzz * chore: remove chromium/cherry-pick-48a136e77e6d.patch already present upstream * chore: remove chromium/cherry-pick-e6e23ba00379.patch already present upstream * [Code Health] Remove value based RegisterPref for Dict and List Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4533537 * Remove `cxx17_backports.h` and adjust unittest file Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4534916 Notes: mostly just removing #include and s/base::clamp/std::clamp/ * refactor: add FakeBrowserProcess helper class Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4424072 Used in ElectronBrowserMainParts' fake_browser_process_ field. Previously this was an BrowserProcessImpl instance, but upstream 4424072 makes that an abstract base class. `FakeBrowserProcess` is a thin subclass with the minimum code needed to make it concrete. `ElectronBrowserMainParts::fake_browser_process_` is now a `shared_ptr` instead of a `unique_ptr` so we can avoid exposing `FakeBrowserProcess` in the header. * fixup! refactor: add FakeBrowserProcess helper class remove unnecessary unique_ptr * fix: Browser::SetDockIcon() when !Browser.is_ready() Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4410741 An alternative fix for https://github.com/electron/electron/pull/36279 . The previous fix was to call `SetSupportedScales()` ourselves (`1b1609a`), but upstream has removed this API. CC @codebytere * fixup! chore: remove chromium/cherry-pick-e6e23ba00379.patch * chore: update chromium/export_gin_v8platform_pageallocator_for_usage_outside_of_the_gin.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4517404 patch manually reapplied due to upstream code shear * chore: update patches * chore: add dep: resource_coordinator:mojo_bindings Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4521464 * fixup! chore: add dep: resource_coordinator:mojo_bindings chore: make lint happy * chore: patch out Profile methods in titlebar_config Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4508143 (primary) Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4534461 (followup) * chore: bump chromium in DEPS to 115.0.5780.0 * chore: update chromium/disable_hidden.patch no manual changes; patch succeeded with fuzz * chore: update chromium/sysroot.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4535715 no manual changes; patch succeeded with fuzz * chore: update chromium/feat_enable_offscreen_rendering_with_viz_compositor.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4403623 patch manually reapplied due to upstream code shear * chore: update chromium/refactor_expose_cursor_changes_to_the_webcontentsobserver.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4547380 patch manually reapplied due to upstream code shear * chore: update patches * fixup! fix: Browser::SetDockIcon() when !Browser.is_ready() chore: iwyu image.h * chore: bump chromium in DEPS to 115.0.5782.0 * chore: bump chromium in DEPS to 115.0.5784.0 * 4514181: CR2023: Update filled cr-input styles. https://chromium-review.googlesource.com/c/chromium/src/+/4514181 * 4521894: Remove SiteInstanceDeleting usage outside of tests. https://chromium-review.googlesource.com/c/chromium/src/+/4521894 * 4525355: Move backup_util and bundle_locations to base/apple https://chromium-review.googlesource.com/c/chromium/src/+/4525355 * 4484743: webauthn: add underlying support for calling iCloud Keychain on macOS. https://chromium-review.googlesource.com/c/chromium/src/+/4484743 * chore: fixup patch indices * 4546398: Convert /chrome/browser to use ARC https://chromium-review.googlesource.com/c/chromium/src/+/4546398 * chore: bump chromium in DEPS to 115.0.5786.0 * chore: update patches * 4540682: Initialize PDF SDK with policy in chrome_pdf::RenderPDFPageToDC() https://chromium-review.googlesource.com/c/chromium/src/+/4540682 * Don't import ObjC++ fn headers into electron_api_app * 4535715: Refactor sysroot-creator.sh https://chromium-review.googlesource.com/c/chromium/src/+/4535715 * fixup! refactor: add FakeBrowserProcess helper class * 4531903: [string][test] Create/Copy strings to old space before externalization https://chromium-review.googlesource.com/c/v8/v8/+/4531903 * 59645: Add APIs to support RSA keys with large e. https://boringssl-review.googlesource.com/c/boringssl/+/59645 --------- Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>	2023-05-23 21:58:58 +02:00
Milan Burda	2acb97aa85	chore: eliminate a few uses of base::AdaptCallbackForRepeating() (#38293 )	2023-05-18 17:01:44 -04:00
Shelley Vohr	32d8f84cad	fix: `getNormalBounds()` for transparent windows on Windows (#38218 )	2023-05-17 13:11:43 +02:00
Shelley Vohr	ad07712561	fix: `win.isMaximized()` for transparent windows on Windows (#38234 )	2023-05-17 10:17:08 +02:00
Shelley Vohr	e83197669c	fix: unify `BrowserWindow.isVisible()` logic cross-platform (#38242 )	2023-05-16 11:46:45 +02:00
Shelley Vohr	042663e190	fix: `isMaximized` after minimize/fullscreen on macOS (#38291 ) fix: isMaximized after isMinimized on macOS	2023-05-16 09:26:41 +02:00
Shelley Vohr	e19500fa03	feat: support Mica/Acrylic on Windows (#38163 ) * feat: support Mica/Acrylic on Windows * chore: feedback from review	2023-05-15 16:31:57 -04:00
Shelley Vohr	c2d7164021	chore: remove unnecessary spellchecker revert patch (#38248 )	2023-05-15 16:17:00 -04:00
Shelley Vohr	e7fc1a422d	feat: add missing 'cursor-changed' type values (#38210 )	2023-05-15 10:27:09 +02:00
Milan Burda	0149ae72e6	refactor: use standard naming for enum class values (#38232 )	2023-05-12 15:24:01 +02:00
Milan Burda	88a9962e22	refactor: convert HashAlgorithm to enum class (#38233 )	2023-05-12 15:23:42 +02:00
John Kleinschmidt	3dbc0a365f	chore: enable check raw ptr fields (#38167 )	2023-05-11 16:07:39 -04:00
electron-roller[bot]	894e056e6b	chore: bump chromium to 115.0.5760.0 (main) (#38033 ) * chore: bump chromium in DEPS to 114.0.5721.0 * chore: update patches * chore: bump chromium in DEPS to 114.0.5723.0 * chore: update patches * chore: bump chromium in DEPS to 114.0.5725.0 * chore: update patches * chore: bump chromium in DEPS to 114.0.5727.0 * chore: bump chromium in DEPS to 114.0.5729.0 * chore: bump chromium in DEPS to 114.0.5731.0 * chore: update patches * 4450570: Clean up content shell https://chromium-review.googlesource.com/c/chromium/src/+/4450570 * 4262527: geolocation: Introduce mojom::GeopositionResult https://chromium-review.googlesource.com/c/chromium/src/+/4262527 * `4450327`: Android/Nav: Stop taking content timeout timer from old host. https://chromium-review.googlesource.com/c/chromium/src/+/4450327 Also, see: 4451366: Reland "Prerender: Fix prerender new content timeout start timing" https://chromium-review.googlesource.com/c/chromium/src/+/4451366 * chore: bump chromium in DEPS to 114.0.5733.2 * chore: update patches * chore: bump CircleCI xcode version this will hopefully get us the necessary macOS sdk 13.3 on CI. * chore: bump chromium in DEPS to 114.0.5735.0 * chore: update patches * test: fix geolocation test * chore: bump chromium in DEPS to 115.0.5736.0 * chore: update patches * chore: bump chromium in DEPS to 115.0.5738.0 * chore: update patches * fix: remove profiles from spellcheck service * chore: update libc++ filenames * chore: bump chromium in DEPS to 115.0.5740.0 * chore: update patches * chore: bump chromium in DEPS to 115.0.5742.0 * chore: update patches * chore: bump chromium in DEPS to 115.0.5744.0 * chore: update patches * chore: bump chromium in DEPS to 115.0.5746.0 * chore: update patches * chore: update filenames.libcxx.gni * chore: bump chromium in DEPS to 115.0.5748.0 * chore: update patches * build: update libcxx filenames * chore: bump chromium in DEPS to 115.0.5750.0 * chore: bump chromium in DEPS to 115.0.5752.2 * chore: bump chromium in DEPS to 115.0.5754.0 * chore: bump chromium in DEPS to 115.0.5756.0 * chore: bump chromium in DEPS to 115.0.5758.0 * chore: update patches * chore: update patch after rebase * 4500969: Delete content/dev_ui_content_resources.grd file. https://chromium-review.googlesource.com/c/chromium/src/+/4500969 * Use base.Value.Dict in OmahaAttributesHandler related code https://chromium-review.googlesource.com/c/chromium/src/+/4506402 * chore: bump chromium in DEPS to 115.0.5760.0 * chore: update patches * chore: fixup line endings * 4336172: Include client-drawn window decorations in aspect ratio. \| Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4336172 (cherry picked from commit 27c2f6c43e8e4a792b33fdf8cf3af880376406be) * spec: fix race condition in alwaysOnTop test (cherry picked from commit 2ec5213fa0998d9cf21248257e7b5a5581044ea3) * build: use xcode 14.2 not 14.3 (cherry picked from commit b7c62351a77102e854a801c363f391b177ebf672) * build: use macOS 12 to run tests The new macOS 13 VMs appear to have different screen / display behavior (cherry picked from commit 14dc1dbc24cec85111a7482b49049f6acbfbc5f1) * Remove always-true flag --harmony-sharedarraybuffer https://chromium-review.googlesource.com/c/v8/v8/+/4429630 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: clavin <clavin@electronjs.org> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: Keeley Hammond <vertedinde@electronjs.org> Co-authored-by: VerteDinde <keeleymhammond@gmail.com> Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>	2023-05-10 10:47:48 -04:00
Shelley Vohr	13e309e1fb	fix: only exit fullscreen conditionally with `setKiosk` (#38219 ) fix: only exit fullscreen conditionally with setKiosk	2023-05-09 12:28:37 -04:00
Shelley Vohr	f432245456	fix: handle `AXManualAccessibility` attribute cross-protocol (#38142 ) * fix: handle AXManualAccessibility attribute cross-protocol * Update shell/browser/mac/electron_application.mm Co-authored-by: Robo <hop2deep@gmail.com> --------- Co-authored-by: Robo <hop2deep@gmail.com>	2023-05-09 11:13:14 +02:00
Shelley Vohr	a6c9aefb4a	chore: fix TrustedTypes policy in `chrome://accessibility` (#38179 ) chore: fix TrustedTypes policy in chrome://accessibility	2023-05-08 10:39:04 +02:00
Shelley Vohr	35a03a6bc1	refactor: remove IPC from mouse_util (#38183 )	2023-05-08 09:50:30 +02:00
Shelley Vohr	f8d534f33e	chore: stop using a `RenderWidgetHost` observer in `FileSelectHelper` (#38168 ) chore: stop using a RenderWidgetHost observer in FileSelectHelper	2023-05-04 21:43:29 +02:00
Shelley Vohr	ee1e6aab3e	chore: implement `WebContentsDelegate::GetFullscreenState` (#38141 ) Refs https://chromium-review.googlesource.com/c/chromium/src/+/4255184	2023-05-03 15:55:47 +02:00
Shelley Vohr	a8c0ed890f	feat: surface more `webContents` text selection commands (#37978 ) * feat: surface more text selection commands * refactor: use options argument * docs: correct for review	2023-05-02 21:14:29 -04:00
David Sanders	a26343f3e0	fix: falsy transparent shouldn't affect webContents background (#36914 )	2023-05-02 14:44:34 -07:00
Shelley Vohr	d95f9d2c63	chore: add OCR scaffolding to PDF Viewer (#38127 )	2023-05-02 10:27:32 +02:00
Milan Burda	7c482518bf	chore: add missing content::WebContentsDelegate section (#38133 )	2023-05-01 09:23:47 -04:00
Shelley Vohr	ba8887f586	feat: emit `context-menu` event from extensions (#38029 ) feat: emit context-menu event from extensions	2023-04-27 12:54:51 +02:00
Shelley Vohr	f35b9b3f06	fix: `AXManualAccessibility` showing failure (#38102 ) fix: AXManualAccessibility showing failure	2023-04-26 19:41:56 +02:00
Bruno Pitrus	a0a44f07dd	chore: correct extra qualification causing build error with GCC (#37548 ) * chore: correct extra qualification causing build error with GCC * fixup for lint * chore: fix lint --------- Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>	2023-04-26 10:40:02 -04:00
David Sanders	08593fd2bd	chore: fix clang-tidy warnings (#38079 ) * chore: fix clang-tidy warnings * refactor: avoid need for NOLINTNEXTLINE	2023-04-26 10:09:54 -04:00
Shelley Vohr	f4b7e59b2d	fix: crash on missing `RenderWidgetHostView` (#38100 ) chore: fix crash on missing RenderWidgetHostView	2023-04-25 11:30:16 +02:00
Milan Burda	964934c161	fix: defaults broken in shell.openExternal() options (#38038 ) Co-authored-by: Milan Burda <miburda@microsoft.com>	2023-04-21 13:13:59 -04:00
Robo	0240f6664e	fix: crash in utilityProcess when generating code from strings (#38014 )	2023-04-20 09:27:02 +09:00
Jeremy Rose	ba835ddac1	feat: add thermal states to powerMonitor (#37935 ) * feat: add thermal states to powerMonitor * update docs	2023-04-19 11:46:55 +02:00
electron-roller[bot]	de192c2db2	chore: bump node to v18.16.0 (main) (#37973 ) * chore: bump node in DEPS to v18.16.0 * build,test: add proper support for IBM i https://github.com/nodejs/node/pull/46739 * lib: enforce use of trailing commas https://github.com/nodejs/node/pull/46881 * src: add initial support for single executable applications https://github.com/nodejs/node/pull/45038 * lib: do not crash using workers with disabled shared array buffers https://github.com/nodejs/node/pull/41023 * src: remove shadowed variable in OptionsParser::Parse https://github.com/nodejs/node/pull/46672 * src: allow embedder control of code generation policy https://github.com/nodejs/node/pull/46368 * src: allow optional Isolate termination in node::Stop() https://github.com/nodejs/node/pull/46583 * lib: fix BroadcastChannel initialization location https://github.com/nodejs/node/pull/46864 * chore: fixup patch indices * chore: sync filenames.json * fix: add simdutf dep to src/inspector BUILD.gn - https://github.com/nodejs/node/pull/46471 - https://github.com/nodejs/node/pull/46472 * deps: replace url parser with Ada https://github.com/nodejs/node/pull/46410 * tls: support automatic DHE https://github.com/nodejs/node/pull/46978 * fixup! src: add initial support for single executable applications * http: unify header treatment https://github.com/nodejs/node/pull/46528 * fix: libc++ buffer overflow in string_view ctor https://github.com/nodejs/node/pull/46410 * test: include strace openat test https://github.com/nodejs/node/pull/46150 * fixup! fixup! src: add initial support for single executable applications --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>	2023-04-18 22:23:11 +02:00
Shelley Vohr	32afdda9ee	feat: add `did-resign-active` event on app (#37933 ) feat: add did-resign-active event on app	2023-04-18 16:53:39 +02:00
electron-roller[bot]	7a6af1a529	chore: bump chromium to 114.0.5715.0 (main) (#37976 ) * chore: bump chromium in DEPS to 114.0.5712.0 * chore: update patches * 4401084: Remove extensions::InfoMap which is no longer needed. \| https://chromium-review.googlesource.com/c/chromium/src/+/4401084 * 4415646: Add more details to print settings error log \| https://chromium-review.googlesource.com/c/chromium/src/+/4415646 * chore: bump chromium in DEPS to 114.0.5714.0 * chore: update patches * chore: update libcxx filenames * chore: bump chromium in DEPS to 114.0.5715.0 * chore: update patches * fix extensions test --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: VerteDinde <vertedinde@electronjs.org> Co-authored-by: Jeremy Rose <jeremya@chromium.org>	2023-04-17 14:40:26 -07:00
Alexey Kuzmin	1ffe7ee76b	build: fix building with no PDF support (#38003 )	2023-04-17 11:02:43 -04:00
Shelley Vohr	f0e1848a5e	chore: replace uses of `ComPtr::GetAddressOf()` with `ComPtr::operator&` (#37948 ) chore: replace uses of ComPtr::GetAddressOf() with ComPtr::operator&	2023-04-16 17:08:37 -07:00
Shelley Vohr	fa3379a5d5	chore: fix lint (#37971 )	2023-04-13 15:54:41 +02:00
David Sanders	e84bcb39e7	fix: defaultFontFamily in webPreferences (#37863 ) * fix: defaultFontFamily in webPreferences * chore: check if default_font_family_ is empty	2023-04-13 11:30:25 +02:00
Shelley Vohr	fceeb64e7c	fix: swipe event emission on macOS (#37946 )	2023-04-13 11:28:22 +02:00
electron-roller[bot]	33a625d0ee	chore: bump chromium to 114.0.5710.0 (main) (#37950 ) * chore: bump chromium in DEPS to 114.0.5710.0 * chore: update patches * 4411421: [json-schema-compiler] Support separating numbers in enum entries \| https://chromium-review.googlesource.com/c/chromium/src/+/4411421 * 4400251: Remove MayBlock and TaskShutdownBehavior from BrowserTaskTraits \| https://chromium-review.googlesource.com/c/chromium/src/+/4400251 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Keeley Hammond <vertedinde@electronjs.org> Co-authored-by: VerteDinde <keeleymhammond@gmail.com>	2023-04-12 18:10:31 -07:00
Jeremy Rose	fef1b04238	feat: remove on(ready) requirement from powerMonitor (#37937 )	2023-04-12 15:37:52 -07:00
electron-roller[bot]	908bef7ca9	chore: bump chromium to 114.0.5708.0 (main) (#37834 ) * chore: bump chromium in DEPS to 114.0.5696.0 * chore: update patches * chore: revert clang revert (cherry picked from commit 4c3ffa8001b5fdbfc99374bf77895d8d8e35ee31) * test: remove unneeded test for title on ses.setCertificateVerifyProc This test is unnecessary because all that really needs to be verified is that the request was rejected. * chore: Revert "Reland "[BRP] Enable clang plugin check for Linux"" * chore: bump chromium in DEPS to 114.0.5697.0 * chore: bump chromium in DEPS to 114.0.5698.0 * chore: update patches * chore: bump chromium in DEPS to 114.0.5700.0 * chore: update patches * chore: bump chromium in DEPS to 114.0.5702.0 * chore: bump chromium in DEPS to 114.0.5704.0 * chore: update patches * chore: bump chromium in DEPS to 114.0.5705.0 * 4368281: Add bottom-up CertVerifier change observer flow. \| https://chromium-review.googlesource.com/c/chromium/src/+/4368281 * 4402277: Enable check_raw_ptr_fields for Linux \| https://chromium-review.googlesource.com/c/chromium/src/+/4402277 * 4389621: [ChromeAppsDeprecation] Remove deprecated chrome apps from AppService \| https://chromium-review.googlesource.com/c/chromium/src/+/4389621 * 4402191: Allow default initializing BrowserTaskTraits \| https://chromium-review.googlesource.com/c/chromium/src/+/4402191 * chore: bump chromium in DEPS to 114.0.5708.0 * chore: remove incorrectly re-added clang patch * chore: update patches (clean sync) * ci: use newer clang for 32-bit Linux ARM Fixes crash on compiling skia/skia/SkPatchUtils.cpp * build: generate new libcxx filenames * 4409898: Update paper printable area in UpdatePrintSettings \| https://chromium-review.googlesource.com/c/chromium/src/+/4409898 * chore: update sysroots.json Sysroot CL: https://chromium-review.googlesource.com/c/chromium/src/+/4383374 Chromium CL: 4246577: media/gpu: Add CQP AV1 VA-API video encoder \| https://chromium-review.googlesource.com/c/chromium/src/+/4246577 * 4336198: [task] Move source location and use it in v8 platform \| https://chromium-review.googlesource.com/c/v8/v8/+/4336198 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: VerteDinde <vertedinde@electronjs.org> Co-authored-by: VerteDinde <keeleymhammond@gmail.com> Co-authored-by: electron-patch-conflict-fixer[bot] <83340002+electron-patch-conflict-fixer[bot]@users.noreply.github.com>	2023-04-12 07:37:48 -04:00
Samuel Attard	c01dff8d89	fix: exceptions during function/promise result conversions live in calling world (#37904 )	2023-04-11 11:57:48 +02:00
Shelley Vohr	c65632d404	fix: broken buttons in PDF viewer (#37856 )	2023-04-11 15:30:36 +09:00
David Sanders	adb1172066	chore: use nested namespaces (#37855 )	2023-04-11 15:30:25 +09:00
David Sanders	e929b2140d	chore: change some for loops to range-based (#37857 )	2023-04-11 15:27:07 +09:00
David Sanders	82442239bc	chore: use emplace when possible (#37877 )	2023-04-11 15:21:03 +09:00
Samuel Attard	6958668448	fix: exceptions in nested conversions live in the target world (#37895 )	2023-04-10 14:58:27 -07:00
Shelley Vohr	251e567eff	fix: don't emit `did-fail-load` for MediaDocuments (#37824 ) * fix: don't emit did-fail-load for MediaDocuments * spec: add test	2023-04-06 10:23:34 +02:00
Fedor Indutny	6bfef67aae	feat: session.resolveHost (#37690 ) * feat: session.resolveHost Expose Chromium's host resolution API through the Session object. * Update shell/browser/api/electron_api_session.cc Co-authored-by: Jeremy Rose <nornagon@nornagon.net> * address feedback * fix tests * address feedback * Add options * Update shell/browser/api/electron_api_session.cc Co-authored-by: Cheng Zhao <github@zcbenz.com> * Update shell/browser/net/resolve_host_function.cc Co-authored-by: Cheng Zhao <github@zcbenz.com> * lint * return object * add missing file * fix crash * handle scope * links --------- Co-authored-by: Fedor Indutny <indutny@signal.org> Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com> Co-authored-by: Jeremy Rose <nornagon@nornagon.net> Co-authored-by: Cheng Zhao <github@zcbenz.com>	2023-04-05 10:06:14 -04:00
Shelley Vohr	3f42040a1b	fix: Fn+F fullscreen transitioning on macOS (#37803 )	2023-04-04 15:16:59 +02:00
Jeremy Rose	e9d5c3517c	fix: apply csp correctly when contextIsolation: false (#37756 ) * fix: apply csp correctly when contextIsolation: false * better comments	2023-04-04 17:31:49 +09:00
Jeremy Rose	f40bd2da23	fix: record helper error messages in electron_main_mac (#37807 )	2023-04-03 13:14:19 -07:00
David Sanders	6012172187	fix: set background color for menu bar on Windows (#37766 )	2023-03-31 18:06:09 +02:00
electron-roller[bot]	3fa03977c7	chore: bump chromium to 114.0.5684.0 (main) (#37701 ) * chore: bump chromium in DEPS to 113.0.5672.0 * chore: bump chromium in DEPS to 114.0.5673.0 * chore: bump chromium in DEPS to 114.0.5675.0 * chore: update patches * 4223697: [json-schema-compiler] T::Populate with base::Value::Dict https://chromium-review.googlesource.com/c/chromium/src/+/4223697 * chore: update filenames.libcxx.gni * 4290476: Report an explicit pause reason when stopping after taking a step. https://chromium-review.googlesource.com/c/v8/v8/+/4290476 * chore: bump chromium in DEPS to 114.0.5682.0 * 4373699: [SystemProfileSelectionDefaultNone] Enable feature by default https://chromium-review.googlesource.com/c/chromium/src/+/4373699 * chore: update patches * Revert AsyncCompileJSToWasmWrapperJob simplification https://chromium-review.googlesource.com/c/v8/v8/+/4347597/11 * 4365718: Reland "Reland "Reland "[Tracing] Use Perfetto client library for tracing on Linux""" https://chromium-review.googlesource.com/c/chromium/src/+/4365718 * chore: bump chromium in DEPS to 114.0.5684.0 * chore: update patches * 4335544: [handles] Refactor classes for abstract handles https://chromium-review.googlesource.com/c/v8/v8/+/4335544 * update patch description to include tracking issue --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>	2023-03-30 22:03:58 -04:00
Will Anderson	2b9dae4b06	feat: add `will-frame-navigate` event (#34418 ) * feat: add will-navigate-in-frame event to webContents * docs: add documentation for webview will-frame-navigate event * feat: Eliminate isInPlace argument from will-frame-navigate event * fix: Fire will-frame-navigate before will-navigate * feat: send will-frame-navigate with a WebFrameMain in the event details * docs: Update WebContents docs for new API signature * feat: Add custom event forwarding for <webview> will-frame-navigate * fix: wrap WebFrameMain so it can be sent as an event * test: update webContents and <webview> tests to match new signatures * chore: undo unnecessary change * fix: don't switch will-navigate to use EmitNavigationEventDetails * test: clean up will-navigate and will-frame-navigate tests for <webview> * chore: apply lint fixes * chore: move GetRenderFrameHost helper into anonymous namespace * docs: auto-generate WillFrameNavigateDetails rather than defining it manually * test: Update <webview> tests to actually pass under new spec runner * docs: Add section explaining relationship between various nav events * test: Add some tests to ensure navigation event order doesn't silently change * test: Always monitor all nav events to ensure unexpected ones don't fire * test: Add test to verify in-page navigation event order * feat: Change to new style where extra params are exposed as event props * fix: Remove unused EmitNavigationEventDetails * fix: Update tests to use new async helpers * docs: Rename and reorder sections documenting navigation events --------- Co-authored-by: Milan Burda <milan.burda@gmail.com>	2023-03-28 10:55:41 -04:00
Shelley Vohr	4c6092e151	fix: draggable regions shouldn't capture clicks on frames windows (#37594 )	2023-03-28 10:52:28 -04:00
Shelley Vohr	97b19a7946	chore: generator objects can't be sent over the context bridge (#37593 ) * chore: generator objects can't be sent over the context bridge * Trigger Build --------- Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>	2023-03-27 20:36:55 -04:00
Shelley Vohr	b27e4cae21	fix: crash in `MessagePortMain` with some `postMessage` params (#37585 ) * fix: crash in MessagePortMain postMessage * Update shell/browser/api/message_port.cc Co-authored-by: Charles Kerr <charles@charleskerr.com> --------- Co-authored-by: Charles Kerr <charles@charleskerr.com>	2023-03-27 13:56:55 -04:00
Jeremy Rose	fda8ea9277	feat: add protocol.handle (#36674 )	2023-03-27 10:00:55 -07:00
John Kleinschmidt	6a6908c4c8	fix: allow cancelling of bluetooth requests (#37601 ) * fix: allow cancelling of bluetooth requests allows cancelling of bluetooth requests when no devices present * docs: update docs to reflect how bluetooth works.	2023-03-27 09:31:15 -04:00
electron-roller[bot]	916861036d	chore: bump chromium to 113.0.5668.0 (main) (#37646 ) * chore: bump chromium in DEPS to 113.0.5668.0 * chore: update patches * chore: fixup for lint --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>	2023-03-22 20:09:13 -04:00
electron-roller[bot]	5023b49713	chore: bump chromium to 113.0.5666.0 (main) (#37634 ) * chore: bump chromium in DEPS to 113.0.5666.0 * chore: update patches * Make Clear-Site-Data: "cookies" respect third-party cookie blocking https://chromium-review.googlesource.com/c/chromium/src/+/4346675 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>	2023-03-21 21:19:23 -04:00
electron-roller[bot]	46d3c4e04f	chore: bump chromium to 113.0.5664.0 (main) (#37620 ) * chore: bump chromium in DEPS to 113.0.5664.0 * chore: update patches * [Code Health] Migrate to WebUIDataSource::CreateAndAdd(), part 8 https://chromium-review.googlesource.com/c/chromium/src/+/4121701 Needed because of 4349773: Get rid of WebUIDataSource::Create() and WebUIDataSource::Add() \| https://chromium-review.googlesource.com/c/chromium/src/+/4349773 landing --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>	2023-03-20 21:37:21 -04:00
Charles Kerr	caa5989eed	fix: avoid deprecated value apis (#37590 ) * fix: use base::Value::Dict:::Remove() instead of RemoveKe() the latter is deprecated. * fix: use base::Value::Dict::FindString() instead of base::Value::FindStringKey() The latter is deprecated. * chore: make lint happy	2023-03-20 10:38:45 -04:00
George Joseph	e0c348a2f8	feat: Allow usage of an absolute path for partitions used in a session (#37604 ) * Allow an absolute path to be used for creating sessions Allows an absolute path to be used for creating sessions by adding the session.fromPath() API. * Fixup! Clarify that an emptry string is not permitted as a parameter to fromPath()	2023-03-20 10:34:49 -04:00
Shelley Vohr	eb613ef3d4	fix: invoke `app.dock.{hide\|show}` instead of duplicating logic (#37599 ) fix: invoke app.dock.{hide\|show} instead of duplicating logic	2023-03-20 10:30:49 -04:00
Milan Burda	7ed3c7a359	chore: remove unnecessary casting to base::Value (#37591 ) Co-authored-by: Milan Burda <miburda@microsoft.com>	2023-03-20 10:26:42 -04:00
electron-roller[bot]	5261e08d0c	chore: bump chromium to 113.0.5660.0 (main) (#37612 ) * chore: bump chromium in DEPS to 113.0.5657.0 * chore: bump chromium in DEPS to 113.0.5660.0 * chore: update patches printing.patch https://chromium-review.googlesource.com/c/chromium/src/+/4347664 https://chromium-review.googlesource.com/c/chromium/src/+/4347664 https://chromium-review.googlesource.com/c/chromium/src/+/4338810 https://chromium-review.googlesource.com/c/chromium/src/+/4339496 mas_disable_remote_layer.patch https://chromium-review.googlesource.com/c/chromium/src/+/4334544 https://chromium-review.googlesource.com/c/chromium/src/+/4335299 * Add API to verify `TOP_LEVEL_STORAGE_ACCESS` permission status https://chromium-review.googlesource.com/c/chromium/src/+/4306712 * Move os_crypt into a sync/ subdirectory. https://chromium-review.googlesource.com/c/chromium/src/+/4336304 * chore: generate libc++ headers --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: deepak1556 <hop2deep@gmail.com>	2023-03-20 07:06:57 -04:00
John Kleinschmidt	9611b641c9	chore: Use thread_local: base/threading/ (#37600 ) https://chromium-review.googlesource.com/c/chromium/src/+/4335524	2023-03-17 09:27:41 -04:00
Shelley Vohr	b8f970c1c7	fix: properly bubble up cookie creation failure message (#37586 )	2023-03-16 13:48:14 +01:00
electron-roller[bot]	48d0b09ad9	chore: bump chromium to 113.0.5653.0 (main) (#37587 ) * chore: bump chromium in DEPS to 113.0.5653.0 * chore: update patches * [Extensions c2s] Move HasActiveTabAndCanAccess() to //extensions https://chromium-review.googlesource.com/c/chromium/src/+/4305558 * [Privacy Hub] Respecting ChromeOS geoloc setting https://chromium-review.googlesource.com/c/chromium/src/+/4171824 * Add runtime DLLs to win_clang_x64 when needed https://chromium-review.googlesource.com/c/chromium/src/+/4336228 * chore: fix lint --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: deepak1556 <hop2deep@gmail.com>	2023-03-16 19:03:53 +09:00
Milan Burda	6dc46e5bcf	refactor: replace deprecated base::Value::Set<Type>Key usage (#37570 ) Co-authored-by: Milan Burda <miburda@microsoft.com>	2023-03-15 09:07:51 -04:00
electron-roller[bot]	061e2e5e73	chore: bump chromium to 113.0.5651.0 (main) (#37553 ) * chore: bump chromium in DEPS to 113.0.5645.0 * chore: update patches/chromium/mas_avoid_usage_of_private_macos_apis.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4300129 Fix simple code shear * chore: update patches/chromium/build_only_use_the_mas_build_config_in_the_required_components.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4297496 Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4327491 patch-fuzz update; no manual changes * chore: remove patches/chromium/fix_x11_window_restore_minimized_maximized_window.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4252946 Upstreamed by zcbenz, so local patch is no longer needed * chore: update chromium/printing.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4313019 Remove cookie parameter from PrintViewManagerBase::UpdatePrintSettings() * chore: remove NOTIMPLEMENTED BrowserProcessImpl::GetBreadcrumbPersistentStorageManager() Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4247145 method removed upstream, so we do not need to add a stub for it in the subclass * chore: remove PrintViewManagerElectron::UpdatePrintSettings() Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4313019 Previously, our implementation checked to see if we recognized the cookie param that was passed in. If so, we reported a bad message. Otherwise, we passed it up to the base class' UpdatePrintSettings(). CL4313019 removed the cookie param, so checking for a bad cookie param is no longer necessary / no longer possible. Since the only remaining task was to pass the work up to the base class, this commit removes the subclass implmentation entirely. * chore: update patches * chore: bump chromium in DEPS to 113.0.5647.0 * chore: bump chromium in DEPS to 113.0.5649.2 * chore: bump chromium in DEPS to 113.0.5651.0 * chore: update patches --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: deepak1556 <hop2deep@gmail.com>	2023-03-15 18:20:32 +09:00
Jeremy Spiegel	bf1cc1aeb2	fix: don't set delegate for `QLPreviewPanel` (#37530 ) fix: don't set delegate for QLPreviewPanel	2023-03-14 14:41:34 +01:00
electron-roller[bot]	feaf18e371	chore: bump chromium to 113.0.5636.0 (main) (#37130 ) * chore: bump chromium in DEPS to 112.0.5576.0 * 4211172: Use the Mac ImageTransportSurface on iOS. https://chromium-review.googlesource.com/c/chromium/src/+/4211172 * 4191759: Reuse PrintBackend process from query for printing https://chromium-review.googlesource.com/c/chromium/src/+/4191759 * 4189718: Revert "[code health] Remove NotificationService use by SpellcheckService" https://chromium-review.googlesource.com/c/chromium/src/+/4189718 * 4216074: web_contents_delegate: remove content:: https://chromium-review.googlesource.com/c/chromium/src/+/4216074 * 4192284: ios: Add feature flag for PartitionAlloc. https://chromium-review.googlesource.com/c/chromium/src/+/4192284 * chore: bump chromium in DEPS to 112.0.5578.0 * 4211172: Use the Mac ImageTransportSurface on iOS. https://chromium-review.googlesource.com/c/chromium/src/+/4211172 * 4067682: Define ThirdPartyCookiesUserBypass runtime feature and plumb it through to URLRequest.cookie_setting_overrides. https://chromium-review.googlesource.com/c/chromium/src/+/4067682 * chore: fixup patch indices * 4218354: Disable the use of preserve_most on arm64 Windows https://chromium-review.googlesource.com/c/v8/v8/+/4218354 * chore: fixup patch indices * chore: bump chromium in DEPS to 112.0.5579.0 * chore: update patches * chore: bump chromium in DEPS to 112.0.5581.0 * chore: update patches * refactor: use modern base values in tracing Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4210912 * refactor: remove GetFontLookupTableCacheDir Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4191820 * refactor: base value type DICTIONARY replaced with DICT Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4198081 * chore: add stub impls for WCO routing Refs: https://chromium-review.googlesource.com/c/chromium/src/+/4182690 * refactor: rename latency metrics Refs: https://chromium-review.googlesource.com/c/chromium/src/+/4048262 * refactor: add sanitized context to clipboard write Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4178264 * refactor: s/Rect/WindowFeatures Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4167001 * refacotr: switch mojom::NetworkHintsHandler to use SchemeHostPair instead of URL Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4185417 * chore: remove dead DecodeToken code * refactor: refactoring geolocation manager Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4161603 * chore: iwyu net/cert/cert_verify_result.h * build: use xcode 14 * chore: bump chromium in DEPS to 112.0.5583.0 * chore: update patches * chore: fixup mas patches * refactor: base::span explicit conversion checks Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4219636 * chore: bump chromium in DEPS to 112.0.5591.0 * chore: bump chromium in DEPS to 112.0.5593.0 * chore: bump chromium in DEPS to 112.0.5594.3 * chore: bump chromium in DEPS to 112.0.5597.0 * chore: update chromium patches * 4242507: Move most of GetChromeKeySystems() into components/cdm Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4242507 It seems as though the bug this patch was trying to resolve is now fixed. * chore: update v8 patches * 4240798: Get rid of ShowInvalidPrinterSettingsError() in PrintManagerHost. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4240798 * 4247938: Bump min required GTK version to 3.20 Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4247938 * 4173660: Remove unused argument in BeforeUnloadCompleted Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4173660 * 4226656: Add response url to SimpleURLLoader::OnRedirectCallback Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4226656 * fixup!: 4240798: Get rid of ShowInvalidPrinterSettingsError() in PrintManager Host. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4240798 * chore: bump chromium in DEPS to 112.0.5599.0 * chore: update patches * 4251237: [StorageKey Cleanup] (2) Rename CreateFirstParty constructors Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4251237 * 4256866: [Extensions] Replace GetHooksForAPI with a RegisterHooksDelegate Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4256866 * chore: bump chromium in DEPS to 112.0.5601.0 * chore: update patches * chore: bump chromium in DEPS to 112.0.5603.0 * chore: bump chromium in DEPS to 112.0.5605.0 * chore: bump chromium in DEPS to 112.0.5607.0 * update patches * fix mas patch * chore: bump chromium in DEPS to 112.0.5609.0 * chore: update patches * build: update appveyor image 4072083: New toolchain for Windows 11 10.0.22621.755 SDK \| https://chromium-review.googlesource.com/c/chromium/src/+/4072083 * chore: bump chromium in DEPS to 112.0.5611.0 * fix patches * chore: update patches * 4261434: Remove browser_watcher (1/3): Move ExitCodeWatcher to chrome/app https://chromium-review.googlesource.com/c/chromium/src/+/4261434 * 4258446: Move network::mojom::ClearDataFilter to its own mojom file https://chromium-review.googlesource.com/c/chromium/src/+/4258446 * 4128591: Enable large pdbs by default https://chromium-review.googlesource.com/c/chromium/src/+/4128591 * move dbgcore/dbghelp to extensions_to_skip * chore: bump chromium in DEPS to 113.0.5624.0 * chore: bump chromium in DEPS to 113.0.5626.0 * chore: bump chromium in DEPS to 113.0.5628.2 * chore: bump chromium in DEPS to 113.0.5630.0 * chore: bump chromium in DEPS to 113.0.5632.0 * chore: bump chromium in DEPS to 113.0.5634.0 * chore: bump chromium in DEPS to 113.0.5636.0 * 4255184: Permit popups from fullscreen-within-tab openers https://chromium-review.googlesource.com/c/chromium/src/+/4255184 * 4297715: [mac] Introduce BluetoothLowEnergyAdapterApple to reuse CoreBluetooth https://chromium-review.googlesource.com/c/chromium/src/+/4297715 * 4301154: Remove GLContextCGL and cleanup relevant code https://chromium-review.googlesource.com/c/chromium/src/+/4301154 * 4278389: CDP: fix Page.addScriptToEvaluateOnNewDocument in iframes https://chromium-review.googlesource.com/c/chromium/src/+/4278389 * 4240798: Get rid of ShowInvalidPrinterSettingsError() in PrintManagerHost. https://chromium-review.googlesource.com/c/chromium/src/+/4240798 * 4291989: Refactor logic determining untrusted mojo invitation flag. https://chromium-review.googlesource.com/c/chromium/src/+/4291989 * 4110189: Add Select option to content touch selection menu. https://chromium-review.googlesource.com/c/chromium/src/+/4110189 * 4309923: [Extensions] Add a unit test for API permissions having features https://chromium-review.googlesource.com/c/chromium/src/+/4309923 * 4282657: Revert "[headless] Route stdio to parent console on Windows." https://chromium-review.googlesource.com/c/chromium/src/+/4282657 * 4306685: [v8] Improve V8 flag configuration to avoid errors https://chromium-review.googlesource.com/c/chromium/src/+/4306685 * 4295455: Add fallback Linux UI for when GTK 3.20 isn't available https://chromium-review.googlesource.com/c/chromium/src/+/4295455 * 4289774: Remove feature for shared sandbox policies https://chromium-review.googlesource.com/c/chromium/src/+/4289774 * 4292705: Rename WebSwapCGLLayer to ANGLESwapCGLLayer outside WebKit. https://chromium-review.googlesource.com/c/angle/angle/+/4292705 * chore: fixup patch indices * fixup! 4297715: [mac] Introduce BluetoothLowEnergyAdapterApple to reuse CoreBluetooth * 4289789: Remove base::JSONReader::ReadDeprecated https://chromium-review.googlesource.com/c/chromium/src/+/4289789 * 4281521: Remove `base::Value::FindKey()` https://chromium-review.googlesource.com/c/chromium/src/+/4281521 * 4276761: Update NAK constructor and GetIsCrossSite https://chromium-review.googlesource.com/c/chromium/src/+/4276761 * 4288119: Let GetUpload work with UploadInfo pointers https://chromium-review.googlesource.com/c/chromium/src/+/4288119 * 4285322: content: Move WebExposedIsolationLevel to its own public header https://chromium-review.googlesource.com/c/chromium/src/+/4285322 * 4251818: [Extensions] Make ExtensionSet moveable. https://chromium-review.googlesource.com/c/chromium/src/+/4251818 * 4299554: [json-schema-compiler] Refactor to Params::Create (14/74) https://chromium-review.googlesource.com/c/chromium/src/+/4299554 * chore: update printing patch indices * chore: update chromium/add_maximized_parameter_to_linuxui_getwindowframeprovider.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4295455 Our patch changes the signature of `LinuxUiTheme::GetWindowFrameProvider()`. Upstream 4295455 added a new subclass (FallbackLinuxUi) so sync its version of GetWindowFrameProvider() to match our changes. * chore: disable node test parallel/test-intl Disabling the test because upstream is still working on this feature. Xref: https://chromium-review.googlesource.com/c/v8/v8/+/4237675 Xref: https://bugs.chromium.org/p/chromium/issues/detail?id=1414292 When upstream churn is done we should re-enable this test and update it as necessary. * win7dep: Remove ResolveCoreWinRTStringDelayload Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4277708 Upstream has removed this since Win7 support is deprecated. This updates our `language_util_win.cc` file using the same approach that 4277708 uses for `base/win/win_util.cc`. * fix: remove use of ResolveCoreWinRTDelayload() Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4297979 A followup to prev commit, which removed ResolveCoreWinRTStringDelayload(). This PR follows the 4297979 approach of simply removing the calls, e.g. https://chromium-review.googlesource.com/c/chromium/src/+/4297979/4/chrome/browser/device_reauth/win/authenticator_win.cc * fix: add d3dcompiler_47 to the zip manifest Xref: https://chromium-review.googlesource.com/c/angle/angle/+/4285717 Xref (24-x-y): `0fb1def32b` * This clang roll breaks Linux arm 32-bit Xref (24-x-y): `1229114494` Xref (chromium): https://crbug.com/1410101 * fix: WebUSB on ARM64 macs (#37441) * chore: update patches * chore: fix macOS CI build. Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4278307 That whole dir was previously being removed to save space since we don't use it. We still don't use anything in the file, but gn needs it to exist. * fixup! chore: fix macOS CI build. chore: mkdir --parents does not exist on BSD; use mkdir -p * chore: update chromium/mas_disable_remote_accessibility.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4273450 Upstream added a new block of code using NSAccessibilityRemoteUIElement, so stub it out with `#if !IS_MAS_BUILD()` same as we do everwhere else. * chore: address code review nit :) --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Samuel Attard <marshallofsound@electronjs.org> Co-authored-by: Keeley Hammond <vertedinde@electronjs.org> Co-authored-by: Jeremy Rose <jeremya@chromium.org> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>	2023-03-10 10:07:42 -06:00
Shelley Vohr	8ee58e18fd	refactor: `createThumbnailFromPath` takes `size` not `maxSize` (#37362 ) refactor: createThumbnailFromPath takes size not maxSize	2023-03-08 21:48:29 -05:00
Keeley Hammond	77bd80dfb2	fix: fallback to X11 capturer if pipewire fails on Wayland (#37511 ) * fix: fallback to x11 desktop capturer on Wayland * fix: sanitize window/screen capturer inputs * chore: clean up patch description	2023-03-07 13:59:06 -08:00
John Kleinschmidt	efde7a140b	fix: WebUSB on ARM64 macs (#37441 )	2023-03-07 12:40:40 -05:00
Shelley Vohr	512e56baf7	feat: expose `audio-state-changed` on `webContents` (#37366 ) feat: expose audio-state-changed on webContents	2023-03-06 17:00:24 +01:00
Calvin	c8f715f9a1	fix: Showing the about panel is async on all platforms (#37440 ) * fix: about panel is a base::Value::Dict * nix this test for a diff PR * what if the about dialog was not blocking * add this test back in * document synchronicity * github editor is a fan of spaces	2023-03-06 09:46:35 -05:00
Shelley Vohr	829fb4f586	fix: don't double-log unhandled rejections (#37464 )	2023-03-06 11:04:43 +01:00
Shelley Vohr	17ccb3c6ec	refactor: leverage Skia helpers for NSColor ANSI logic (#37452 )	2023-03-03 09:42:50 +01:00
Jeremy Rose	6bd9ee6988	feat: net.fetch() supports custom protocols (#36606 )	2023-03-02 15:47:45 -08:00
Jeremy Rose	76c825d619	fix: draggable regions on MAS (#37466 )	2023-03-02 11:21:51 -08:00
Jeremy Rose	c3f06ef037	fix: DCHECK in MessageSync in rare cases (#37439 )	2023-03-02 10:03:52 +01:00
Shelley Vohr	9b20b3a722	chore: improve `contents.takeHeapSnapshot` error messages (#37434 ) * chore: improve contents.takeHeapSnapshot error messages * fix wstring conversion issue	2023-03-01 10:50:36 -05:00
Shelley Vohr	8f2917db01	fix: min/max width/height enforcement when `aspectRatio` is set (#37306 ) fix: min/max width/height with aspect ratio	2023-03-01 10:50:14 -05:00
Theo Gravity	49df19214e	feat: add enableLocalEcho flag to setDisplayMediaRequestHandler() callback (#37315 )	2023-03-01 11:37:19 +01:00
Shelley Vohr	5e25d23794	fix: handle closing `webContents` in `BrowserView`s (#37420 ) * fix: handle closing webContents in BrowserViews * test: add window.close() test	2023-03-01 11:35:06 +01:00
Shelley Vohr	8fb0f43030	fix: `Notification` with reply obscuring first action on macOS (#37381 ) fix: Notification with reply obscuring first action	2023-03-01 09:46:56 +01:00
Calvin	2e03bdb9b6	fix: about panel crash (#37373 ) * fix: about panel is a base::Value::Dict * nix this test for a diff PR	2023-02-28 17:26:00 -05:00
Jeremy Rose	3a5ae28c95	feat: expose initiator in navigation events (#37085 )	2023-02-28 11:08:22 -08:00
Milan Burda	ed7b5c44a2	feat: add types to webRequest filter (#30914 )	2023-02-27 11:16:59 -08:00
Jeremy Rose	e27905c765	fix: allow contextmenu event in draggable regions (#37386 )	2023-02-23 16:05:30 -08:00
Shelley Vohr	6395898a79	refactor: use associated `v8::Context` for event setup (#37355 ) refactor: use associated v8::Context for event setup	2023-02-22 10:03:46 +01:00
Shelley Vohr	32c60b29bb	fix: html fullscreen when window not fullscreenable (#37348 )	2023-02-21 12:11:34 +01:00
Black-Hole	868676aa5c	feat: add `httpOnly` `cookies.get` filter (#37255 ) feat: add httpOnly cookies filter	2023-02-21 11:44:35 +01:00
Jeremy Rose	872d1fe05a	feat: implement net.fetch (#36733 )	2023-02-20 12:57:38 -08:00
Cheng Zhao	0de1012280	feat: add BrowserWindow.set/getWindowButtonPosition APIs (#37094 )	2023-02-17 19:06:32 +09:00
Shelley Vohr	8eee4f2df1	fix: `BrowserView` crash when 'beforeunload' prevented (#37205 ) fix: crash when beforeunload prevented	2023-02-14 18:40:37 +01:00
Shelley Vohr	2e8114aea3	refactor: simplify Node.js event loop with `SpinEventLoop` (#34884 ) refactor: simplify Node.js event loop with SpinEventLoop	2023-02-14 09:54:09 +01:00
Milan Burda	a38b711fb1	feat: add logUsage to shell.openExternal() options (#37139 ) Co-authored-by: Milan Burda <miburda@microsoft.com>	2023-02-14 17:53:18 +09:00
Jeremy Rose	71944f2c3b	refactor: simplify events (#37099 )	2023-02-13 13:39:18 -08:00
Black-Hole	8b3e498436	fix: cookies filter secure invalid (#37203 )	2023-02-13 15:02:55 +01:00
Jeremy Rose	01f1522cbd	chore: change undocumented protocol.registerProtocol to detect body type (#36595 ) * feat: add protocol.registerProtocol * remove wip handleProtocol code * lint * Update shell/browser/net/electron_url_loader_factory.h Co-authored-by: Cheng Zhao <zcbenz@gmail.com> * fix --------- Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: Cheng Zhao <zcbenz@gmail.com>	2023-02-13 16:48:30 +09:00
David Sanders	a37f572388	chore: update links in comments (#37197 )	2023-02-11 18:52:54 -08:00
Milan Burda	3180312595	chore: update https://cs.chromium.org/ links to https://source.chromium.org/ (#37190 ) Co-authored-by: Milan Burda <miburda@microsoft.com>	2023-02-11 18:52:32 -08:00
Shelley Vohr	478ce96914	fix: avoid using v8 on Isolate termination (#35766 ) * fix: avoid using v8 on Isolate termination * chore: refactor for review --------- Co-authored-by: electron-patch-conflict-fixer[bot] <83340002+electron-patch-conflict-fixer[bot]@users.noreply.github.com>	2023-02-09 09:48:49 +01:00
Milan Burda	35a9e67dba	chore: rename built-in modules to bindings to match naming update in node (#37182 )	2023-02-09 10:31:38 +09:00
Bruno Pitrus	df6f99aa72	fix: correct redefinition which is invalid C++ (#36096 ) * fix: correct redefinition which is invalid C++ See https://stackoverflow.com/a/15538759 for an explanation of class scope. GCC gives an error when compiling this code: https://godbolt.org/z/sYhc3cMjE * Update export_gin_v8platform_pageallocator_for_usage_outside_of_the_gin.patch --------- Co-authored-by: Cheng Zhao <zcbenz@gmail.com> Co-authored-by: Cheng Zhao <github@zcbenz.com>	2023-02-08 16:03:47 +09:00
Milan Burda	6a3cb34326	fix: expose native bindings by process type (#35949 )	2023-02-07 20:22:18 -05:00
electron-roller[bot]	de607cbcde	chore: bump node to v18.14.0 (main) (#37129 ) * chore: bump node in DEPS to v18.14.0 * src: add support for externally shared js builtins https://github.com/nodejs/node/pull/44376 * test: fix test broken under --node-builtin-modules-path https://github.com/nodejs/node/pull/45894 * build: add option to disable shared readonly heap https://github.com/nodejs/node/pull/45887 * src: remove unnecessary semicolons https://github.com/nodejs/node/pull/46171 * src: remove return after abort https://github.com/nodejs/node/pull/46172 * chore: fixup patch indices * test_runner: parse yaml https://github.com/nodejs/node/pull/45815 * src: use simdutf for converting externalized builtins to UTF-16 https://github.com/nodejs/node/pull/46119 * src: rename internal module declaration as internal bindings https://github.com/nodejs/node/pull/45551 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>	2023-02-07 15:51:07 -05:00
Jeremy Rose	67dc178e70	refactor: move gin_helper::Constructible methods to prototype (#37087 )	2023-02-06 12:59:49 -08:00
Milan Burda	8d382b9c60	chore: remove deprecated capturer count APIs (#37075 ) chore: remove deprecated incrementCapturerCount() / decrementCapturerCount() Co-authored-by: Milan Burda <miburda@microsoft.com>	2023-02-06 07:54:47 -08:00
Samuel Attard	7dcd97f864	fix: enable basic a11y when voice control is active (#37122 ) c.f. https://chromium-review.googlesource.com/c/chromium/src/+/2680102	2023-02-06 20:32:21 +09:00
electron-roller[bot]	d02c9f8bc6	chore: bump chromium to 111.0.5544.3 (main) (#36820 ) * chore: bump chromium in DEPS to 111.0.5522.0 * chore: bump chromium in DEPS to 111.0.5524.0 * chore: bump chromium in DEPS to 111.0.5526.0 * chore: bump chromium in DEPS to 111.0.5528.0 * chore: update patches/chromium/mas_avoid_usage_of_private_macos_apis.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4132807 Fix simple code shear * chore: update patches/chromium/unsandboxed_ppapi_processes_skip_zygote.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4130675 Fix simple code shear * chore: update patches/chromium/hack_plugin_response_interceptor_to_point_to_electron.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4144281 Fix simple code shear; applied cleanly w/patch-fuzz * chore: update patches/chromium/disable_unload_metrics.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4126173 Fix simple code shear; applied cleanly w/patch-fuzz * chore: update patches/chromium/feat_add_data_parameter_to_processsingleton.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4144281 Fix simple code shear; applied cleanly w/patch-fuzz * chore: update patches/chromium/preconnect_manager.patch https://chromium-review.googlesource.com/c/chromium/src/+/4144281 Fix simple code shear; applied cleanly w/patch-fuzz * chore: update patches/v8/force_cppheapcreateparams_to_be_noncopyable.patch https://chromium-review.googlesource.com/c/v8/v8/+/3533019 Fix simple code shear; applied cleanly w/patch-fuzz * chore: update patches * chore: update patches/chromium/add_maximized_parameter_to_linuxui_getwindowframeprovider.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4128765 Upstream added a new call to HeaderContext(), whose signature we have patched * chore: bump chromium in DEPS to 111.0.5530.0 * chore: update patches * Move ChildProcessHost* from content/common to content/browser Xref: Move ChildProcessHost* from content/common to content/browser * Remove RenderViewHostChanged Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4134103 [upstream removal of RenderViewHostChanged] Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4092763 Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4093234 Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133892 Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4134103 [examples of upstream code adjusting to the change] Upstream handles this change in roughly two approaches: 1. Move the code over to RenderFrameHostChanged(old_host, new_host) but test for new_host->IsInPrimaryMainFrame() before acting 2. Migrate to the PrimaryPageChanged(page) API and use page.GetMainDocument() to get the RenderFrameHost. I've chosen 1. because electron_api_web_contents needed that pointer to old_host to call RemoveInputEventListener(), but I may be missing some context & would appreciate review on this commit. * Make electron/shell/browser/relauncher_win.cc use <winternl.h> Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4129135 Many internal Windows types are now available in winternl.h so upstrem no longer defines the types themselves. * Move ChildProcessHost* from content/common to content/browser Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4134795 * fixup! Make electron/shell/browser/relauncher_win.cc use <winternl.h> winternl.h does not define the field we need, so clone the struct Chromium was using into unnamed namespace * fixup! Move ChildProcessHost* from content/common to content/browser chore: update #includes too * chore: bump chromium in DEPS to 111.0.5532.0 * chore: sync patches/chromium/pepper_plugin_support.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133323 manually reync patch; no code changes * chore: sync patches/chromium/mas_no_private_api.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4143865 the content/common/pseudonymization_salt.cc patch is no longer needed * chore: sync patches/chromium/mas_disable_remote_accessibility.patch patch-fuzz update; no manual changes * chore: sync patches/chromium/build_do_not_depend_on_packed_resource_integrity.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4111725 manually reync patch; no code changes * chore: sync patches/chromium/create_browser_v8_snapshot_file_name_fuse.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133323 manually reync patch; no code changes * chore: sync patches/v8/fix_build_deprecated_attribute_for_older_msvc_versions.patch Xref: https://chromium-review.googlesource.com/c/v8/v8/+/4127230 patch-fuzz update; no manual changes * chore: rebuild patches * fixup! Remove RenderViewHostChanged Use PrimaryPageChanged() * chore: remove unused method TabsUpdateFunction::OnExecuteCodeFinished() Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133991 This private, already-unused function showed up as a FTBFS because it took a base::ListValue parameter and ListValue was removed upstream. * task posting v3: remove includes of runner handles and IWYU task runners Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133323 * chore: lint * chore: more lint * fixup! task posting v3: remove includes of runner handles and IWYU task runners macOS, too * fixup! task posting v3: remove includes of runner handles and IWYU task runners * chore: bump chromium in DEPS to 111.0.5534.0 * chore: sync patches/chromium/allow_new_privileges_in_unsandboxed_child_processes.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4141862 patch-fuzz update; no manual changes * chore: sync patches/chromium/logging_win32_only_create_a_console_if_logging_to_stderr.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4153110 Sync to minor upstream changes. Add const correctness. * chore: sync electron/patches/chromium/feat_configure_launch_options_for_service_process.patch https://chromium-review.googlesource.com/c/chromium/src/+/4141862 patch-fuzz update; no manual changes * chore: patches/v8/fix_build_deprecated_attribute_for_older_msvc_versions.patch sync https://chromium-review.googlesource.com/c/v8/v8/+/4147787 patch-fuzz update; no manual changes * chore: update patches * chore: bump chromium in DEPS to 111.0.5536.0 * chore: sync patches/chromium/allow_new_privileges_in_unsandboxed_child_processes.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4141863 Sync with upstream code changes. Minor code golf for readability. Note: upstream is laying groundwork for being able to work off of env vars instead of switches. Doesn't affect us yet but worth being aware of. > + // Environment variables could be supported in the future, but are not > + // currently supported when launching with the zygote. * chore: update patches/chromium/feat_expose_raw_response_headers_from_urlloader.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4126836 patch-fuzz update; no manual changes * chore: sync electron/patches/chromium/feat_configure_launch_options_for_service_process.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4141863 manual sync * chore: sync electron/patches/v8/fix_build_deprecated_attribute_for_older_msvc_versions.patch https://chromium-review.googlesource.com/c/v8/v8/+/4147788 fuzz-patch * chore: rebuild patches * chore: bump chromium in DEPS to 111.0.5538.0 * chore: bump chromium in DEPS to 111.0.5540.0 * chore: update patches * Remove sdk_forward_declarations https://chromium-review.googlesource.com/c/chromium/src/+/4166680 * task posting v3: Remove task runner handles from codebase entirely Refs https://chromium-review.googlesource.com/c/chromium/src/+/4150928 * Cleanup child_process_launcher_helper* Refs https://chromium-review.googlesource.com/c/chromium/src/+/4141863 * fix: utilityprocess spec on macOS * fix: build on windows Refs https://chromium-review.googlesource.com/c/chromium/src/+/4141863 * chore: fix lint * chore: bump chromium 111.0.5544.3 * chore: gen filenames.libcxx.gni * Add check for Executable+Writable handles in renderer processes. Refs https://chromium-review.googlesource.com/c/chromium/src/+/3774416 * fixup! Add check for Executable+Writable handles in renderer processes. * 4143761: [110] Disable SwiftShader for WebGL on M1 Macs. https://chromium-review.googlesource.com/c/chromium/src/+/4143761 (cherry picked from commit 2f74db3c2139424c416f92d9169aeaa8a2f9c1ec) * chore: bump chromium to 111.0.5555.0 * 56085: Remove hmac.h include from ssl.h. https://boringssl-review.googlesource.com/c/boringssl/+/56085 * 4167020: Remove forwarding headers https://chromium-review.googlesource.com/c/chromium/src/+/4167020 * chore: bump chromium to 111.0.5559.0 * 4181044: Restrict WebCursor usage to RenderWidgetHostViewAura https://chromium-review.googlesource.com/c/chromium/src/+/4181044 * 4189437: views: rename ink_drop_host_view to ink_drop_host https://chromium-review.googlesource.com/c/chromium/src/+/4189437 * chore: bump chromium to 111.0.5560.0 * 4167016: win7dep: remove non aeroglass code https://chromium-review.googlesource.com/c/chromium/src/+/4167016 * fixup after rebase: Remove forwarding header s https://chromium-review.googlesource.com/c/chromium/src/+/4167020 * 4125755: Reland "Reject getDisplayMedia calls without user activation" https://chromium-review.googlesource.com/c/chromium/src/+/4125755 * test: add workaround * chore: update patches * fix: alter coreModuleRegExp to prevent arm crash * Revert "fix: alter coreModuleRegExp to prevent arm crash" This reverts commit 7e50630c98137831a711c5abdbc8809e60cf1d73. * 4218354: Disable the use of preserve_most on arm64 Windows https://chromium-review.googlesource.com/c/v8/v8/+/4218354 * chore: review changes --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: deepak1556 <hop2deep@gmail.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>	2023-02-03 12:43:42 +01:00
Milan Burda	446c7809cc	refactor: process event emitting for sandboxed renderers (#37109 ) Co-authored-by: Milan Burda <miburda@microsoft.com>	2023-02-03 11:59:57 +01:00
Milan Burda	fd761ec8f7	chore: strip trailing whitespace (#35969 )	2023-02-01 12:59:16 +01:00
Shelley Vohr	23739c644b	fix: crash on `WebWorkerObserver` script execution (#37050 ) fix: crash on WebWorkerObserver script execution	2023-01-31 12:29:29 +01:00
Jeremy Rose	85f41d59ac	fix: ensure autofill popup view is > 1x1 in size (#36121 ) * fix: ensure autofill popup view is > 1x1 in size ref #26667 * Update shell/browser/ui/views/autofill_popup_view.cc Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>	2023-01-27 10:50:19 +01:00
Shelley Vohr	0026fdb78a	fix: resizing borders in nondraggable regions (#37016 ) * fix: resizing borders in nondraggable regions * chore: remove frame handling from ShouldDescendIntoChildForEventHandling	2023-01-26 14:04:19 +01:00
Mikaël Barbero	1486cbdf64	feat: add support for unlocking with Apple Watch (#36935 )	2023-01-26 13:05:42 +01:00
Cheng Zhao	c303135b02	fix: fallback to GtkStatusIcon when app indicator is not supported (#36815 ) * chore: get ready for multi backend tray * fix: fallback to GtkStatusIcon when app indicator is not supported * chore: use smart pointers	2023-01-26 19:15:55 +09:00
Shelley Vohr	7d46d3ec9d	feat: emit `devtools-open-url` event for DevTools link selection (#36774 ) * feat: emit event for DevTools link selection * chore: devtools-open-in-new-tab -> devtools-open-url	2023-01-26 09:54:26 +01:00
Robo	a30a9c7c4f	chore: remove crashpad related sandbox policy (#37013 )	2023-01-26 09:01:34 +09:00
Shelley Vohr	afca3ff965	chore: call `ListenerDestroyed()` in `FileSelectHelper::RunFileChooserEnd()` (#37006 ) chore: call ListenerDestroyed() in FileSelectHelper::RunFileChooserEnd()	2023-01-25 15:51:01 +01:00
Shelley Vohr	86f99e9cf0	chore: cleanup `ElectronContentClient::AddPlugins` (#37005 ) chore: cleanup ElectronContentClient::AddPlugins	2023-01-25 14:57:30 +01:00

... 4 5 6 7 8 ...

3354 commits