Darshan Sen
25f2abb64d
chore: use std::forward() in ConvertToV8() ( #31817 )
...
The variable `input` is accepted by a universal reference, so it doesn't
make sense to cast a potential lvalue reference into an rvalue
reference. In case `input` is an lvalue reference, we should rather
forward the value as is to `ToV8()`.
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
2021-11-16 09:15:32 +01:00
Milan Burda
65a980c673
refactor: replace deprecated DISALLOW_COPY_AND_ASSIGN ( #31633 )
2021-11-03 20:41:45 +09:00
David Sanders
95a9ff952c
chore: cleanup usages of const char* ( #29906 )
2021-07-02 09:51:52 +09:00
Jeremy Rose
34a4e26b24
fix: check DCHECK_IS_ON() instead of #ifdef DCHECK_IS_ON ( #29620 )
2021-06-14 11:06:09 +09:00
David Sanders
79cb5144ae
chore: use std::make_unique/base::MakeRefCounted when possible ( #29510 )
2021-06-08 11:00:05 +09:00
electron-roller[bot]
8532e1239e
chore: bump chromium to 93.0.4530.0 (master) ( #29256 )
...
* chore: bump chromium in DEPS to 92.0.4512.6
* 2887336: [CaptureHandle][#2 ] Propagate CaptureHandleConfig in browser process
https://chromium-review.googlesource.com/c/chromium/src/+/2887336
* refactor: base::Optional -> absl::optional
* chore: fixup patch indices
* chore: bump chromium in DEPS to 92.0.4514.0
* 2899417: Make build work when enable_pdf is set to false.
https://chromium-review.googlesource.com/c/chromium/src/+/2899417
* 2904731: use BrowserContext instead of Profile in PreconnectManager
https://chromium-review.googlesource.com/c/chromium/src/+/2904731
* 2295749: fix: check IsSecureEventInputEnabled in constructor before setting SetPasswordInputEnabled to true
https://chromium-review.googlesource.com/c/chromium/src/+/2295749
* 2893803: Add a GetWebView to RenderFrame.
https://chromium-review.googlesource.com/c/chromium/src/+/2893803
* 2892345: Implement WebContents::ForEachRenderFrameHost
https://chromium-review.googlesource.com/c/chromium/src/+/2892345
* chore: fixup patch indices
* 2892048: Real instance methods for BrowserContext: remaining 5 methods.
https://chromium-review.googlesource.com/c/chromium/src/+/2892048
* 2902821: [mojo] Don't require full header includes for referenced interfaces
https://chromium-review.googlesource.com/c/chromium/src/+/2902821
* 2496500: Remove last deprecated extension Event ctor.
https://chromium-review.googlesource.com/c/chromium/src/+/2496500
* chore: fixup malformed pepper support patch
* chore: bump chromium in DEPS to 92.0.4515.0
* 2908461: Add CreateEmptyPrintPagesParamsPtr() inside print_view_manager_base.cc.
https://chromium-review.googlesource.com/c/chromium/src/+/2908461
* 2880838: viz: add optional HDRMetadata to TransferableResource
https://chromium-review.googlesource.com/c/chromium/src/+/2880838
* chore: fixup patch indices
* chore: bump chromium in DEPS to 92.0.4515.5
* chore: update patches
* chore: bump chromium in DEPS to 92.0.4515.7
* chore: bump chromium in DEPS to 92.0.4515.9
* chore: bump chromium in DEPS to 93.0.4522.0
* chore: bump chromium in DEPS to 93.0.4523.0
* chore: bump chromium in DEPS to 93.0.4524.0
* chore: update patches
* chore: enable_pak_file_integrity_checks was reverted
* chore: update patches
* refactor: base/optional was replaced with absl::optional
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* refactor: replace all usages of base::nullopt with absl::nullopt
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* chore: add missing base::Contains include
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* refactor: replace all usages of base::make_optional with
absl::make_optional
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* refactor: replace WorldScriptContext() with GetScriptContextFromWorldId
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2893213
* chore: clean up left over opening namespace
Refs: 95bfe6d08fhttps://chromium-review.googlesource.com/c/chromium/src/+/2910202
* refactor: replace GetCurrentDisplayIterator with the hard checker
GetCurrentDisplay
This code looks suspicious but if the iterator was invalid before it
will also be invalid now.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2893191
* refactor: headers are now passed directly in extensions client
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2918906
* refactor: base::DictionaryValue::empty() has been removed
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2912424
* chore: add missing includes for network URLLoaderFactory
Refs: unknown, probably a side effect of header changes
* refactor: make convenience wrapper around AppendArg
There is no converter FromV8 for base::StringPiece (apparently its not
possible). So we now take in an std::string and use the construct for
StringPiece to do implicit conversion.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2905544
* chore: add patch
* chore: bump chromium in DEPS to 93.0.4525.0
* chore: update patches
* refactor: CanResize has been de-virtualized
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2485774
* chore: update resource integrity patch
* chore: add character encoding idl patch
* chore: bump chromium in DEPS to 93.0.4526.0
* chore: update patches
* chore: bump chromium in DEPS to 93.0.4527.0
* chore: bump chromium in DEPS to 93.0.4528.0
* chore: update patches
* chore: update idl encoding patch
* chore: bump chromium in DEPS to 93.0.4529.0
* chore: update patches
* chore: bump chromium in DEPS to 93.0.4530.0
* chore: update patches
* fix: only SetCanResize after the widget has been initialized
* chore: add patch for vr on windows gn gen
* spec: fix focus related tests on linux due to delay in focus swap
* chore: remove new usages of base::Optional from main
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <sattard@slack-corp.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2021-06-03 01:05:04 -07:00
David Sanders
93c9374e95
chore: trim unused STL includes ( #29414 )
2021-06-01 10:34:44 +09:00
Samuel Attard
f01e35f4ea
feat: add support for Blob's going over the ctx bridge ( #29247 )
2021-05-26 10:34:29 -07:00
Milan Burda
241cceb2c9
refactor: eliminate duplicate code ( #29174 )
2021-05-24 11:32:55 +09:00
Milan Burda
a51aaeb28f
refactor: replace v8::Local<T>::Cast() with As<T>() ( #29097 )
2021-05-12 16:38:21 +09:00
Electron Bot
cdf04f3ae7
chore: bump chromium to 92.0.4488.0 (master) ( #28676 )
...
* chore: bump chromium in DEPS to 92.0.4478.0
* chore: update chromium patches
* chore: update v8 patches
* fix: add scale parameter to LookupIconFromFilepath
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2748317
Follow up: https://github.com/electron/electron/issues/28678
* build: depend on gtkprint config for gtk_util.h
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2824022
* build: add missing print_job_constants header
Refs: unknown
* chore: bump chromium in DEPS to 92.0.4479.0
* update patches
* chore: bump chromium in DEPS to 92.0.4480.0
* chore: bump chromium in DEPS to 92.0.4481.0
* chore: bump chromium in DEPS to 92.0.4482.2
* chore: bump chromium in DEPS to 92.0.4483.0
* chore: update patches
* chore: bump chromium in DEPS to 92.0.4484.0
* chore: bump chromium in DEPS to 92.0.4485.0
* fix patches
* update patches
* 2810414: [LSC] Add PRESUBMIT check for ASCIIToUTF16("...") and UTF8ToUTF16("...")
https://chromium-review.googlesource.com/c/chromium/src/+/2810414
* 2781233: NotificationService: Plumb document_url for non-persistent notifications.
https://chromium-review.googlesource.com/c/chromium/src/+/2781233
* fixup! 2810414: [LSC] Add PRESUBMIT check for ASCIIToUTF16("...") and UTF8ToUTF16("...")
* 2836669: Refactor GTK build target and dependencies
https://chromium-review.googlesource.com/c/chromium/src/+/2836669
* chore: bump chromium in DEPS to 92.0.4486.0
* update patches
* fix DecrementCapturerCount patch
* explicitly include badging.mojom.h
* include ui/gtk/gtk_ui_factory.h for BuildGtkUi()
* fixup! 2810414: [LSC] Add PRESUBMIT check for ASCIIToUTF16("...") and UTF8ToUTF16("...")
* iwyu fix for base::size
* iwyu for TRACE_EVENT0
* 2799631: Use structured interface for DevTools messages
https://chromium-review.googlesource.com/c/chromium/src/+/2799631
* 2801573: Convert enum to enum class for Widget::InitParams::Activatable
https://chromium-review.googlesource.com/c/chromium/src/+/2801573
* 2805764: Add ContentBrowserClient support for service worker-scoped binders
https://chromium-review.googlesource.com/c/chromium/src/+/2805764
* fixup! 2799631: Use structured interface for DevTools messages
* fixup! 2805764: Add ContentBrowserClient support for service worker-scoped binders
* oops, use of linux_ui after std::move
* fix devtools message handling for null params
* disable node test parallel/test-debug-args
https://chromium-review.googlesource.com/c/v8/v8/+/2843348
* fix gn check
* chore: bump chromium in DEPS to 92.0.4487.0
* chore: update patches
* chore: bump chromium in DEPS to 92.0.4488.0
* update patches
* Remove vpython use from Chromium DEPS file
https://chromium-review.googlesource.com/c/chromium/src/+/2810121
* Partial revert "workaround: disable CFG longjmp protection for Windows on Arm"
https://chromium-review.googlesource.com/c/chromium/src/+/2788210
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
2021-04-27 14:27:34 -07:00
Shelley Vohr
9fecf8369f
fix: errors thrown in functions over the contextBridge ( #28346 )
...
* fix: errors thrown in functions over the contextBridge
* spec: add a test
* fix: ensure exception is a v8::Object
2021-03-30 00:26:49 -07:00
Samuel Attard
7918ddb026
perf: do not double-proxy methods being return over the contextBridge ( #28285 )
2021-03-24 11:43:02 -07:00
Nikita Kot
e99893df22
feat: add ContextBridgeMutability feature ( #27348 )
2021-03-22 10:16:35 -07:00
Samuel Attard
e406ba9558
fix: values return from the ctx bridge with dynamic property support should themselves support dynamic properties ( #27899 )
2021-02-25 13:09:00 -08:00
Shelley Vohr
40aeb0d994
fix: dont try to serialize WasmModuleObjects ( #27518 )
2021-01-28 18:20:28 -08:00
Samuel Attard
db08f08b88
feat: enable world safe JS by default ( #26889 )
...
* feat: enable world safe JS by default
* refactor: use the ctx bridge to send executeJavaScript results in a world safe way
* docs: add more info about the breaking change
* include default in IsEnabled check
2021-01-26 14:23:35 -08:00
Samuel Attard
b9c9e7fc06
feat: add support for DOM elements going over the context bridge ( #26776 )
...
* feat: add support for DOM elements going over the context bridge
* Update context-bridge.md
2020-12-10 13:03:00 -08:00
Nikita Kot
7672aa9525
feat: exposeInMainWorld allow to expose non-object APIs ( #26594 )
2020-12-04 09:43:20 -08:00
Milan Burda
1c99a9b425
refactor: Chromium code style for enum classes ( #26165 )
2020-10-27 10:51:45 -07:00
David Sanders
554ad93d45
chore: prefer empty() check for readability ( #26109 )
2020-10-22 13:24:59 -07:00
Samuel Attard
5cfe956fe1
fix: ensure that errors thrown in the context bridge are created in the correct context ( #24534 )
2020-07-23 14:32:38 -07:00
Samuel Attard
d4a4269989
perf: do not convert object keys in ctx bridge as they are always primitives ( #24671 )
...
* perf: do not convert object keys in ctx bridge as they are always primitives
* Update shell/renderer/api/electron_api_context_bridge.cc
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2020-07-21 15:26:16 -07:00
Samuel Attard
3f54f240bd
perf: pass primitives directly through the context bridge, avoids copying ( #24531 )
2020-07-14 18:38:54 -07:00
Samuel Attard
9d7ba98209
refactor: remove the RenderFrameFunctionStore and use privates to memory manage ( #23592 )
2020-05-15 11:57:40 -07:00
Milan Burda
ef176ce368
build: fix building with enable_remote_module = false ( #23499 )
2020-05-12 18:32:04 +02:00
Samuel Attard
7bba36a095
chore: add TRACE calls for heavy ctx bridge methods ( #23501 )
2020-05-11 14:24:43 -07:00
Samuel Attard
7f9b7b2e95
chore: clean up context bridge scopes and add specs for internal bridge ( #23334 )
...
* chore: clean up context bridge context scopes
* spec: add specs for internalContextBridge
2020-05-11 13:41:42 -07:00
Samuel Attard
075472d6ef
fix: do not leak IPC or context bridge promises ( #23321 )
2020-04-29 15:51:41 -07:00
Samuel Attard
abe5cf398c
refactor: port window.open and window.opener to use ctx bridge instead of hole punching ( #23235 )
...
* refactor: port window.open and window.opener to use ctx bridge instead of hole punching
* refactor: only run the isolated init bundle when webview is enabled
2020-04-27 12:46:04 -07:00
Samuel Attard
96bf9ce77f
refactor: port parts of window-setup to use ctx bridge instead of being run in the main world ( #23194 )
...
* refactor: port parts of window-setup to use ctx bridge instead of being run in the main world
* chore: update ctx bridge specs for new base numbers
2020-04-22 12:42:51 -07:00
Samuel Attard
e4c82fdf2d
Merge pull request from GHSA-h9jc-284h-533g
2020-04-16 14:10:18 -07:00
Samuel Attard
2563681583
fix: disable contextBridge object identity caching ( #21803 )
...
* fix: disable contextBridge object identity caching
* cleanup
* chore: make non-const references raw pointers
* fix: zero-param constructors are not explicit
* refactor: use base::LinkedList
Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>
2020-03-03 23:18:22 -08:00
Electron Bot
39baf68790
chore: bump chromium to 5b340c815ce15ab2efcf277ed19e9 (master) ( #22064 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: loc <andy@slack-corp.com>
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>
2020-03-03 13:35:05 -08:00
Samuel Maddock
8cc0435d9c
fix(extensions): set lowest isolated world id ( #22212 )
...
* fix(extensions): set lowest isolated world id
* refactor: move world IDs into separate header file
Several files are including electron_render_frame_observer.h just for the world IDs.
2020-02-24 13:33:58 +09:00
Jeremy Apthorp
602913cb4c
chore: rename node bindings atom => electron ( #22176 )
2020-02-14 06:25:39 -05:00
Samuel Attard
dafbf04b9a
fix: use a WeakPtr so we do not UAF the store in FunctionLifetimeMonitor ( #22056 )
2020-02-08 20:49:38 -08:00
Jeremy Apthorp
d9321f4df7
chore: rename atom -> electron ( #21986 )
2020-02-04 12:19:40 -08:00
