deepak1556
4e6b148eaa
webContents: fix executejavascript when called before page load
2016-04-28 01:54:08 +05:30
Cheng Zhao
06cf0406fe
Dereference remote objects with native code
...
Previously we rely on the v8util.setDestructor to dereference the remote
objects in JavaScript, however as documented in V8, it is forbidden to
call V8 APIs in object's destructor (e.g. the weak callback), and doing
so would result in crashs.
This commit removes the JavaScript setDestructor method, and avoids
doing the dereference work with V8.
2016-04-26 16:16:22 +09:00
Cheng Zhao
570dc7ca9b
Merge branch 'MarshallOfSound-master'
2016-04-26 11:15:56 +09:00
Samuel Attard
315cd9d2c8
Emit an error if quitAndInstall
is called without an update being available
2016-04-26 11:55:57 +10:00
Cheng Zhao
a421c66f3f
Deprecate the platform-theme-changed event
2016-04-25 14:35:34 +09:00
Cheng Zhao
ddd8eae661
Move isAeroGlassEnabled and isDarkMode to systemPreferences
2016-04-25 12:35:09 +09:00
Cheng Zhao
13f8599ba1
Add systemPreferences module
2016-04-25 11:32:33 +09:00
Kevin Sawicki
8e7bf1051d
Disable node integration on webview when disabled on window
2016-04-21 11:52:10 -07:00
Cheng Zhao
b5c1db9ad9
Guard against unexist owner when removing ref to remote object
2016-04-21 11:23:20 +09:00
Cheng Zhao
aa29dc0c8a
Merge pull request #5199 from Mr0grog/5183-disambiguate-loading-from-main-frame-loading
...
Add `isLoadingMainFrame()` to WebContents
2016-04-20 20:49:56 +09:00
Cheng Zhao
680652d01c
buffer, null, array etc. all belong to object
2016-04-20 14:32:32 +09:00
Cheng Zhao
ff1b7d18f6
Cleanup the code determining value's type
2016-04-20 14:26:49 +09:00
Rob Brackett
64a84dee3b
Add isLoadingMainFrame
method to WebContents.
...
Also switch `webContents.executeJavaScript` to check it instead of `isLoading`.
There doesn’t seem to be a reasonable public way to get this information out of Chromium, so it’s synthesized here based on WebContentsObserver callbacks.
Fixes #5183 .
2016-04-18 10:37:08 -07:00
Cheng Zhao
cb947873c4
Merge pull request #5161 from electron/felix/iss5097
...
AutoUpdate Windows: Don't spawn if running
2016-04-15 20:10:03 +09:00
Felix Rieseberg
a5b93211e6
AutoUpdate Windows: Don't spawn if running
...
Previously, the auto updater would run as many squirrel processes
as told. This introduces a little change where instead of spawning
a second process, we attach to the already running process - or, if
different arguments are passed, return and emit an error.
This is not failsafe, but it ensures that we don't run into simple
race condition crashes.
Closes $5097
2016-04-14 11:22:28 -07:00
Cheng Zhao
31eb793fb0
Avoid adding a new option to webPreferences
2016-04-14 10:50:07 +09:00
Cheng Zhao
8f0e594007
Fix lint warnings
2016-04-13 23:10:31 +09:00
Cheng Zhao
43c44da50b
Correctly set initial visibilityState
2016-04-13 23:07:28 +09:00
Cheng Zhao
07a4c52919
Reduces the IPC messages used for visibilityState
2016-04-13 21:36:43 +09:00
Cheng Zhao
92882c358a
No more need to delay did-fail-load event
2016-04-13 19:33:59 +09:00
Cheng Zhao
2fbe06a2a5
Handle the Page.reload command coming from devtools
2016-04-12 16:36:12 +09:00
Kevin Sawicki
8d8d5878a3
Rename ATOM_ ipc event prefix to ELECTRON_
2016-04-07 09:04:55 -07:00
Kevin Sawicki
eafe9c245b
Disable guest node integration when embedder has it disabled
2016-04-01 16:48:21 -07:00
Kevin Sawicki
e5164d2255
Check of nodeIntegration is strictly equal to false
2016-04-01 16:42:21 -07:00
Kevin Sawicki
dbe1c1d4e4
Check nodeIntegration on embedder's webPreferences
2016-04-01 16:40:50 -07:00
Kevin Sawicki
463e077c3a
Disable node on child when disabled on parent
2016-04-01 16:39:18 -07:00
Kevin Sawicki
400efa1b7d
Fallback to using the last argument as the callback
2016-04-01 12:54:06 -07:00
Kevin Sawicki
464dad3135
Store default_app in .asar archive
2016-04-01 12:40:32 -07:00
Robo
7016fbe258
browser: fix disposition value for new-window event
2016-04-01 08:14:29 +05:30
Zeke Sikelianos
b5afad9da7
avoid using eslint comment exceptions
2016-03-30 17:00:34 -07:00
Zeke Sikelianos
42e7ee2b4a
finish standardizing!
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
4e2f1311e0
replace __proto__ with Object.setPrototype
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
2c3cacdc08
standardize by hand
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
e6698102c9
standardize by hand
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
09635ae50e
reduce ignore list in favor of one-liner ignores
2016-03-30 17:00:32 -07:00
Zeke Sikelianos
ee181294b3
manual syntax fixes on rpc server
2016-03-30 17:00:30 -07:00
Zeke Sikelianos
4d4f479721
manually standardize this tricky file
2016-03-30 17:00:30 -07:00
Zeke Sikelianos
4794385fac
first pass at standardizing; suite still passing!
2016-03-30 17:00:30 -07:00
Sergey Bekrin
4ac08870d0
Tweak error messages for dialog API
2016-03-30 23:07:13 +03:00
Sergey Bekrin
7f78781800
Improve error reporting when using invalid argument types for dialog API methods
2016-03-23 10:44:11 +03:00
Kevin Sawicki
2d32956903
Destructure objects
2016-03-22 13:11:42 -07:00
Kevin Sawicki
4127b524d5
Destructure params directly
2016-03-22 13:11:42 -07:00
Kevin Sawicki
43746727aa
Use direct params instead of rest params
2016-03-22 13:11:42 -07:00
Kevin Sawicki
4f4dc2f4d8
Use destructuring assigment
2016-03-22 13:11:42 -07:00
Cheng Zhao
a52285596e
Merge pull request #4846 from atom/rest-parameters
...
Use rest parameters
2016-03-21 21:03:28 +09:00
Cheng Zhao
e08b48ab48
Merge pull request #4840 from atom/undefined-menu-accelerator
...
Undefined menu accelerator
2016-03-21 21:02:44 +09:00
Kevin Sawicki
8889c29866
Use rest parameters
2016-03-18 11:51:02 -07:00
Kevin Sawicki
6aa452cda4
Set _setDeprecatedOptionsCheck on exports
2016-03-18 09:06:03 -07:00
Kevin Sawicki
7668c1ea0b
Use deprecate.warn instead of deprecate.log
2016-03-18 09:02:58 -07:00
Zeke Sikelianos
344dda4029
ignore set menu item fields
2016-03-17 16:20:23 -07:00