* refactor: decouple api::Protocol from ElectronBrowserContext
now they do not know about each other
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: make electron::api::ProtocolError private
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: remove unused isolate arg in Protocol constructor
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: use =default for trivial destructor
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
refactor: use GetDefaultStoragePartition()
Use GetDefaultStorageParition() instead of GetStoragePartition(nullptr)
- It improves code uniformity, since we use get-default everywhere else
- It's more readable
- It's marginally faster, since GetStoragePartition() has more steps
Added in 49b0a1bf4a
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
The former is now a pass-through for the latter and is slated for removal
Xref: https://issues.chromium.org/issues/402415654907781
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: make UtilityProcessWrapper inherit privately from mojo::MessageReceiver
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: make ParentPort inherit privately from mojo::MessageReceiver
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: make MessagePort inherit privately from mojo::MessageReceiver
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: bump chromium to 135.0.7049.7 (main) (#45900)
chore: bump chromium in DEPS to 135.0.7049.7
(cherry picked from commit bb1c3dff21)
* chore: bump chromium to 136.0.7053.1 (main) (#45906)
* chore: bump chromium in DEPS to 136.0.7052.0
* chore: update mas_avoid_private_macos_api_usage.patch.patch
6318359
patch applied manually due to context shear
* chore: update preconnect_manager.patch
Xref: 6318420
patch applied manually due to context shear
* chore: e patches all
* chore: bump chromium to 136.0.7053.1
* chore: update fix_remove_profiles_from_spellcheck_service.patch
Xref: 6326575
patch applied manually due to context shear
* chore: e patches all
* chore: revert removal of v8 API used by Node.js
* devtools: Remove DevToolsUIBindings::SendJsonRequest() | 6326236
* 6244461: Merge //content/common/user_agent.cc into //components/embedder_support:user_agent | 6244461
* 6313744: Migrate views::Background factory methods to ColorVariant | 6313744
* 6314545: Remove multiple argument support from base::ToString() | 6314545
* 6317362: [Extensions] Inline MessagingDelegate::CreateReceiverForTab() | 6317362
* 6308998: Add SettingAccess structured metrics event for DevTools | 6308998
* 6295214: Remove redundant state field in per-extension preferences | 6295214
NB: this change is copied from the upstream change to extensions/shell/browser/shell_extension_loader.cc
* fix: ui/ linter error
This is showing up in an eslint build step in Electron:
> /__w/electron/electron/src/out/Default/gen/ui/webui/resources/cr_elements/preprocessed/cr_menu_selector/cr_menu_selector.ts
> 77:23 error This assertion is unnecessary since the receiver accepts the original type of the expression @typescript-eslint/no-unnecessary-type-assertion
>
> ✖ 1 problem (1 error, 0 warnings)
> 1 error and 0 warnings potentially fixable with the `--fix` option.
However, removing the assertion causes a typescript build failure:
> gen/ui/webui/resources/cr_elements/preprocessed/cr_menu_selector/cr_menu_selector.ts:77:23 - error TS2345: Argument of type 'HTMLElement | null' is not assignable to parameter of type 'HTMLElement'.
> Type 'null' is not assignable to type 'HTMLElement'.
>
> 77 items.indexOf(this.querySelector<HTMLElement>(':focus'));
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
So I think the two different steps may be picking up typescript definitions.
This patch should be removed after the issue is tracked down
and fixed in a followup task.
* fix: -Wnonnull warning
Fixes this warning:
> 2025-03-07T01:05:01.8637705Z ../../third_party/electron_node/src/debug_utils.cc(257,12): error: null passed to a callee that requires a non-null argument [-Werror,-Wnonnull]
> 2025-03-07T01:05:01.8638267Z 257 | return nullptr;
> 2025-03-07T01:05:01.8638481Z | ^~~~~~~
> 2025-03-07T01:05:01.8638700Z 1 error generated.
Not sure why this warning was never triggered before; `git blame`
indicates this code hasn't changed in ages:
> c40a8273ef2 (Michaël Zasso 2024-05-10 09:50:20 +0200 255) #endif // DEBUG
> 8e2d33f1562 (Anna Henningsen 2018-06-07 16:54:29 +0200 256) }
> 247b5130595 (Refael Ackermann 2018-10-22 15:07:00 -0400 257) return nullptr;
> 247b5130595 (Refael Ackermann 2018-10-22 15:07:00 -0400 258) }
Presumably this is failing in this Chromium roll due to a
clang version bump.
We should remove this patch after upstreaming it.
* docs: add upstream pr link for Node patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
(cherry picked from commit 458b14b8ed)
* chore!: bump chromium to 136.0.7054.0 (main) (#45923)
* chore: bump chromium in DEPS to 136.0.7054.0
* chore: update allow_in-process_windows_to_have_different_web_prefs.patch
Xref: 5906158
patch applied manually due to context shear
* chore: e patches all
* refactor!: Session.clearStorageData(syncable)
Xref: 6309405
Remove syncable type from opts.quota in Session.clearStorageData(opts)
because it that category has been removed upstream.
BREAKING CHANGE: Removed ses.clearDataStorage({ quota: 'syncable' })
* docs: deprecate Session.clearDataStorage({ quota })
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
(cherry picked from commit 20414f66ca)
* chore: bump chromium to 136.0.7058.1 (main) (#45928)
* chore: bump chromium in DEPS to 136.0.7056.0
* chore: update mas_avoid_private_macos_api_usage.patch.patch
no manual changes; patch applied with fuzz
* chore: update fix_adapt_exclusive_access_for_electron_needs.patch
patch applied manually due to context shear
6319958: [FS] Replace GURL with url::Origin for Excluisve Access Bubble | 6319958
* chore: update feat_allow_usage_of_sccontentsharingpicker_on_supported_platforms.patch
no manual changes; patch applied with fuzz
6311876: Expose captured surface resolution for MacOS | 6311876
* chore: e patches all
* 6319958: [FS] Replace GURL with url::Origin for Excluisve Access Bubble | 6319958
* 6326673: views: Delete the single-parameter Widget::InitParams constructor. | 6326673
* 6331102
* 6331102: [A11yPerformance] Rename AXMode::kScreenReader to kExtendedProperties | 6331102
Sync with shell/browser/ui/webui/accessibility_ui.cc to
upstream chrome/browser/accessibility/accessibility_ui.cc
changes in 4af8657
* chore: bump Chromium 136.0.7058.1 (#45933)
chore: bump chromium in DEPS to 136.0.7058.1
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
(cherry picked from commit b0c11371e0)
* chore: bump chromium to 136.0.7062.0 (main) (#45957)
* chore: bump chromium in DEPS to 136.0.7059.0
* chore: bump chromium in DEPS to 136.0.7060.0
* chore: bump chromium in DEPS to 136.0.7062.0
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
(cherry picked from commit 2de8fd7d93)
* fixup! chore: bump chromium to 136.0.7053.1 (main) (#45906)
chore: fix patch shear
* chore: remove cherry-pick-521faebc8a7c.patch
fixed upstream @ 521faeb
6334632: Disable setting primtive restart for WebGL in the cmd decoder. | 6334632
* chore: remove cherry-pick-9dacf5694dfd.patch
fixed upstream @ 9dacf56
6330188: Move WebGL primitive restart state setting to the GPU process. | 6330188
* chore: e patches all
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* fix: re-enable synchronous spellcheck on Windows
* revert: fix: empty suggestions with windows platform checker
---------
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
* chore: bump chromium to 134.0.6992.0
* chore: add BrowserProcessImpl::CreateGlobalFeaturesForTesting() stub
Xref: 6216193
Remove GlobalFeatures from TestingBrowserProcess::Init
* chore: bump chromium to 134.0.6994.0
* 6208630: Mac sandbox: don't use protobuf for policy serialization | 6208630
* [PDF] Remove HasUnsupportedFeature Mojo interface
Xref: 6220800
* 6217444: Remove scoped_gdi_object.h type aliases. | 6217444
* chore: bump chromium to 134.0.6998.10
* 6221378: Revert [OBC] Exclude Aliasing Cookies in FilterCookiesWithOptions() | 6221378
* Update ExtensionPrefs::GetDisableReasons to return DisableReasonSet
Xref: 6218840
change copied from 6218840 extensions/shell/browser/shell_extension_loader.cc
* 6218402: Typemap ui.gfx.DXGIHandle <=> gfx::DXGIHandle | 6218402
* chore: disable flaky contentTracing test
not new to this roll; it is happening in main as well
* fixup! chore: disable flaky contentTracing test
---------
Co-authored-by: alice <alice@makenotion.com>
* feat: Working navigationHistory.restore with just title/url
* feat: Restore page state, too
* chore: Docs, lint, tests
* Implement feedback
* More magic
* Make _awaitNextLoad truly private
* Implement API group feedback
* One more round of feedback
- Prefer GURL() when we want to return a non-reference empty URL.
- In ServiceWorkerMain::GetStorageKey(), use a reference instead
of instantiating a new temporary GURL.
From url/gurl.h:
> // Returns a reference to a singleton empty GURL. This object is for
> // callers who return references but don't have anything to return in
> // some cases. If you just want an empty URL for normal use, prefer
> // GURL().
* chore: bump chromium in DEPS to 134.0.6976.0
* chore: update mas_avoid_private_macos_api_usage.patch.patch
6171046
process_info_mac.cc -> process_info_mac.mm
* chore: update build_do_not_depend_on_packed_resource_integrity.patch
6196857
* chore: update feat_add_support_for_missing_dialog_features_to_shell_dialogs.patch
618229661834046187853
A lot changed in the upstream implementation. There's a good chance I got
this wrong as threading has changed and moved some variables into globals.
* chore: remove build_remove_vr_directx_helpers_dependency.patch
6186102
This landed upstream
* chore: e patches all
* chore: update net::CookieInclusionStatus::ExclusionReason enum
61832526185544
* chore: update content::WebAuthenticationDelegate import
6189769
* Revert "chore: disable focus handling test due to win32/ia32 regression"
This reverts commit 1a57ba5d59848d0c841ddda59c9299a4f957452a.
* chore: bump chromium in DEPS to 134.0.6978.0
* chore: bump chromium in DEPS to 134.0.6980.0
* chore: bump chromium in DEPS to 134.0.6982.0
* chore: bump chromium in DEPS to 134.0.6984.0
* 6196281: Allow direct embedder IsPdfInternalPluginAllowedOrigin() interaction
6196281
* 6196283: Delete PdfInternalPluginDelegate
6196283
* chore: update patches
* chore: bump chromium in DEPS to 134.0.6986.0
* chore: update patches
* 6205762: Support option to use window.showSaveFilePicker() in PDF attachment code
6205762
See also:
* https://issues.chromium.org/issues/373852607
* 5939153: [PDF] Add PdfUseShowSaveFilePicker feature flag | 5939153
* 6205761: Delete spurious Ink-specific code in pdf_viewer.ts | 6205761
* 6209609: Remove WebVector: Automatic changes
6209609
* 6205488: UI: make QT5 optional
6205488
* 6178281: Rename pak files from branding strings
6178281
* fixup! 6209609: Remove WebVector: Automatic changes 6209609
* 6193249: Switch from safe_browsing::EventResult to enterprise_connectors:EventResult
6193249
* 6197457: Remove Pause/ResumeReadingBodyFromNet IPCs
6197457
* 6191230: Record total time spent on a picture in picture window
6191230
* chore: bump chromium in DEPS to 134.0.6988.0
* chore: update patches
* 6215440: Remove base/ranges/.
6215440
* Disable unsafe buffers error
Not sure what changed, but we're now seeing unsafe buffer errors in Chromium code, at least when using reclient. Will update this comment if we find out the cause.
* 6187853: SelectFileDialogLinuxPortal: Use dbus_xdg::Request and DbusType
6187853
* fix `setDisplayMediaRequestHandler` test
Given how this test is written, I would expect this assertion to be false. It seems the oppositue was true before, but that was also acknowledged to be suprising. Seems that the underlying implementation is now fixed and works as expected.
* fixup! 6187853: SelectFileDialogLinuxPortal: Use dbus_xdg::Request and DbusType 6187853
* chore: udpate patches
* Multiple PRS: 6185544 | 6183252
* fix: cast enum class to numeric type
* fix: add 1 to MAX_EXCLUSION_REASON because enum values are zero-based, and we want the total count of reasons.
* Reapply "chore: disable focus handling test due to win32/ia32 regression"
This reverts commit 760b1a519b5919b483c66bc3096eeefb4d7011f4.
* refactor: use ExclusionReasonBitset::kValueCount for size
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: alice <alice@makenotion.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* refactor: use MakeFixedFlatMap() in InclusionStatusToString()
* fix: add log message for EXCLUDE_ALIASING
refactor: add static_assert() to ensure our messages stay
in sync with the CookieInclusion reasons in net/cookies/
* feat: ServiceWorkerMain
* refactor: disconnect remote
* handle version_info_ nullptr case
* initiate finish request when possible and enumerate errors
* explicit name for test method
* oops
* fix: wait for redundant version to stop before destroying
* docs: clarify when undefined is returned
* chore: remove extra semicolons
* chore: bump chromium in DEPS to 134.0.6948.0
* chore: update can_create_window.patch
6151982
no patch code changes, but had to manually apply due to upstream context shear
* chore: update proxy_config_monitor.patch
no manual changes; patch applied with fuzz 2
Xref: 6126219
* chore: update build_add_electron_tracing_category.patch
Xref: 6149256
* chore: update adjust_accessibility_ui_for_electron.patch
6105650
no patch code changes, but had to manually apply due to upstream context shear
* chore: e patches all
* chore: use fully-qualified path for all.gn
Xref: 6154997
* chore: do not use a variable when assigning rtc_use_h264
Xref: 6154997
* Move GlobalShortcutListenerLinux to //ui/base
Xref: 6097375
* [MPArch Guest View] Make WebPreferences queried per frame tree root
Xref: 6096390
* [Status Icons] Allow vector resources
6139403
* [Extensions] Move MatchOriginAsFallbackBehavior to Mojom
Xref: 6141793
* Remove StrongAlias::Hasher
Xref: 6132291
* Rename text-change and select-change methods and related stuff
Xref: 6148816
* [Code Health] Remove stale feature EnableWebUsbOnExtensionServiceWorker
6115161
* [Extensions Cleanup] Move creation of tab-based ports to factory method
6143725
* refactor: add StatusIconGtk::SetIcon()
Xref: 6139403
copied from chrome/browser/status_icons/status_icon.cc
* refactor: add TrayIconLinux::GetIcon()
Xref: 6139403
* chore: update feat_allow_usage_of_sccontentsharingpicker_on_supported_platforms.patch
remove unused filter_ field
* chore: bump chromium in DEPS to 134.0.6950.0
* chore: bump chromium in DEPS to 134.0.6952.0
* chore: bump chromium in DEPS to 134.0.6954.0
* chore: bump chromium in DEPS to 134.0.6956.0
* chore: update Chromium patches
* 6165749: Check scanout support in RenderableGpuMemoryBufferPool | 6165749
* 6106730: [Win] Use DXGI swapchains and DCOMP visuals in software mode | 6106730
* chore: update patches
* chore: bump chromium in DEPS to 134.0.6958.0
* chore: bump chromium in DEPS to 134.0.6960.0
* chore: update chromium patches
* 6168371: Remove extensions GlobalShortcutListener wrapper | 6168371
* chore: update patches
* 6161637: WebUI: Leverage build_webui() in chrome://translate-internals | 6161637
* chore: bump chromium in DEPS to 134.0.6962.0
* 6177329: Remove policy.used_policy_certificates pref on ChromeOS | 6177329
* 6180524: Simplify logic in components/os_crypt/sync/BUILD.gn | 6180524
* 6144831: Enforce --disallow-v8-feature-flag-overrides in the renderer | 6144831
* chore: update patches
* chore: bump chromium in DEPS to 134.0.6964.0
* 6181010: Ensure busy cursor does not show via LaunchWithoutSandbox | 6181010
* chore: update patches
* chore: bump chromium in DEPS to 134.0.6966.0
* 6180598: [api] Remove Reallocate | 6180598
* 6170781: [Refactor] Move UninstallExtension to ExtensionRegistrar. | 6170781
* chore: update filenames.libcxx.gni
* 6168207: cdm: Remove widevine_cdm_version.h | 6168207
* chore: bump chromium in DEPS to 134.0.6968.0
* 6030552: [macOS] Allow using vibrancy with NativeWidgetNSWindowBridge | 6030552
* fix: use explicit copy to replace realloc impl
6180598https://issues.chromium.org/issues/331326406
As per recommendation, "File an issue with Node to explicitly copy,because they copy under the hood anyway"
* fixup! 6106730: [Win] Use DXGI swapchains and DCOMP visuals in software mode | 6106730
* fix: undefine win32 StrCat
6172292
* fix: //device/vr:directx_helpers breaking the build
6064548
Upstreamed in 6186102
* fix: avoid calling ui::Layer::SetFillsBoundsOpaquely
6175787
The layer opacity is determined by the background color's alpha value
* fix: build with proprietary_codecs
The explicit setting of rtc_use_h264 is no longer needed since
https://webrtc-review.googlesource.com/c/src/+/62380
* fix: increase empty trace file size threshold
6176642
Traces now contain a net-constants property to allow them to be converted to a net log.
These contain ~1240 new properties with formatted JSON data.
* fix: node tests missing resource management globals
6174695
* fixup! fix: use explicit copy to replace realloc impl
* chore: disable focus handling test due to win32/ia32 regression
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
Co-authored-by: Samuel Maddock <samuelmaddock@electronjs.org>
* fix: backport patch to fix systemd unit activation in Chromium
This backports a patch from Chromium, which fixes systemd unit
activation. That is, a globalShortcuts feature that Chromium has
needs to create a systemd unit and rename it properly. Portal's
global shortcuts uses that name afterwards to map the app with
the shortcuts bound. However, there might be a race between
Chromium binding shortcuts and renaming the unit.
This is a first step to add Portal's globalShortcuts to
Electron.
* feat: Support global shortcuts via GlobalShortcutsPortal feature
Chromium has a new feature called GlobalShortcutsPortal. It
allows clients to use Portal's globalShortcuts to register and
listen to shortcuts.
This patches adds necessary bits, which allows Electron to
use that feature.
In order to make it work, one has to add
--enable-features=GlobalShortcutsPortal
Test: tested manually with a sample app.
* docs: add GlobalShortcutsPortal feature to globalShortcuts docs
Electron supports Portal's globalShortcuts API now via Chromium, and Electron
apps can use that in a Wayland session. Update the docs with the required
feature flag that must be passed to be able to use that implementation.
refactor: simplify StopTracing() a little by using a string_view instead of an optional<string>
We have compile-time string literals that we're passing to a method
that takes a string_view argument, so we don't need all this extra
optional<string> scaffolding
* refactor: remove InspectableWebContentsViewMac in favor of the Views version
* cherry-pick: refactor: remove InspectableWebContentsViewMac in favor of the Views version (#41326)
commit e67ab9a93d
Confilcts not resolved, except removal of the files removed
by the original commit.
* resolved conflicts and build issues after cherry-pick
* cherry-picked: fix: add method allowing to disable headless mode in native widget
https://github.com/electron/electron/pull/42996
fixing
https://github.com/electron/electron/issues/42995
* fix: displaying select popup in window created as fullscreen window
`constrainFrameRect:toScreen:` is not being call for windows created
with `fullscreen: true` therefore `headless` mode was not being removed
and `RenderWidgetHostNSViewBridge::DisplayPopupMenu` ignored displaying
popup.
Issue could be fixed by placing additional removal of `headless` mode
in the `toggleFullScreen:`, but `orderWindow:relativeTo:` is called
both for a regular and a fullscreen window, therefore there will be
a single place fixing both cases.
Because `electron::NativeWindowMac` lifetime may be shorter than
`ElectronNSWindow` on which macOS may execute `orderWindow:relativeTo:`
we need to clear `shell_` when `NativeWindow` is being closed.
Fixes#43010.
* fix: Content visibility when using `vibrancy`
We need to put `NSVisualEffectView` before `ViewsCompositorSuperview`
otherwise when using `vibrancy` in `BrowserWindow` `NSVisualEffectView`
will hide content displayed by the compositor.
Fixes#43003Fixes#42336
In fact main issues reported in these tickets were not present after
cherry-picking original refactor switching to `views::WebView`, so
text could be selected and click event was properly generated. However
both issues testcases were using `vibrancy` and actual content was
invisible, because it was covered by the `NSVisualEffectView`.
* fix: EXCEPTION_ACCESS_VIOLATION crash on BrowserWindow.destroy()
Restored postponed deletion of the `NativeWindow`.
Restoration caused `DCHECK(new_parent_ui_layer->GetCompositor());` failure
in `BrowserCompositorMac::SetParentUiLayer` after the spec test:
`chrome extensions chrome.webRequest does not take precedence over Electron webRequest - http`
with stack:
```
7 Electron Framework 0x000000011fe07830 content::BrowserCompositorMac::SetParentUiLayer(ui::Layer*) + 628
8 Electron Framework 0x000000011fe0c154 content::RenderWidgetHostViewMac::SetParentUiLayer(ui::Layer*) + 220
9 Electron Framework 0x000000011fe226a8 content::WebContentsViewMac::CreateViewForWidget(content::RenderWidgetHost*) + 600
10 Electron Framework 0x000000011fd37e4c content::WebContentsImpl::CreateRenderWidgetHostViewForRenderManager(content::RenderViewHost*) + 164
11 Electron Framework 0x000000011fb32278 content::RenderFrameHostManager::CreateSpeculativeRenderFrame(content::SiteInstanceImpl*, bool, scoped_refptr<content::BrowsingContextState> const&) + 816
12 Electron Framework 0x000000011fb2ab8c content::RenderFrameHostManager::CreateSpeculativeRenderFrameHost(content::SiteInstanceImpl*, content::SiteInstanceImpl*, bool) + 1308
13 Electron Framework 0x000000011fb28598 content::RenderFrameHostManager::GetFrameHostForNavigation(content::NavigationRequest*, content::BrowsingContextGroupSwap*, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>*) + 1796
14 Electron Framework 0x000000011fa78660 content::NavigationRequest::SelectFrameHostForOnRequestFailedInternal(bool, bool, std::__Cr::optional<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>> const&) + 280
15 Electron Framework 0x000000011fa6a994 content::NavigationRequest::OnRequestFailedInternal(network::URLLoaderCompletionStatus const&, bool, std::__Cr::optional<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>> const&, bo
+ 1008
16 Electron Framework 0x000000011fa7772c content::NavigationRequest::OnRequestFailed(network::URLLoaderCompletionStatus const&) + 72
17 Electron Framework 0x000000011f8554ac content::NavigationURLLoaderImpl::NotifyRequestFailed(network::URLLoaderCompletionStatus const&) + 248
```
This was probably the reason of removing `NativeWindow` immediately
in order to cleanup `views_host_` in `WebContentsViewMac` to prevent
using layer without compositor in `WebContentsViewMac::CreateViewForWidget`.
`[ElectronNSWindowDelegate windowWillClose:]` is deleting window host
and the compositor used by the `NativeWindow` therefore detach `NativeWindow`
contents from parent. This will clear `views_host_` and prevent failing
mentioned `DCHECK`.
Fixes#42975
* chore: Applied review suggestions
* refactor: directly cleanup shell
---------
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
* chore: bump chromium in DEPS to 133.0.6902.0
* chore: bump chromium in DEPS to 133.0.6903.0
* chore: update patches
* Update PdfViewer Save File Picker to use showSaveFilePicker.
Refs 6074308
* Code Health: Clean up stale MacWebContentsOcclusion
Refs 6078344
* Change RenderProcessHost::GetID to RenderProcessHost::GetDeprecatedID
Refs 6065543
* [WebRTC] Make WebRTC IP Handling policy a mojo enum
Refs 6063620
* chore: gen filenames.libcxx.gni
* Remove allow_unsafe_buffers pragma in //printing
Refs 6092280
* refactor: to use ChildProcessId where possible
Refs https://issues.chromium.org/issues/379869738
* [Win] Update TabletMode detection code
Refs 6003486
* chore: bump chromium in DEPS to 133.0.6905.0
* chore: update patches
* Reland "Move global shortcut listener to //ui/base"
Refs 6099035
* [shared storage] Implement the batch `with_lock` option for response header
Refs 6072742
* chore: bump chromium in DEPS to 133.0.6907.0
* chore: bump chromium in DEPS to 133.0.6909.0
* chore: bump chromium in DEPS to 133.0.6911.0
* chore: bump chromium in DEPS to 133.0.6912.0
* chore: update patches
* WebUI: Reveal hidden deps to ui/webui/resources.
Refs 6096291
* chore: bump chromium in DEPS to 133.0.6913.0
* chore: bump chromium in DEPS to 133.0.6915.0
* Code Health: Clean up stale base::Feature "AccessibilityTreeForViews"
Refs 6104174
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* fix: remove fastapitypedarray usage
* chore: update patches
* chore: script/gen-libc++-filenames.js
* Code Health: Clean up stale base::Feature "WinRetrieveSuggestionsOnlyOnDemand"
Refs 6109477
* fix: empty suggestions with windows platform checker
Amends the fix from https://github.com/electron/electron/pull/29690
since the feature flag is no longer available. We follow the
same pattern as //chrome/browser/renderer_context_menu/spelling_menu_observer.cc
to generate the suggestion list on demand when context menu action
is invoked.
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* fixup! fix: empty suggestions with windows platform checker
* fixup! fix: empty suggestions with windows platform checker
* revert: 6078344: Code Health: Clean up stale MacWebContentsOcclusion | 6078344
* Revert "revert: 6078344: Code Health: Clean up stale MacWebContentsOcclusion | 6078344"
This reverts commit 9cacda452ed5a072351e8f5a35b009d91843a08c.
* chore: bump to 133.0.6920.0, update patches
* Revert "6078344: Code Health: Clean up stale MacWebContentsOcclusion"
Refs: 6078344
* fixup! Update PdfViewer Save File Picker to use showSaveFilePicker.
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* fix: add patch to fix desktopCapturer.getSources not returning electron window on Windows
* add chromium link
* Update patches/chromium/fix_desktop_capturer_show_own_window.patch
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
* fix on electron side
* set flag to true
* wrong capturer
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
* chore: bump chromium in DEPS to 133.0.6858.0
* chore: bump chromium in DEPS to 133.0.6860.0
* chore: update patches
v8/revert_fastapi_remove_dynamic_overload_resolution.patch had some additions due to 6023139
* 6044060: Reland "Moves shared GN templates into //build/config/apple."
6044060
* Revert "6023139: [fastapi] Add support for attribute setters"
6023139
* Update printing.patch
The removed include is present in the original source file now, just slightly before where it was being added.
6015430: Reduce platform-like buildflags in sandbox code
Refs: 6015430
* 6039836: Migrate Command::IsMediaKey to be a member of ui::Accelerator
6039836
* 6038659: [CodeHealth] Clean up the feature ZstdContentEncoding
6038659
* chore: bump chromium in DEPS to 133.0.6862.0
* chore: update patches
* 72747: crypto: switch to C++
https://boringssl-review.googlesource.com/c/boringssl/+/72747
* fixup! 72747: crypto: switch to C++ https://boringssl-review.googlesource.com/c/boringssl/+/72747
* chore: gen libc++ filenames
* 6042601: [shared storage] Implement with_lock option for methods from response headers
6042601
* chore: bump chromium in DEPS to 133.0.6864.0
* chore: bump chromium in DEPS to 133.0.6866.0
* chore: bump chromium in DEPS to 133.0.6868.0
* chore: bump chromium in DEPS to 133.0.6870.0
* chore: bump chromium in DEPS to 133.0.6872.0
* chore: bump chromium in DEPS to 133.0.6874.0
* chore: bump chromium in DEPS to 133.0.6876.0
* 6039992: Fix false activation logic for context menu. | 6039992
* chore: update patches
* chore: update patches
* chore: bump chromium in DEPS to 133.0.6878.0
* chore: update patches
* [Build] Organize //components/dbus into a single component
Xref: 6055280
* Merge //components/dbus/* into a single //components/dbus, which
matches how most components are organized. This avoids having
many small shared libraries which incurs unnecessary overhead.
* Limit visibility of //components/dbus/* to //components/dbus
* fixup! Update _LIBCPP_ABI_VERSION to always have a default value while keeping unstable false due to changes in llvm https://github.com/llvm/llvm-project/pull/112094
* 6040416: Let s know which widget the input came on. | 6040416
* 6056267: [MPArch guest view] Fix authentication for MPArch guests | 6056267
* make_span() is deprecated: https://issues.chromium.org/issues/341907909
* fixup: https://issues.chromium.org/issues/341907909
* chore: delete extra bracket from removing make_span commit
* fixup: 6059305: Make WTF::UTF8ConversionMode a scoped enum | 6059305
* 6051058: CookieInclusionStatus: Remove ctors which bypass invariants | 6051058
* 6038981: Remove most remaining CHECK(false)s | 6038981
* build: use third_party/simdutf in Node.js
* chore: node ./script/gen-libc++-filenames.js
* chore: fix strict-cast conversion error in subspan()
Xref: 6044946
* chore: fix strict-cast conversion error in base::as_bytes()
Xref: 6044946
* chore: fix strict-cast conversion error in span.split_at()
Xref: 6044946
* chore: use shorthand target name
* chore: better docs in build_add_public_config_simdutf_config.patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: alice <alice@makenotion.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
