Kevin Sawicki
f891df55d4
Call done callback with Error
2017-04-18 16:06:10 -07:00
Kevin Sawicki
4af44b1be6
Consolidate window closing
2017-04-18 16:04:27 -07:00
Kevin Sawicki
8f0ac057e3
Add initial spec for cookies.flushStore
2017-04-18 09:08:27 -07:00
Kevin Sawicki
ca46d52b0c
Add button with icon to touch bar spec
2017-04-18 09:01:43 -07:00
Yuya Ochiai
75184046f6
Add events to manage sheets of macOS BrowserWindow
2017-04-15 16:26:45 +09:00
Birunthan Mohanathas
ccdeb4746e
Destroy BrowserViews after each test
2017-04-13 01:27:31 +03:00
Birunthan Mohanathas
06fcf2c19d
Add support for BrowserView autoresizing
2017-04-13 01:27:31 +03:00
Birunthan Mohanathas
8b9f7e5b00
Implement initial, experimental BrowserView API
...
Right now, `<webview>` is the only way to embed additional content in a
`BrowserWindow`. Unfortunately `<webview>` suffers from a [number of
problems](https://github.com/electron/electron/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aopen%20label%3Awebview%20 ).
To make matters worse, many of these are upstream Chromium bugs instead
of Electron-specific bugs.
For us at [Figma](https://www.figma.com ), the main issue is very slow
performance.
Despite the upstream improvements to `<webview>` through the OOPIF work, it is
probable that there will continue to be `<webview>`-specific bugs in the
future.
Therefore, this introduces a `<webview>` alternative to called `BrowserView`,
which...
- is a thin wrapper around `api::WebContents` (so bugs in `BrowserView` will
likely also be bugs in `BrowserWindow` web contents)
- is instantiated in the main process like `BrowserWindow` (and unlike
`<webview>`, which lives in the DOM of a `BrowserWindow` web contents)
- needs to be added to a `BrowserWindow` to display something on the screen
This implements the most basic API. The API is expected to evolve and change in
the near future and has consequently been marked as experimental. Please do not
use this API in production unless you are prepared to deal with breaking
changes.
In the future, we will want to change the API to support multiple
`BrowserView`s per window. We will also want to consider z-ordering
auto-resizing, and possibly even nested views.
2017-04-13 01:27:27 +03:00
Ryohei Ikegami
c77e07bc15
Fix afterEach
2017-04-12 11:55:41 +09:00
Kevin Sawicki
bfb9388191
Add failing spec for app.exit with >2 windows
2017-04-11 09:09:17 -07:00
Kevin Sawicki
e2a00e423c
Merge pull request #9104 from electron/fix-crash-reporter-test
...
Fix sandboxed crashReporter for windows
2017-04-10 15:38:12 -07:00
Kevin Sawicki
e2e9e8ae24
Wait until server closes in afterEach
2017-04-07 16:42:01 -07:00
Kevin Sawicki
588f699d56
🎨
2017-04-06 09:52:52 -07:00
Kevin Sawicki
7f28b7a151
Add failing spec for fork --eval message bug
2017-04-06 09:48:34 -07:00
Thiago de Arruda
ce1a5e3c9c
Fix sandboxed crashReporter for windows.
...
- Use `path` module from browser process in sandboxed renderer. This is required
because the return value of `path.join` is platform-specific, and this is an
assumtion of crash-reporter.js which is shared between sandboxed and
non-sandboxed renderers.
- Set `process.platform` and `process.execPath` in sandboxed renderer
environment. This is required to spawn the windows crash service from
sandboxed renderer.
- Use a single temporary directory for all crashReporter tests. This is required
to make tests more deterministic across platforms(since mac's crashpad doesn't
support changing the crash dump directory). Also make a few improvements/fixes
to the `uploadToServer` test.
2017-04-05 18:09:24 -03:00
Kevin Sawicki
74a3a34caa
Add spec for interaction event with escape item
2017-04-04 13:14:56 -07:00
Kevin Sawicki
bbadeb62ac
Check that escape item is non-null before checking id
2017-04-04 13:12:29 -07:00
Kevin Sawicki
414540bfcb
Support passing escape item to TouchBar constructor
2017-04-04 12:50:41 -07:00
Kevin Sawicki
b24b4212c5
Make escape item a property instead of setter
2017-04-04 12:50:41 -07:00
Kevin Sawicki
21c1ddffb3
Handle change and interaction events on escape items
2017-04-04 12:50:41 -07:00
Kevin Sawicki
591cd8d073
Update window via listener when escape item changes
2017-04-04 12:50:41 -07:00
Kevin Sawicki
0501a20fe6
Clear escape item
2017-04-04 12:50:41 -07:00
Kevin Sawicki
6eacec7dc3
replaceEscapeItem -> setEscapeItem
2017-04-04 12:50:41 -07:00
Samuel Attard
2ba937289c
Add smoke test for escape replacement
2017-04-04 12:50:41 -07:00
Kevin Sawicki
746f636016
Add tests for setting remote property null/undefined
2017-04-04 11:18:16 -07:00
Kevin Sawicki
e5f70f90a4
Add spec for remote setter with remote object
2017-04-04 11:18:16 -07:00
Kevin Sawicki
3e9014c371
Merge pull request #9099 from electron/certificate-trust
...
macOS: Add certificate trust API
2017-04-04 11:17:09 -07:00
Kevin Sawicki
2bd47eb672
Add specs for showCertificateTrustDialog option errors
2017-04-04 10:49:21 -07:00
Ryohei Ikegami
9cb6bc098d
Use beforeEach/afterEach
2017-04-04 09:08:27 +09:00
Kevin Sawicki
257f6b142f
Add spec for remote setter not surfacing error
2017-04-03 09:10:46 -07:00
Ryohei Ikegami
d1212d4a43
Fix JS style
2017-04-03 20:23:36 +09:00
Ryohei Ikegami
673f4f4d0c
Add test for require
to search under app dir
2017-04-03 20:11:19 +09:00
Kevin Sawicki
d677a436ec
🎨
2017-03-31 10:42:43 -07:00
Thiago de Arruda
460fb9cdb9
Add tests for uploadToServer
option.
2017-03-31 13:48:07 -03:00
Kevin Sawicki
39fdc26921
Time out after 5 minutes
2017-03-30 14:39:48 -07:00
Kevin Sawicki
b85ebb00aa
Tweak logged messages
2017-03-30 14:36:52 -07:00
Kevin Sawicki
7873130019
Add comment to codecs app script
2017-03-30 14:36:52 -07:00
Kevin Sawicki
6b8f840da0
Add script to verify ffmpeg without proprietary codecs
2017-03-30 14:36:52 -07:00
Kevin Sawicki
fcb7cbc54a
Check name directly instead of arguments length
2017-03-30 14:03:00 -07:00
Kevin Sawicki
a2588c1fd9
Merge pull request #9052 from tonyganch/native_tabs
...
Native tabs on macOS
2017-03-30 14:02:19 -07:00
Kevin Sawicki
e699e88b4c
Add initial tabbingIdentifier spec
2017-03-30 13:46:58 -07:00
Thiago de Arruda
b3cf00a19a
Fix net module to accept non-string header values
...
This is required to be compatible with node.js http module.
2017-03-30 16:01:40 -03:00
Kevin Sawicki
57edc28b0d
Merge pull request #8880 from mst128256/2814
...
Default menu items for 'Edit' and 'Window' #2814
2017-03-29 12:31:58 -07:00
Kevin Sawicki
8b4bf1f29e
🎨
2017-03-29 12:29:36 -07:00
deepak1556
b14c4dcdc0
address review comments
2017-03-28 19:05:44 +05:30
deepak1556
3ae62615f4
net: allow controlling redirects
2017-03-28 18:46:21 +05:30
Kevin Sawicki
9249228ac3
Merge pull request #9034 from electron/disable-flaky-appveyor-spec
...
Disable flaky post navigation spec on AppVeyor
2017-03-27 14:05:42 -07:00
Kevin Sawicki
f24baffc79
Expect count to be 0
2017-03-27 10:21:01 -07:00
Kevin Sawicki
9a4783bf34
Disable flaky post navigation spec on AppVeyor
2017-03-27 09:15:40 -07:00
mst128256
6a7b4feb35
Fixed for linting
2017-03-24 12:31:49 +01:00
mst128256
9e471d8f1c
Added specs
2017-03-24 12:14:08 +01:00
Thiago de Arruda
a5eef516a7
Fix indent in api-crash-reporter-spec.js
2017-03-23 10:01:02 -03:00
Thiago de Arruda
5ee6205c0a
Run the crash reporter specs with sandbox option.
...
- Create a function that accepts BrowserWindow options and generates a suite
that contains the renderer-specific tests.
- Run the function twice to execute the tests with and without sandbox option.
2017-03-23 10:01:02 -03:00
Cheng Zhao
40b35a991f
Fix js lint
2017-03-20 12:52:46 -07:00
Cheng Zhao
940d77b9a0
Fix typos and adjust sentences
2017-03-20 12:52:46 -07:00
Cheng Zhao
033aa16e04
test: Node integration in web workers
2017-03-20 12:52:46 -07:00
Kevin Sawicki
286f529968
Merge pull request #8890 from twolfson/dev/proxy.to.string.sqwished
...
🐛 Add toString support to remote functions
2017-03-20 09:35:51 -07:00
Kevin Sawicki
648d3324fb
Add spec for remote function with toString property
2017-03-17 10:28:23 -07:00
Kevin Sawicki
11a4c7e408
🎨
2017-03-17 09:57:17 -07:00
Kevin Sawicki
0e55e5cbb5
Add initial spec for clipboard.readBuffer
2017-03-17 09:57:17 -07:00
Kevin Sawicki
a35cce5f7a
Enable takeHeapSnapshot spec
2017-03-17 09:14:17 -07:00
Todd Wolfson
818738ce84
🐛 Add toString support to remote functions
2017-03-17 08:21:37 -07:00
Kevin Sawicki
da0d0e7aac
Merge pull request #8910 from electron/touchbar-scrubber
...
Touchbar NSScrubber
2017-03-16 09:10:59 -07:00
Kevin Sawicki
49d48a4eb0
Add more non-default options to scrubber spec
2017-03-14 14:15:04 -07:00
deepak1556
80ce60f644
spec: check if pdf has loaded
2017-03-14 00:26:27 +05:30
deepak1556
6be779c777
update spec with new asset
2017-03-14 00:26:27 +05:30
deepak1556
eda413861a
update spec
2017-03-14 00:26:27 +05:30
Cheng Zhao
210f40dd53
Convert "\" to "/" in file:// url
2017-03-14 00:26:27 +05:30
deepak1556
a4400dc549
add basic spec
2017-03-14 00:26:27 +05:30
deepak1556
3baa186c0a
fix failing download spec
2017-03-14 00:26:27 +05:30
Kevin Sawicki
0dcdd60010
Add initial TouchBarScrubber spec
2017-03-13 11:17:55 -07:00
Kevin Sawicki
3349e32196
Verify selectedIndex to prevent NSRangeException
2017-03-10 10:09:18 -08:00
Kevin Sawicki
3b2faf7b89
Add initial TouchBarSegmentedControl spec
2017-03-10 10:04:22 -08:00
Kevin Sawicki
14e8e463b3
Merge pull request #8864 from electron/zoom_controller_webview_patch
...
browser: track origin zoom with HostZoomMap
2017-03-09 11:27:34 -08:00
Kevin Sawicki
2946f624ac
Add spec for adding representation to existing image
2017-03-09 09:56:42 -08:00
Kevin Sawicki
6e977cbc3a
Assert emptiness and size of built up images
2017-03-09 09:56:42 -08:00
Kevin Sawicki
7e039d92ec
Support adding representation from data URL
2017-03-09 09:56:42 -08:00
Kevin Sawicki
17b70670f8
Add initial NativeImage.addRepresentation specs
2017-03-09 09:56:42 -08:00
Kevin Sawicki
ff5081816f
Remove unneeded done call
2017-03-09 09:53:01 -08:00
John Kleinschmidt
d5a658bbe4
Fixed pass by reference and added spec
2017-03-08 22:06:26 -05:00
deepak1556
224ffe44aa
add spec
2017-03-08 19:16:55 +05:30
Kevin Sawicki
31cae8e1aa
Add more scale factor specs
2017-03-07 12:34:31 -08:00
Kevin Sawicki
82a81bb26e
Support scale factor to buffer APIs
2017-03-07 12:27:55 -08:00
Kevin Sawicki
e4ead6d018
Remove hasRepresentation and just use 1x png result
2017-03-07 12:27:55 -08:00
Kevin Sawicki
8bc65ef495
Add failing spec for toPNG with scale factor
2017-03-07 12:27:55 -08:00
Kevin Sawicki
50ade57700
Add more hasRepresentation asserts
2017-03-07 12:27:55 -08:00
Kevin Sawicki
0bbbeb307e
Support toDataURL without 1x representation
2017-03-07 12:27:55 -08:00
Kevin Sawicki
8eaf48e552
Add spec for 1x1 PNG data URL
2017-03-07 12:27:55 -08:00
Kevin Sawicki
b46e48cae1
Add failing toDataURL spec
2017-03-07 12:27:55 -08:00
Kevin Sawicki
6fcb784f6e
Add failing spec for no callback
2017-03-06 10:49:23 -08:00
Kevin Sawicki
f549bda9fc
Merge pull request #8799 from nitsakh/baseURLForDataURL
...
Support base URL option to loadURL for data URLs
2017-03-06 10:25:53 -08:00
Kevin Sawicki
886b47e713
Merge pull request #8724 from electron/defer_load_url
...
webContents: defer url load when there is a pending navigation entry
2017-03-06 10:18:36 -08:00
Kevin Sawicki
d26e4a4abf
Merge pull request #8800 from electron/https-website
...
Update website URLs to use HTTPS
2017-03-06 09:32:20 -08:00
deepak1556
90885d1d8c
simply spec
2017-03-06 00:22:20 +05:30
deepak1556
eb827eb020
update spec
2017-03-06 00:10:46 +05:30
deepak1556
dead1ae1ba
webContents: defer url load when there is a pending navigation entry
2017-03-06 00:10:46 +05:30
Kevin Sawicki
ca2898a60e
Check that window responds to touchBar selector for pre-10.12.1 compat
2017-03-03 14:00:39 -08:00
Kevin Sawicki
c349aeff80
Add initial touch bar specs
2017-03-03 14:00:39 -08:00
Nitish Sakhawalkar
d75db0ea1a
Fixed js lint issues.
2017-03-02 14:37:09 -08:00
Nitish Sakhawalkar
370562b129
Moving data url test outside post navigation block. Trailing separator comment in the docs.
2017-03-02 12:14:18 -08:00