Thiago de Arruda
a9a9e58b68
Fix random crash on app quit.
...
Move AtomCTDelegate to brightray as RequireCTDelegate and transfer ownership to
brightray::URLRequestContextGetter. This fixes the wrong lifetime assumptions
that result in AtomCTDelegate being used after free in some scenarios.
Close #10051
2017-11-17 12:03:23 -03:00
Charles Kerr
9f922e9932
Merge pull request #11099 from electron/fix-emit-call-crash
...
Fix crash when emitting unhandled error on native EventEmitter
2017-11-16 15:57:07 -06:00
Samuel Attard
fc265b7600
linter plz
2017-11-17 06:15:53 +11:00
Samuel Attard
bdbc6bb165
Clean up empty logic
2017-11-17 06:09:35 +11:00
Alexey Kuzmin
8657169017
Revert "Implement login helper to manage login item in Mac App Store build"
2017-11-16 19:05:13 +03:00
Samuel Attard
57f934a806
Appease the linter
2017-11-15 18:24:18 +11:00
Samuel Attard
8a8f169628
Add comments and use ToLocal instead of ToLocalChecked
2017-11-15 18:24:18 +11:00
Charles Kerr
3a1106d026
Merge pull request #11103 from electron/full-version-string
...
fix: Provide full and correct version in `process.version`
2017-11-14 19:18:03 -06:00
Felix Rieseberg
ee2a28b35b
🔧 Clean it up
2017-11-14 13:45:50 -08:00
Charles Kerr
31172ecaa0
Merge pull request #11008 from electron/implement-stream-protocol
...
Implement {register,intercept}StreamProtocol
2017-11-14 09:31:57 -06:00
Cheng Zhao
4b8ab8fc97
Merge pull request #10856 from dittos/mas-login-helper
...
Implement login helper to manage login item in Mac App Store build
2017-11-14 21:34:50 +09:00
Thiago de Arruda
5ea3a5886b
Implement {register,intecept}StreamProtocol
...
These new functions are more flexible than the other
{intercept,register}*ProtocoProtocol functions, since it allows the user to
return a node.js stream to feed the data to the protocol handler.
It also allows the user to specify a response header dictionary, which makes it
possible to correctly intercept any request made from renderers.
2017-11-13 16:16:14 -03:00
Thiago de Arruda
68f514b92f
Implement EventSubscriber<T> class.
...
This class simplifies the task of subscribing/handling javascript events from
C++ classes in the main process.
2017-11-13 15:22:50 -03:00
Thiago de Arruda
64bfabdeba
Make BindFunctionWith function visible to other modules.
2017-11-13 15:21:22 -03:00
Thiago de Arruda
6b666b69c0
Implement GetLoadTimingInfo in JsAsker class.
...
This is required to avoid a crash in blink when implementing a custom protocol
handler that deals with redirects.
2017-11-13 15:20:56 -03:00
Thiago de Arruda
6b2ddc4814
Stop allowing electron.net requests to be intercepted.
...
Not very useful to intercept requests from `electron.net`, since both the
interception machinery and `electron.net` live in the browser process.
2017-11-13 15:20:46 -03:00
Thiago de Arruda
32113bf7f9
Implement V8 -> C++ conversion of net::HttpResponseHeaders.
2017-11-13 15:20:40 -03:00
Thiago de Arruda
9c04d18387
Modify FillRequestDetails to pass headers dictionary.
2017-11-13 15:19:59 -03:00
Felix Rieseberg
163a33a9db
Add fallbacks
2017-11-13 09:27:02 -08:00
Felix Rieseberg
b382dec4a2
🔧 Rename the label
2017-11-13 09:26:52 -08:00
Cheng Zhao
72440d4ae7
No need to add new methods to WebContentsPreferences
2017-11-13 17:35:49 +09:00
Cheng Zhao
cee1c459c7
Do not accidentally change the behavior of did-change-theme-color
2017-11-13 16:20:54 +09:00
Cheng Zhao
7e0593950c
Code style fixes
2017-11-13 16:13:54 +09:00
Heilig Benedek
276e12ce71
pass on web_contents to properly handle devtools
2017-11-13 15:50:50 +09:00
Heilig Benedek
26daffea9c
use smart pointer for paint_canvas
2017-11-13 15:50:49 +09:00
Heilig Benedek
4b10445c2e
lint fix
2017-11-13 15:50:49 +09:00
Heilig Benedek
193beb57c9
fix datalist element popup position when menu is hidden
2017-11-13 15:50:49 +09:00
Heilig Benedek
f8b3009ebf
restructure code to use web_preferences if possible
2017-11-13 15:50:49 +09:00
Heilig Benedek
71b36ef54d
don't show the dummy window for the rest of the dialogs too on mac
2017-11-13 15:46:46 +09:00
Heilig Benedek
13b86598e8
don't show osr dummy window when dialog is shown on mac
2017-11-13 15:46:46 +09:00
Heilig Benedek
35dc6d03b9
lint fix
2017-11-13 15:46:46 +09:00
Heilig Benedek
e39aacb30e
fix a bug that caused a crash when using an offscreen window with detached devtools, related to autofill popups
2017-11-13 15:46:46 +09:00
Heilig Benedek
5daaff91ea
fix a bug where datalist elements wouldn't actually set the value of the input associated with them
2017-11-13 15:46:46 +09:00
Felix Rieseberg
7b0b87bfef
🔧 Use full version string
2017-11-12 22:37:46 -08:00
Samuel Attard
3c0b233d04
Fix line length in caller.cc
2017-11-13 11:42:42 +11:00
Samuel Attard
aa6b9a5025
Fix crash when emitting unhandled error on native EventEmitter
2017-11-13 03:03:58 +11:00
Samuel Attard
a06a8a6f79
Merge pull request #11056 from ajmacd/allow-browser-window-logs
...
Allow BrowserWindows to emit `console-message` events.
2017-11-11 14:34:39 +11:00
Samuel Attard
bb997c2ea4
Forward declare the scrubber layout
2017-11-08 16:48:08 +13:00
Andrew MacDonald
c260a0ab78
Allow BrowserWindows to emit console-message events.
2017-11-07 15:31:15 -08:00
Armagan Amcalar
edd113548a
Make ScrubberItem width dynamic
...
Depending on whether a ScrubberItem has text or an icon, this changeset
calculates the actual width and sizes the TouchBar items accordingly.
Previously, all ScrubberItems, regardless of their content, had a static
width of 50px.
This commit also fixes #10539 .
2017-11-07 00:09:14 +01:00
John Kleinschmidt
5383b4809f
v1.8.2-beta.2
2017-11-06 16:11:34 -05:00
Charles Kerr
4ceeddc09f
Merge pull request #10972 from electron/dpi-issues
...
Workaround for Windows DPI issues
2017-11-02 10:16:11 -05:00
Shelley Vohr
24acd74d15
update deprecation warning
2017-11-01 22:23:33 -04:00
Shelley Vohr
3af83f1c97
add new method and mark setExtraParameter for deprecation
2017-11-01 21:57:43 -04:00
Felix Rieseberg
e8f8100e19
🔧 Add fixme
2017-11-01 11:30:32 -07:00
Shelley Vohr
7f89cd0774
remove const from non-member function
2017-10-31 23:55:22 -04:00
Shelley Vohr
93df164485
add const and other small edits
2017-10-31 23:42:25 -04:00
Shelley Vohr
a538e47994
complete GetParameters method & all tests passing
2017-10-31 18:19:04 -04:00
Shelley Vohr
3136f833a5
fixes and updates to GetParameters
2017-10-31 13:51:44 -04:00
Felix Rieseberg
58708d6242
🔧 Lowercase
2017-10-31 10:31:05 -07:00
