Jeremy Apthorp
d7b41462af
build: [gn win] fix dllimport usage in node's usage of icu
...
We're abusing the nodejs build a little bit by building it without ICU support, but forcing the inspector to be built, which depends on ICU. This synchronizes one of the build flags that's required to get ICU to link on Windows.
2018-07-23 10:11:32 -07:00
Jeremy Apthorp
16b66db9c7
build: [gn] working on 32bit windows
2018-07-19 17:04:44 -07:00
Jeremy Apthorp
70068f313a
build: [gn] add target for building node headers
2018-07-18 12:01:16 -07:00
John Kleinschmidt
e922b1733b
Merge pull request #13636 from nornagon/gn-release
...
build: [gn] release build
2018-07-12 10:45:21 -04:00
John Kleinschmidt
9c2287c142
Merge pull request #13635 from electron/node-win32-lean-and-mean
...
build: [gn] define WIN32_LEAN_AND_MEAN in the node build
2018-07-12 08:25:25 -04:00
Jeremy Apthorp
6089254439
build: [gn linux] link static libs for node release build
2018-07-11 18:11:48 -07:00
Jeremy Apthorp
aa4982d830
build: [gn] define WIN32_LEAN_AND_MEAN in the node build
2018-07-11 17:52:18 -07:00
Jeremy Apthorp
097daa6e32
build: [gn] build node with clang-cl
2018-07-11 17:51:35 -07:00
Jeremy Apthorp
03131c5e77
build: [gn] node as a static lib
2018-07-11 10:43:52 -07:00
Jeremy Apthorp
1e1adef9b6
build: [gn] use clang and custom stdlib when building node on linux
2018-07-10 13:42:36 -07:00
Jeremy Apthorp
d4cf3cee22
build: [gn] use platform-appropriate shlib_suffix when building node
2018-07-10 13:42:33 -07:00
Jeremy Apthorp
99ecbfbd3b
build: [gn] use consistent node configuration between gyp and build
2018-07-10 13:42:29 -07:00
Jeremy Apthorp
59fb4eccb4
chore: [gn] link against debug node when in debug mode ( #13490 )
...
This is required on Windows, because in Debug mode, C++ stdlib containers have a different size to when in Release mode, so the code in `node.dll` thought that `node::Environment` was a different size to the code in `electron.exe`, which uh, caused problems.
It should also make debugging through node a bit easier on all platforms.
2018-06-28 14:42:09 -07:00
Jeremy Apthorp
475eef01c3
chore: [gn] copy node.dll in addition to node.dll.lib ( #13489 )
...
On Windows, you need to link against the `.lib` but the `.dll` needs to be next to the `.exe` at runtime, so we need to copy both.
2018-06-28 14:25:56 -07:00
Jeremy Apthorp
39e6943f1e
chore: [gn] changes to BUILD.gn for windows ( #13434 )
...
Grab basket of changes needed to get the `electron_lib` target building on Windows with GN.
2018-06-26 22:58:20 +02:00
Jeremy Apthorp
2d9a491771
chore: [gn] correct library paths for node on windows ( #13429 )
...
For some reason the windows node build needs `.dll` on the ends of these libraries, and also needs to be linked against `dbghelp`.
Additionally, copy the `WHOLEARCHIVE` hacks from common.gypi, which was doing the same thing.
2018-06-26 22:57:05 +02:00
Jeremy Apthorp
aa4ca406c8
chore: update GN build for chrome 66
2018-06-21 11:30:43 -07:00
Jeremy Apthorp
c598272891
refactor: [gn] compile node with boringssl ( #13285 )
2018-06-19 10:39:43 -05:00
Jeremy Apthorp
4321db401c
Build node by calling ./configure
2018-05-31 11:18:26 -07:00
Jeremy Apthorp
b160093b91
refactor: GN builds on linux ( #12957 )
2018-05-16 12:51:11 -07:00
Jeremy Apthorp
7a36322432
[gn] Include node/common.gypi when building node
...
Not sure how this ever worked, but the GN build certainly doesn't work
on Linux without this.
2018-05-15 09:53:24 -07:00
Jeremy Apthorp
f2b1b3f6b8
Add GN build
2018-05-10 14:03:02 -07:00
