Haojian Wu
328cf4789b
Should override the virtual destructor.
2017-03-30 23:19:43 +02:00
Haojian Wu
e8abee9ca9
Replace C-style casts with static_cast.
2017-03-30 23:05:47 +02:00
Haojian Wu
ff745e1a82
Use prefix increment in for loops.
2017-03-30 22:56:21 +02:00
Haojian Wu
8d8c7ce6ad
Correct type cast.
2017-03-30 22:53:20 +02:00
Haojian Wu
bb51401c4c
Use base::mac::NSToCast.
2017-03-30 22:33:09 +02:00
Haojian Wu
1b9780035c
Remove redundant calls to smart pointer's get method.
2017-03-30 22:22:40 +02:00
Haojian Wu
d425b63b0d
NULL => nullptr
2017-03-30 22:12:14 +02:00
Haojian Wu
00693ba075
Replace "size()" with "empty()".
2017-03-30 21:59:18 +02:00
Haojian Wu
6ef3be23fd
Avoid copy in for range loop.
2017-03-30 21:56:28 +02:00
Haojian Wu
5f724e57bc
Avoid unnecessary copy of parameters.
2017-03-29 22:06:07 +02:00
Haojian Wu
99293dd57f
Fix namespace comments.
2017-03-29 20:47:41 +02:00
Cheng Zhao
637bdc239b
Merge pull request #8923 from electron/geolocation_request_context_patch
...
browser: Create separate request context for geolocation service.
2017-03-27 22:45:46 -07:00
Kevin Sawicki
6a2cdcf32f
Merge pull request #8956 from electron/expose-crash-reporter-to-sandbox
...
Expose crash reporter to sandbox
2017-03-27 10:09:36 -07:00
Kevin Sawicki
b1275a8ef0
Merge pull request #8984 from hansenzhang/display-menuitem-label
...
Fix '&' not showing in MenuItem label
2017-03-27 09:47:50 -07:00
Thiago de Arruda
bf756e3c00
Prevent browserify from leaking the require function
...
Define a "require" argument in the wrapper functions that runs browserify
bundles, which will prevent browserify from leaking the require function.
Note that this doesn't affect the isolated renderer script, only when `-r` flag
is passed to browserify command it will export a require function. It is still
added to isolated renderer script to prevent future mistakes(doesn't hurt
defining a "require" local).
2017-03-23 10:01:02 -03:00
Thiago de Arruda
e1aebef57c
Make sandbox APIs more compatible with normal renderers
...
- Expose remote shortcuts for the `fs`, `os` and `child_process` modules.
- Expose the `url` and `timers` modules(the browserify versions)
- Add `process.crash` and `process.platform`
2017-03-23 10:01:02 -03:00
Kevin Sawicki
46aed5ff6f
Bump v1.6.4
2017-03-22 09:16:08 -07:00
Cheng Zhao
e539129db2
Merge pull request #8852 from electron/web-worker-hook
...
Add Node.js integration to WebWorker
2017-03-22 09:01:42 -07:00
Hansen Zhang
426563a843
#8881 - Display '&' in MenuItem label
2017-03-22 11:52:25 -04:00
deepak1556
4ab2c92418
CommonWebContentsDelegate::DestroyWebContents => ResetManagedWebContents
2017-03-22 07:30:36 +05:30
Cheng Zhao
99d3fce3c7
node::Environment should be destroyed before AtomBindings
...
The shutdown code may still uses the APIs provieded by AtomBindings.
2017-03-20 13:01:28 -07:00
Cheng Zhao
0287f23e3b
Fix cpplint warning
2017-03-20 12:52:46 -07:00
Cheng Zhao
940d77b9a0
Fix typos and adjust sentences
2017-03-20 12:52:46 -07:00
Cheng Zhao
033aa16e04
test: Node integration in web workers
2017-03-20 12:52:46 -07:00
Cheng Zhao
a49af26e39
Add nodeIntegrationInWorker option
2017-03-20 12:52:46 -07:00
Cheng Zhao
e496e18f6e
Make Archive thread safe
2017-03-20 12:52:46 -07:00
Cheng Zhao
c068285ff8
AtomBindings should not use default uv loop
2017-03-20 12:52:46 -07:00
Cheng Zhao
9c9c8ec5f1
WebWorkerObserver should be destroyed on exit
2017-03-20 12:52:46 -07:00
Cheng Zhao
d2f185bea5
Create new uv loop in each worker
2017-03-20 12:52:46 -07:00
Cheng Zhao
69df934710
Converter for base::Callback is not thread safe
2017-03-20 12:52:45 -07:00
Cheng Zhao
b467c3939e
Add a new type of NodeBindings
2017-03-20 12:52:45 -07:00
Cheng Zhao
2cbdb6bac3
Wrap ContextCreated with context scope
2017-03-20 12:52:45 -07:00
Cheng Zhao
e017e157ba
Insert node integrations into WebWorker
2017-03-20 12:52:45 -07:00
deepak1556
72adbf7a2f
destroy guest webcontents before embedder
2017-03-19 10:25:13 +05:30
deepak1556
16f9754445
Create separate request context for geolocation service.
...
* Geolocation service cannot hold reference to browser context,
since it is destroyed at the end of everything and this will
confuse the shutdown path of browser context.
* Geolocation service run on its own thread.
2017-03-19 01:11:55 +05:30
Kevin Sawicki
f119bc0944
Remove unused args param
2017-03-17 10:35:54 -07:00
Kevin Sawicki
ab05346572
Add clipboard.readBuffer
2017-03-17 09:57:17 -07:00
Kevin Sawicki
6d45052eea
Merge pull request #8900 from electron/handle-buffer-instances-in-sandbox
...
Handle Buffer deserialization in sandboxed renderers
2017-03-16 10:12:09 -07:00
Thiago de Arruda
a6e4867111
Handle Buffer deserialization in sandboxed renderers
...
In sandboxed renderers we use browserify to provide a node-like environment. The
Buffer class used by browserify is actually just a wrapper around Uint8Array,
but to deserialize Buffer correctly we must expose the class as a hidden value
and use it in V8ValueConverter.
2017-03-16 13:20:09 -03:00
Kevin Sawicki
da0d0e7aac
Merge pull request #8910 from electron/touchbar-scrubber
...
Touchbar NSScrubber
2017-03-16 09:10:59 -07:00
Kevin Sawicki
e98ac94d51
🎨
2017-03-15 11:22:31 -07:00
Kevin Sawicki
f41db87e47
Use NSZeroRect for scrubber frame
2017-03-15 09:45:50 -07:00
Kevin Sawicki
466c39ed19
Use icon for consistency with other touch bar APIs
2017-03-15 09:33:11 -07:00
Kevin Sawicki
6175ee05e2
Remove unneeded long cast
2017-03-14 13:59:29 -07:00
Kevin Sawicki
8b7675baee
Add more forward declarations for scrubber APIs
2017-03-14 13:57:39 -07:00
Samuel Attard
a55cddaa53
Add more options
2017-03-14 18:57:57 +11:00
deepak1556
15e2b2335f
address review comments
2017-03-14 00:26:27 +05:30
deepak1556
d022d108a3
Dont intercept pdf request for subframes
...
Will not work without OOPIF support
2017-03-14 00:26:27 +05:30
deepak1556
4381e0895f
propagate zoom changes to pdf plugin
2017-03-14 00:26:27 +05:30
deepak1556
eda413861a
update spec
2017-03-14 00:26:27 +05:30