trop[bot]
cdbb09835d
refactor: declare gin::Wrapper subclasses as final ( #43566 )
...
As per the gin docs: "Wrappable<T> explicitly does not support further
subclassing of T. Subclasses of Wrappable<T> should be declared final."
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-04 20:37:51 -05:00
trop[bot]
467d649dfa
chore: remove unused Notification fields icon_path_, has_icon_ ( #43294 )
...
Last use of `icon_path_` was removed on May 29, 2017 (c741b584
)
Last use of `has_icon_` was removed on May 30, 2017 (5048425e
)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-12 12:09:29 +02:00
Charles Kerr
ffec3127d5
refactor: inline simple getters ( #41125 )
2024-01-29 20:43:28 -06:00
Shelley Vohr
c7bdd907d7
fix: set prototype names on gin::Constructible
classes ( #39006 )
...
* fix: set prototype names on gin::Constructible classes
* test: add tests
2023-07-10 11:49:20 +02:00
John Kleinschmidt
3dbc0a365f
chore: enable check raw ptr fields ( #38167 )
2023-05-11 16:07:39 -04:00
Jeremy Rose
67dc178e70
refactor: move gin_helper::Constructible methods to prototype ( #37087 )
2023-02-06 12:59:49 -08:00
David Sanders
5d120359f6
chore: used nested namespaces ( #34737 )
2022-06-29 12:55:47 -07:00
Milan Burda
c4ea33d1bf
chore: add ELECTRON_ prefix to C++ include guards ( #31925 )
2021-11-22 16:34:31 +09:00
Milan Burda
65a980c673
refactor: replace deprecated DISALLOW_COPY_AND_ASSIGN ( #31633 )
2021-11-03 20:41:45 +09:00
David Sanders
ba26580f23
chore: use consistent parameter names ( #29361 )
2021-06-01 10:46:25 +09:00
David Sanders
93c9374e95
chore: trim unused STL includes ( #29414 )
2021-06-01 10:34:44 +09:00
John Kleinschmidt
22d8f22cfb
2757472: Reland "Reland "[LSC] Remove base::string16 alias""
...
https://chromium-review.googlesource.com/c/chromium/src/+/2757472
2021-03-16 12:18:45 -04:00
David Sanders
d8167ce138
chore: use consistent parameter names ( #26162 )
2020-10-27 10:18:36 -05:00
bitdisaster
b43859f098
feat: custom toast xml and failure reporting for notifications ( #25401 )
...
* allow custom toast xml and report failures
* docs
* tests
* don't use namespaces
* lint doesn't like trailing commas
* addressing feedback
2020-09-29 12:20:10 -07:00
Jeremy Apthorp
765c08c600
refactor: ginify Notification ( #22821 )
2020-03-31 11:42:32 -07:00
Jeremy Apthorp
d9321f4df7
chore: rename atom -> electron ( #21986 )
2020-02-04 12:19:40 -08:00