Milan Burda
9d9d6ca20b
Fix empty description when only one extension is given
2018-05-16 01:58:58 +02:00
Jeremy Apthorp
73eb5af2cc
refactor: remove unnecessary std::moves in linux code ( #12951 )
...
The compiler was complaining that the move was preventing copy elision.
2018-05-15 14:33:47 -07:00
Jeremy Apthorp
8fa48d1c04
fix: unused variable warnings in linux code ( #12950 )
2018-05-15 13:49:27 -05:00
Jeremy Apthorp
c4134c3516
refactor: breakpad #includes to work with GN and GYP ( #12953 )
2018-05-15 11:33:19 -07:00
Jeremy Apthorp
136105e353
fix: wrong list index type in file_dialog_gtk.cc ( #12952 )
2018-05-15 13:22:52 -05:00
Milan Burda
6a4d9309b2
Remove unnecessary heap allocations of atom::V8ValueConverter instances ( #12924 )
2018-05-15 09:21:23 -05:00
Cheng Zhao
2f3fcb9dbe
give window a default content view
...
Certain APIs are expecting the window to have a content view, having a
default one simplifies our design.
2018-05-15 14:12:47 +09:00
Cheng Zhao
ea97f43145
check content view in SetMenuBarVisibility
2018-05-15 14:12:47 +09:00
Cheng Zhao
bb2715e7a5
feat: add TopLevelWindow.setContentView API
2018-05-15 14:12:47 +09:00
Cheng Zhao
2b24b26e59
refactor: do not pass WebContents to NativeWindow
2018-05-15 14:03:21 +09:00
Cheng Zhao
640877ebf8
attach native view after widget is created
2018-05-15 14:03:21 +09:00
Cheng Zhao
5a320222e2
feat: add WebContentsView API
2018-05-15 14:03:21 +09:00
Cheng Zhao
e058d11657
feat: add View API
2018-05-15 14:03:21 +09:00
John Kleinschmidt
fe7947da90
Merge pull request #12805 from electron/update-blacklist-switches
...
update command-line backlist switches
2018-05-14 13:31:26 -04:00
John Kleinschmidt
0fd8513c80
Merge pull request #12904 from electron/fix-12875
...
Allow frameless transparent windows to be sized smaller than 64x64 on Windows
2018-05-14 10:46:40 -04:00
Heilig Benedek
ce8af7d499
#else instead of #elif
2018-05-12 22:05:25 +02:00
Heilig Benedek
c6bf39b283
Only include windows headers on windows
2018-05-12 21:33:47 +02:00
Heilig Benedek
f1fd457411
Format code with clang-format
2018-05-12 19:51:19 +02:00
Heilig Benedek
eae0674f61
Match chromium's workaround when setting size of unresizable windows
2018-05-12 17:37:31 +02:00
Jeremy Apthorp
cc386f2345
Merge pull request #12884 from nornagon/views-defines
...
Require !OS_MACOSX as well as TOOLKIT_VIEWS for views code
2018-05-10 14:13:19 -07:00
Jeremy Apthorp
72057bf7ef
clang-format atom_api_web_contents.cc
2018-05-10 14:11:19 -07:00
Jeremy Apthorp
87d0175c76
Require !OS_MACOSX as well as TOOLKIT_VIEWS for views code
2018-05-10 14:11:19 -07:00
Jeremy Apthorp
73ac019882
Fix up #includes to work with both GYP and GN
2018-05-10 13:38:40 -07:00
Samuel Attard
5b5c161601
feat: new makeSingleInstance API ( #12782 )
...
* Refactor app.makeSingleInstance
* new API `app.isPrimaryInstance()`
* new API `app.isSingleInstance()`
* new event `app.on('second-instance')`
* deprecated old syntax `app.makeSingleInstance(cb)`
* deprecated old syntax of `app.makeSingleInstance() --> bool` in favor
of `app.isPrimaryInstance()`
* Fix spec, we don't need process.nextTick hacks any more
* Make deprecation TODO for the return value of makeSingleInstance
* Refactor makeSingleInstance to requestSingleInstanceLock and add appropriate deprecation comments
* I swear this isn't tricking the linter
* Make const
* Add deprecation warnings for release, and add to planned-breaking-changes
BREAKING CHANGE
2018-05-08 01:29:18 +10:00
Jeremy Apthorp
118da36b52
Send document-start/end to the right context when contextIsolation=true ( #12738 )
2018-05-04 23:39:54 -07:00
Jeremy Apthorp
b280ea5579
chromium-style fixes ( #12826 )
2018-05-03 23:45:12 -07:00
Cheng Zhao
a2c3db666e
viewDidMoveToSuperview may not be implemented
2018-05-04 09:55:09 +09:00
Cheng Zhao
5547df6073
report correct content size in AtomNSWindow
...
The views framework relies on NSWindow to return content size of window,
since we don't use the borderless window, the original result would
include titlebar. We have to override the function to return correct
result for frameless window.
2018-05-04 09:55:09 +09:00
Cheng Zhao
28fc58067b
remove usage of FullSizeContentView
2018-05-04 09:55:09 +09:00
Cheng Zhao
a9709a635c
display WebContents as views::View on macOS
2018-05-04 09:55:09 +09:00
Cheng Zhao
ada884a129
refactor: setup contentView on initialization
2018-05-04 09:55:09 +09:00
mikeykhalil
94ffd4bfc0
add getter for ignoreDoubleClickEvents field
2018-05-03 13:49:33 -07:00
mikeykhalil
208374afa4
clean up ignore double click event implementation
2018-05-03 13:49:33 -07:00
mikeykhalil
1f29124d11
updated Tray API to ignore double click events on macOS ( #8952 )
2018-05-03 13:49:32 -07:00
Alexey Kuzmin
3fd0ec99ae
Better OSR tests ( #12817 )
...
* Add features.isOffscreenRenderingEnabled()
* Use .isOffscreenRenderingEnabled() to determine if OSR is available
* Add a helper closeTheWindow() function
* Skip OSR tests if they are disabled
2018-05-03 11:10:25 -05:00
Jeremy Apthorp
cdc5022305
Fix chromium-style errors ( #12802 )
2018-05-03 09:04:22 -05:00
Charles Kerr
1b8b73ce71
update command-line backlist switches
...
part of the diff comes from the fact that we've bumped
to a new version of libcc.
another part comes from adding network_switch_list.h, whose
switch definitions follow a slightly different format.
2018-05-02 20:58:22 -05:00
Jeremy Apthorp
78ab97ab04
Fix crash when releasing a script context that never had node injected ( #12741 )
2018-05-01 20:00:46 -04:00
bughit
55a7f6f0ce
add did-frame-navigate event to WebContents ( #12723 )
...
* add did-frame-navigate event to WebContents, pass http response code to it and did-navigate
* docs for frame routing id related api changes on WebFrame and WebContents
2018-05-01 13:34:41 +09:00
Cheng Zhao
c67d1b62e3
refactor: NativeWindowViews should not be a View ( #12750 )
2018-05-01 13:28:22 +09:00
Samuel Attard
338a816ffd
Screen Lock / Unlock events ( #12714 )
...
* initial lock-screen and unlock-screen event implementation for macOS
* Implementation of lock-screen and unlock-screen on windows
2018-05-01 02:04:27 +10:00
Cheng Zhao
089428857c
remove unnecessary defines
2018-04-30 10:56:54 +09:00
Cheng Zhao
e07ea24610
remove unnecessary static_cast
2018-04-30 10:56:54 +09:00
Cheng Zhao
2225cc9608
refactor: manage widget_ in NativeWindow
2018-04-30 10:56:54 +09:00
Cheng Zhao
727cd68cee
refactor: Use widget() instead of window_
2018-04-30 10:56:54 +09:00
Cheng Zhao
6d18bd0633
refactor: Make NativeWindow inherit WidgetDelegate
2018-04-30 10:56:54 +09:00
Zeke Sikelianos
cc98bd6b6d
Merge pull request #12662 from electron/prevent-default
...
Stop overwriting prevent_default if default wasn't prevented
2018-04-26 12:12:18 -07:00
Jeremy Apthorp
dd7e0f80fe
Turn off visual zoom by default ( #12679 )
2018-04-26 10:27:35 -05:00
Jeremy Apthorp
1a64b9f0c2
Disable navigating on drag/drop ( #12655 )
...
* Disable navigating on drag/drop
* Add a WebPreferences option to re-enable navigate on drag/drop
2018-04-26 10:23:27 -05:00
bughit
4fcd178c36
expose WebFrame#routingId ( #12614 )
...
* expose WebFrame#routingId and pass it to WebContents frame specific events along with frameProcessId; add WebContets.did-start-navigation event
* fix compilation error on ia32 Windows
2018-04-26 19:17:55 +09:00
Cheng Zhao
cf70267871
remove unnecessary overrides
2018-04-26 09:48:12 +09:00
Cheng Zhao
5e48dd9d45
be aware of views::Widget's layer
2018-04-25 15:10:29 +09:00
Cheng Zhao
39242c978f
fix failed BrowserWindow tests
2018-04-25 15:10:29 +09:00
Cheng Zhao
75a624434c
refactor: use views::Widget on macOS
2018-04-25 15:10:29 +09:00
Nitish Sakhawalkar
2579071b98
Deprecate did-get-response-details and did-get-redirect-request ( #12615 )
...
* Deprecate webContents events did-get-response-details and did-get-redirect-request.
* Update guest view files
* Update webview tag docs and update specs
* Update deprecate.event function
* Update comment
* Update more
* Update documentation for other deprecated event
2018-04-23 14:46:12 -05:00
Shelley Vohr
12a57ff1c2
clang-format objc files ( #12673 )
2018-04-20 11:47:04 -07:00
Cheng Zhao
28b85762fd
Merge pull request #12660 from electron/mac-views
...
Refactor NativeWindow (Part 8): Prepare work for using views::Widget on macOS
2018-04-20 21:31:28 +09:00
Robo
ff571f3b5d
Part I: Move from base::Bind to base::BindOnce and remove unneeded base::Passed ( #12661 )
2018-04-20 19:55:05 +09:00
Cheng Zhao
aa5c80f8a6
Fix new clang warnings
2018-04-20 19:26:20 +09:00
Cheng Zhao
c44279bb10
Move AtomNSWindow to a new file
2018-04-20 19:26:20 +09:00
Cheng Zhao
569967ac21
Move QLPreviewPanelDataSource to AtomNSWindowDelegate
2018-04-20 19:17:08 +09:00
Cheng Zhao
f6a7e5ea23
Move NSTouchBarDelegate to AtomNSWindowDelegate
2018-04-20 19:15:45 +09:00
Cheng Zhao
8e9667d86c
Manage AtomTouchBar in NativeWindow instead of AtomNSWindow
2018-04-20 19:15:01 +09:00
Cheng Zhao
ce54fd334d
Move AtomNSWindowDelegate to a new file
2018-04-20 19:12:17 +09:00
Cheng Zhao
1c6c75da4f
Merge the logic of managing ViewsDelegate
2018-04-20 19:10:37 +09:00
Cheng Zhao
9bc79f840e
mac: Override NativeWidgetMac
2018-04-20 19:10:37 +09:00
Cheng Zhao
37a7df49d6
mac: Provide ViewsDelegate
2018-04-20 19:10:37 +09:00
deepak1556
30f1d0991b
enable chromium style checker plugin for electron and brightray targets
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
eb7ccf8afa
Bring mac code into conformance with -Wobjc-missing-property-synthesis
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
f3c00e96aa
Bring mac code into conformance with -Wunguarded-availability
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
27cee90e5e
[chromium-style] move methods out of headers
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
f1587da480
[chromium-style] out-of-line default constructors and destructors
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
6c26bb1cf8
[chromium-style] destructors of ref-counted objects should be private
2018-04-19 11:12:10 -07:00
Jeremy Apthorp
e6695cf2ec
[chromium-style] override / virtual warnings
2018-04-19 11:12:10 -07:00
Jeremy Apthorp
a635f078c6
[chromium-style] auto variable type must not deduce to a raw pointer type
2018-04-19 11:10:52 -07:00
Birunthan Mohanathas
cd407d1c3f
Stop overwriting prevent_default if default wasn't prevented
...
This didn't actually cause any issues because there is only one listener
for the affected methods right now. Should we have added more, the last
called observer would have overwritten `prevent_default`. Lets only set
it when necessary to avoid this footgun in the future.
2018-04-19 12:45:21 +02:00
Cheng Zhao
7473b612c5
Make Menu API accept TopLevelWindow
2018-04-19 13:08:37 +09:00
Cheng Zhao
1340b17424
Do not return TopLevelWindow in BrowserWindow.getAllWindows
2018-04-19 13:08:37 +09:00
Cheng Zhao
e38f511737
Make BrowserWindow inheirt TopLevelWindow in JS
2018-04-19 13:08:37 +09:00
Cheng Zhao
71ebd99dfa
Expose TopLevelWindow to JavaScript
2018-04-19 13:08:36 +09:00
Cheng Zhao
cfed9fa4b9
Make sure we append parent->child_windows after InitWith
2018-04-19 12:45:48 +09:00
Cheng Zhao
89d909ab43
Only include UIAutomationCoreApi.h where necessary
2018-04-19 11:14:55 +09:00
Shelley Vohr
35a4a07320
fix include definition errors
2018-04-18 20:48:46 -04:00
Shelley Vohr
ec35966715
remove unused macro
2018-04-18 20:48:45 -04:00
Shelley Vohr
9f7a8832a1
remove include ordering filter
2018-04-18 20:48:45 -04:00
Shelley Vohr
c6f4bbd143
also format missing .cc files
2018-04-18 20:48:45 -04:00
Shelley Vohr
53bdf22c85
clang-format atom files
2018-04-18 20:48:45 -04:00
Shelley Vohr
ca406637af
add converters for base::BindOnce and base::BindRepeating
2018-04-17 18:47:12 -04:00
Shelley Vohr
7a8a0f6b4b
Merge pull request #12616 from electron/fix-copy-to
...
switch to sk_tool_utils::copy_to()
2018-04-16 22:18:23 -04:00
Zeke Sikelianos
40ff17c9f9
Merge pull request #12619 from electron/add-before-update-event
...
add new event to auto-updater
2018-04-16 12:43:15 -07:00
Shelley Vohr
354f872919
run clang-format
2018-04-16 15:08:17 -04:00
Shelley Vohr
a19ddfc578
fix copy_to conditional
2018-04-16 12:14:35 -04:00
Samuel Attard
d06c79f5d3
Correct the default of allowRunningInsecureContent as per docs ( #12556 )
...
* Correct the default of allowRunningInsecureContent as per docs
* fix linting
* Update calls to match native_mate API change
2018-04-16 08:28:54 -05:00
Shelley Vohr
90a7b5ebce
switch to simplified version of copy_to
2018-04-16 08:47:34 -04:00
Shelley Vohr
06892775d4
add new event to auto-updater
2018-04-14 21:29:36 -04:00
Shelley Vohr
43a9092c16
remove accidental file change
2018-04-14 21:24:19 -04:00
Shelley Vohr
1727a9eca9
pull up definition and remove include
2018-04-14 21:23:05 -04:00
Shelley Vohr
8b4a89c445
.deepCopyTo() => sk_tool_utils::copy_to()
2018-04-14 12:50:55 -04:00
Cheng Zhao
858828d343
Refactor NativeWindow (Part 6): Move NativeWindow bindings to api::TopLevelWindow ( #12596 )
...
* Add atom::api::TopLevelWindow
* Make BrowserWindow inherit TopLevelWindow
* Fix reading from wrong weak map
* Read options after setting content view
* OnWindowClosed is not guarenteed to run now
* Fix the offscreen hack in BrowserWindow
* Fix building on Linux
* Fix tests on Linux
* Fix building on Windows
2018-04-14 11:04:23 +09:00
Zhuo Lu
a0cac05555
Clear cache storage data ( #12546 )
2018-04-13 13:03:16 -04:00
Robo
ad2baccefa
tools: pass custom template for js2c ( #12593 )
...
* Update node v9.7.0 ref
* tools: pass custom template to node/tools/js2c.py
2018-04-13 08:20:04 -04:00
Shelley Vohr
d722008367
remove unnecessary ptr_util.h include
2018-04-12 22:34:26 -04:00
Shelley Vohr
b05932310b
replace base::MakeUnique with std::make_unique
2018-04-12 08:48:32 -04:00
Cheng Zhao
d706a30849
Fix crash when releasing window
2018-04-11 15:12:53 +09:00
Cheng Zhao
2b5bde4071
InstallView is no longer needed
2018-04-11 15:12:53 +09:00
Cheng Zhao
5a95aaaa54
kVibrancyType should be read in InitFromOptions
2018-04-11 15:12:53 +09:00
Cheng Zhao
cfd8ea8eb0
mac: Correctly unload previous content view
2018-04-11 15:12:53 +09:00
Cheng Zhao
56735d4ff5
Add NativeWindow::SetContentView
2018-04-11 15:12:53 +09:00
Cheng Zhao
13473ee138
web_view_ => content_view_
2018-04-11 15:12:53 +09:00
Cheng Zhao
97e8800677
Remove web_contents from NativeWindow's constructor
2018-04-11 15:12:53 +09:00
Nitish Sakhawalkar
6fc819dae1
Fix transparency in capturePage ( #12561 )
...
* Fix transparent window capture. Transparency is preserved and not converted to black pixels anymore
* Add test to make sure aplha channel exists in captured image
2018-04-10 19:07:15 +09:00
Andreas
6b5e09478c
Mouse forward on macOS ( #12281 )
...
* Accept mouse events according to the forward parameter on macOS.
* Update BrowserWindow docs: mouse forward is available on macOS
2018-04-09 19:35:05 +09:00
Cheng Zhao
41134f52d9
Fix memory leaks in file_dialog_mac.mm
2018-04-09 16:51:25 +09:00
Yuya Ochiai
2131dc839a
Show file filter name for accessory view of file dialog
...
- Respect filters option of dialog.showOpenDialog() and
dialog.showSaveDialog(). (#10335 )
- Show "All Files" for <input> apart from "accept" attribute. (#11456 )
2018-04-09 16:50:21 +09:00
OJ Kwon
4c51c03779
feat(performspellcheck): queue spell check request asynchronously ( #12112 )
...
* feat(spellcheckrequest): implement spellcheckrequest
* feat(performspellcheck): queue spell check request asynchronously
2018-04-09 15:18:50 +09:00
Andrew MacDonald
6bfb122cd1
Add a display_id parameter to the desktopCapturer API. ( #12417 )
...
* Add a screen_api_id parameter to the desktopCapturer API.
When using the DirectX capturer on Windows, there was previously no way
to associate desktopCapturer/getUserMedia and electron.screen API
screens. This new parameter provides the association.
* Fix non-Windows build.
* Fix Mac.
* Fix Mac harder.
* JS lint
* clang-format C++ code.
* IWYU
* display_id, Linux comment, better test
* lint
* Fix tests on Linux.
* Add display_id documentation.
2018-04-09 14:43:35 +09:00
Robo
65e8199a93
Enable plznavigate aka browser side navigation ( #12535 )
...
* enable plznavigate code path
* AtomBrowserClient::GetGeolocationApiKey returns the right default
* use IsLoadingToDifferentDocument to identify top level navigation in mainFrame
* use candidate site instance when available
* spec: don't test httpReferrer option for file origin
* update libcc ref
* affinity: only group same site in this mode
* plznavigate: don't emit did-get-response-details event for blob scheme
2018-04-06 16:22:52 +09:00
Charles Kerr
f8b8dc1494
Simplify views/menu_bar focus management ( #12536 )
...
* Simplify views/menu_bar focus management
* Make the linter happy
* Remove NativeWindowView focus manager listener API
* remove unnecessary change
* MenuBar ctor now takes a views::View
2018-04-05 21:53:08 -05:00
Charles Kerr
cad8eed6e4
Use ui:view's Activate() on Linux ( #12539 )
...
In NativeWindowViews, we started rolling our own _NET_ACTIVE_WINDOW
event in June 2016 to raise windows because Chromium's implementation
wasn't working as expected. (See commit 32b692b6
)
I'm not seeing this behavior in our current version of libcc,
so I wonder if this workaround is still needed?
2018-04-05 22:39:53 -04:00
Jeremy Apthorp
f0d08f4da1
Propagate referrer to new windows ( #12397 )
...
* Propagate referrer to new windows
Fixes #9205
* Rearrange -new-window event arguments for backwards-compatibility
* Plumb referrer policy through guest-window-manager
* Document the Referrer structure and its uses
* Add tests for referrer in new windows
* Docs nits
2018-04-05 18:13:24 -05:00
Heilig Benedek
a14ebc80d2
Disable chromium's redraw locking on Windows when DWM is disabled ( #12501 )
...
* disable redraw locking on windows
* update libcc ref
2018-04-05 15:55:26 +09:00
Adrien Fery
5486a65702
Improve in-app purchase for MacOS ( #12464 )
...
* Add methods to finish transactions
* Add a method to get the product descriptions from the App Store
* Improve the documentation of a transaction structure
* Add a tutorial for In App Purchase
* Fix typo in In-App Purchase tutorial
* Fix style of In-App Purchase files
* Fix In-App-Purchase product structure conversion in amr64
* Fix code style in In-App Purchase tutorial documentation
* Fix typos in In-App Purchase documentation
* Fix typo in In-App Purchase spec
* Slight style fixes
2018-04-05 15:33:13 +09:00
Heilig Benedek
52b1065b3b
Focus webview directly in offscreen mode ( #12507 )
2018-04-05 15:14:42 +09:00
Robo
c1404ff2c1
vendor: Update native mate to fix v8 DCHECK crash ( #12534 )
...
* update native_mate ref
* Remove MarkHighMemoryUsage api
2018-04-05 00:47:18 -05:00
Cheng Zhao
c75dd93b92
Move AutofillPopup from NativeWindow to WebContents ( #12514 )
2018-04-05 09:53:51 +09:00
Aleš Pergl
3a45d541f3
Expose IsOffScreen method always to JS. ( #12530 )
2018-04-04 12:19:08 -05:00
MadfishDT
200388ff96
add moveTop API to move window z-oder to top for win32, mac ( #12485 )
...
* add moveTop API to move window z-oder to top for win32, mac
* BrowserWindow::MoveTop SetMethod bug fix
2018-04-03 08:04:32 -05:00
Cheng Zhao
8fc5c6c862
Refactor NativeWindow (Part 3): Remove is_offscreen_dummy from NativeWindow ( #12503 )
...
* Don't use is_offscreen_dummy in MessageBox
* Don't use is_offscreen_dummy in DownloadManagerDelegate
* Don't use is_offscreen_dummy in CommonWebContentsDelegate
* Remove is_offscreen_dummy from NativeWindow
2018-04-03 12:19:35 +09:00
Jeremy Apthorp
a7352e57d5
WebFrame.setVisualZoomLevelLimits sets user-agent scale constraints ( #12488 )
...
Fixes #11216 .
2018-04-02 18:20:13 -04:00
Nitish Sakhawalkar
fbff355742
Support for navigator.languages ( #12419 )
2018-04-02 12:47:00 +09:00
Robo
171230e45d
Cleanup destruction of URLRequestContextGetter ( #12305 )
...
- Add Leak detector
- Indicate shutdown of request context from Browser Context
- Change stored references to URLRequestContextGetter to use BrowserContext
- Destroy session properties explicitly
2018-03-30 08:24:55 -05:00
Zhuo Lu
c50a460ce6
Do not block main process for async dialog ( #12404 )
2018-03-22 08:57:33 -04:00
Clément Beffa
642f5a84d4
Workspace notifications support on macOS ( #12093 )
2018-03-22 18:41:03 +09:00
Nitish Sakhawalkar
9d1527b1df
Fix context menu for sandbox devtools ( #11933 )
2018-03-22 16:15:57 +09:00
Cheng Zhao
05fcec829e
Use Clone explicitly instead of MergeDictionary
2018-03-22 15:29:20 +09:00
Cheng Zhao
0abbedcdae
Fix error caused by refactor
2018-03-22 15:21:56 +09:00
Cheng Zhao
6df2326a30
Cleanup the static methods of WebContentsPreferences
...
The static methods are totally unnecessary, and it makes code harder to
understand since we are using different ways to do the same things.
2018-03-22 15:21:56 +09:00
Cheng Zhao
001275339b
Hide WebContentPreferences::GetWebContentsFromProcessID from public
2018-03-22 15:20:03 +09:00
Cheng Zhao
3d47a8a2fd
Remove the static getter methods from WebContentsPreferences
2018-03-22 15:20:03 +09:00
Cheng Zhao
887bc12350
Add WebContentsPreferences::From that checks parameter
2018-03-22 15:16:26 +09:00
Cheng Zhao
9772777919
web_prefrences() => dict()
...
Having property name being the same with class name is making code
harder to understand, and dict is much shorter.
2018-03-22 15:15:30 +09:00
Shelley Vohr
05dc04dacc
don't check darkmode for drawStatusBarBackgroundInRect ( #12395 )
2018-03-21 19:03:57 -04:00
Charles Kerr
0d7becff87
Use the appname as the tray icon's default tooltip ( #12388 )
...
This makes an upstream DCHECK happy in AppIndicatorIcon::SetToolTip.
Empty tooltip strings are discouraged, as discussed in commit log
b6c510aa543193337041517c2d70113840189b06.
Fixes #12386 .
2018-03-21 12:15:30 -05:00
John Kleinschmidt
060b592fc8
Merge pull request #12348 from electron/fix-browser-view-draggable-region
...
Update draggable regions when changing BrowserView
2018-03-20 10:40:27 -04:00
Cheng Zhao
2e94a730cc
Isolate the code using content::WebContentsImpl
2018-03-20 10:13:17 +03:00
Gellert Hegyi
a9cdd6614a
fixes class name
2018-03-20 10:13:17 +03:00
Gellert Hegyi
0ad8815bbc
fixes offscreen rendering issues
2018-03-20 10:13:17 +03:00
Cheng Zhao
d4969783d7
Avoid including web_contents_impl.h
...
This can fix the build error caused by duplicate typedefs.
2018-03-20 10:13:17 +03:00
deepak1556
e24c0dda5d
add features module to detect availability of build time features at runtime
2018-03-20 10:13:17 +03:00
deepak1556
4b39d17e5f
move pdf viewer behind feature flag
2018-03-20 10:13:17 +03:00