shelley vohr
18362eb948
improve Menu and MenuItem testing ( #12015 )
...
* split menu/menuitem and add some tests
* fix ipc send issue
* feedback: make tests less brittle
* clean up MenuItem accelerator and label tests
2018-02-23 07:53:59 -06:00
John Kleinschmidt
2a97e48465
Merge pull request #11968 from electron/refactor-menu-popup
...
Refactor menu.popup
2018-02-21 14:29:52 -05:00
Charles Kerr
5a25b88b50
Fix browserWindow detection in menu.popup()
2018-02-20 18:35:39 -06:00
Charles Kerr
708f39a1a5
update a few menu.popup() calls to use the new API
2018-02-20 14:02:24 -06:00
Cheng Zhao
dc62e51ba4
Fix the cyclic reference in menu delegate ( #11967 )
...
* Fix the cyclic reference in menu delegate
* Fix menu tests due to delegate change
2018-02-20 10:11:35 -06:00
Shelley Vohr
fb7fb4972d
options all the things
2018-02-20 11:10:53 -05:00
Shelley Vohr
73ab87b87f
add new and changed specs
2018-02-19 20:59:47 -05:00
Shelley Vohr
9c52d273dd
add spec for menu.popup(window, callback)
2018-02-19 13:15:49 -05:00
shelley vohr
5240352326
Remove extra menu separators ( #11827 )
...
* add function to remove leading/trailing separators
* change const name for clarity
* add spec to check filtered separators
* clean method and add edge case spec per review
2018-02-05 11:55:12 -06:00
Shelley Vohr
3d032c2b57
forgot to remove .only from spec
2018-01-27 12:38:55 -05:00
Shelley Vohr
3679a9c37a
fix event callback placement in spec
2018-01-27 12:36:51 -05:00
Shelley Vohr
e345342e36
add first pass at menu event specs
2018-01-27 11:23:46 -05:00
Cheng Zhao
46330ac2a9
Remove the closed event of Menu
...
The callback of Menu.popup does more things, and there is actually no
request for the closed event.
2018-01-01 17:22:07 +09:00
Cheng Zhao
73d78d345a
Make callback work for old-style Menu.popup call
...
While the old-style Menu.popup has been deprecated, it is still being
used widely in apps and even in Electron itself.
2018-01-01 17:17:01 +09:00
Cheng Zhao
2ec3b8ce76
spec: callback for Menu.popup
2018-01-01 16:56:22 +09:00
Heilig Benedek
5bf16c2495
remove async:true from menu tests
2017-12-20 15:41:12 +09:00
Heilig Benedek
ef7357dedc
update tests for menu closed event and call cancel on closePopup
2017-12-20 15:40:07 +09:00
Heilig Benedek
14b65467d8
add test for menu closed event
2017-12-20 15:40:07 +09:00
Felix Rieseberg
317422f431
👷 Close popup in aftereach
2017-12-12 12:23:02 -08:00
Felix Rieseberg
c4ec8b4545
🔧 Feedback
2017-12-12 11:25:01 -08:00
Felix Rieseberg
76df41b5d0
👷 Properly test x vs y
2017-12-12 11:25:01 -08:00
Felix Rieseberg
ace558f54a
👷 Hence, better testing
2017-12-12 11:25:01 -08:00
Felix Rieseberg
5a658fa5f6
👷 Add a spec
2017-12-12 11:25:01 -08:00
Alexey Kuzmin
1c8eb03574
Revert "fix: Fix menu.popup() bugs"
2017-12-12 13:59:34 +03:00
Felix Rieseberg
89b90be6a2
🔧 Feedback
2017-12-11 14:43:35 -08:00
Felix Rieseberg
f7ebfff8ae
👷 Properly test x vs y
2017-12-11 14:05:07 -08:00
Felix Rieseberg
dfd7598d48
👷 Hence, better testing
2017-12-11 14:03:04 -08:00
Felix Rieseberg
725f6c97d6
👷 Add a spec
2017-12-08 14:52:21 -08:00
Birunthan Mohanathas
4e859b4718
Remove "async" option from menu.popup()
...
All menus are async now. See "Cleanup MenuRunner API"
https://codereview.chromium.org/2790773002
2017-11-24 10:58:17 +09:00
Felix Rieseberg
07dea13c77
👷 Let’s add a spec!
2017-11-07 13:29:37 -08:00
Shelley Vohr
e4214a6cbe
[WIP] Upgrade more specs ( #10945 )
...
Finish upgrading specs to ES6
2017-10-27 16:45:58 -04:00
Shelley Vohr
135454342d
remove .only from spec
2017-10-24 22:41:28 -04:00
Shelley Vohr
f7bc5481f3
add a few more tests to api_menu_spec
2017-10-24 22:40:31 -04:00
Shelley Vohr
d54148de4e
remove from spec
2017-10-24 20:31:02 -04:00
Shelley Vohr
0e6100ae17
upgrade menu spec to ES6
2017-10-24 20:27:26 -04:00
Shelley Vohr
3c6a7c332a
add unit test for getMenuItemById
2017-09-26 20:05:51 -04:00
Kevin Sawicki
8b4bf1f29e
🎨
2017-03-29 12:29:36 -07:00
mst128256
6a7b4feb35
Fixed for linting
2017-03-24 12:31:49 +01:00
mst128256
9e471d8f1c
Added specs
2017-03-24 12:14:08 +01:00
Kevin Sawicki
0a5ccdccb4
Add spec for async Menu.popup
2017-02-22 10:30:28 -08:00
Kevin Sawicki
947556a23f
Move MenuItem spec into root describe
2017-02-22 10:30:28 -08:00
Zeke Sikelianos
bcce7aff18
test that overrideProperty is not overwritten
2016-10-10 15:25:56 -07:00
Zeke Sikelianos
b7e078e98d
sanitize MenuItem options
2016-10-06 14:37:13 -07:00
Zeke Sikelianos
fdf3f6ce30
remove unneeded new keyword
2016-10-05 13:44:28 -07:00
Zeke Sikelianos
16b3962b66
preserve custom properties passed to MenuItem constructor
2016-10-05 12:24:08 -07:00
Yuya Ochiai
43f955194e
🏁 Use Ctrl+Y as the accelerator of redo on Windows
2016-09-18 17:07:34 +09:00
Feross Aboukhadijeh
9bc144c880
Fix test for PR #6600
...
Just realized that the tests don't pass after my PR. This fixes that :)
2016-07-25 17:27:45 -07:00
Kevin Sawicki
791cbc929a
Update spec to request defualt accelerator from item
2016-07-07 11:55:59 -07:00
Kevin Sawicki
197ec98800
Remove standard linter warnings
2016-06-29 09:46:16 -07:00
Kevin Sawicki
813e528350
Update expected accelerator
2016-06-22 15:41:45 -07:00
