Commit graph

44 commits

Author SHA1 Message Date
Samuel Attard
cad1d9aa9c Handle case where IO thread is not yet running, in C67 this results
in a hard crash

refs: https://chromium-review.googlesource.com/c/chromium/src/+/973556
2018-09-11 20:24:03 +02:00
Zhuo Lu
ab24a1e36d feat: netLog API for dynamic logging control (#13068)
* Introduce `net.{start|stop}Logging()`

- Slight regression right now as Electron won't automatically start logging net-logs at launch, will soon be fixed
- To implement callback for async controls

* Add `net.isLogging` & optional callback param for `net.stopLogging()`

* Fix small regression on --log-net-log

--log-net-log should work again

* Error on empty file path

* Only start with valid file path

* Remove unused var

* Allow setting log file path before URLRequestContextGetter starts logging

* Add net log tests

* Remove redundant checks

* Use brightray::NetLog

* Clean up code

* Should automatically stop listening

* 🎨 Attempt to fix styles

* Only run non-null callback

* Dump file to tmpdir

* Simplify net log spec

Spawned Electron process on Linux CI can fail to launch

* Separate netLog module

* Remove net logging test from net spec

* Add tests for netLog

* Fix header guard

* Clean up code

* Add netLog.currentlyLoggingPath

* Callback with filepath

* Add test for case when only .stopLogging() is called

* Add docs

* Reintroduce error on invalid arg

* Update copyright

* Update error message

* Juggle file path string types
2018-06-19 11:45:58 +10:00
Jeremy Apthorp
27cee90e5e [chromium-style] move methods out of headers 2018-04-19 11:12:58 -07:00
Shelley Vohr
49c8c31220
format previously misses .cc files 2018-04-17 21:56:12 -04:00
deepak1556
cdab073614 FIX: add chrome-devtools:// to list of WebUI schemes
https://chromium-review.googlesource.com/c/chromium/src/+/617598
2018-02-23 10:21:24 +09:00
deepak1556
a1592446da REVIEW: access GetApplicationLocale on sequence that allows IO 2018-01-02 16:37:08 +09:00
Samuel Attard
5048425e6e
Update implementation as per feedback 2017-05-30 19:06:51 +10:00
Kevin Sawicki
d7321ed980 Add brightray prefix to include paths from within brightray 2017-05-19 08:46:15 -07:00
Ales Pergl
0fa6c82b3f Use NotificationPresenterWin7 on Windows 7 2017-04-05 14:30:15 +02:00
Haojian Wu
22035e2d6d Fix cpplint: at least two spaces between code and comments. 2017-03-31 20:59:27 +02:00
Haojian Wu
424078cfdb Fix namespace comments. 2017-03-30 21:49:15 +02:00
Kevin Sawicki
2ece711c2e Format line length to 80 instead of 100 2017-03-23 15:47:30 -07:00
Cheng Zhao
babd741786 Get rid of default BrowserContext 2016-06-22 15:40:52 +09:00
Cheng Zhao
f5bfbada97 NetLog should be managed by BrowserClient 2016-05-23 19:02:13 +09:00
Cheng Zhao
851ef398fb Adapt to changes of Chrome 51 API changes 2016-05-23 10:59:07 +09:00
Cheng Zhao
baf5f384cd Pass() is deprecated for std::move 2016-03-08 20:59:29 +09:00
Cheng Zhao
6f81d1e29f Expose NotificationPresenter to public 2015-12-24 22:20:47 +08:00
Cheng Zhao
c4d192b9a4 linux: Fix building 2015-08-21 16:14:19 +08:00
Cheng Zhao
8a92ef34a7 Store NetLog in BrowserClient 2015-08-11 18:29:55 +08:00
Robo
7496cb29fe create netlog for devtoolsnetlogobserver 2015-07-15 00:54:28 +05:30
Cheng Zhao
7e88fe107d linux: Pass v8 snapshot's fd to child process 2015-04-21 21:43:30 +08:00
Cheng Zhao
a5026907e4 Implement PlatformNotificationService 2015-03-08 19:37:13 -07:00
Cheng Zhao
c874219101 Use the new devtools API 2015-02-03 10:57:25 -08:00
Cheng Zhao
02d632c4f7 Fix change of ShowDesktopNotification API 2015-02-03 10:57:25 -08:00
Cheng Zhao
51ef072de5 Implement GetDevToolsManagerDelegate, fixes atom/atom-shell#969 2015-01-02 15:18:24 -08:00
Cheng Zhao
5bec155c81 Adapt to API changes of Chrome 38 2014-10-11 16:38:27 +08:00
Cheng Zhao
dca1c51b32 Fix API changes of Chrome37. 2014-08-31 18:43:01 +08:00
Cheng Zhao
7b6fbff40d Implement BrowserClient::GetDefaultDownloadDirectory(). 2014-07-28 17:48:55 +08:00
Cheng Zhao
f552dc7ba4 mac: Fix the notification presenter of new API. 2014-07-28 11:52:26 +08:00
Cheng Zhao
6dd580526e Refactor notification presenter for new desktop notification interface. 2014-07-27 11:27:04 +00:00
Cheng Zhao
d5283b2337 Allow access FileSystem api in devtools.
It is required by the load/save feature of profilers.
2014-07-09 15:38:53 +08:00
Adam Roben
42b86242ea Add support for Chrome 35's "protocol interceptors"
See https://codereview.chromium.org/187223003
2014-06-27 11:54:27 -04:00
Patrick Reynolds
a82e9f30ed use libnotify to pop up notifications on Linux 2013-12-18 23:14:36 -06:00
Adam Roben
101a7bfa21 Fix cpplint errors in browser_client.cc 2013-11-17 17:39:01 -05:00
Adam Roben
2595335045 Enable navigator.webkitGetUserMedia()
The code came from chrome/browser/media, but was simplified to remove
dependencies on other parts of chrome/ and to always allow the media stream
request.
2013-07-31 11:08:45 -07:00
Adam Roben
3d12cb2c64 Don't crash when HTML notifications are used on Windows
Eventually we'll implement real support for this, but for now not crashing is
more important.
2013-05-31 08:05:14 -04:00
Adam Roben
12d01e4fd5 ifdef out a bunch of Mac-specific code
This is a hacky solution but helps us deal with other compiler/linker errors.
2013-05-22 13:55:56 -04:00
Adam Roben
94d7b383c5 Fix DCHECK() assertion in BrowserClient 2013-04-24 10:54:53 -04:00
Adam Roben
80cb76355c Update to latest libchromiumcontent
* vendor/libchromiumcontent b6a0d85...0d607ee (3):
  > Stop trying to compile SQLitePersistentCookieStore separately
  > Update to latest Chromium trunk revision
  > Merge pull request #4 from aroben/atom
2013-04-17 23:27:53 -04:00
Adam Roben
080d9f59e9 Implement Notification.close() 2013-03-29 09:36:07 -04:00
Adam Roben
651ab18a21 Turn NotificationPresenter into an abstract base class
This will allow us to have Mac-specific member variables without a bunch of
ifdefs.
2013-03-28 18:03:58 -04:00
Adam Roben
3c41af84a1 Move notification-related code into a new NotificationPresenter class 2013-03-28 17:50:07 -04:00
Adam Roben
881a203b57 Fix double-delete of BrowserMainParts
The caller of BrowserClient::CreateBrowserMainParts handles destroying the
BrowserMainParts instance we return.
2013-03-27 08:55:54 -04:00
Adam Roben
e451d92121 Initial commit 2013-03-13 15:31:24 -04:00