Milan Burda
04aafcc5ef
refactor: simplify <webview> event dispatch ( #30458 )
...
* refactor: simplify <webview> event dispatch
* Update lib/browser/guest-view-manager.ts
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* remove undocumented new-window event properties
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2021-08-17 12:10:27 -04:00
Milan Burda
6e43b0bcbf
refactor: only create webContents after 'will-attach-webview' ( #30311 )
2021-08-03 10:08:49 -07:00
Robo
2b897c8ad8
fix: crash due to race between attach and destruction of webview ( #24344 )
2021-08-02 08:35:57 -07:00
Milan Burda
c5ad7ed0cd
refactor: remove guestInstanceId from WebPreferences ( #30280 )
...
* refactor: remove guestInstanceId from WebPreferences
* refactor: remove WebViewManager::GetEmbedder
2021-07-28 15:32:53 -07:00
Shelley Vohr
9b5dd5380f
fix: Inspector method overrides when contextIsolation enabled ( #29841 )
2021-06-24 20:36:22 +02:00
Milan Burda
de6696ef1d
chore: remove unused and broken ipcRendererInternal.sendTo() ( #29743 )
2021-06-17 23:26:18 -05:00
Milan Burda
8fc86517fa
refactor: expose process.contextId directly ( #29236 )
2021-05-24 16:51:54 +09:00
Milan Burda
c68c65f383
refactor: implement <webview> using contextBridge ( #29037 )
...
* refactor: implement <webview> using contextBridge
* chore: address PR feedback
* chore: address PR feedback
* fix: check for HTMLIFrameElement instance in attachGuest
2021-05-15 16:42:07 +09:00
Milan Burda
49ef1fe342
refactor: use WeakMap instead of hidden V8 properties to store WebViewImpl ( #29049 )
2021-05-07 17:56:22 -07:00
Milan Burda
25f5c01cec
refactor: remove setupWebViewAttributes gymnastics ( #29032 )
2021-05-07 09:07:47 +02:00
Milan Burda
cbba602eae
chore: cleanup dead <webview> related code ( #29039 )
2021-05-06 13:56:05 -07:00
Milan Burda
dab9a88413
refactor: invoke loadURL in SrcAttribute instead of sending IPC directly ( #29031 )
2021-05-06 13:55:32 -07:00
Milan Burda
2c65060ec8
chore: make raw requires type-safe ( #29006 )
...
* chore: make raw requires type-safe
* refactor: no need for separate webViewImplModule
* refactor: no need for separate guestViewInternalModule
2021-05-05 18:05:01 -07:00
Milan Burda
2086e1903c
refactor: 'focus-change' does not need guestInstanceId ( #29001 )
...
* refactor: 'focus-change' does not need guestInstanceId
* refactor: rename internal 'focus-change' event to '-focus-change'
2021-05-05 11:37:40 -07:00
Milan Burda
476e908269
fix: <webview> focus / blur events don't work with contextIsolation enabled ( #29004 )
2021-05-05 11:31:44 -07:00
Milan Burda
961b74b2ac
refactor: use "as const" for constant mappings ( #28980 )
2021-05-04 14:12:49 -07:00
Samuel Attard
e5e8ab4eea
refactor: remove more dead code post render process reuse ( #28983 )
...
* Overrides for window.history.*
* Node environment cleanup / creation logic
* Options and switches that are now static values
2021-05-04 11:30:29 -07:00
Jeremy Rose
4ca518468d
feat: remove BrowserWindow option inheritance ( #28550 )
2021-04-21 10:55:17 -07:00
Samuel Attard
6df2680cb6
refactor: clean up webFrame implementation to use gin wrappers ( #28497 )
...
* refactor: clean up webFrame implementation to use gin wrappers
The previous implementation of webFrame in the renderer process leaked
sub-frame contexts and global objects across the context boundaries thus
making it possible for apps to either maliciously or accidentally
violate the contextIsolation boundary.
This re-implementation binds all methods in native code directly to
content::RenderFrame instances instead of relying on JS to provide a
"window" with every method request. This is much more consistent with
the rest of the Electron codebase and is substantially safer.
* chore: un-re-order for ease of review
* chore: pass isolate around instead of ErrorThrower
* chore: fix rebase typo
* chore: remove unused variables
2021-04-12 16:35:18 -07:00
Shelley Vohr
95e26e2fd4
refactor: use URL API ( #28583 )
2021-04-09 14:22:18 -07:00
Milan Burda
da8c35e3b2
chore: remove deprecated worldSafeExecuteJavaScript option ( #28456 )
2021-04-08 12:03:57 -04:00
Milan Burda
55c66e3e92
chore: add types for electron_renderer_web_frame binding ( #28455 )
...
* chore: add types for electron_renderer_web_frame binding
* chore: use keyof for getWebPreference type
Co-authored-by: Samuel Attard <sattard@slack-corp.com>
2021-04-02 14:34:28 -07:00
Milan Burda
485fa5bea9
feat: add process.contextId used by @electron/remote ( #28007 )
2021-03-17 11:23:03 -07:00
Milan Burda
5b205731f6
chore: remove deprecated remote module ( #25734 )
...
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2021-03-09 17:12:40 -08:00
Milan Burda
bf7e445883
fix: warning when worldSafeExecuteJavaScript is disabled ( #27928 )
2021-03-02 09:45:27 -08:00
Shelley Vohr
599f398ddc
fix: enableBlinkFeatures warning in webviews ( #27753 )
2021-02-18 11:11:35 -08:00
Jeremy Rose
706d9ede9b
refactor: only allow internal messages from the main process ( #27676 )
2021-02-09 17:12:26 -08:00
Milan Burda
79b3393768
chore: remove bunch of usages of any ( #27512 )
2021-01-29 12:41:59 -08:00
Milan Burda
64b7be751a
fix: CSP with unsafe-eval
detection with Trusted Types ( #27446 )
2021-01-25 10:31:25 +09:00
Milan Burda
4a5c5843c4
fix: <webview> not working with Trusted Types ( #27445 )
2021-01-25 10:29:25 +09:00
Milan Burda
70190ec2b1
chore: update to latest TypeScript, which has built-in WeakRef declarations ( #27425 )
2021-01-22 11:25:47 -08:00
Milan Burda
8b74361b0c
refactor: store WeakMaps in CallbacksRegistry / ObjectsRegistry ( #27037 )
2021-01-20 14:03:10 -08:00
Samuel Attard
3db4e612f4
fix: handle security warnings promise when JS is disabled ( #26837 )
2020-12-07 10:58:00 -08:00
Nikita Kot
7672aa9525
feat: exposeInMainWorld allow to expose non-object APIs ( #26594 )
2020-12-04 09:43:20 -08:00
Milan Burda
b37982987a
chore: remove unused sendToAll + related APIs ( #26771 )
...
* chore: remove unused sendToAll + related APIs
* refactor: no need to args.ShallowClone() anymore
2020-12-03 15:55:50 +09:00
Milan Burda
022bafc485
chore: remove deprecated crashReporter APIs ( #26695 )
2020-11-26 22:07:40 +03:00
Milan Burda
c8d77cae4a
refactor: replace V8 hidden values with WeakMap / WeakSet ( #26659 )
2020-11-24 16:11:39 -05:00
Milan Burda
6932e02eb8
refactor: use getWebPreference() for all options ( #26531 )
2020-11-23 22:39:08 +03:00
Milan Burda
5ee9cc202b
fix: ensure that internal messages are sent from the main process ( #26429 )
2020-11-12 06:20:01 +03:00
loc
0b85fdf26c
feat: add webContents.setWindowOpenHandler API ( #24517 )
...
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2020-11-10 09:06:03 -08:00
Jeremy Rose
34156c424c
fix: [webview] fix missing properties on events when contextIsolation: true ( #26289 )
2020-11-04 11:15:20 +09:00
Milan Burda
d25fa7b075
refactor: store <webview> attributes as typed Map ( #26307 )
2020-11-03 15:02:23 -08:00
Milan Burda
0c2e2bca92
refactor: don't send ipcRenderer.sendSync() returnValue as an array ( #26178 )
2020-10-28 18:48:20 +03:00
Milan Burda
2c68bad631
refactor: create IPC_MESSAGES enum for IPC message channels ( #25694 )
2020-10-14 00:11:06 +03:00
David Sanders
b194030a34
chore: cleanup some typos in comments ( #25770 )
2020-10-13 10:25:21 -07:00
Milan Burda
fb11a12d5b
refactor: replace a few any-s with proper types ( #25681 )
2020-10-08 03:01:23 +02:00
Milan Burda
db911f29ad
refactor: remove duplicate <webview> event list ( #25697 )
2020-10-06 15:11:26 +02:00
Milan Burda
8df4faa8f0
chore: cleanup typings/internal-electron.d.ts ( #25711 )
2020-10-02 04:52:29 +02:00
Jeremy Rose
822b044068
fix: suppress worldSafe warning emitted from security checks ( #25692 )
2020-10-01 08:59:52 -07:00
Jeremy Rose
9f4a097e03
feat: remove getMediaSourceIdForWebContents() ( #25414 )
...
This reverts commit 204f001c5d
.
2020-09-14 10:38:05 -07:00