Charles Kerr
d663b4eaee
fix: fix gn cpplint warnings ( #14583 )
...
* chore: fix cpplint 'include_what_you_use' warnings
Typically by including <memory>, <utility> etc.
* chore: fix 'static/global string constant' warning
Use C style strings instead of std::string.
Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
/home/charles/electron/electron-gn/src/electron/script/cpplint.js
* refactor: remove global string variables.
Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.
The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
* fix: initializer error introduced in last commit
* fix: remove WIP file that was included by accident
* fix: include order
* fix: include order
* fix: include order
* fix: include order, again
2018-09-12 19:25:56 -05:00
Robo
bce5bd87a8
fix: opt into location services once device service has been started ( #14253 )
...
* fix: opt into location services once device service has been started
* refactor: provide fake location provider to mock geolocation reponses
* chore: add spec for navigator.geolocation api using fake location provider
2018-08-23 08:51:46 -07:00
deepak1556
383b21e20a
Change calls to GeolocationProvider::UserDidOptIntoLocationServices() to occur via Mojo.
...
https://chromium-review.googlesource.com/c/chromium/src/+/760239
2018-06-19 11:49:42 +10:00
Aleksei Kuzmin
079e5df740
Adds ability for BrowserMainParts::PreEarlyInitialization() to fail
...
https://chromium-review.googlesource.com/862964
2018-06-19 11:46:59 +10:00
Milan Burda
2337237d58
Refactoring: use C++11 class member variable initialization
2018-05-22 00:18:38 +02:00
Cheng Zhao
1c6c75da4f
Merge the logic of managing ViewsDelegate
2018-04-20 19:10:37 +09:00
Cheng Zhao
37a7df49d6
mac: Provide ViewsDelegate
2018-04-20 19:10:37 +09:00
Jeremy Apthorp
e6695cf2ec
[chromium-style] override / virtual warnings
2018-04-19 11:12:10 -07:00
Robo
171230e45d
Cleanup destruction of URLRequestContextGetter ( #12305 )
...
- Add Leak detector
- Indicate shutdown of request context from Browser Context
- Change stored references to URLRequestContextGetter to use BrowserContext
- Destroy session properties explicitly
2018-03-30 08:24:55 -05:00
Cheng Zhao
952928dc79
Singleton must be created on request
...
The creation of singleton relies on the `userData` dir, which can be
changed by user, we have to ensure singleton uses the `userData` dir set
by user.
2018-01-03 18:59:12 +09:00
deepak1556
a1592446da
REVIEW: access GetApplicationLocale on sequence that allows IO
2018-01-02 16:37:08 +09:00
deepak1556
88e53b1b5e
REVIEW: destroy process singleton on sequence where IO is allowed
2018-01-02 16:37:07 +09:00
Kevin Sawicki
a33643c518
Start node inspector agent when --inspect is present
2017-05-16 14:44:28 -07:00
Kevin Sawicki
4824c24fbc
Remove non-functional node debugger usage
2017-05-11 10:59:51 -07:00
Cheng Zhao
99d3fce3c7
node::Environment should be destroyed before AtomBindings
...
The shutdown code may still uses the APIs provieded by AtomBindings.
2017-03-20 13:01:28 -07:00
Cheng Zhao
a0605275b9
Clean up node environment on exit in main process
2017-03-02 17:19:00 +09:00
Cheng Zhao
7ba391da7c
Update to API changes of Chrome 51
2016-05-23 10:59:39 +09:00
Dongjoon Hyun
0c92d44077
Fix typos in comments.
2016-03-07 20:22:03 -08:00
Kevin Sawicki
92433be888
Include exit code with quit event
2015-12-09 18:09:59 -08:00
Cheng Zhao
eb8426269f
Remove itself from the cleanup list when it is destroyed
2015-12-03 17:04:40 +08:00
Cheng Zhao
863199348f
Make process.exit() quit gracefully
...
Instead of abrupting the whole program immediately, we should close all
windows and release all native resources gracefully on exit. This avoids
possible crashes.
Fix #3350 .
2015-11-06 20:25:20 +08:00
Cheng Zhao
84410a7e1c
mac: Destroy the app delegate before running destruction callbacks
...
Otherwise users might be able to access wrapper functions after they are
destroyed.
2015-11-04 17:23:27 +08:00
Cheng Zhao
0e131f760b
Quit gracefully when Ctrl-C is pressed
2015-10-04 19:21:36 +08:00
Cheng Zhao
74b76102a8
linux: No longer needs to manually read DPI settings
...
It is now done in brightray by reading the value from GTK+.
2015-10-04 16:53:20 +08:00
Cheng Zhao
9d51da505e
Run destruction callbacks before message loop gets destroyed
2015-09-09 19:27:08 +08:00
Cheng Zhao
fafb28e41a
Move management of browser context to BrowserContext
2015-09-06 10:54:34 +08:00
Cheng Zhao
ba25bed45b
Store BrowserContext in ref-counted ptr
2015-09-06 10:54:34 +08:00
Cheng Zhao
3773f81fd5
Pass partition name instead of path to BrowserContext
2015-09-06 10:53:39 +08:00
Robo
8f59c0b642
create partitionId with encodedURIcomponent
2015-09-03 20:49:29 +05:30
Robo
d180d3b168
webview: fix partition attribute
2015-09-03 20:49:29 +05:30
Cheng Zhao
262b66b93a
Feed gin::PerIsolateData with a task runner
2015-09-03 17:50:23 +09:00
Cheng Zhao
a1a6ea6fe1
Revert "Remove our own debugger implementation"
...
This reverts commit 1d148fe2fb
.
2015-08-27 12:25:28 +08:00
Cheng Zhao
cc8b22b5ff
Make each class only have one weak map
2015-06-24 17:58:12 +08:00
Cheng Zhao
e6341ceaaa
Move BrowserProcess to BrowserMainParts
2015-06-18 16:34:02 +08:00
Cheng Zhao
1d148fe2fb
Remove our own debugger implementation
...
Previously it was used because Node doesn't provide one for latest V8.
2015-04-20 14:35:57 +08:00
Cheng Zhao
43421aedcf
OVERRIDE macro is now removed
2015-01-27 13:18:30 -08:00
Kevin Sawicki
b6b6fc3bfd
Remove All Rights Reserved after GitHub copyright
...
Closes #762
2014-10-31 11:17:05 -07:00
Cheng Zhao
4b75b10542
Add libgio loader
2014-10-21 18:50:50 +08:00
Cheng Zhao
4dd7848084
Run idle GC in browser every 1m
2014-10-17 12:41:40 +08:00
Cheng Zhao
1207dfde4c
Add support for --debug switch.
2014-08-19 23:36:26 +08:00
Cheng Zhao
a6ede12cd7
Make sure javascript environment is initialized after ProxyResolverV8.
2014-07-28 20:28:50 +08:00
Cheng Zhao
61db17412c
Use views to implement NativeWindow and MessageBox on Linux.
2014-07-04 01:30:36 +08:00
Cheng Zhao
6a891be0e4
Make the node environment constrained in browser_main_parts.
2014-06-30 14:16:16 +08:00
Cheng Zhao
f176b2c58f
Switch to use MIT license.
2014-05-04 20:29:08 +08:00
Cheng Zhao
c0875864dc
Handle IPC messages in webContents instead of BrowserWindow.
2014-04-25 16:13:16 +08:00
Cheng Zhao
bbef33a33a
Bring back build/header_guard cpplint.
2014-03-16 08:58:59 +08:00
Cheng Zhao
516d46444d
Move all sources under atom/.
2014-03-16 08:30:26 +08:00