Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	8991c0056e 
 
						 
						
							
							
								
								
								feat: promisify dialog.showMessageBox()  ( #17298 )  
							
							 
							
							... 
							
							
							
							* feat: promisify dialog.showMessageBox()
* address feedback from review 
							
						 
						
							2019-03-12 11:06:59 -07:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Robo 
								
							 
						 
						
							
							
								
							
							
	52fe92d02e  
						 
						
							
							
								
								
								feat: Upgrade to Chromium 71.0.3578.98 ( #15966 )  
							
							 
							
							
							
						 
						
							2019-01-11 17:00:43 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	81e00d8e56  
						 
						
							
							
								
								
								chore: fix V8 deprecation warnings ( #15842 )  
							
							 
							
							
							
						 
						
							2018-11-27 16:42:02 -05:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Charles Kerr 
								
							 
						 
						
							
							
								
							
							
	
	
	869e0ab14d 
 
						 
						
							
							
								
								
								fix: honor dialog.showMessageBox()'s Icon argument on Linux ( #15326 )  
							
							 
							
							... 
							
							
							
							* Don't call gtk_widget_show_all() on popup dialog.
Fixes  #15317 .
Notes: Fixed incorrect display of some GtkMessageDialog icons.
The issue is caused because GtkMessageDialog contains an icon widget
which is not shown when there's no associated icon. Our call to
`gtk_widget_show_all()` overrides this, showing the uninitialized
icon widget.
This PR fixes the issue by calling `gtk_widget_show()` where needed
and removing use of `gtk_widget_show_all()` in the message dialog.
* use gtk_dialog_set_default_response() for default
* fix: support icons on gtk+ messageboxes. 
							
						 
						
							2018-10-23 12:44:47 -05:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	2337237d58  
						 
						
							
							
								
								
								Refactoring: use C++11 class member variable initialization  
							
							 
							
							
							
						 
						
							2018-05-22 00:18:38 +02:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Jeremy Apthorp 
								
							 
						 
						
							
							
								
							
							
	da0fd10423  
						 
						
							
							
								
								
								refactor: chromium-style warnings in linux code ( #12949 )  
							
							 
							
							
							
						 
						
							2018-05-16 14:12:45 -05:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	c6f4bbd143 
 
						 
						
							
							
								
								
								also format missing .cc files  
							
							 
							
							
							
						 
						
							2018-04-18 20:48:45 -04:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	97e8800677  
						 
						
							
							
								
								
								Remove web_contents from NativeWindow's constructor  
							
							 
							
							
							
						 
						
							2018-04-11 15:12:53 +09:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Charles Kerr 
								
							 
						 
						
							
							
								
							
							
	5e7a5ce3a9  
						 
						
							
							
								
								
								run clang-format on changed sources  
							
							 
							
							
							
						 
						
							2018-02-15 15:20:55 -06:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Charles Kerr 
								
							 
						 
						
							
							
								
							
							
	4b766d26df  
						 
						
							
							
								
								
								make the linter happy  
							
							 
							
							
							
						 
						
							2018-02-09 19:29:32 -06:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Charles Kerr 
								
							 
						 
						
							
							
								
							
							
	b107d3f440  
						 
						
							
							
								
								
								remove icons from messageboxes on gtk  
							
							 
							
							... 
							
							
							
							Icons are deprecated in GtkMessageBoxes as of GTK+ 3.12. The GNOME HIG no longer shows icons in example dialogs; see https://developer.gnome.org/hig/stable/dialogs.html.en  and https://developer.gnome.org/gtk3/stable/GtkMessageDialog.html  
							
						 
						
							2018-02-09 17:53:02 -06:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Charles Kerr 
								
							 
						 
						
							
							
								
							
							
	ffff400236  
						 
						
							
							
								
								
								fix 'GTK_STOCK_*' deprecation warnings  
							
							 
							
							
							
						 
						
							2018-02-09 17:45:34 -06:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Aleksei Kuzmin 
								
							 
						 
						
							
							
								
							
							
	fe9ae41f98  
						 
						
							
							
								
								
								Use gtk_toggle_button_get_active()  
							
							 
							
							
							
						 
						
							2017-11-24 10:58:53 +09:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	b3d60bfb3a  
						 
						
							
							
								
								
								Fix building on Linux  
							
							 
							
							
							
						 
						
							2017-04-27 16:34:52 +09:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	7994acf0ea  
						 
						
							
							
								
								
								Use CHROMEGTK_CALLBACK_0 and ignore gpointer data  
							
							 
							
							
							
						 
						
							2017-02-09 09:49:09 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Birunthan Mohanathas 
								
							 
						 
						
							
							
								
							
							
	c8c11e68c6  
						 
						
							
							
								
								
								Add support for checkbox with dialog.showMessageBox  
							
							 
							
							... 
							
							
							
							This adds the `checkboxLabel` and `checkboxChecked` options to display a
checkbox in the message box. Fixes  #6048 . 
							
						 
						
							2017-02-09 09:03:54 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	be29ea4dad  
						 
						
							
							
								
								
								libgtk2ui => libgtkui  
							
							 
							
							
							
						 
						
							2017-02-06 10:34:29 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	8c5f26373b  
						 
						
							
							
								
								
								Add override  
							
							 
							
							
							
						 
						
							2016-12-22 09:33:21 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Kevin Sawicki 
								
							 
						 
						
							
							
								
							
							
	87f09131aa  
						 
						
							
							
								
								
								Observe window and only use it when it is open  
							
							 
							
							
							
						 
						
							2016-12-22 09:33:21 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	7848608198  
						 
						
							
							
								
								
								Replace DialogScope with UnresponsiveSuppressor  
							
							 
							
							... 
							
							
							
							The latter is global-wide. 
							
						 
						
							2016-07-11 15:29:03 +09:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	816b2ea8f2  
						 
						
							
							
								
								
								linux: Disable parent window when showing modal dialogs ( #6160 )  
							
							 
							
							
							
						 
						
							2016-06-21 08:54:55 +00:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	b32bc8cf3e  
						 
						
							
							
								
								
								Merge pull request  #5502  from anthonyryan1/master  
							
							 
							
							... 
							
							
							
							Replace gtk_widget_hide_all with gtk_widget_hide 
							
						 
						
							2016-05-12 19:37:25 +09:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Anthony Ryan 
								
							 
						 
						
							
							
								
							
							
	c29b844a97  
						 
						
							
							
								
								
								Replace gtk_widget_hide_all with gtk_widget_hide  
							
							 
							
							... 
							
							
							
							gtk_widget_hide_all was deprecated in gtk+ 2.24 and was removed
entirely in recent versions. This is a pretty straight forward
replacement. 
							
						 
						
							2016-05-11 15:33:43 -04:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									deepak1556 
								
							 
						 
						
							
							
								
							
							
	64718888dd  
						 
						
							
							
								
								
								dialog: resize icon on linux before showing  
							
							 
							
							
							
						 
						
							2016-05-11 22:30:10 +05:30  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	26bd97d6cf  
						 
						
							
							
								
								
								Fix style issues of  #4029  
							
							 
							
							
							
						 
						
							2016-01-11 21:12:07 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									leethomas 
								
							 
						 
						
							
							
								
							
							
	ae5c6add11  
						 
						
							
							
								
								
								rename all references to default_button_index -> default_id to keep consistent with cancel_id  
							
							 
							
							
							
						 
						
							2016-01-10 15:33:27 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									leethomas 
								
							 
						 
						
							
							
								
							
							
	dfce803045  
						 
						
							
							
								
								
								🏁  update windows message_box function signatures to accept default_button_index....and do nothing with it  
							
							 
							
							
							
						 
						
							2016-01-08 08:23:06 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									leethomas 
								
							 
						 
						
							
							
								
							
							
	22c455175a  
						 
						
							
							
								
								
								🐧  add default button index for linux/gtk  
							
							 
							
							
							
						 
						
							2016-01-08 08:22:10 -08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	73e7773d84  
						 
						
							
							
								
								
								Update to API changes of Chrome 47  
							
							 
							
							
							
						 
						
							2015-12-07 19:56:23 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	da724d65d7  
						 
						
							
							
								
								
								Add |options| for ShowMessageBox  
							
							 
							
							
							
						 
						
							2015-07-23 14:16:43 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	fb537d91fc  
						 
						
							
							
								
								
								Set default cancelId in JavaScript  
							
							 
							
							
							
						 
						
							2015-07-07 18:39:08 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	b158427271  
						 
						
							
							
								
								
								Add cancelId option for showMessageBox  
							
							 
							
							
							
						 
						
							2015-07-07 18:39:08 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	a2d1ec2c1f  
						 
						
							
							
								
								
								Make "title" work  
							
							 
							
							
							
						 
						
							2015-07-07 17:21:30 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	9b25c16980  
						 
						
							
							
								
								
								Allow "detail" to be empty  
							
							 
							
							
							
						 
						
							2015-07-07 17:21:30 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	810f14aecb  
						 
						
							
							
								
								
								Simplify the code  
							
							 
							
							
							
						 
						
							2015-07-07 17:21:30 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	e627592eed  
						 
						
							
							
								
								
								Reuse ShowMessageBox in ShowErrorBox  
							
							 
							
							
							
						 
						
							2015-07-07 17:21:30 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	3e6394a004  
						 
						
							
							
								
								
								gtk: Map dialog type to message box type  
							
							 
							
							
							
						 
						
							2015-07-07 17:21:30 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	02e28ea758  
						 
						
							
							
								
								
								Fix focusing message box  
							
							 
							
							
							
						 
						
							2015-07-07 17:21:30 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	b98cdf71c4  
						 
						
							
							
								
								
								gtk: Implement message box APIs  
							
							 
							
							
							
						 
						
							2015-07-07 17:21:26 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	1ff00281f3  
						 
						
							
							
								
								
								Seperate linux's implementation of message box  
							
							 
							
							
							
						 
						
							2015-07-07 15:12:08 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	61db17412c  
						 
						
							
							
								
								
								Use views to implement NativeWindow and MessageBox on Linux.  
							
							 
							
							
							
						 
						
							2014-07-04 01:30:36 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	84878c4c77  
						 
						
							
							
								
								
								Initial work for Aura on Linux.  
							
							 
							
							
							
						 
						
							2014-07-02 22:49:45 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	32c881bde9  
						 
						
							
							
								
								
								gtk: Make BrowserWindow::HasModalDialog work.  
							
							 
							
							... 
							
							
							
							Fixes  atom/atom#2658 . 
							
						 
						
							2014-06-24 21:52:06 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	f176b2c58f  
						 
						
							
							
								
								
								Switch to use MIT license.  
							
							 
							
							
							
						 
						
							2014-05-04 20:29:08 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	b6ac06c022  
						 
						
							
							
								
								
								Order header files.  
							
							 
							
							
							
						 
						
							2014-03-16 09:37:04 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	68cb6ee861  
						 
						
							
							
								
								
								Move atom/browser/ui/gtk to chrome/.  
							
							 
							
							
							
						 
						
							2014-03-16 08:39:43 +08:00  
						
						
							 
							
							
							
								 
							 
							
							
								 
							 
							
						 
					 
				
					
						
							
								
								
									 
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	516d46444d  
						 
						
							
							
								
								
								Move all sources under atom/.  
							
							 
							
							
							
						 
						
							2014-03-16 08:30:26 +08:00