Kevin Sawicki
7a3a092c72
Merge pull request #9687 from electron/fix-custom-window-button-view
...
Simplify customButtonsOnHover implementation
2017-06-06 18:54:04 -07:00
Birunthan Mohanathas
391c07b80a
Simplify custom window button positioning
2017-06-07 03:33:33 +03:00
Kevin Sawicki
915f6a6f54
Merge pull request #9178 from electron/visibilitystate
...
Let Chromium manage `document.visibilityState` and `document.hidden`
2017-06-06 17:32:49 -07:00
Kevin Sawicki
dc5221d551
Guard against null window like before
2017-06-06 17:02:23 -07:00
Kevin Sawicki
c60a9d242e
Disable minimize spec on Linux CI
2017-06-06 16:58:28 -07:00
Kevin Sawicki
a53e98c0f3
Add visibilitystate test for showInactive
2017-06-06 16:45:46 -07:00
Kevin Sawicki
52137485f2
Add separate specs for hide/show/minimize visibilitychange events
2017-06-06 16:22:07 -07:00
Kevin Sawicki
28cd973805
Mention document.hidden in spec description
2017-06-06 15:20:08 -07:00
Birunthan Mohanathas
f60315141b
Remove unnecessary if check
2017-06-07 01:19:53 +03:00
Kevin Sawicki
d2d28c42f1
Remove unused constant
2017-06-06 15:19:29 -07:00
Birunthan Mohanathas
3106478510
Rename SemaphoreView to CustomWindowButtonView
2017-06-07 01:18:22 +03:00
Birunthan Mohanathas
7d2226e05e
Let Chromium manage document.visibilityState
and document.hidden
...
Chromium already includes the necessary plumbing to manage the
visibility properties and `visibilitychange` event so this gets rid of
most of our custom logic for `BrowserWindow` and `BrowserView`.
Note that `webview` remains unchanged and is still affected by the issues
listed below.
User facing changes:
- The `document` visibility properties and `visibilitychange` event are
now also updated/fired in response to occlusion changes on macOS. In
other words, `document.visibilityState` will now be `hidden` on macOS
if the window is occluded by another window.
- Previously, `visibilitychange` was also fired by *both* Electron and
Chromium in some cases (e.g. when hiding the window). Now it is only
fired by Chromium so you no longer get duplicate events.
- The visiblity state of `BrowserWindow`s created with `{ show: false }`
is now initially `visible` until the window is shown and hidden.
- The visibility state of `BrowserWindow`s with `backgroundThrottling`
disabled is now permanently `visible`.
This should also fix #6860 (but not for `webview`).
2017-06-06 15:16:01 -07:00
Kevin Sawicki
d40a7569cc
Merge pull request #9686 from awaigand/patch-2
...
📝 Fixed typo
2017-06-06 14:33:26 -07:00
Andreas Waigand
f608c2b2d9
📝 Fixed typo
...
[ci skip]
2017-06-06 23:30:45 +02:00
Kevin Sawicki
21439a138b
Merge pull request #9682 from electron/release-detection
...
Rebuild native modules when configuration starts with R
2017-06-06 13:37:48 -07:00
Kevin Sawicki
5fa9cd646f
Rebuild test modules when configuration starts with R
2017-06-06 08:41:40 -07:00
Kevin Sawicki
53b6ee0e3f
Merge pull request #9468 from tonyganch/9296-history-state
...
Remove page url check during `history.pushState`
2017-06-05 14:47:49 -07:00
Kevin Sawicki
af1d0c45ca
Load URL after registering listener
2017-06-05 14:47:11 -07:00
Kevin Sawicki
777b5b17de
Move pushState spec chromium-spec with other history specs
2017-06-05 14:45:45 -07:00
Kevin Sawicki
dfa4af2210
Merge pull request #8958 from mst128256/8730
...
Area near the top border in frameless window is clickable
2017-06-05 14:30:41 -07:00
Kevin Sawicki
4989b21dbc
Autorelease semaphore view
2017-06-05 14:28:58 -07:00
Kevin Sawicki
1adc94b650
Mention customButtonsOnHover is for frameless windows
2017-06-05 14:18:08 -07:00
Kevin Sawicki
d5dc849c7a
Doc customButtonsOnHover in frameless window guide
2017-06-05 14:16:44 -07:00
Kevin Sawicki
41d582f689
Add back hidden-inset as a deprecated option
2017-06-05 14:16:23 -07:00
Kevin Sawicki
594302fcff
Update docs to use hiddenInset
2017-06-05 14:07:57 -07:00
Kevin Sawicki
3a2abde804
Add TODO for hidden-inset deprecation
2017-06-05 13:58:50 -07:00
Kevin Sawicki
9537303e9a
Remove unused customWindowButtons switch
2017-06-05 13:57:25 -07:00
Kevin Sawicki
de0daa2481
Autorelease tracking area
2017-06-05 13:48:30 -07:00
Kevin Sawicki
7d10bf229d
Switch to titleBarStyle for custom window buttons on hover
2017-06-05 13:30:32 -07:00
Kevin Sawicki
566e04f1c0
🎨
2017-06-05 13:13:16 -07:00
Kevin Sawicki
410e5bce60
Document customWindowButtons option
2017-06-05 13:04:17 -07:00
Kevin Sawicki
37ba1b0a6b
Declare mouse inside variable in interface
2017-06-05 12:55:39 -07:00
Kevin Sawicki
1493d6763c
Make custom window buttons an option
2017-06-05 12:50:18 -07:00
Kevin Sawicki
2880cfdc9c
🎨 Minor formatting tweaks
2017-06-05 11:08:05 -07:00
mst128256
96251e55de
Removed commented code
2017-06-05 10:41:52 -07:00
mst128256
9b4664daa5
Area near the top border in frameless window is clickable
2017-06-05 10:41:52 -07:00
Kevin Sawicki
9a362eed53
Merge pull request #9572 from shubham2892/api-height-menubar-macos
...
API height menubar macos
2017-06-05 10:35:16 -07:00
Kevin Sawicki
653ef6f839
🎨
2017-06-05 10:33:46 -07:00
Kevin Sawicki
352a9268ad
Merge pull request #9674 from electron/revert_8724
...
Revert "Merge pull request #8724 from electron/defer_load_url"
2017-06-05 10:21:18 -07:00
Kevin Sawicki
f5989dc12f
Merge pull request #9615 from rajatsingla28/web
...
Docs: Add requirement for `webContents.sendInputEvent()` to work.
2017-06-05 10:03:48 -07:00
Kevin Sawicki
afa2dd5ce5
Minor updates to focus note
2017-06-05 10:03:25 -07:00
Kevin Sawicki
7f974c9990
Merge pull request #9667 from solinium/master
...
change 'request' version
2017-06-05 10:00:08 -07:00
Kevin Sawicki
5bf2d23700
Merge pull request #9657 from electron/menu-docs-patch
...
Typescript menu popup fix
2017-06-05 08:55:57 -07:00
Kevin Sawicki
fb47dc9e48
🎨
2017-06-05 08:55:42 -07:00
deepak1556
50ac7b2edd
Revert "Merge pull request #8724 from electron/defer_load_url"
...
Possible cause for #9121
This reverts commit 886b47e713
, reversing
changes made to 479af3c9e2
.
2017-06-05 19:04:21 +05:30
dharders
aeb68c2369
✅ Add test for Windows fullscreen state toggle. Fix #6036
2017-06-05 11:39:15 +10:00
Alexander Gujral
43ff2e8ec1
change request version
...
https://nodesecurity.io/advisories/request_remote-memory-exposure
security vulnerability for earlier versions
2017-06-04 13:49:59 -04:00
Rajat
2df7680d24
Docs: Add requirement for webContents.sendInputEvent()
to work.
2017-06-03 23:47:15 +05:30
Shubham
c2603aaac2
🎨 Add documentation
2017-06-03 11:48:18 -04:00
Shubham
e9aa9eaf5e
🎨 code structure fix
2017-06-03 10:56:37 -04:00