Milan Burda
dac29f9949
refactor: type-safe module imports / requires ( #41192 )
2024-02-05 16:36:28 +09:00
Kilian Valkhof
3ec04fd449
docs: add note about fuses to our security documentation ( #41210 )
...
* Add note about fuses to our security documentation
Additionally, add the missing #18 to the ToC.
* lint issues for security.md
* Update docs/tutorial/security.md
Co-authored-by: Felix Rieseberg <fr@makenotion.com>
* move reference links to bottom of security.md
---------
Co-authored-by: Felix Rieseberg <fr@makenotion.com>
2024-02-02 17:28:36 -06:00
Charles Kerr
2ebaebb603
refactor: replace use of deprecated base::JSONWriter::WriteJson()
( #41215 )
...
* refactor: use base::WriteJson() in ListValueToNSArray()
refactor: use base::WriteJson() in DictionaryValueToNSDictionary()
* refactor: use base::WriteJson() in Debugger::SendCommand()
* refactor: use base::WriteJson() in ScriptingExecuteScriptFunction::Run()
* refactor: use base::WriteJson() in HandleAccessibilityRequestCallback()
2024-02-02 12:25:58 -06:00
Sam Maddock
9bfa16ad7f
fix: typescript error for optional dependency ( #41202 )
2024-02-01 13:00:20 +09:00
electron-roller[bot]
bccb7b572a
chore: bump chromium to 123.0.6272.0 (main) ( #41130 )
...
* chore: bump chromium in DEPS to 123.0.6265.0
* chore: bump chromium in DEPS to 123.0.6266.0
* chore: update feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5232280
reverts the revert *and* undoes the rewrites 😵
* chore: update chromium/disable_hidden.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5148491
minor manual intervention
* chore: update patches
* chore: Rename mouse lock to pointer lock
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5148491
* refactor: fix use of newly-removed QuitCurrentWhenIdleClosureDeprecated()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4710351
Xref: https://github.com/electron/electron/pull/26022
This usage was added in #26022 as part of Wayland support and some
simple fiddles WfM with this patch on Wayland, but I'm unsure what
to be testing for & would like a second opinion on this commit.
* chore: bump chromium in DEPS to 123.0.6268.0
* chore: update patches
* 5235021: WebUI: Migrate accessibility and bluetooth internals to WebUIConfig
https://chromium-review.googlesource.com/c/chromium/src/+/5235021
* address review comment for 5196547
See: https://chromium-review.googlesource.com/c/chromium/src/+/5196547
Review comment: https://github.com/electron/electron/pull/41130#discussion_r1468973786
* 5075962: Introduce URLLoaderFactoryBuilder
https://chromium-review.googlesource.com/c/chromium/src/+/5075962
* chore: bump chromium in DEPS to 123.0.6270.0
* the missing semicolon strikes again
* chore: update chromium patches
* chore: update v8 patches
* 5242326: Some followup cleanup to Fuchia files in chrome | https://chromium-review.googlesource.com/c/chromium/src/+/5242326
* chore: bump chromium in DEPS to 123.0.6272.0
* chore: update patches
* chore: update patch after rebase
* 5247339: [Clipboard] Remove ClipboardContentType enum.
https://chromium-review.googlesource.com/c/chromium/src/+/5247339
* Reland: "Allow content shell to enable the built-in DNS resolver"
https://chromium-review.googlesource.com/c/chromium/src/+/5232354
* 5018206: [accessibility] Migrate to ScopedAccessibilityMode
https://chromium-review.googlesource.com/c/chromium/src/+/5018206
* 5246669: [Default Nav Transition]Add GetBackForwardTransitionAnimationManager on WebContentsView | https://chromium-review.googlesource.com/c/chromium/src/+/5246669
* fix: move nut-js to optional spec deps (#41199 )
* chore: bump chromium in DEPS to 123.0.6265.0
* chore: bump chromium in DEPS to 123.0.6266.0
* chore: update feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5232280
reverts the revert *and* undoes the rewrites 😵
* chore: update chromium/disable_hidden.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5148491
minor manual intervention
* chore: update patches
* chore: Rename mouse lock to pointer lock
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5148491
* refactor: fix use of newly-removed QuitCurrentWhenIdleClosureDeprecated()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4710351
Xref: https://github.com/electron/electron/pull/26022
This usage was added in #26022 as part of Wayland support and some
simple fiddles WfM with this patch on Wayland, but I'm unsure what
to be testing for & would like a second opinion on this commit.
* chore: bump chromium in DEPS to 123.0.6268.0
* chore: update patches
* 5235021: WebUI: Migrate accessibility and bluetooth internals to WebUIConfig
https://chromium-review.googlesource.com/c/chromium/src/+/5235021
* address review comment for 5196547
See: https://chromium-review.googlesource.com/c/chromium/src/+/5196547
Review comment: https://github.com/electron/electron/pull/41130#discussion_r1468973786
* 5075962: Introduce URLLoaderFactoryBuilder
https://chromium-review.googlesource.com/c/chromium/src/+/5075962
* chore: bump chromium in DEPS to 123.0.6270.0
* the missing semicolon strikes again
* chore: update chromium patches
* chore: update v8 patches
* 5242326: Some followup cleanup to Fuchia files in chrome | https://chromium-review.googlesource.com/c/chromium/src/+/5242326
* chore: bump chromium in DEPS to 123.0.6272.0
* chore: update patches
* chore: update patch after rebase
* 5247339: [Clipboard] Remove ClipboardContentType enum.
https://chromium-review.googlesource.com/c/chromium/src/+/5247339
* Reland: "Allow content shell to enable the built-in DNS resolver"
https://chromium-review.googlesource.com/c/chromium/src/+/5232354
* 5018206: [accessibility] Migrate to ScopedAccessibilityMode
https://chromium-review.googlesource.com/c/chromium/src/+/5018206
* 5246669: [Default Nav Transition]Add GetBackForwardTransitionAnimationManager on WebContentsView | https://chromium-review.googlesource.com/c/chromium/src/+/5246669
* fix: typescript error for optional dependency
(cherry picked from commit ea17105c8c01bd1f4c1df5e72190a687d92f93cc)
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Sam Maddock <smaddock@slack-corp.com>
2024-01-31 17:04:13 -06:00
Sam Maddock
12870cafb7
fix: move nut-js to optional spec deps ( #41199 )
2024-02-01 07:35:09 +13:00
Shelley Vohr
e4d5dc138f
fix: select-usb-device
should respect filters
option ( #41166 )
...
fix: select-usb-device should respect filters option
2024-01-31 09:53:30 -05:00
Shelley Vohr
6df3443617
fix: validate printToPDF
margins
against pageSize
( #41157 )
...
fix: validate margins against pageSize
2024-01-31 10:48:41 +01:00
Sam Maddock
85bebfb180
test: draggable region allows moving window ( #41127 )
...
* chore: add nut.js
* test: dragging window updates position
* instantly move mouse position
* limit platforms to run drag tests on
* defer loading nut-js
2024-01-31 10:29:17 +01:00
Milan Burda
fb88375ab4
refactor: type-safe imports in lib/node/init.ts ( #41148 )
2024-01-31 08:38:56 +09:00
Charles Kerr
0e0a0bf724
fix: avoid potential CHECK()
failure in DictionaryToRect()
( #41160 )
...
refactor: use gfx::Rect::Contains() instead of reinventing the wheel
perf: use base::Value::FindInt() to avoid redundant map lookups
2024-01-30 14:48:47 -06:00
Charles Kerr
08615b2d4e
refactor: simplify code by using base::Value::EnsureList() ( #41162 )
2024-01-30 14:48:09 -06:00
Shelley Vohr
90c7d6c823
fix: shouldPrintBackgrounds
-> printBackground
in webContents.printToPDF
( #41161 )
...
fix: shouldPrintBackgrounds -> printBackground
2024-01-30 14:47:55 -06:00
Shelley Vohr
6786fde576
docs: document printToPDF
generateDocumentOutline
option ( #41156 )
...
* doc: document printToPDF generateDocumentOutline option
* doc: ready event to whenReady
2024-01-30 09:55:03 -06:00
Shelley Vohr
fc917985ae
fix: ensure WebContents
before checking draggable region ( #41154 )
...
fix: ensure WebContents before checking draggable region
2024-01-30 11:53:19 +01:00
Charles Kerr
ffec3127d5
refactor: inline simple getters ( #41125 )
2024-01-29 20:43:28 -06:00
github-actions[bot]
4e19321ba8
build: update appveyor image to latest version ( #41134 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com>
2024-01-29 14:12:59 -05:00
David Sanders
679a6589cd
chore: add extra links to issue template chooser ( #41135 )
2024-01-29 09:51:43 -05:00
Cheng Zhao
de76fc01ec
chore: fix outdated osk patch on main branch ( #41152 )
2024-01-29 15:35:33 +09:00
Cheng Zhao
2571396584
fix: update osk patch to fix more corner cases ( #41131 )
...
This is a follow up to https://github.com/electron/electron/pull/35921
that, it fixes more corner cases that on-screen-keyboard does not hide
for webviews.
This change has been applied in Teams for quite a while and should be
reliable enough to introduce to Electron.
2024-01-29 10:42:59 +09:00
Shelley Vohr
8104c7908a
fix: potential async_hooks
crash in NotifyWindowRestore
on Windows ( #40576 )
...
* fix: potential async_hooks crash in NotifyWindowRestore on Windows
* fix: don't use CallbackScope for Error objects
2024-01-26 12:53:07 -06:00
Cheng Zhao
db2bf1a0d1
fix: apply module search paths restriction on worker and child process ( #41118 )
2024-01-26 17:29:04 +09:00
electron-roller[bot]
6c9f9de40a
chore: bump chromium to 123.0.6264.0 (main) ( #41124 )
...
* chore: bump chromium in DEPS to 123.0.6264.0
* chore: update patches
* 5224145: Revert "Reland "Automated T* -> raw_ptr<T> rewrite 'refresh'""
https://chromium-review.googlesource.com/c/chromium/src/+/5224145
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-01-25 18:57:47 -05:00
John Kleinschmidt
9e630eb66a
build: remove unneeded dlls in Windows zip ( #41120 )
...
* build: fixup zip manifest check on Windows
* build: remove unused dlls
2024-01-25 15:26:21 -05:00
electron-roller[bot]
1a0991a9b9
chore: bump chromium to 122.0.6261.6 (main) ( #40949 )
...
* chore: bump chromium in DEPS to 122.0.6239.2
* chore: update patches
* refactor: extensions replaced StringPiece with string_view
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5171926
* chore: bump chromium in DEPS to 122.0.6240.0
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6241.5
* chore: bump chromium in DEPS to 122.0.6245.0
* chore: bump chromium in DEPS to 122.0.6247.0
* chore: bump chromium in DEPS to 122.0.6249.0
* chore: bump chromium in DEPS to 122.0.6251.0
* 5192010: Rename {absl => std}::optional in //chrome/
https://chromium-review.googlesource.com/c/chromium/src/+/5192010
* 5109767: CodeHealth: Fix leaked raw_ptr in Linux ProcessSingleton
https://chromium-review.googlesource.com/c/chromium/src/+/5109767
* 5105227: [media_preview] Show requested device in permission bubble
https://chromium-review.googlesource.com/c/chromium/src/+/5105227
* chore: bump chromium in DEPS to 122.0.6253.0
* chore: update patches
* 5180720: Polish tiled browser window UI on Linux | https://chromium-review.googlesource.com/c/chromium/src/+/5180720
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6255.0
* chore: update patches
* 5186276: [autopip] Make "allow once" per navigation | https://chromium-review.googlesource.com/c/chromium/src/+/5186276
* chore: bump chromium in DEPS to 122.0.6257.0
* chore: bump chromium in DEPS to 122.0.6259.0
* chore: update patches
* 5190661: Automated T* -> raw_ptr<T> rewrite "refresh" | https://chromium-review.googlesource.com/c/chromium/src/+/5190661
* 5206106: Make sure RenderFrameHosts are active when printing | https://chromium-review.googlesource.com/c/chromium/src/+/5206106
* 5202674: Reland "Automated T* -> raw_ptr<T> rewrite 'refresh'"
https://chromium-review.googlesource.com/c/chromium/src/+/5202674
* fixup CodeHealth: Fix leaked raw_ptr in Linux ProcessSingleton
https://chromium-review.googlesource.com/c/chromium/src/+/5109767
* fixup 5206106: Make sure RenderFrameHosts are active when printing
* Make legacy ToV8() helpers private to ScriptPromiseResolver, their only user
https://chromium-review.googlesource.com/c/chromium/src/+/5207474
* fixup CodeHealth: Fix leaked raw_ptr in Linux ProcessSingleton
* fixup 5186276: [autopip] Make "allow once" per navigation
https://chromium-review.googlesource.com/c/chromium/src/+/5186276
* chore: update patches after rebase
* chore: bump chromium in DEPS to 122.0.6260.0
* 5191363: Mark LOG(FATAL) [[noreturn]]
https://chromium-review.googlesource.com/c/chromium/src/+/5191363
* fixup 5186276: [autopip] Make "allow once" per navigation
https://chromium-review.googlesource.com/c/chromium/src/+/5186276
* fixup Make legacy ToV8() helpers private to ScriptPromiseResolver
https://chromium-review.googlesource.com/c/chromium/src/+/5207474
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6261.0
* chore: update patches
* chore: restore patch that was mistakenly removed
* 5181931: Improve LoginHandler (Part 9 / N)
https://chromium-review.googlesource.com/c/chromium/src/+/5181931
* Dispatch SiteInstanceGotProcess() only when both process and site are set.
https://chromium-review.googlesource.com/c/chromium/src/+/5142354
* 5171446: [AsyncSB] Pass navigation_id into CreateURLLoaderThrottles
https://chromium-review.googlesource.com/c/chromium/src/+/5171446
* 5213708: Move DownloadTargetInfo into components/download
https://chromium-review.googlesource.com/c/chromium/src/+/5213708
* extensions: Add a loader for Controlled Frame embedder scripts
https://chromium-review.googlesource.com/c/chromium/src/+/5202765
* [CSC][Zoom] Add initial_zoom_level to DisplayMediaInformation
https://chromium-review.googlesource.com/c/chromium/src/+/5168626
* chore: bump chromium in DEPS to 123.0.6262.0
* chore: bump chromium in DEPS to 122.0.6261.6
* fix: suppress clang -Wimplicit-const-int-float-conversion
* fixup 5191363: Mark LOG(FATAL) [[noreturn]] for Windows
https://chromium-review.googlesource.com/c/chromium/src/+/5191363
* 5167921: Remove Widget::IsTranslucentWindowOpacitySupported
https://chromium-review.googlesource.com/c/chromium/src/+/5167921
Also
5148392: PinnedState: Support pinned state in PlatformWindowState | https://chromium-review.googlesource.com/c/chromium/src/+/5148392
* fixup: 5180720: Polish tiled browser window UI on Linux
https://chromium-review.googlesource.com/c/chromium/src/+/5180720
* 5170669: clipboard: Migrate DOMException constructors to RejectWith-
https://chromium-review.googlesource.com/c/chromium/src/+/5170669
* 5178824: [Fullscreen] Record UKM data
https://chromium-review.googlesource.com/c/chromium/src/+/5178824
* chore: update patches after rebase
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-01-25 12:46:30 -05:00
Charles Kerr
921da723b8
fix: dangling raw_ptr in OSRWHV destructor ( #41088 )
...
`delegated_frame_host_` holds a pointer to `delegated_frame_host_client_`.
Since `delegated_frame_host_client_` was being destroyed first, that
pointer was dangling in the OSRWHV destructor.
Also, make these two unique_ptr fields `const` since they point to the
same objects for the lifespan of the OSRWHV.
2024-01-25 10:15:32 +09:00
Shelley Vohr
3e6a038af7
fix: draggable regions not working ( #41030 )
...
* fix: draggable regions not working
* fix: only support app regions for main frame
---------
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2024-01-25 09:12:54 +09:00
Maikel Ortega Hernández
a05bfd332d
fix: on error, reset spawnedProcess ( #41033 )
...
reset spawnedProcess instance in case of error
2024-01-24 16:45:08 -06:00
Charles Kerr
4164ef93ad
refactor: remove banned std::to_string() calls ( #41087 )
...
* refactor: do not use banned std::to_string() in ServiceWorkerContext::GetAllRunningWorkerInfo()
* refactor: do not use banned std::to_string() in REPORT_AND_RETURN_IF_FAILED()
* refactor: do not use banned std::to_string() in JSChunkedDataPipeGetter::OnWriteChunkComplete()
* refactor: do not use banned std::to_string() in SetCrashKey()
* chore: remove unused #include
2024-01-24 16:43:31 -06:00
Cheng Zhao
d13a93fb61
chore: remove node patches by using the preload feature ( #41080 )
2024-01-24 09:54:32 -06:00
Cheng Zhao
031d636823
fix: only remove hijackable envs from foreign parent ( #41079 )
2024-01-24 09:51:27 -06:00
Max Schmitt
5ced88a90a
docs: update Playwright automated-testing guide ( #41081 )
2024-01-24 09:50:55 -06:00
Charles Kerr
1af9612edf
fix: ElectronBrowserContext::PartitionKey comparisons ( #41055 )
...
* fix: ElectronBrowserContext::PartitionKey comparisons
Use c++20 default comparisons to simplify + fix PartitionKey sorting:
- The equality operator is broken. `PartitionKey{"foo", false}` is both
equal, to and less than, `PartitionKey{"foo", true}`
- For some keys, the same session can be retrieved via both `fromPath()`
and `fromPartition()`. This use case was discussed and removed from
the original PR after code review said "always returning different
sessions feels lower maintenance." The current behavior is a bug that
comes from the comparison operators not checking the keys' types.
Xref: 3f1aea9af9 (r1099745359)
Xref: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++-features.md#Default-comparisons-allowed
* fixup! fix: ElectronBrowserContext::PartitionKey comparisons
2024-01-23 09:41:44 -06:00
Valerius Petrini
1300e83884
docs: fixed typos and grammatical errors ( #40966 )
...
* docs: fixed typos
* Update docs/tutorial/performance.md
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
* Update performance.md
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
2024-01-19 08:21:42 -06:00
Michaela Laurencin
03a3deca18
ci: add stale-exempt label to exempt issues from automation ( #41031 )
2024-01-18 16:57:49 -05:00
electron-roller[bot]
f4ee3c1b2a
chore: bump node to v20.11.0 (main) ( #40941 )
...
* chore: bump node in DEPS to v20.11.0
* module: bootstrap module loaders in shadow realm
https://github.com/nodejs/node/pull/48655
* src: add commit hash shorthand in zlib version
https://github.com/nodejs/node/pull/50158
* v8,tools: expose necessary V8 defines
https://github.com/nodejs/node/pull/50820
* esm: do not call getSource when format is commonjs
https://github.com/nodejs/node/pull/50465
* esm: fallback to readFileSync when source is nullish
https://github.com/nodejs/node/pull/50825
* vm: allow dynamic import with a referrer realm
https://github.com/nodejs/node/pull/50360
* test: skip test-diagnostics-channel-memory-leak.js
https://github.com/nodejs/node/pull/50327
* esm: do not call getSource when format is commonjs
https://github.com/nodejs/node/pull/50465
* lib: fix assert throwing different error messages in ESM and CJS
https://github.com/nodejs/node/pull/50634
* src: fix compatility with upcoming V8 12.1 APIs
https://github.com/nodejs/node/pull/50709
* deps: update base64 to 0.5.1
https://github.com/nodejs/node/pull/50629
* src: avoid silent coercion to signed/unsigned int
https://github.com/nodejs/node/pull/50663
* src: fix compatility with upcoming V8 12.1 APIs
https://github.com/nodejs/node/pull/50709
* chore: fix patch indices
* chore: update patches
* test: disable TLS cipher test
This can't be enabled owing to BoringSSL incompatibilities.
https://github.com/nodejs/node/pull/50186
* fix: check for Buffer and global definition in shadow realm
https://github.com/nodejs/node/pull/51239
* test: disable parallel/test-shadow-realm-custom-loader
Incompatible with our asar logic, resulting in the following failure:
> Failed to CompileAndCall electron script: electron/js2c/asar_bundle
* chore: remove deleted parallel/test-crypto-modp1-error test
* test: make test-node-output-v8-warning generic
https://github.com/nodejs/node/pull/50421
* chore: fixup ModuleWrap patch
* test: match wpt/streams/transferable/transform-stream-members.any.js to upstream
* fix: sandbox is not enabled on arm
* chore: disable v8 sandbox on ia32/arm
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
2024-01-18 16:16:45 -05:00
github-actions[bot]
6ea7da4b90
build: update appveyor image to latest version ( #40951 )
...
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com>
2024-01-18 16:08:00 -05:00
Guo Hao (Andrew) Lay
135c542555
feat: Windows integrity check ( #40504 )
...
* Add Windows integrity check feature into Electron
Co-authored-by: Weiyun Dai <weiyun.chn@gmail.com>
* Add integrity checker header file to sources
Co-authored-by: Weiyun Dai <weiyun.chn@gmail.com>
* Moved integrity checker after checking command line args
Co-authored-by: Weiyun Dai <weiyun.chn@gmail.com>
* Revert previous Windows integrity check commits (2379a60, 331cf3c, a3c47ec)
Co-authored-by: guohaolay <guohaolay@gmail.com>
* Implement asar header integrity for Windows platform.
Co-authored-by: guohaolay <guohaolay@gmail.com>
* Fix Archive::RelativePath() on Windows platform.
Co-authored-by: guohaolay <guohaolay@gmail.com>
* Address comments.
* Address Windows integrity check PR comments.
* Update absl::optional to std::optional.
* Fix spelling.
---------
Co-authored-by: Weiyun Dai <weiyun.chn@gmail.com>
Co-authored-by: Weiyun Dai <weiyund@amazon.com>
Co-authored-by: Weiyun Dai <35878488+WeiyunD@users.noreply.github.com>
2024-01-19 09:00:49 +13:00
John Kleinschmidt
3dafb318a8
test: fixup assertNotWindows ( #41045 )
...
* chore: fixup assertNotWindows
* remove logging
2024-01-18 14:04:43 -05:00
Shelley Vohr
7e6fb97a2f
fix: crash when dialog.showMessageBoxSync
with missing buttons ( #40996 )
...
* fix: crash when dialog.showMessageBoxSync missing buttons
* chore: feedback from review
2024-01-18 13:21:15 +01:00
Shelley Vohr
df7f07a8af
fix: modal rounding on nonmodal windows ( #41003 )
...
* fix: modal rounding on nonmodal windows
* chore: feedback from review
2024-01-18 09:59:54 +01:00
Tamás Zahola
f97d8719e6
fix: use HasStyleMask(NSWindowStyleMaskResizable)
instead of IsResizable()
for enabling/disabling window maximize button ( #40994 )
2024-01-17 18:23:41 +01:00
Charles Kerr
021592200e
refactor: remove deprecated ToInternalValue() ( #40980 )
...
* refactor: do not use deprecated ToInternalValue() in ElectronExtensionLoader::FinishExtensionLoad()
* refactor: do not use deprecated ToInternalValue() in NotificationPresenterWin::SaveIconToFilesystem()
* chore: rename temp variable to now_usec for clarity
2024-01-17 10:17:43 -05:00
Shelley Vohr
6803624576
fix: check for Node.js-created module when contextIsolation
disabled ( #40993 )
2024-01-16 14:29:00 +01:00
Robo
4949c4c4e1
chore: fix building blink_tests target ( #40982 )
2024-01-16 12:24:14 +01:00
Shelley Vohr
61f619a5e6
ci: correctly export RBE_experimental_credentials_helper_args ( #40997 )
2024-01-15 19:48:10 +01:00
Charles Kerr
b3e01220cb
refactor: fix deprecated base::Base64Encode() API calls ( #40962 )
...
* refactor: replace deprecated Base64Encode() usage in IWC::NetworkResourceLoader::OnDataReceived()
* refactor: replace deprecated Base64Encode() usage EncodeToken(const base::UnguessableToken& token)
2024-01-15 11:01:35 +01:00
Charles Kerr
80b220d214
refactor: use base::NoDestructor instead of base::LazyInstance ( #40947 )
...
* refactor: use NoDestructor for g_io_thread_application_locale
* refactor: use NoDestructor for ExtensionActionAPI::GetFactoryInstance()
* refactor: use NoDestructor for ElectronExtensionsClient::GetPermissionMessageProvider()
* refactor: use NoDestructor for feat_add_support_for_overriding_the_base_spellchecker_download_url.patch
* chore: remove unused #include
* fixup! refactor: use NoDestructor for ElectronExtensionsClient::GetPermissionMessageProvider()
make sure instance is static
* chore: remove unused #include "base/lazy_instance.h"
2024-01-12 14:50:29 +01:00
Shelley Vohr
57b29903e3
build: log got error response bodies ( #40965 )
2024-01-12 14:37:39 +01:00
Samuel Attard
bbfe809d02
docs: add reclient docs, remove goma docs ( #40948 )
...
* docs: add reclient docs, remove goma docs
* Apply suggestions from code review
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-01-12 13:50:20 +13:00